Skip to contentSkip to conversation

edgerouter.conf: enable generation of wic.bmap

PATCH In review Ed Bartosh 3 participants 6 messages Dec 9, 2016 – Dec 12, 2016

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH 1/1 edgerouter.conf: enable generation of wic.bmap

Enabled generation of block map(bmap) files for wic images built for edgerouter machine. This should simplify flashing images with bmaptool.

[YOCTO #10621]

---
 meta-yocto-bsp/conf/machine/edgerouter.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-yocto-bsp/conf/machine/edgerouter.conf +1 -1
index 720a947..c6193d9 100644
@@ -18,7 +18,7 @@ USE_VT ?= "0"
 
 MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
 
-IMAGE_FSTYPES ?= "jffs2 tar.bz2 wic"
+IMAGE_FSTYPES ?= "jffs2 tar.bz2 wic wic.bmap"
 JFFS2_ERASEBLOCK = "0x10000"
 
 WKS_FILE ?= "sdimage-bootpart.wks"
Signature · 1 line
2.1.4
#1 lore raw
Quoted 8 lines · Ed Bartosh

Enabled generation of block map(bmap) files for wic images built for edgerouter machine. This should simplify flashing images with bmaptool.

[YOCTO #10621]

I think this is more of a distro decision than machine, whether they want to support use of bmaptool for their users/customers. It’d be nice if it was easier to control compression from the distro, too. For example, if we want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be able to switch to that for all machines that use wic. I’m not sure how best to pull that off, however. Something to think about for the future.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#2 lore raw
Quoted 13 lines · Christopher Larson
Quoted 8 lines · Ed Bartosh

Enabled generation of block map(bmap) files for wic images built for edgerouter machine. This should simplify flashing images with bmaptool.

[YOCTO #10621]

Quoted 6 lines

I think this is more of a distro decision than machine, whether they want to support use of bmaptool for their users/customers. It’d be nice if it was easier to control compression from the distro, too. For example, if we want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be able to switch to that for all machines that use wic. I’m not sure how best to pull that off, however. Something to think about for the future.

I think thats a good point, however, distro should be able to define something like
if machine is capable of supporting feature X then lets enable it. I dont think we
should add machine knowledge into distros either.

Quoted 13 lines

--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 23 lines · Khem Raj
Quoted 8 lines · Christopher Larson
Quoted 5 lines · Ed Bartosh

Enabled generation of block map(bmap) files for wic images built for edgerouter machine. This should simplify flashing images with bmaptool.

Quoted 6 lines
Quoted 3 lines

[YOCTO #10621]

I think this is more of a distro decision than machine, whether they

want to

Quoted 2 lines

support use of bmaptool for their users/customers. It’d be nice if it was easier to control compression from the distro, too. For example, if we

want

Quoted 1 line

to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be

able to

Quoted 1 line

switch to that for all machines that use wic. I’m not sure how best to

Quoted 8 lines

pull

Quoted 1 line

that off, however. Something to think about for the future.

I think thats a good point, however, distro should be able to define something like
if machine is capable of supporting feature X then lets enable it. I dont think we
should add machine knowledge into distros either.

Agreed. We do that already with features variables, but there’s no equivalent for IMAGE_FSTYPES, of course. Presumably IMAGE_FSTYPES_append = “ ${@‘wic.bmap’ if ‘${USING_WIC}’ else ‘’}” or so would get part of the way there. Replacing wic with wic.bz2 or vice versa would be slightly more complex.

Signature · 4 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
author
#4 lore raw
In reply to Christopher Larson
Quoted 12 lines · Christopher Larson
Quoted 8 lines · Ed Bartosh

Enabled generation of block map(bmap) files for wic images built for edgerouter machine. This should simplify flashing images with bmaptool.

[YOCTO #10621]

Quoted 6 lines

I think this is more of a distro decision than machine, whether they want to support use of bmaptool for their users/customers. It’d be nice if it was easier to control compression from the distro, too. For example, if we want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be able to switch to that for all machines that use wic. I’m not sure how best to pull that off, however. Something to think about for the future.

Thanks for pointing out to it. I did it this way for two reasons:
- IMAGE_FSTYPES was already modified in edgerouter.conf
- I wanted to enable generation of wic.bmap for subset of machines, i.e. only for hardware reference BSPs mentioned in README.hardware

If there is a better to do it I'd be happy to update my patch.

--
Regards,
Ed

#5 lore raw
Quoted 19 lines · Ed Bartosh
Quoted 7 lines · Christopher Larson
Quoted 4 lines · Ed Bartosh

Enabled generation of block map(bmap) files for wic images built for edgerouter machine. This should simplify flashing images with bmaptool.

Quoted 8 lines
Quoted 4 lines

[YOCTO #10621]

I think this is more of a distro decision than machine, whether they want to support use of bmaptool for their users/customers. It’d be nice if it was easier to control compression from the distro, too. For example, if

we

Quoted 2 lines

want to distribute wic.bz2+wic.bmap in our installers, it’d be nice to be able to switch to that for all machines that use wic. I’m not sure how

Quoted 8 lines

best

Quoted 1 line

to pull that off, however. Something to think about for the future.

Thanks for pointing out to it. I did it this way for two reasons:
- IMAGE_FSTYPES was already modified in edgerouter.conf
- I wanted to enable generation of wic.bmap for subset of machines, i.e. only for hardware reference BSPs mentioned in README.hardware

That’s a fair point. As khem indicated, this is a bit of an intersection between distro and machine, hardware capabilities and distro policy. I expect this is fine as is, but something to consider improving going forward. I’m not certain a distro/machine feature makes sense for something like this, but perhaps something else might.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics