Skip to contentSkip to conversation

Further enhance async-push feature description

PATCH In review David Sommerseth 3 participants 4 messages Dec 14, 2016 – Nov 1, 2017

lore
Share & tools
lore

David Sommerseth

author
#0 lore raw

PATCH 1/1 Further enhance async-push feature description

Signed-off-by David Sommerseth <[email protected]...>
---
 Changes.rst  | 9 +++++----
 configure.ac | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)
Changes.rst +5 -4
index a5002dd..7da1119 100644
@@ -148,10 +148,11 @@ Control channel encryption (``--tls-crypt``)
     post-quantum security.
 
 Asynchronous push reply
-    If asynchronous authentication is enabled and completed after server received
-    PUSH_REQUEST message, server sends PUSH_REPLY immediately without waiting for next
-    PUSH_REQUEST. Requires use of ``--enable-async-push`` as ./configure parameter at
-    build time.
+    Plug-ins providing support for deferred authentication can benefit from a more
+    responsive authentication where the server sends PUSH_REPLY immediately once
+    the authentication result is ready instead of waiting for the the client to
+    to send PUSH_REQUEST once more.  This requires OpenVPN to be built with
+    ``./configure --enable-async-push``.  This is a compile-time only switch.
 
 
 Deprecated features
configure.ac +1 -1
index 27bdcc3..4f086ea 100644
@@ -266,7 +266,7 @@ AC_ARG_ENABLE(
 
 AC_ARG_ENABLE(
 	[async-push],
-	[AS_HELP_STRING([--enable-async-push], [enable async-push support @<:@default=no@:>@])],
+	[AS_HELP_STRING([--enable-async-push], [enable async-push support for plugins providing deferred authentication @<:@default=no@:>@])],
 	,
 	[enable_async_push="no"]
 )
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 32 lines · David Sommerseth
Signed-off-by David Sommerseth <[email protected]...>
---
 Changes.rst  | 9 +++++----
 configure.ac | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)
Changes.rst +5 -4
index a5002dd..7da1119 100644
@@ -148,10 +148,11 @@ Control channel encryption (``--tls-crypt``)
     post-quantum security.
 
 Asynchronous push reply
-    If asynchronous authentication is enabled and completed after server received
-    PUSH_REQUEST message, server sends PUSH_REPLY immediately without waiting for next
-    PUSH_REQUEST. Requires use of ``--enable-async-push`` as ./configure parameter at
-    build time.
+    Plug-ins providing support for deferred authentication can benefit from a more
+    responsive authentication where the server sends PUSH_REPLY immediately once
+    the authentication result is ready instead of waiting for the the client to
+    to send PUSH_REQUEST once more.  This requires OpenVPN to be built with
+    ``./configure --enable-async-push``.  This is a compile-time only switch.
 
 
 Deprecated features
configure.ac +0 -0
index 27bdcc3..4f086ea 100644

configure.ac AC_ARG_ENABLE( · line 272

Quoted 8 lines
configure.ac +1 -1
@@ -266,7 +266,7 @@ AC_ARG_ENABLE(
 
 AC_ARG_ENABLE(
 	[async-push],
-	[AS_HELP_STRING([--enable-async-push], [enable async-push support @<:@default=no@:>@])],
+	[AS_HELP_STRING([--enable-async-push], [enable async-push support for plugins providing deferred authentication @<:@default=no@:>@])],
 	,
 	[enable_async_push="no"]
 )

ACK.

Related question: looks both useful and harmless. Should we enable this by default in 2.5?

-Steffan

#2 lore raw

Hi,

finding lost gems in my mailbox...

Quoted 11 lines · Steffan Karger

configure.ac AC_ARG_ENABLE( · line 271

Quoted 6 lines

AC_ARG_ENABLE(

configure.ac +1 -1
 	[async-push],
-	[AS_HELP_STRING([--enable-async-push], [enable async-push support @<:@default=no@:>@])],
+	[AS_HELP_STRING([--enable-async-push], [enable async-push support for plugins providing deferred authentication @<:@default=no@:>@])],
 	,
 	[enable_async_push="no"]

ACK.

Related question: looks both useful and harmless. Should we enable this by default in 2.5?

Skimmed through the code, and generally speaking, this would make sense.

OTOH the code is currently linux only (inotify is not available on FreeBSD, at least), so this would just change the default but won't get rid of any #ifdef, unfortunately... :-(

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
author
#3 lore raw
In reply to David Sommerseth

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Your patch has been applied to the master branch

commit 1a8f6b9159708a943ebdb64404de4c5fc887303b

Author: David Sommerseth
Date:   Wed Dec 14 13:23:30 2016 +0100
     Further enhance async-push feature description

     Signed-off-by: David Sommerseth <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://www.mail-archive.com/search?l=mid&[email protected]...

- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJYUUDQAAoJEIbPlEyWcf3yEU8QAI45qh0vPSuWT2u+ATEFYDHJ awATBJxfZMhn4oP1v7AYd/5CYC2g6tPxEVpDBqvMoXvdfc19nz3OdMVIcycrJroH qTaeDzrz8eERMTHhGJoYb4EG+b18j/FDl/ZHmiBAiBje+3f174oxpDkTrL6PyZfZ vuAyWl2OfCKT3IuIYPVLwL6ihmdhuDjfLPemRZ4SbAe6Uz521fsI4wur2v1iMtIq t5sLV+i+P4bnR1vj7SQNSTxcE+RVIjKP4lktEGhU8n39DF5/iRe2Xpttd9hgy9gp IWUf1ARh7yvvGo5v269tsTr8dq5Xcdda5/nDAFBoRNrQCmBLz4GRa7jiHGqLd0g9 QxdqIMQk06/mfqkN/1dkBH8oVkHXrDPA70X+f1T+B+Yi7xRYbLKXYg/jgXr6uox+ kpzhiBfDL4OwacxGfNzaj5bNIKqGeSf2jAx+ghaMsF+wrzst8PTHhPPguy2379mW 1O7EeJOxHomXwV0VN8iPOlKO1QDPl0RioRwl4olvo7OFgt4XaDktoRBWY3K3v3TV zycBqos+7QvBowTtK4lxfBmGN12oWMgdT4anP3J7T0p0UjAxFkj0ba52zfRG7NYR oeDVu4iaVHMU9YqeguyhCc4zu7kYMkkrr4BzbKGINXyNVCH9RgVaCu7mHf/bn0aM iZ9bPgI+QEsMyte3pBd1
=26OE
-----END PGP SIGNATURE-----