Skip to contentSkip to conversation

Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig

PATCH Superseded Fabio Estevam 2 participants 3 messages Dec 15, 2016 – Dec 17, 2016

Subsystems (5)
Arm (32-bit) Arm i.MX and Layerscape Arm Samsung Exynos Tegra architecture support +1 more subsystems
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v3 1/1 Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig

From: Fabio Estevam <[email protected]>

Move USE_ARCH_MEMCPY/MEMSET options to Kconfig.

Make it "default y" for the ARMv7 architecture and make it depend on !ARM64 && !SPL.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v2:
- Move it to arch/arm/Kconfig
- Change default and depends logic

 arch/arm/Kconfig                   | 18 ++++++++++++++++++
 include/configs/armadillo-800eva.h |  2 --
 include/configs/blanche.h          |  3 ---
 include/configs/colibri_imx7.h     |  2 --
 include/configs/colibri_vf.h       |  2 --
 include/configs/exynos-common.h    |  3 ---
 include/configs/pcm052.h           |  1 -
 include/configs/tegra-common.h     |  6 ------
 include/configs/uniphier.h         |  5 -----
 include/configs/vf610twr.h         |  1 -
 10 files changed, 18 insertions(+), 25 deletions(-)
arch/arm/Kconfig +18 -0
index 714dd8b..b15f13f 100644
@@ -126,6 +126,24 @@ config ENABLE_ARM_SOC_BOOT0_HOOK
 	  ARM_SOC_BOOT0_HOOK which contains the required assembler
 	  preprocessor code.
 
+config USE_ARCH_MEMCPY
+	bool "Use an assembly optimized implementation of memcpy"
+	default y if CPU_V7
+	depends on !ARM64 && !SPL
+	help
+	  Enable the generation of an optimized version of memcpy.
+	  Such implementation may be faster under some conditions
+	  but may increase the binary size.
+
+config USE_ARCH_MEMSET
+	bool "Use an assembly optimized implementation of memset"
+	default y if CPU_V7
+	depends on !ARM64 && !SPL
+	help
+	  Enable the generation of an optimized version of memset.
+	  Such implementation may be faster under some conditions
+	  but may increase the binary size.
+
 config ARCH_OMAP2
 	bool
 	select CPU_V7
include/configs/armadillo-800eva.h +0 -2
index 2d24253..3775a49 100644
@@ -28,8 +28,6 @@
 
 #define CONFIG_ARCH_CPU_INIT
 #define CONFIG_BOARD_EARLY_INIT_F
-#define CONFIG_USE_ARCH_MEMSET
-#define CONFIG_USE_ARCH_MEMCPY
 #define CONFIG_TMU_TIMER
 #define CONFIG_SYS_DCACHE_OFF
include/configs/blanche.h +0 -3
index f094bbe..0deb350 100755
@@ -16,9 +16,6 @@
 
 #include "rcar-gen2-common.h"
 
-#define CONFIG_USE_ARCH_MEMSET
-#define CONFIG_USE_ARCH_MEMCPY
-
 /* STACK */
 #define CONFIG_SYS_INIT_SP_ADDR		0xE817FFFC
 #define STACK_AREA_SIZE			0xC000
include/configs/colibri_imx7.h +0 -2
index 5ce0a34..bc3b53b 100644
@@ -15,8 +15,6 @@
 #include "mx7_common.h"
 
 #define CONFIG_SYS_THUMB_BUILD
-#define CONFIG_USE_ARCH_MEMCPY
-#define CONFIG_USE_ARCH_MEMSET
 
 /*#define CONFIG_DBG_MONITOR*/
 #define PHYS_SDRAM_SIZE			SZ_512M
include/configs/colibri_vf.h +0 -2
index d58145e..47dea62 100644
@@ -16,8 +16,6 @@
 
 #define CONFIG_VF610
 #define CONFIG_SYS_THUMB_BUILD
-#define CONFIG_USE_ARCH_MEMCPY
-#define CONFIG_USE_ARCH_MEMSET
 #define CONFIG_SYS_FSL_CLK
 
 #define CONFIG_ARCH_MISC_INIT
include/configs/exynos-common.h +0 -3
index 3b61a41..566f246 100644
@@ -20,9 +20,6 @@
 #define CONFIG_SKIP_LOWLEVEL_INIT
 #define CONFIG_BOARD_EARLY_INIT_F
 
-#define CONFIG_USE_ARCH_MEMCPY
-#define CONFIG_USE_ARCH_MEMSET
-
 /* Keep L2 Cache Disabled */
 
 /* input clock of PLL: 24MHz input clock */
include/configs/pcm052.h +0 -1
index eb1944a..e70c3f0 100644
@@ -35,7 +35,6 @@
 #define CONFIG_SYS_NAND_ONFI_DETECTION
 
 #ifdef CONFIG_CMD_NAND
-#define CONFIG_USE_ARCH_MEMCPY
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
 #define CONFIG_SYS_NAND_BASE		NFC_BASE_ADDR
include/configs/tegra-common.h +0 -6
index 63b711b..23a0e78 100644
@@ -76,12 +76,6 @@
 #define CONFIG_SYS_MEMTEST_START	(NV_PA_SDRC_CS0 + 0x600000)
 #define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + 0x100000)
 
-#ifndef CONFIG_ARM64
-#ifndef CONFIG_SPL_BUILD
-#define CONFIG_USE_ARCH_MEMCPY
-#endif
-#endif
-
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */
include/configs/uniphier.h +0 -5
index f9c9f82..74f1373 100644
@@ -63,11 +63,6 @@
 /* serial console configuration */
 #define CONFIG_BAUDRATE			115200
 
-#if !defined(CONFIG_SPL_BUILD) && !defined(CONFIG_ARM64)
-#define CONFIG_USE_ARCH_MEMSET
-#define CONFIG_USE_ARCH_MEMCPY
-#endif
-
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 
 #define CONFIG_CMDLINE_EDITING		/* add command line history	*/
include/configs/vf610twr.h +0 -1
index af5ba61..6aeb078 100644
@@ -42,7 +42,6 @@
 #define CONFIG_SYS_NAND_ONFI_DETECTION
 
 #ifdef CONFIG_CMD_NAND
-#define CONFIG_USE_ARCH_MEMCPY
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
 #define CONFIG_SYS_NAND_BASE		NFC_BASE_ADDR
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 1/1 Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig

Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Move USE_ARCH_MEMCPY/MEMSET options to Kconfig.

Make it "default y" for the ARMv7 architecture and make it depend on !ARM64 && !SPL.

Signed-off-by Fabio Estevam <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161216/d0de094d/attachment.sig>
author reviewer
#2 lore raw

PATCH v3 1/1 Kconfig: Move USE_ARCH_MEMCPY/MEMSET to Kconfig

Quoted 4 lines · Tom Rini
Quoted 2 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Quoted 8 lines
Quoted 6 lines

Move USE_ARCH_MEMCPY/MEMSET options to Kconfig.

Make it "default y" for the ARMv7 architecture and make it depend on !ARM64 && !SPL.

Signed-off-by Fabio Estevam <[email protected]>

Applied to u-boot/master, thanks!

Thanks, Tom.

Are you also happy with this one?
https://patchwork.ozlabs.org/patch/706199/