Skip to contentSkip to conversation

Staging: comedi: comedidev.h: Drop old style zero-length array

PATCH In review Cheah Kok Cheong 2 participants 2 messages Dec 21, 2016 – Jan 3, 2017 Staging

lore
Share & tools
lore

Cheah Kok Cheong

author
#0 lore raw

PATCH 1/1 Staging: comedi: comedidev.h: Drop old style zero-length array

According to Documentation/Changes, the minimum gcc version required to compile the kernel is 3.2 (this is probably outdated too).

Signed-off-by Cheah Kok Cheong <[email protected]>
---
 drivers/staging/comedi/comedidev.h | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/comedi/comedidev.h +1 -7
index 0c7c37a..9713d96 100644
@@ -612,12 +612,6 @@ extern const struct comedi_lrange range_unknown;
 
 #define range_digital		range_unipolar5
 
-#if __GNUC__ >= 3
-#define GCC_ZERO_LENGTH_ARRAY
-#else
-#define GCC_ZERO_LENGTH_ARRAY 0
-#endif
-
 /**
  * struct comedi_lrange - Describes a COMEDI range table
  * @length: Number of entries in the range table.

@@ -631,7 +625,7 @@ extern const struct comedi_lrange range_unknown;
  */
 struct comedi_lrange {
 	int length;
-	struct comedi_krange range[GCC_ZERO_LENGTH_ARRAY];
+	struct comedi_krange range[];
 };
 
 /**
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · Cheah Kok Cheong

According to Documentation/Changes, the minimum gcc version required to compile the kernel is 3.2 (this is probably outdated too).

Signed-off-by Cheah Kok Cheong <[email protected]>
---
 drivers/staging/comedi/comedidev.h | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/comedi/comedidev.h +0 -6
index 0c7c37a..9713d96 100644
@@ -612,12 +612,6 @@ extern const struct comedi_lrange range_unknown;
 
 #define range_digital		range_unipolar5
 
-#if __GNUC__ >= 3
-#define GCC_ZERO_LENGTH_ARRAY
-#else
-#define GCC_ZERO_LENGTH_ARRAY 0
-#endif
-
 /**
  * struct comedi_lrange - Describes a COMEDI range table
  * @length: Number of entries in the range table.

drivers/staging/comedi/comedidev.h extern const struct comedi_lrange range_unknown; · line 631

Quoted 8 lines
drivers/staging/comedi/comedidev.h +1 -1
@@ -631,7 +625,7 @@ extern const struct comedi_lrange range_unknown;
  */
 struct comedi_lrange {
 	int length;
-	struct comedi_krange range[GCC_ZERO_LENGTH_ARRAY];
+	struct comedi_krange range[];
 };
 
 /**

Yes, that seems to be redundant. Thanks!

Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-