drm: Wrap the check for atomic_commit implementation
Subsystems (3)
PATCH 1/2 drm: Wrap the check for atomic_commit implementation
This check is useful for drivers that do not have DRIVER_ATOMIC set but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.
--- drivers/gpu/drm/drm_fb_helper.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +- include/drm/drmP.h | 5 +++++ 5 files changed, 14 insertions(+), 9 deletions(-)
drivers/gpu/drm/drm_fb_helper.c +3 -3
@@ -405,7 +405,7 @@ static int restore_fbdev_mode(struct drm_fb_helper *fb_helper)drm_warn_on_modeset_not_all_locked (dev); -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev))return restore_fbdev_mode_atomic (fb_helper);drm_for_each_plane (plane, dev) {
@@ -1444,7 +1444,7 @@ int drm_fb_helper_pan_display(struct fb_var_screeninfo *var,return -EBUSY ; } -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) { ret =pan_display_atomic (var, info); goto unlock; }
@@ -2060,7 +2060,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,* NULL we fallback to the default drm_atomic_helper_best_encoder() * helper. */ -if (fb_helper->dev->mode_config.funcs->atomic_commit && +if (drm_drv_uses_atomic_modeset (fb_helper->dev) && !connector_funcs->best_encoder) encoder =drm_atomic_helper_best_encoder (connector);else
drivers/gpu/drm/nouveau/nouveau_connector.c +2 -2
@@ -769,7 +769,7 @@ nouveau_connector_set_property(struct drm_connector *connector,struct drm_encoder *encoder =to_drm_encoder (nv_encoder);int ret; -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_set_property (connector, property, value); ret = connector->funcs->atomic_set_property(&nv_connector->base,
@@ -1074,7 +1074,7 @@ nouveau_connector_helper_funcs = {static int nouveau_connector_dpms (struct drm_connector *connector,int mode) { -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_dpms (connector, mode);return drm_helper_connector_dpms (connector, mode); }
drivers/gpu/drm/nouveau/nouveau_display.c +3 -3
@@ -162,7 +162,7 @@ nouveau_display_vblstamp(struct drm_device *dev, unsigned int pipe,list_for_each_entry (crtc, &dev->mode_config.crtc_list, head) {if (nouveau_crtc (crtc)->index == pipe) {struct drm_display_mode *mode; -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev)) mode = &crtc->state->adjusted_mode;else mode = &crtc->hwmode;
@@ -738,7 +738,7 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)struct nouveau_display *disp =nouveau_display (dev);struct drm_crtc *crtc; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {if (!runtime) { disp->suspend =nouveau_atomic_suspend (dev);if (IS_ERR (disp->suspend)) {
@@ -784,7 +784,7 @@ nouveau_display_resume(struct drm_device *dev, bool runtime)struct drm_crtc *crtc;int ret; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {nouveau_display_init (dev);if (disp->suspend) {drm_atomic_helper_resume (dev, disp->suspend);
drivers/gpu/drm/nouveau/nouveau_fbcon.c +1 -1
@@ -524,7 +524,7 @@ nouveau_fbcon_init(struct drm_device *dev) preferred_bpp =32 ;/* disable all the possible outputs/crtcs before entering KMS mode */ -if (!dev->mode_config.funcs->atomic_commit) +if (!drm_drv_uses_atomic_modeset (dev))drm_helper_disable_unused_functions (dev); ret =drm_fb_helper_initial_config (&fbcon->helper, preferred_bpp);
include/drm/drmP.h +5 -0
@@ -647,6 +647,11 @@ static __inline__ int drm_core_check_feature(struct drm_device *dev,return ((dev->driver->driver_features & feature) ?1 :0 ); } +static inline int drm_drv_uses_atomic_modeset (struct drm_device *dev) +{ +return dev->mode_config.funcs->atomic_commit ?1 :0 ; +} +static inline void drm_device_set_unplugged (struct drm_device *dev) {smp_wmb ();
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm: Get atomic property value even if DRIVER_ATOMIC is not set
i915 does not set DRIVER_ATOMIC by default yet but uses atomic_check and atomic_commit. drm_object_property_get_value() does not read the correct value of atomic properties if DRIVER_ATOMIC is not set. Checking whether the driver uses atomic modeset is a better check instead as the property values are tracked in the state structures.
--- drivers/gpu/drm/drm_mode_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_mode_object.c +1 -1
@@ -273,7 +273,7 @@ int drm_object_property_get_value(struct drm_mode_object *obj,* their value in obj->properties->values[].. mostly to avoid * having to deal w/ EDID and similar props in atomic paths: */ -if (drm_core_check_feature (property->dev,DRIVER_ATOMIC ) && +if (drm_drv_uses_atomic_modeset (property->dev) && !(property->flags &DRM_MODE_PROP_IMMUTABLE ))return drm_atomic_get_property (obj, property, val);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm: Get atomic property value even if DRIVER_ATOMIC is not set
Quoted 8 lines · Dhinakaran Pandiyan
i915 does not set
DRIVER_ATOMICby default yet but usesatomic_checkandatomic_commit.drm_object_property_get_value()does not read the correct value of atomic properties ifDRIVER_ATOMICis not set. Checking whether the driver uses atomic modeset is a better check instead as the property values are tracked in the state structures.Cc Daniel Vetter <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>
I've reviewed all other users for DRIVER_ATOMIC checks, and I think this is the only one left that we should change. Will merge as soon as you've respun patch 1.
-Daniel
Quoted 20 lines
--- drivers/gpu/drm/drm_mode_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_mode_object.c +1
-1@@ -273,7 +273,7 @@ int drm_object_property_get_value(struct drm_mode_object *obj,* their value in obj->properties->values[].. mostly to avoid * having to deal w/ EDID and similar props in atomic paths: */ -if (drm_core_check_feature (property->dev,DRIVER_ATOMIC ) && +if (drm_drv_uses_atomic_modeset (property->dev) && !(property->flags &DRM_MODE_PROP_IMMUTABLE ))return drm_atomic_get_property (obj, property, val);Signature · 1 line
2.7.4
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/2] drm: Wrap the check for atomic_commit implementation
In reply to Dhinakaran Pandiyan== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm: Wrap the check for atomic_commit implementation
URL : https://patchwork.freedesktop.org/series/17075/
State : success
== Summary ==
Series 17075v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/17075/revisions/1/mbox/
fi-bdw-5557u total:247 pass:233 dwarn:0 dfail:0 fail:0 skip:14 fi-bsw-n3050 total:247 pass:208 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:247 pass:225 dwarn:1 dfail:0 fail:0 skip:21 fi-bxt-t5700 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-j1900 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19 fi-hsw-4770r total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19 fi-ilk-650 total:247 pass:195 dwarn:0 dfail:0 fail:0 skip:52 fi-ivb-3520m total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21 fi-ivb-3770 total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21 fi-kbl-7500u total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6260u total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13 fi-skl-6700hq total:247 pass:227 dwarn:0 dfail:0 fail:0 skip:20 fi-skl-6700k total:247 pass:224 dwarn:3 dfail:0 fail:0 skip:20 fi-skl-6770hq total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13 fi-snb-2520m total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31 fi-snb-2600 total:247 pass:215 dwarn:0 dfail:0 fail:0 skip:32
6096aee14ea52e3163729129ee7362e56ff3efb9 drm-tip: 2016y-12m-20d-16h-33m-17s UTC integration manifest 92a7917 drm: Get atomic property value even if DRIVER_ATOMIC is not set
4555b02 drm: Wrap the check for atomic_commit implementation
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3348/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 119 lines · Dhinakaran Pandiyan
This check is useful for drivers that do not have
DRIVER_ATOMICset but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.Suggested-by Daniel Vetter <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ben Skeggs <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>--- drivers/gpu/drm/drm_fb_helper.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +- include/drm/drmP.h | 5 +++++ 5 files changed, 14 insertions(+), 9 deletions(-)drivers/gpu/drm/drm_fb_helper.c +3
-3@@ -405,7 +405,7 @@ static int restore_fbdev_mode(struct drm_fb_helper *fb_helper)drm_warn_on_modeset_not_all_locked (dev); -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev))return restore_fbdev_mode_atomic (fb_helper);drm_for_each_plane (plane, dev) {@@ -1444,7 +1444,7 @@ int drm_fb_helper_pan_display(struct fb_var_screeninfo *var,return -EBUSY ; } -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) { ret =pan_display_atomic (var, info); goto unlock; }@@ -2060,7 +2060,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,* NULL we fallback to the default drm_atomic_helper_best_encoder() * helper. */ -if (fb_helper->dev->mode_config.funcs->atomic_commit && +if (drm_drv_uses_atomic_modeset (fb_helper->dev) && !connector_funcs->best_encoder) encoder =drm_atomic_helper_best_encoder (connector);else drivers/gpu/drm/nouveau/nouveau_connector.c +2
-2@@ -769,7 +769,7 @@ nouveau_connector_set_property(struct drm_connector *connector,struct drm_encoder *encoder =to_drm_encoder (nv_encoder);int ret; -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_set_property (connector, property, value); ret = connector->funcs->atomic_set_property(&nv_connector->base,@@ -1074,7 +1074,7 @@ nouveau_connector_helper_funcs = {static int nouveau_connector_dpms (struct drm_connector *connector,int mode) { -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_dpms (connector, mode);return drm_helper_connector_dpms (connector, mode); }drivers/gpu/drm/nouveau/nouveau_display.c +3
-3@@ -162,7 +162,7 @@ nouveau_display_vblstamp(struct drm_device *dev, unsigned int pipe,list_for_each_entry (crtc, &dev->mode_config.crtc_list, head) {if (nouveau_crtc (crtc)->index == pipe) {struct drm_display_mode *mode; -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev)) mode = &crtc->state->adjusted_mode;else mode = &crtc->hwmode;@@ -738,7 +738,7 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)struct nouveau_display *disp =nouveau_display (dev);struct drm_crtc *crtc; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {if (!runtime) { disp->suspend =nouveau_atomic_suspend (dev);if (IS_ERR (disp->suspend)) {@@ -784,7 +784,7 @@ nouveau_display_resume(struct drm_device *dev, bool runtime)struct drm_crtc *crtc;int ret; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {nouveau_display_init (dev);if (disp->suspend) {drm_atomic_helper_resume (dev, disp->suspend);drivers/gpu/drm/nouveau/nouveau_fbcon.c +1
-1@@ -524,7 +524,7 @@ nouveau_fbcon_init(struct drm_device *dev) preferred_bpp =32 ;/* disable all the possible outputs/crtcs before entering KMS mode */ -if (!dev->mode_config.funcs->atomic_commit) +if (!drm_drv_uses_atomic_modeset (dev))drm_helper_disable_unused_functions (dev); ret =drm_fb_helper_initial_config (&fbcon->helper, preferred_bpp);include/drm/drmP.h +0
-0
include/drm/drmP.h static __inline__ int drm_core_check_feature(struct drm_device *dev, · line 650
Quoted 4 lines
include/drm/drmP.h +1
-0@@ -647,6 +647,11 @@ static __inline__ int drm_core_check_feature(struct drm_device *dev,return ((dev->driver->driver_features & feature) ?1 :0 ); } +static inline int drm_drv_uses_atomic_modeset (struct drm_device *dev)
Please put this into the drm_atomic.h header and wrap some kernel-doc around it to explain when to use this. Otherwise looks good to me. -Daniel
Quoted 10 lines
include/drm/drmP.h +4
-0+{ +return dev->mode_config.funcs->atomic_commit ?1 :0 ; +} +static inline void drm_device_set_unplugged (struct drm_device *dev) {smp_wmb ();Signature · 1 line
2.7.4
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/2 drm: Wrap the check for atomic_commit implementation
This check is useful for drivers that do not have DRIVER_ATOMIC set but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.
v2:
Change return type to bool (Ville)
Move the function drm_atomic.h (Daniel)
--- drivers/gpu/drm/drm_fb_helper.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_connector.c | 5 +++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 ++- include/drm/drm_atomic.h | 11 +++++++++++ 5 files changed, 22 insertions(+), 9 deletions(-)
drivers/gpu/drm/drm_fb_helper.c +3 -3
@@ -405,7 +405,7 @@ static int restore_fbdev_mode(struct drm_fb_helper *fb_helper)drm_warn_on_modeset_not_all_locked (dev); -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev))return restore_fbdev_mode_atomic (fb_helper);drm_for_each_plane (plane, dev) {
@@ -1444,7 +1444,7 @@ int drm_fb_helper_pan_display(struct fb_var_screeninfo *var,return -EBUSY ; } -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) { ret =pan_display_atomic (var, info); goto unlock; }
@@ -2060,7 +2060,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,* NULL we fallback to the default drm_atomic_helper_best_encoder() * helper. */ -if (fb_helper->dev->mode_config.funcs->atomic_commit && +if (drm_drv_uses_atomic_modeset (fb_helper->dev) && !connector_funcs->best_encoder) encoder =drm_atomic_helper_best_encoder (connector);else
drivers/gpu/drm/nouveau/nouveau_connector.c +3 -2
@@ -33,6 +33,7 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_edid.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_atomic.h> #include "nouveau_reg.h" #include "nouveau_drv.h"
@@ -769,7 +770,7 @@ nouveau_connector_set_property(struct drm_connector *connector,struct drm_encoder *encoder =to_drm_encoder (nv_encoder);int ret; -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_set_property (connector, property, value); ret = connector->funcs->atomic_set_property(&nv_connector->base,
@@ -1074,7 +1075,7 @@ nouveau_connector_helper_funcs = {static int nouveau_connector_dpms (struct drm_connector *connector,int mode) { -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_dpms (connector, mode);return drm_helper_connector_dpms (connector, mode); }
drivers/gpu/drm/nouveau/nouveau_display.c +3 -3
@@ -162,7 +162,7 @@ nouveau_display_vblstamp(struct drm_device *dev, unsigned int pipe,list_for_each_entry (crtc, &dev->mode_config.crtc_list, head) {if (nouveau_crtc (crtc)->index == pipe) {struct drm_display_mode *mode; -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev)) mode = &crtc->state->adjusted_mode;else mode = &crtc->hwmode;
@@ -738,7 +738,7 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)struct nouveau_display *disp =nouveau_display (dev);struct drm_crtc *crtc; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {if (!runtime) { disp->suspend =nouveau_atomic_suspend (dev);if (IS_ERR (disp->suspend)) {
@@ -784,7 +784,7 @@ nouveau_display_resume(struct drm_device *dev, bool runtime)struct drm_crtc *crtc;int ret; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {nouveau_display_init (dev);if (disp->suspend) {drm_atomic_helper_resume (dev, disp->suspend);
drivers/gpu/drm/nouveau/nouveau_fbcon.c +2 -1
@@ -41,6 +41,7 @@#include <drm/drm_crtc.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_fb_helper.h> +#include <drm/drm_atomic.h> #include "nouveau_drv.h" #include "nouveau_gem.h"
@@ -524,7 +525,7 @@ nouveau_fbcon_init(struct drm_device *dev) preferred_bpp =32 ;/* disable all the possible outputs/crtcs before entering KMS mode */ -if (!dev->mode_config.funcs->atomic_commit) +if (!drm_drv_uses_atomic_modeset (dev))drm_helper_disable_unused_functions (dev); ret =drm_fb_helper_initial_config (&fbcon->helper, preferred_bpp);
include/drm/drm_atomic.h +11 -0
@@ -419,5 +419,16 @@ drm_atomic_crtc_needs_modeset(const struct drm_crtc_state *state) state->connectors_changed; } +/* drm_drv_uses_atomic_modeset - check if the driver implements +* atomic_commit() +* @dev: DRM device +* +* This check is useful if drivers do not have DRIVER_ATOMIC set but +* have atomic modesetting internally implemented. +*/ +static inline bool drm_drv_uses_atomic_modeset (struct drm_device *dev) +{ +return dev->mode_config.funcs->atomic_commit ? true : false; +}#endif /* DRM_ATOMIC_H_ */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/2 drm: Get atomic property value even if DRIVER_ATOMIC is not set
i915 does not set DRIVER_ATOMIC by default yet but uses atomic_check and atomic_commit. drm_object_property_get_value() does not read the correct value of atomic properties if DRIVER_ATOMIC is not set. Checking whether the driver uses atomic modeset is a better check instead as the property values are tracked in the state structures.
v2: Included header
--- drivers/gpu/drm/drm_mode_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_mode_object.c +2 -1
@@ -23,6 +23,7 @@#include <linux/export.h> #include <drm/drmP.h> #include <drm/drm_mode_object.h> +#include <drm/drm_atomic.h> #include "drm_crtc_internal.h"
@@ -273,7 +274,7 @@ int drm_object_property_get_value(struct drm_mode_object *obj,* their value in obj->properties->values[].. mostly to avoid * having to deal w/ EDID and similar props in atomic paths: */ -if (drm_core_check_feature (property->dev,DRIVER_ATOMIC ) && +if (drm_drv_uses_atomic_modeset (property->dev) && !(property->flags &DRM_MODE_PROP_IMMUTABLE ))return drm_atomic_get_property (obj, property, val);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2 2/2] drm: Get atomic property value even if DRIVER_ATOMIC is not set
Quoted 6 lines · Dhinakaran Pandiyan
i915 does not set
DRIVER_ATOMICby default yet but usesatomic_checkandatomic_commit.drm_object_property_get_value()does not read the correct value of atomic properties ifDRIVER_ATOMICis not set. Checking whether the driver uses atomic modeset is a better check instead as the property values are tracked in the state structures.
I think we are in the same boat. Adding Andrey and Harry.
Alex
Quoted 33 lines
v2: Included header
Cc Daniel Vetter <[email protected]>Reviewed-by Daniel Vetter <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>--- drivers/gpu/drm/drm_mode_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_mode_object.c +2
-2@@ -23,6 +23,7 @@#include <linux/export.h> #include <drm/drmP.h> #include <drm/drm_mode_object.h> +#include <drm/drm_atomic.h> #include "drm_crtc_internal.h" @@ -273,7 +274,7 @@ int drm_object_property_get_value(struct drm_mode_object *obj,* their value in obj->properties->values[].. mostly to avoid * having to deal w/ EDID and similar props in atomic paths: */ -if (drm_core_check_feature (property->dev,DRIVER_ATOMIC ) && +if (drm_drv_uses_atomic_modeset (property->dev) && !(property->flags &DRM_MODE_PROP_IMMUTABLE ))return drm_atomic_get_property (obj, property, val); --2.7.4
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 142 lines · Dhinakaran Pandiyan
This check is useful for drivers that do not have
DRIVER_ATOMICset but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.v2:
Change return type to bool (Ville)
Move the functiondrm_atomic.h(Daniel)Suggested-by Daniel Vetter <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ben Skeggs <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>--- drivers/gpu/drm/drm_fb_helper.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_connector.c | 5 +++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 ++- include/drm/drm_atomic.h | 11 +++++++++++ 5 files changed, 22 insertions(+), 9 deletions(-)drivers/gpu/drm/drm_fb_helper.c +3
-3@@ -405,7 +405,7 @@ static int restore_fbdev_mode(struct drm_fb_helper *fb_helper)drm_warn_on_modeset_not_all_locked (dev); -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev))return restore_fbdev_mode_atomic (fb_helper);drm_for_each_plane (plane, dev) {@@ -1444,7 +1444,7 @@ int drm_fb_helper_pan_display(struct fb_var_screeninfo *var,return -EBUSY ; } -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) { ret =pan_display_atomic (var, info); goto unlock; }@@ -2060,7 +2060,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,* NULL we fallback to the default drm_atomic_helper_best_encoder() * helper. */ -if (fb_helper->dev->mode_config.funcs->atomic_commit && +if (drm_drv_uses_atomic_modeset (fb_helper->dev) && !connector_funcs->best_encoder) encoder =drm_atomic_helper_best_encoder (connector);else drivers/gpu/drm/nouveau/nouveau_connector.c +3
-2@@ -33,6 +33,7 @@#include <drm/drm_atomic_helper.h> #include <drm/drm_edid.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_atomic.h> #include "nouveau_reg.h" #include "nouveau_drv.h" @@ -769,7 +770,7 @@ nouveau_connector_set_property(struct drm_connector *connector,struct drm_encoder *encoder =to_drm_encoder (nv_encoder);int ret; -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_set_property (connector, property, value); ret = connector->funcs->atomic_set_property(&nv_connector->base,@@ -1074,7 +1075,7 @@ nouveau_connector_helper_funcs = {static int nouveau_connector_dpms (struct drm_connector *connector,int mode) { -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_dpms (connector, mode);return drm_helper_connector_dpms (connector, mode); }drivers/gpu/drm/nouveau/nouveau_display.c +3
-3@@ -162,7 +162,7 @@ nouveau_display_vblstamp(struct drm_device *dev, unsigned int pipe,list_for_each_entry (crtc, &dev->mode_config.crtc_list, head) {if (nouveau_crtc (crtc)->index == pipe) {struct drm_display_mode *mode; -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev)) mode = &crtc->state->adjusted_mode;else mode = &crtc->hwmode;@@ -738,7 +738,7 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)struct nouveau_display *disp =nouveau_display (dev);struct drm_crtc *crtc; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {if (!runtime) { disp->suspend =nouveau_atomic_suspend (dev);if (IS_ERR (disp->suspend)) {@@ -784,7 +784,7 @@ nouveau_display_resume(struct drm_device *dev, bool runtime)struct drm_crtc *crtc;int ret; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {nouveau_display_init (dev);if (disp->suspend) {drm_atomic_helper_resume (dev, disp->suspend);drivers/gpu/drm/nouveau/nouveau_fbcon.c +2
-1@@ -41,6 +41,7 @@#include <drm/drm_crtc.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_fb_helper.h> +#include <drm/drm_atomic.h> #include "nouveau_drv.h" #include "nouveau_gem.h" @@ -524,7 +525,7 @@ nouveau_fbcon_init(struct drm_device *dev) preferred_bpp =32 ;/* disable all the possible outputs/crtcs before entering KMS mode */ -if (!dev->mode_config.funcs->atomic_commit) +if (!drm_drv_uses_atomic_modeset (dev))drm_helper_disable_unused_functions (dev); ret =drm_fb_helper_initial_config (&fbcon->helper, preferred_bpp);include/drm/drm_atomic.h +0
-0@@ -419,5 +419,16 @@ drm_atomic_crtc_needs_modeset(const struct drm_crtc_state *state) state->connectors_changed; }
include/drm/drm_atomic.h drm_atomic_crtc_needs_modeset(const struct drm_crtc_state *state) · line 431
Quoted 10 lines
include/drm/drm_atomic.h +10
-0+/* drm_drv_uses_atomic_modeset - check if the driver implements +* atomic_commit() +* @dev: DRM device +* +* This check is useful if drivers do not have DRIVER_ATOMIC set but +* have atomic modesetting internally implemented. +*/ +static inline bool drm_drv_uses_atomic_modeset (struct drm_device *dev) +{ +return dev->mode_config.funcs->atomic_commit ? true : false;
You forgot the part from Ville's review that the entire "?:" at the end is
redundant: A pointer in bool context automatically converts to a bool like this, and we use this _everywhere_. Please remove and respin.
Also when you resend the entire patch series, pls start a new thread. CI otherwise assumes that you're only partially resend patches and tries to merge old&new series, which doesn't apply ofc. Since it's already a mess you new to start a new series even if only patch 1 changed. -Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botreproduce:
Hi Dhinakaran,
[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20161222]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dhinakaran-Pandiyan/drm-Wrap-the-check-for-atomic_commit-implementation/20161222-153523 base: git://people.freedesktop.org/~airlied/linux.git drm-next config: i386-randconfig-s1-201651 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c:19:0:
include/drm/drm_atomic.h: In function 'drm_drv_uses_atomic_modeset':
>> include/drm/drm_atomic.h:436:12: error: dereferencing pointer to incomplete type 'struct drm_device'
return dev->mode_config.funcs->atomic_commit ? true : false;
^~vim +436 include/drm/drm_atomic.h
430 *
431 * This check is useful if drivers do not have DRIVER_ATOMIC set but
432 * have atomic modesetting internally implemented.
433 */
434 static inline bool drm_drv_uses_atomic_modeset(struct drm_device *dev)
435 {
> 436 return dev->mode_config.funcs->atomic_commit ? true : false;
437 }
438
439 #endif /* DRM_ATOMIC_H_ */
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 21 lines · Dhinakaran Pandiyan
This check is useful for drivers that do not have
DRIVER_ATOMICset but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.v2:
Change return type to bool (Ville)
Move the functiondrm_atomic.h(Daniel)Suggested-by Daniel Vetter <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ben Skeggs <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>---
drivers/gpu/drm/drm_fb_helper.c | 6 +++---drivers/gpu/drm/nouveau/nouveau_connector.c| 5 +++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 ++- include/drm/drm_atomic.h | 11 +++++++++++5 files changed, 22 insertions(+), 9 deletions(-)
...
Quoted 10 lines
include/drm/drm_atomic.h +0
-0@@ -419,5 +419,16 @@ drm_atomic_crtc_needs_modeset(const struct drm_crtc_state *state) state->connectors_changed; }
+/*drm_drv_uses_atomic_modeset- check if the driver implements
Shouldn't this be
/**
* drm_drv_uses_atomic_modeset - ...
so it is included in the generated documentation?
Ander
Quoted 10 lines
+ *
atomic_commit()
+ * @dev: DRM device
+ *
+ * This check is useful if drivers do not haveDRIVER_ATOMICset but
+ * have atomic modesetting internally implemented.
+ */include/drm/drm_atomic.h +4
-0+static inline bool drm_drv_uses_atomic_modeset (struct drm_device *dev) +{ +return dev->mode_config.funcs->atomic_commit ? true : false; +}
Quoted 2 lines
#endif /*DRM_ATOMIC_H_*/
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 38 lines · Ander Conselvan De Oliveira
Quoted 21 lines · Dhinakaran Pandiyan
This check is useful for drivers that do not have
DRIVER_ATOMICset but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.v2:
Change return type to bool (Ville)
Move the functiondrm_atomic.h(Daniel)Suggested-by Daniel Vetter <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ben Skeggs <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>---
drivers/gpu/drm/drm_fb_helper.c | 6 +++---drivers/gpu/drm/nouveau/nouveau_connector.c| 5 +++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 ++- include/drm/drm_atomic.h | 11 +++++++++++5 files changed, 22 insertions(+), 9 deletions(-)...
Quoted 10 lines
include/drm/drm_atomic.h +0
-0@@ -419,5 +419,16 @@ drm_atomic_crtc_needs_modeset(const struct drm_crtc_state *state) state->connectors_changed; }
+/*drm_drv_uses_atomic_modeset- check if the driver implementsShouldn't this be
Quoted 4 lines
/**
* drm_drv_uses_atomic_modeset - ...so it is included in the generated documentation?
Yup. I'm blind this week it seems. DK, please run
$ make DOCBOOKS="" htmldocs
and make sure your new documentation does get rendered correctly and shows up in the output.
-Daniel
Quoted 16 lines
Ander
Quoted 12 lines
+ *
atomic_commit()
+ * @dev: DRM device
+ *
+ * This check is useful if drivers do not haveDRIVER_ATOMICset but
+ * have atomic modesetting internally implemented.
+ */include/drm/drm_atomic.h +4
-0+static inline bool drm_drv_uses_atomic_modeset (struct drm_device *dev) +{ +return dev->mode_config.funcs->atomic_commit ? true : false; +}
#endif /*DRM_ATOMIC_H_*/
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
Done, hope I got it right this time.
-DK
-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Thursday, December 22, 2016 12:52 AM
To: Ander Conselvan De Oliveira <[email protected]>
Cc: Pandiyan, Dhinakaran <[email protected]>; [email protected]; Daniel Vetter <[email protected]>; [email protected]; Ben Skeggs <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm: Wrap the check for atomic_commit implementation
Quoted 39 lines · Ander Conselvan De Oliveira
Quoted 21 lines · Dhinakaran Pandiyan
This check is useful for drivers that do not have
DRIVER_ATOMICset but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.v2:
Change return type to bool (Ville)
Move the functiondrm_atomic.h(Daniel)Suggested-by Daniel Vetter <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ben Skeggs <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>---
drivers/gpu/drm/drm_fb_helper.c | 6 +++---drivers/gpu/drm/nouveau/nouveau_connector.c| 5 +++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 3 ++- include/drm/drm_atomic.h | 11 +++++++++++5 files changed, 22 insertions(+), 9 deletions(-)...
Quoted 11 lines
include/drm/drm_atomic.h +0
-0@@ -419,5 +419,16 @@ drm_atomic_crtc_needs_modeset(const struct
drm_crtc_state
*state)
state->connectors_changed;
}
+/*drm_drv_uses_atomic_modeset- check if the driver implementsShouldn't this be
Quoted 4 lines
/**
* drm_drv_uses_atomic_modeset - ...so it is included in the generated documentation?
Yup. I'm blind this week it seems. DK, please run
$ make DOCBOOKS="" htmldocs
and make sure your new documentation does get rendered correctly and shows up in the output. -Daniel
Quoted 4 lines
Ander
Quoted 12 lines
Quoted 10 lines
+ *
atomic_commit()
+ * @dev: DRM device
+ *
+ * This check is useful if drivers do not haveDRIVER_ATOMICsetinclude/drm/drm_atomic.h +6
-0+but +* have atomic modesetting internally implemented. +*/ +static inline bool drm_drv_uses_atomic_modeset (struct drm_device +*dev) { +return dev->mode_config.funcs->atomic_commit ? true : false; }Quoted 2 lines
#endif /*DRM_ATOMIC_H_*/
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 119 lines · Dhinakaran Pandiyan
This check is useful for drivers that do not have
DRIVER_ATOMICset but have atomic modesetting internally implemented. Wrap the check into a function since this is used in many places and as a bonus, the function name helps to document what the check is for.Suggested-by Daniel Vetter <[email protected]>Cc Daniel Vetter <[email protected]>Cc Ben Skeggs <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>--- drivers/gpu/drm/drm_fb_helper.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_display.c | 6 +++--- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 2 +- include/drm/drmP.h | 5 +++++ 5 files changed, 14 insertions(+), 9 deletions(-)drivers/gpu/drm/drm_fb_helper.c +3
-3@@ -405,7 +405,7 @@ static int restore_fbdev_mode(struct drm_fb_helper *fb_helper)drm_warn_on_modeset_not_all_locked (dev); -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev))return restore_fbdev_mode_atomic (fb_helper);drm_for_each_plane (plane, dev) {@@ -1444,7 +1444,7 @@ int drm_fb_helper_pan_display(struct fb_var_screeninfo *var,return -EBUSY ; } -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) { ret =pan_display_atomic (var, info); goto unlock; }@@ -2060,7 +2060,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,* NULL we fallback to the default drm_atomic_helper_best_encoder() * helper. */ -if (fb_helper->dev->mode_config.funcs->atomic_commit && +if (drm_drv_uses_atomic_modeset (fb_helper->dev) && !connector_funcs->best_encoder) encoder =drm_atomic_helper_best_encoder (connector);else drivers/gpu/drm/nouveau/nouveau_connector.c +2
-2@@ -769,7 +769,7 @@ nouveau_connector_set_property(struct drm_connector *connector,struct drm_encoder *encoder =to_drm_encoder (nv_encoder);int ret; -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_set_property (connector, property, value); ret = connector->funcs->atomic_set_property(&nv_connector->base,@@ -1074,7 +1074,7 @@ nouveau_connector_helper_funcs = {static int nouveau_connector_dpms (struct drm_connector *connector,int mode) { -if (connector->dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (connector->dev))return drm_atomic_helper_connector_dpms (connector, mode);return drm_helper_connector_dpms (connector, mode); }drivers/gpu/drm/nouveau/nouveau_display.c +3
-3@@ -162,7 +162,7 @@ nouveau_display_vblstamp(struct drm_device *dev, unsigned int pipe,list_for_each_entry (crtc, &dev->mode_config.crtc_list, head) {if (nouveau_crtc (crtc)->index == pipe) {struct drm_display_mode *mode; -if (dev->mode_config.funcs->atomic_commit) +if (drm_drv_uses_atomic_modeset (dev)) mode = &crtc->state->adjusted_mode;else mode = &crtc->hwmode;@@ -738,7 +738,7 @@ nouveau_display_suspend(struct drm_device *dev, bool runtime)struct nouveau_display *disp =nouveau_display (dev);struct drm_crtc *crtc; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {if (!runtime) { disp->suspend =nouveau_atomic_suspend (dev);if (IS_ERR (disp->suspend)) {@@ -784,7 +784,7 @@ nouveau_display_resume(struct drm_device *dev, bool runtime)struct drm_crtc *crtc;int ret; -if (dev->mode_config.funcs->atomic_commit) { +if (drm_drv_uses_atomic_modeset (dev)) {nouveau_display_init (dev);if (disp->suspend) {drm_atomic_helper_resume (dev, disp->suspend);drivers/gpu/drm/nouveau/nouveau_fbcon.c +1
-1@@ -524,7 +524,7 @@ nouveau_fbcon_init(struct drm_device *dev) preferred_bpp =32 ;/* disable all the possible outputs/crtcs before entering KMS mode */ -if (!dev->mode_config.funcs->atomic_commit) +if (!drm_drv_uses_atomic_modeset (dev))drm_helper_disable_unused_functions (dev); ret =drm_fb_helper_initial_config (&fbcon->helper, preferred_bpp);include/drm/drmP.h +0
-0
include/drm/drmP.h static __inline__ int drm_core_check_feature(struct drm_device *dev, · line 653
Quoted 7 lines
include/drm/drmP.h +4
-0@@ -647,6 +647,11 @@ static __inline__ int drm_core_check_feature(struct drm_device *dev,return ((dev->driver->driver_features & feature) ?1 :0 ); } +static inline int drm_drv_uses_atomic_modeset (struct drm_device *dev) +{ +return dev->mode_config.funcs->atomic_commit ?1 :0 ; +}
bool ...
{
return atomic_commit != NULL;
}Quoted 11 lines
include/drm/drmP.h +1
-0+static inline void drm_device_set_unplugged (struct drm_device *dev) {smp_wmb ();Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [v2,2/2] drm: Get atomic property value even if DRIVER_ATOMIC is not set (rev3)
In reply to Dhinakaran Pandiyan== Series Details ==
== Series Details ==
Series: series starting with [v2,2/2] drm: Get atomic property value even if DRIVER_ATOMIC is not set (rev3)
URL : https://patchwork.freedesktop.org/series/17075/
State : failure
== Summary ==
CC [M] drivers/gpu/drm/i915/intel_dsi_panel_vbt.o CC [M] drivers/gpu/drm/i915/intel_dsi_pll.o CC [M] drivers/gpu/drm/i915/intel_i2c.o CC [M] drivers/gpu/drm/i915/intel_hdmi.o CC [M] drivers/gpu/drm/i915/intel_dvo.o CC [M] drivers/gpu/drm/i915/intel_lvds.o CC [M] drivers/gpu/drm/i915/intel_lspcon.o CC [M] drivers/gpu/drm/i915/intel_panel.o CC [M] drivers/gpu/drm/i915/intel_sdvo.o CC [M] drivers/gpu/drm/i915/intel_tv.o CC [M] drivers/gpu/drm/i915/i915_perf.o CC [M] drivers/gpu/drm/i915/i915_vgpu.o CC [M] drivers/gpu/drm/i915/i915_gpu_error.o CC [M] drivers/gpu/drm/i915/intel_gvt.o CC [M] drivers/gpu/drm/i915/i915_oa_hsw.o CC [M] drivers/gpu/drm/i915/gvt/gvt.o CC [M] drivers/gpu/drm/i915/gvt/aperture_gm.o CC [M] drivers/gpu/drm/i915/gvt/handlers.o CC [M] drivers/gpu/drm/i915/gvt/trace_points.o CC [M] drivers/gpu/drm/i915/gvt/vgpu.o CC [M] drivers/gpu/drm/i915/gvt/firmware.o CC [M] drivers/gpu/drm/i915/gvt/interrupt.o CC [M] drivers/gpu/drm/i915/gvt/gtt.o CC [M] drivers/gpu/drm/i915/gvt/cfg_space.o CC [M] drivers/gpu/drm/i915/gvt/mmio.o CC [M] drivers/gpu/drm/i915/gvt/opregion.o CC [M] drivers/gpu/drm/i915/gvt/display.o CC [M] drivers/gpu/drm/i915/gvt/edid.o CC [M] drivers/gpu/drm/i915/gvt/execlist.o CC [M] drivers/gpu/drm/i915/gvt/sched_policy.o CC [M] drivers/gpu/drm/i915/gvt/render.o CC [M] drivers/gpu/drm/i915/gvt/scheduler.o CC [M] drivers/gpu/drm/i915/gvt/cmd_parser.o LD [M] sound/pci/hda/snd-hda-codec-generic.o LD sound/pci/built-in.o LD drivers/thermal/thermal_sys.o LD drivers/thermal/built-in.o LD drivers/spi/built-in.o LD drivers/acpi/acpica/acpi.o LD drivers/video/fbdev/built-in.o LD drivers/tty/serial/8250/8250.o LD [M] drivers/net/ethernet/intel/igbvf/igbvf.o LD sound/built-in.o LD drivers/iommu/built-in.o LD net/packet/built-in.o LD drivers/acpi/acpica/built-in.o LD drivers/usb/gadget/udc/udc-core.o LD drivers/scsi/scsi_mod.o LD drivers/usb/gadget/udc/built-in.o LD drivers/usb/gadget/built-in.o LD drivers/acpi/built-in.o LD [M] drivers/net/ethernet/intel/e1000/e1000.o LD net/xfrm/built-in.o LD lib/raid6/raid6_pq.o LD [M] drivers/net/ethernet/broadcom/genet/genet.o LD drivers/video/console/built-in.o LD lib/raid6/built-in.o LD drivers/video/built-in.o LD drivers/tty/serial/8250/8250_base.o LD drivers/scsi/sd_mod.o LD drivers/tty/serial/8250/built-in.o LD drivers/scsi/built-in.o LD drivers/tty/serial/built-in.o LD net/ipv6/ipv6.o LD drivers/usb/core/usbcore.o LD [M] drivers/net/ethernet/intel/igb/igb.o LD net/ipv6/built-in.o LD drivers/usb/core/built-in.o AR lib/lib.a EXPORTS lib/lib-ksyms.o LD lib/built-in.o LD fs/btrfs/btrfs.o LD drivers/md/md-mod.o LD drivers/md/built-in.o CC arch/x86/kernel/cpu/capflags.o LD arch/x86/kernel/cpu/built-in.o LD arch/x86/kernel/built-in.o LD fs/btrfs/built-in.o LD drivers/tty/vt/built-in.o LD drivers/tty/built-in.o LD arch/x86/built-in.o LD net/ipv4/built-in.o LD drivers/usb/host/xhci-hcd.o LD drivers/usb/host/built-in.o LD drivers/usb/built-in.o LD [M] drivers/net/ethernet/intel/e1000e/e1000e.o LD net/core/built-in.o LD net/built-in.o LD fs/ext4/ext4.o LD fs/ext4/built-in.o LD fs/built-in.o LD drivers/net/ethernet/built-in.o LD drivers/net/built-in.o LD [M] drivers/gpu/drm/i915/i915.o
scripts/Makefile.build:544: recipe for target 'drivers/gpu/drm' failed make[2]: *** [drivers/gpu/drm] Error 2 scripts/Makefile.build:544: recipe for target 'drivers/gpu' failed make[1]: *** [drivers/gpu] Error 2
Makefile:988: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [v2,2/2] drm: Get atomic property value even if DRIVER_ATOMIC is not set (rev3)
Don't know what went wrong here, builds fine on my local machine.
-DK
Quoted 109 lines · Patchwork
== Series Details ==
Series: series starting with [v2,2/2] drm: Get atomic property value even if
DRIVER_ATOMICis not set (rev3)
URL : https://patchwork.freedesktop.org/series/17075/
State : failure== Summary ==
CC [M] drivers/gpu/drm/i915/intel_dsi_panel_vbt.o CC [M] drivers/gpu/drm/i915/intel_dsi_pll.o CC [M] drivers/gpu/drm/i915/intel_i2c.o CC [M] drivers/gpu/drm/i915/intel_hdmi.o CC [M] drivers/gpu/drm/i915/intel_dvo.o CC [M] drivers/gpu/drm/i915/intel_lvds.o CC [M] drivers/gpu/drm/i915/intel_lspcon.o CC [M] drivers/gpu/drm/i915/intel_panel.o CC [M] drivers/gpu/drm/i915/intel_sdvo.o CC [M] drivers/gpu/drm/i915/intel_tv.o CC [M] drivers/gpu/drm/i915/i915_perf.o CC [M] drivers/gpu/drm/i915/i915_vgpu.o CC [M] drivers/gpu/drm/i915/i915_gpu_error.o CC [M] drivers/gpu/drm/i915/intel_gvt.o CC [M] drivers/gpu/drm/i915/i915_oa_hsw.o CC [M] drivers/gpu/drm/i915/gvt/gvt.o CC [M] drivers/gpu/drm/i915/gvt/aperture_gm.o CC [M] drivers/gpu/drm/i915/gvt/handlers.o CC [M] drivers/gpu/drm/i915/gvt/trace_points.o CC [M] drivers/gpu/drm/i915/gvt/vgpu.o CC [M] drivers/gpu/drm/i915/gvt/firmware.o CC [M] drivers/gpu/drm/i915/gvt/interrupt.o CC [M] drivers/gpu/drm/i915/gvt/gtt.o CC [M] drivers/gpu/drm/i915/gvt/cfg_space.o CC [M] drivers/gpu/drm/i915/gvt/mmio.o CC [M] drivers/gpu/drm/i915/gvt/opregion.o CC [M] drivers/gpu/drm/i915/gvt/display.o CC [M] drivers/gpu/drm/i915/gvt/edid.o CC [M] drivers/gpu/drm/i915/gvt/execlist.o CC [M] drivers/gpu/drm/i915/gvt/sched_policy.o CC [M] drivers/gpu/drm/i915/gvt/render.o CC [M] drivers/gpu/drm/i915/gvt/scheduler.o CC [M] drivers/gpu/drm/i915/gvt/cmd_parser.o LD [M] sound/pci/hda/snd-hda-codec-generic.o LD sound/pci/built-in.o LD drivers/thermal/thermal_sys.o LD drivers/thermal/built-in.o LD drivers/spi/built-in.o LD drivers/acpi/acpica/acpi.o LD drivers/video/fbdev/built-in.o LD drivers/tty/serial/8250/8250.o LD [M] drivers/net/ethernet/intel/igbvf/igbvf.o LD sound/built-in.o LD drivers/iommu/built-in.o LD net/packet/built-in.o LD drivers/acpi/acpica/built-in.o LD drivers/usb/gadget/udc/udc-core.o LD drivers/scsi/scsi_mod.o LD drivers/usb/gadget/udc/built-in.o LD drivers/usb/gadget/built-in.o LD drivers/acpi/built-in.o LD [M] drivers/net/ethernet/intel/e1000/e1000.o LD net/xfrm/built-in.o LD lib/raid6/raid6_pq.o LD [M] drivers/net/ethernet/broadcom/genet/genet.o LD drivers/video/console/built-in.o LD lib/raid6/built-in.o LD drivers/video/built-in.o LD drivers/tty/serial/8250/8250_base.o LD drivers/scsi/sd_mod.o LD drivers/tty/serial/8250/built-in.o LD drivers/scsi/built-in.o LD drivers/tty/serial/built-in.o LD net/ipv6/ipv6.o LD drivers/usb/core/usbcore.o LD [M] drivers/net/ethernet/intel/igb/igb.o LD net/ipv6/built-in.o LD drivers/usb/core/built-in.o AR lib/lib.a EXPORTS lib/lib-ksyms.o LD lib/built-in.o LD fs/btrfs/btrfs.o LD drivers/md/md-mod.o LD drivers/md/built-in.o CC arch/x86/kernel/cpu/capflags.o LD arch/x86/kernel/cpu/built-in.o LD arch/x86/kernel/built-in.o LD fs/btrfs/built-in.o LD drivers/tty/vt/built-in.o LD drivers/tty/built-in.o LD arch/x86/built-in.o LD net/ipv4/built-in.o LD drivers/usb/host/xhci-hcd.o LD drivers/usb/host/built-in.o LD drivers/usb/built-in.o LD [M] drivers/net/ethernet/intel/e1000e/e1000e.o LD net/core/built-in.o LD net/built-in.o LD fs/ext4/ext4.o LD fs/ext4/built-in.o LD fs/built-in.o LD drivers/net/ethernet/built-in.o LD drivers/net/built-in.o LD [M] drivers/gpu/drm/i915/i915.o
scripts/Makefile.build:544: recipe for target 'drivers/gpu/drm' failed make[2]: *** [drivers/gpu/drm] Error 2scripts/Makefile.build:544: recipe for target 'drivers/gpu' failed make[1]: *** [drivers/gpu] Error 2
Makefile:988: recipe for target 'drivers' failed
make: *** [drivers] Error 2
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx