Skip to contentSkip to conversation

PCI: imx6: Remove redundant message

PATCH Applied Fabio Estevam 3 participants 3 messages Dec 27, 2016 – Jan 11, 2017

Subsystems (2)
Arm i.MX and Layerscape PCI
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 PCI: imx6: Remove redundant message

From: Fabio Estevam <[email protected]>

When a PCI card is not connected, the following messages are seen on mx6:

imx6q-pcie 1ffc000.pcie: phy link never came up
imx6q-pcie 1ffc000.pcie: Link never came up

The first one comes from the pcie-designware.c core file, so remove the redundant one from the imx6 driver.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/pci/host/pci-imx6.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/host/pci-imx6.c +1 -3
index c8cefb0..66c3b84 100644
@@ -502,10 +502,8 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie)
 			IMX6Q_GPR12_PCIE_CTL_2, 1 << 10);
 
 	ret = imx6_pcie_wait_for_link(imx6_pcie);
-	if (ret) {
-		dev_info(dev, "Link never came up\n");
+	if (ret)
 		goto err_reset_phy;
-	}
 
 	if (imx6_pcie->link_gen == 2) {
 		/* Allow Gen2 mode after the link is up. */
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw

Am Dienstag, den 27.12.2016, 12:40 -0200 schrieb Fabio Estevam:

Quoted 11 lines

From: Fabio Estevam <[email protected]>

When a PCI card is not connected, the following messages are seen on mx6:

imx6q-pcie 1ffc000.pcie: phy link never came up
imx6q-pcie 1ffc000.pcie: Link never came up

The first one comes from the pcie-designware.c core file, so remove the redundant one from the imx6 driver.

Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Lucas Stach <[email protected]>
Quoted 20 lines
---
 drivers/pci/host/pci-imx6.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/host/pci-imx6.c +1 -3
index c8cefb0..66c3b84 100644
@@ -502,10 +502,8 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie)
 			IMX6Q_GPR12_PCIE_CTL_2, 1 << 10);
 
 	ret = imx6_pcie_wait_for_link(imx6_pcie);
-	if (ret) {
-		dev_info(dev, "Link never came up\n");
+	if (ret)
 		goto err_reset_phy;
-	}
 
 	if (imx6_pcie->link_gen == 2) {
 		/* Allow Gen2 mode after the link is up. */
Reviewed-by Lucas Stach on v1 1/1 Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When a PCI card is not connected, the following messages are seen on mx6:

imx6q-pcie 1ffc000.pcie: phy link never came up
imx6q-pcie 1ffc000.pcie: Link never came up

The first one comes from the pcie-designware.c core file, so remove the redundant one from the imx6 driver.

Signed-off-by Fabio Estevam <[email protected]>

Applied to pci/host-imx6 for v4.11 with Lucas' Reviewed-by and the following changelog:

PCI: imx6: Remove redundant "Link never came up" message

When a PCI card is not connected, the following messages are seen on mx6:

imx6q-pcie 1ffc000.pcie: phy link never came up imx6q-pcie 1ffc000.pcie: Link never came up

The first one comes from the pcie-designware.c core file, so remove the redundant one from the imx6 driver.

Signed-off-by Fabio Estevam <[email protected]>
Signed-off-by Bjorn Helgaas <[email protected]>
Reviewed-by Lucas Stach <[email protected]>
Quoted 27 lines
---
 drivers/pci/host/pci-imx6.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/host/pci-imx6.c +1 -3
index c8cefb0..66c3b84 100644
@@ -502,10 +502,8 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie)
 			IMX6Q_GPR12_PCIE_CTL_2, 1 << 10);
 
 	ret = imx6_pcie_wait_for_link(imx6_pcie);
-	if (ret) {
-		dev_info(dev, "Link never came up\n");
+	if (ret)
 		goto err_reset_phy;
-	}
 
 	if (imx6_pcie->link_gen == 2) {
 		/* Allow Gen2 mode after the link is up. */
Signature · 6 lines
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html