kernel: drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()
Subsystems (3)
PATCH 1/1 kernel: drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()
The 'req->mip_levels' parameter in vmw_gb_surface_define_ioctl() is a user-controlled 'uint32_t' value which is used as a loop count limit. This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'.
References:
https://bugzilla.redhat.com/show_bug.cgi?id=1437431
--- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +4 -0
@@ -1281,6 +1281,10 @@ int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data,if (req->multisample_count !=0 )return -EINVAL ; +if (req->mip_levels >DRM_VMW_MAX_SURFACE_FACES * +DRM_VMW_MAX_MIP_LEVELS ) +return -EINVAL ; +if (unlikely (vmw_user_surface_size ==0 )) vmw_user_surface_size =ttm_round_pot (sizeof (*user_srf)) +128 ;
Signature · 6 lines
2.9.3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
This flaw was assigned an id CVE-2017-7346 by MITRE:
http://seclists.org/oss-sec/2017/q1/696
Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer
----- Original Message -----
From: "Vladis Dronov" <[email protected]>
To: "VMware Graphics" <[email protected]>, "Sinclair Yeh" <[email protected]>, "Thomas Hellstrom" <[email protected]>, "David Airlie" <[email protected]>, [email protected], [email protected]
Cc: "Vladis Dronov" <[email protected]>
Sent: Thursday, March 30, 2017 12:27:12 PM
Subject: [PATCH] kernel: drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()
The 'req->mip_levels' parameter in vmw_gb_surface_define_ioctl() is a user-controlled 'uint32_t' value which is used as a loop count limit. This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'.
References:
https://bugzilla.redhat.com/show_bug.cgi?id=1437431
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Vladis,
Quoted 16 lines · Vladis Dronov
The '
req->mip_levels' parameter invmw_gb_surface_define_ioctl()is a user-controlled 'uint32_t' value which is used as a loop count limit. This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'.Signed-off-by Vladis Dronov <[email protected]>--- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +0
-0
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data, · line 1287
Quoted 7 lines
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +4
-0@@ -1281,6 +1281,10 @@ int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data,if (req->multisample_count !=0 )return -EINVAL ; +if (req->mip_levels >DRM_VMW_MAX_SURFACE_FACES * +DRM_VMW_MAX_MIP_LEVELS ) +return -EINVAL ; +
Here, the check should be "> DRM_VMW_MAX_MIP_LEVELS" because req->mip_levels is only for one layer.
Also, as long as we can doing a check, I would suggest we check for 0 as well.
Sinclair
Hello, Sinclair!
Quoted 2 lines
Here, the check should be ">
DRM_VMW_MAX_MIP_LEVELS" becausereq->mip_levelsis only for one layer.
Got it, thanks!
Quoted 2 lines
Also, as long as we can doing a check, I would suggest we check for 0 as well.
Do you mean a check for "req->mip_levels > 0" or for "req->mip_levels >= 0" ?
I glimpsed thru the code and I do not see problems with req->mip_levels being 0, surely I may be mistaking.
Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer
----- Original Message -----
From: "Sinclair Yeh" <[email protected]>
To: "Vladis Dronov" <[email protected]>
Cc: "VMware Graphics" <[email protected]>, "Thomas Hellstrom" <[email protected]>, "David Airlie" <[email protected]>, [email protected], [email protected]
Sent: Friday, March 31, 2017 5:07:12 PM
Subject: Re: [PATCH] kernel: drm/vmwgfx: limit the number of mip levels in vmw_gb_surface_define_ioctl()
Hi Vladis,
Quoted 16 lines · Vladis Dronov
The '
req->mip_levels' parameter invmw_gb_surface_define_ioctl()is a user-controlled 'uint32_t' value which is used as a loop count limit. This can lead to a kernel lockup and DoS. Add check for 'req->mip_levels'.Signed-off-by Vladis Dronov <[email protected]>--- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +0
-0
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data, · line 1287
Quoted 7 lines
drivers/gpu/drm/vmwgfx/vmwgfx_surface.c +4
-0@@ -1281,6 +1281,10 @@ int vmw_gb_surface_define_ioctl(struct drm_device *dev, void *data,if (req->multisample_count !=0 )return -EINVAL ; +if (req->mip_levels >DRM_VMW_MAX_SURFACE_FACES * +DRM_VMW_MAX_MIP_LEVELS ) +return -EINVAL ; +
Here, the check should be "> DRM_VMW_MAX_MIP_LEVELS" because req->mip_levels is only for one layer.
Also, as long as we can doing a check, I would suggest we check for 0 as well.
Sinclair
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel