IB/rxe patches for kernel v4.11
Subsystems (2)
cover IB/rxe patches for kernel v4.11
SGVsbG8gRG91ZywNCg0KVGhlIHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMgYXJlIHdoYXQgSSBjYW1l IHVwIHdpdGggYnkgcmV2aWV3aW5nIGFuZCB0ZXN0aW5nDQp0aGUgcmRtYV9yeGUgZHJpdmVyLiBQ bGVhc2UgY29uc2lkZXIgdGhlc2UgcGF0Y2hlcyBmb3Iga2VybmVsIHY0LjExLg0KDQpUaGFua3Ms DQoNCkJhcnQuDQoNCi0tDQoNCkJhcnQgVmFuIEFzc2NoZSAoMTUpOg0KwqAgSUIvcnhlOiBTdXBw cmVzcyBzcGFyc2Ugd2FybmluZ3MNCsKgIElCL3J4ZTogQ29uc3RpZnkgdGhlIHBvb2wgbmFtZQ0K wqAgSUIvcnhlOiBSZW1vdmUgYW4gdW51c2VkIGZ1bmN0aW9uDQrCoCBJQi9yeGU6IFJlbW92ZSBh biB1bnVzZWQgdmFyaWFibGUNCsKgIElCL3J4ZTogUmVtb3ZlIHN1cGVyZmx1b3VzIGNhc3RzDQrC oCBJQi9yeGU6IEVuYWJsZSB0eXBlIGNoZWNraW5nIG9uIFNLQl9UT19QS1QoKSBhbmQgUEtUX1RP X1NLQigpwqBhcmd1bWVudHMNCsKgIElCL3J4ZTogTGV0IHRoZSBjb21waWxlciBjaGVjayB0aGUg dHlwZSBvZiB0aGUgY2xlYW51cCBmdW5jdGlvbnMNCsKgIElCL3J4ZTogSXNzdWUgd2FybmluZ3Mg b25jZQ0KwqAgSUIvcnhlOiBBZGQgYSBydW50aW1lIGNoZWNrIGluIGFsbG9jX2luZGV4KCkNCsKg IElCL3J4ZTogSW50cm9kdWNlIGZ1bmN0aW9ucyBmb3IgcXVldWUgZHJhaW5pbmcNCsKgIElCL3J4 ZTogR2VuZXJhdGUgYSBjb21wbGV0aW9uIGZvciBhbGwgZmFpbGVkIHdvcmsgcmVxdWVzdHMNCsKg IElCL3J4ZTogRml4IGEgTVIgcmVmZXJlbmNlIGxlYWsgaW4gY2hlY2tfcmtleSgpDQrCoCBJQi9y eGU6IEZpeCByZWZlcmVuY2UgbGVha3MgaW4gbWVtb3J5IGtleSBpbnZhbGlkYXRpb24gY29kZQ0K wqAgSUIvcnhlOiBSZW1vdmUgYSBwb2ludGxlc3MgaW5kaXJlY3Rpb24gbGF5ZXINCsKgIElCL3J4 ZTogRml4IGFuIHNrYiBsZWFrDQoNCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGUuY8Kg wqDCoMKgwqDCoMKgfMKgwqAyICstDQrCoGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2Nv bXAuY8KgwqB8IDgzICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tDQrCoGRyaXZl cnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2NxLmPCoMKgwqDCoHzCoMKgNCArLQ0KwqBkcml2ZXJz L2luZmluaWJhbmQvc3cvcnhlL3J4ZV9oZHIuaMKgwqDCoHwgMTIgKysrKy0NCsKgZHJpdmVycy9p bmZpbmliYW5kL3N3L3J4ZS9yeGVfbG9jLmjCoMKgwqB8IDI5ICsrKysrKysrKy0tLQ0KwqBkcml2 ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9tY2FzdC5jIHzCoMKgOCArKy0tDQrCoGRyaXZlcnMv aW5maW5pYmFuZC9zdy9yeGUvcnhlX21yLmPCoMKgwqDCoHwgMTAgKystLS0NCsKgZHJpdmVycy9p bmZpbmliYW5kL3N3L3J4ZS9yeGVfbmV0LmPCoMKgwqB8IDUxICsrKysrKystLS0tLS0tLS0tLS0t LQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmPCoMKgfCAxNCArKy0tLS0N CsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5owqDCoHzCoMKgOCArKy0tDQrC oGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3FwLmPCoMKgwqDCoHzCoMKgNCArLQ0KwqBk cml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZWN2LmPCoMKgfMKgwqAyICstDQrCoGRyaXZl cnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3JlcS5jwqDCoMKgfCAzMCArKysrKy0tLS0tLS0tDQrC oGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuY8KgwqB8IDY0ICsrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV92ZXJicy5j IHwgMTAgKystLS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfdmVyYnMuaCB8IDI0 ICstLS0tLS0tLS0NCsKgMTYgZmlsZXMgY2hhbmdlZCwgMTY0IGluc2VydGlvbnMoKyksIDE5MSBk ZWxldGlvbnMoLSkNCg0KLS3CoA0KMi4xMS4wDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/15 IB/rxe: Suppress sparse warnings
QXZvaWQgdGhhdCBzcGFyc2UgY29tcGxhaW5zIGFib3V0IHVzaW5nIDAgYXMgYSBwb2ludGVyLiBB dm9pZCB0aGF0DQpzcGFyc2UgY29tcGxhaW5zIGFib3V0IG1pc3NpbmcgZnVuY3Rpb24gZGVjbGFy YXRpb25zLiBBdm9pZCB0aGF0DQpzcGFyc2UgY29tcGxhaW5zIGFib3V0DQplbmRpYW5uZXNzLg0K DQpTaWduZWQtb2ZmLWJ5OiBCYXJ0IFZhbiBBc3NjaGUgPGJhcnQudmFuYXNzY2hlQHNhbmRpc2su Y29tPg0KQ2M6IE1vbmkgU2hvdWEgPG1vbmlzQG1lbGxhbm94LmNvbT4NCkNjOiBBbmRyZXcgQm95 ZXIgPGFuZHJldy5ib3llckBkZWxsLmNvbT4NCi0tLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cv cnhlL3J4ZV9uZXQuY8KgwqB8IDggKysrKy0tLS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4 ZS9yeGVfcmVjdi5jIHwgMiArLQ0KwqAyIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwg NSBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUv cnhlX25ldC5jIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbmV0LmMNCmluZGV4IDM0 MmU3ODE2MzYxMy4uMTUxZjYzOWFiZWJmIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5k L3N3L3J4ZS9yeGVfbmV0LmMNCisrKyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX25l dC5jDQpAQCAtMjQzLDggKzI0Myw4IEBAIHN0YXRpYyBzdHJ1Y3Qgc29ja2V0ICpyeGVfc2V0dXBf dWRwX3R1bm5lbChzdHJ1Y3QgbmV0ICpuZXQsIF9fYmUxNiBwb3J0LA0KwqB7DQrCoAlpbnQgZXJy Ow0KwqAJc3RydWN0IHNvY2tldCAqc29jazsNCi0Jc3RydWN0IHVkcF9wb3J0X2NmZyB1ZHBfY2Zn ID0gezB9Ow0KLQlzdHJ1Y3QgdWRwX3R1bm5lbF9zb2NrX2NmZyB0bmxfY2ZnID0gezB9Ow0KKwlz dHJ1Y3QgdWRwX3BvcnRfY2ZnIHVkcF9jZmcgPSB7IH07DQorCXN0cnVjdCB1ZHBfdHVubmVsX3Nv Y2tfY2ZnIHRubF9jZmcgPSB7IH07DQrCoA0KwqAJaWYgKGlwdjYpIHsNCsKgCQl1ZHBfY2ZnLmZh bWlseSA9IEFGX0lORVQ2Ow0KQEAgLTY1OCw3ICs2NTgsNyBAQCBzdHJ1Y3Qgbm90aWZpZXJfYmxv Y2sgcnhlX25ldF9ub3RpZmllciA9IHsNCsKgCS5ub3RpZmllcl9jYWxsID0gcnhlX25vdGlmeSwN CsKgfTsNCsKgDQotaW50IHJ4ZV9uZXRfaXB2NF9pbml0KHZvaWQpDQorc3RhdGljIGludCByeGVf bmV0X2lwdjRfaW5pdCh2b2lkKQ0KwqB7DQrCoAlyZWN2X3NvY2tldHMuc2s0ID0gcnhlX3NldHVw X3VkcF90dW5uZWwoJmluaXRfbmV0LA0KwqAJCQkJaHRvbnMoUk9DRV9WMl9VRFBfRFBPUlQpLCBm YWxzZSk7DQpAQCAtNjcxLDcgKzY3MSw3IEBAIGludCByeGVfbmV0X2lwdjRfaW5pdCh2b2lkKQ0K wqAJcmV0dXJuIDA7DQrCoH0NCsKgDQotaW50IHJ4ZV9uZXRfaXB2Nl9pbml0KHZvaWQpDQorc3Rh dGljIGludCByeGVfbmV0X2lwdjZfaW5pdCh2b2lkKQ0KwqB7DQrCoCNpZiBJU19FTkFCTEVEKENP TkZJR19JUFY2KQ0KwqANCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4 ZV9yZWN2LmMgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZWN2LmMNCmluZGV4IDI1 MmI0ZDYzN2Q0NS4uNTA4ODYwMzEwOTZmIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5k L3N3L3J4ZS9yeGVfcmVjdi5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9y ZWN2LmMNCkBAIC0zODksNyArMzg5LDcgQEAgaW50IHJ4ZV9yY3Yoc3RydWN0IHNrX2J1ZmYgKnNr YikNCsKgCWNhbGNfaWNyYyA9IHJ4ZV9pY3JjX2hkcihwa3QsIHNrYik7DQrCoAljYWxjX2ljcmMg PSBjcmMzMl9sZShjYWxjX2ljcmMsICh1OCAqKXBheWxvYWRfYWRkcihwa3QpLA0KwqAJCQnCoMKg wqDCoMKgcGF5bG9hZF9zaXplKHBrdCkpOw0KLQljYWxjX2ljcmMgPSBjcHVfdG9fYmUzMih+Y2Fs Y19pY3JjKTsNCisJY2FsY19pY3JjID0gKF9fZm9yY2UgdTMyKWNwdV90b19iZTMyKH5jYWxjX2lj cmMpOw0KwqAJaWYgKHVubGlrZWx5KGNhbGNfaWNyYyAhPSBwYWNrX2ljcmMpKSB7DQrCoAkJaWYg KHNrYi0+cHJvdG9jb2wgPT0gaHRvbnMoRVRIX1BfSVBWNikpDQrCoAkJCXByX3dhcm5fcmF0ZWxp bWl0ZWQoImJhZCBJQ1JDIGZyb20gJXBJNmNcbiIsDQotLcKgDQoyLjExLjANCg== --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 01/15] IB/rxe: Suppress sparse warnings
Quoted 9 lines · Bart Van Assche
Avoid that sparse complains about using 0 as a pointer. Avoid that sparse complains about missing function declarations. Avoid that sparse complains about
endianness.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
Something wrong with commit message.
Thanks,
A message that is not in the archive (sent off-list or not yet received): 20170105125955.GB15685-U/[email protected]
Re: [PATCH 01/15] IB/rxe: Suppress sparse warnings
T24gVGh1LCAyMDE3LTAxLTA1IGF0IDE0OjU5ICswMjAwLCBMZW9uIFJvbWFub3Zza3kgd3JvdGU6 DQo+IE9uIE1vbiwgSmFuIDAyLCAyMDE3IGF0IDEwOjM5OjA1QU0gKzAwMDAsIEJhcnQgVmFuIEFz c2NoZSB3cm90ZToNCj4gPiBBdm9pZCB0aGF0IHNwYXJzZSBjb21wbGFpbnMgYWJvdXQgdXNpbmcg MCBhcyBhIHBvaW50ZXIuIEF2b2lkIHRoYXQNCj4gPiBzcGFyc2UgY29tcGxhaW5zIGFib3V0IG1p c3NpbmcgZnVuY3Rpb24gZGVjbGFyYXRpb25zLiBBdm9pZCB0aGF0DQo+ID4gc3BhcnNlIGNvbXBs YWlucyBhYm91dA0KPiA+IGVuZGlhbm5lc3MuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogQmFy dCBWYW4gQXNzY2hlIDxiYXJ0LnZhbmFzc2NoZUBzYW5kaXNrLmNvbT4NCj4gPiBDYzogTW9uaSBT aG91YSA8bW9uaXNAbWVsbGFub3guY29tPg0KPiA+IENjOiBBbmRyZXcgQm95ZXIgPGFuZHJldy5i b3llckBkZWxsLmNvbT4NCj4gPiAtLS0NCj4gDQo+IFNvbWV0aGluZyB3cm9uZyB3aXRoIGNvbW1p dCBtZXNzYWdlLg0KDQpIZWxsbyBMZW9uLA0KDQpBcmUgeW91IHJlZmVycmluZyB0byB0aGUgZm9y bWF0dGluZyBvciB0byB0aGUgY29udGVudHMgb2YgdGhlIGNvbW1pdA0KbWVzc2FnZT8NCg0KQmFy dC4=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 01/15] IB/rxe: Suppress sparse warnings
Quoted 12 lines · Bart Van Assche
Quoted 11 lines · Leon Romanovsky
Quoted 9 lines · Bart Van Assche
Avoid that sparse complains about using 0 as a pointer. Avoid that sparse complains about missing function declarations. Avoid that sparse complains about
endianness.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
Quoted 6 lines
Quoted 1 line
Something wrong with commit message.
Hello Leon,
Are you referring to the formatting or to the contents of the commit message?
Both, it looks like the message was cut after last about and three "avoid that sparse complains about ..." in the row was unpleasant to me.
Both these nitpicks don't worth to respin.
Thanks
Quoted 2 lines
Bart.
Boyer, Andrew
Reviewed-byRe: [PATCH 01/15] IB/rxe: Suppress sparse warnings
In reply to a message not in the archiveQuoted 5 lines · Bart Van Assche
Avoid that sparse complains about using 0 as a pointer. Avoid that sparse complains about missing function declarations. Avoid that sparse complains about
endianness.
Quoted 7 lines
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_net.c| 8 ++++----drivers/infiniband/sw/rxe/rxe_recv.c| 2 +-2 files changed, 5 insertions(+), 5 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/15 IB/rxe: Constify the pool name
In reply to a message not in the archiveU2lnbmVkLW9mZi1ieTogQmFydCBWYW4gQXNzY2hlIDxiYXJ0LnZhbmFzc2NoZUBzYW5kaXNrLmNv bT4NCkNjOiBNb25pIFNob3VhIDxtb25pc0BtZWxsYW5veC5jb20+DQpDYzogQW5kcmV3IEJveWVy IDxhbmRyZXcuYm95ZXJAZGVsbC5jb20+DQotLS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3Lw0K cnhlL3J4ZV9wb29sLmMgfCAyICstDQrCoGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Bv b2wuaCB8IDIgKy0NCsKgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29s LmMgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmMNCmluZGV4IGQ3MjM5NDdh ODU0Mi4uMjM4YTZiZTAwZDQ2IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4 ZS9yeGVfcG9vbC5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmMN CkBAIC0xMDIsNyArMTAyLDcgQEAgc3RydWN0IHJ4ZV90eXBlX2luZm8gcnhlX3R5cGVfaW5mb1tS WEVfTlVNX1RZUEVTXSA9IHsNCsKgCX0sDQrCoH07DQrCoA0KLXN0YXRpYyBpbmxpbmUgY2hhciAq cG9vbF9uYW1lKHN0cnVjdCByeGVfcG9vbCAqcG9vbCkNCitzdGF0aWMgaW5saW5lIGNvbnN0IGNo YXIgKnBvb2xfbmFtZShzdHJ1Y3QgcnhlX3Bvb2wgKnBvb2wpDQrCoHsNCsKgCXJldHVybiByeGVf dHlwZV9pbmZvW3Bvb2wtPnR5cGVdLm5hbWU7DQrCoH0NCmRpZmYgLS1naXQgYS9kcml2ZXJzL2lu ZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmggYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4 ZV9wb29sLmgNCmluZGV4IDRkMDQ4MzBhZGNhZS4uNzg0NmNjYzU4YjI1IDEwMDY0NA0KLS0tIGEv ZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5oDQorKysgYi9kcml2ZXJzL2luZmlu aWJhbmQvc3cvcnhlL3J4ZV9wb29sLmgNCkBAIC01OCw3ICs1OCw3IEBAIGVudW0gcnhlX2VsZW1f dHlwZSB7DQrCoH07DQrCoA0KwqBzdHJ1Y3QgcnhlX3R5cGVfaW5mbyB7DQotCWNoYXIJCQkqbmFt ZTsNCisJY29uc3QgY2hhcgkJKm5hbWU7DQrCoAlzaXplX3QJCQlzaXplOw0KwqAJdm9pZAkJCSgq Y2xlYW51cCkodm9pZCAqb2JqKTsNCsKgCWVudW0gcnhlX3Bvb2xfZmxhZ3MJZmxhZ3M7DQotLcKg DQoyLjExLjANCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 02/15] IB/rxe: Constify the pool name
Quoted 9 lines · Bart Van Assche
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_pool.c| 2 +-
drivers/infiniband/sw/rxe/rxe_pool.h | 2 +-2 files changed, 2 insertions(+), 2 deletions(-)
Thanks,
Boyer, Andrew
Reviewed-byRe: [PATCH 02/15] IB/rxe: Constify the pool name
In reply to a message not in the archiveQuoted 8 lines · Bart Van Assche
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_pool.c| 2 +-drivers/infiniband/sw/rxe/rxe_pool.h| 2 +-2 files changed, 2 insertions(+), 2 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 3/15 IB/rxe: Remove an unused function
In reply to a message not in the archiveU2lnbmVkLW9mZi1ieTogQmFydCBWYW4gQXNzY2hlIDxiYXJ0LnZhbmFzc2NoZUBzYW5kaXNrLmNv bT4NCkNjOiBNb25pIFNob3VhIDxtb25pc0BtZWxsYW5veC5jb20+DQpDYzogQW5kcmV3IEJveWVy IDxhbmRyZXcuYm95ZXJAZGVsbC5jb20+DQotLS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3Lw0K cnhlL3J4ZV9wb29sLmMgfCA3IC0tLS0tLS0NCsKgMSBmaWxlIGNoYW5nZWQsIDcgZGVsZXRpb25z KC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmMg Yi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmMNCmluZGV4IDIzOGE2YmUwMGQ0 Ni4uNGZlMTExNDhiMzA0IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9y eGVfcG9vbC5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmMNCkBA IC0xMTIsMTMgKzExMiw2IEBAIHN0YXRpYyBpbmxpbmUgc3RydWN0IGttZW1fY2FjaGUgKnBvb2xf Y2FjaGUoc3RydWN0IHJ4ZV9wb29sICpwb29sKQ0KwqAJcmV0dXJuIHJ4ZV90eXBlX2luZm9bcG9v bC0+dHlwZV0uY2FjaGU7DQrCoH0NCsKgDQotc3RhdGljIGlubGluZSBlbnVtIHJ4ZV9lbGVtX3R5 cGUgcnhlX3R5cGUodm9pZCAqYXJnKQ0KLXsNCi0Jc3RydWN0IHJ4ZV9wb29sX2VudHJ5ICplbGVt ID0gYXJnOw0KLQ0KLQlyZXR1cm4gZWxlbS0+cG9vbC0+dHlwZTsNCi19DQotDQrCoGludCByeGVf Y2FjaGVfaW5pdCh2b2lkKQ0KwqB7DQrCoAlpbnQgZXJyOw0KLS3CoA0KMi4xMS4wDQo= --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 03/15] IB/rxe: Remove an unused function
Quoted 8 lines · Bart Van Assche
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_pool.c| 7 -------1 file changed, 7 deletions(-)
Thanks,
Boyer, Andrew
Reviewed-byRe: [PATCH 03/15] IB/rxe: Remove an unused function
In reply to a message not in the archiveQuoted 7 lines · Bart Van Assche
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_pool.c| 7 -------1 file changed, 7 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 4/15 IB/rxe: Remove an unused variable
In reply to a message not in the archiveVGhlIHZhcmlhYmxlICdhdicgaXMgbm90IHVzZWQgc28gcmVtb3ZlIGl0Lg0KDQpTaWduZWQtb2Zm LWJ5OiBCYXJ0IFZhbiBBc3NjaGUgPGJhcnQudmFuYXNzY2hlQHNhbmRpc2suY29tPg0KQ2M6IE1v bmkgU2hvdWEgPG1vbmlzQG1lbGxhbm94LmNvbT4NCkNjOiBBbmRyZXcgQm95ZXIgPGFuZHJldy5i b3llckBkZWxsLmNvbT4NCi0tLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXEu YyB8IDcgKy0tLS0tLQ0KwqAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDYgZGVsZXRp b25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXEu YyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3JlcS5jDQppbmRleCA3M2Q0YTk3NjAz YTEuLmI5NWI2MDM1ZTk4OCAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUv cnhlX3JlcS5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXEuYw0KQEAg LTM2NCwxNiArMzY0LDExIEBAIHN0YXRpYyBpbmxpbmUgaW50IGNoZWNrX2luaXRfZGVwdGgoc3Ry dWN0IHJ4ZV9xcCAqcXAsIHN0cnVjdCByeGVfc2VuZF93cWUgKndxZSkNCsKgc3RhdGljIGlubGlu ZSBpbnQgZ2V0X210dShzdHJ1Y3QgcnhlX3FwICpxcCwgc3RydWN0IHJ4ZV9zZW5kX3dxZSAqd3Fl KQ0KwqB7DQrCoAlzdHJ1Y3QgcnhlX2RldiAqcnhlID0gdG9fcmRldihxcC0+aWJxcC5kZXZpY2Up Ow0KLQlzdHJ1Y3QgcnhlX3BvcnQgKnBvcnQ7DQotCXN0cnVjdCByeGVfYXYgKmF2Ow0KwqANCsKg CWlmICgocXBfdHlwZShxcCkgPT0gSUJfUVBUX1JDKSB8fCAocXBfdHlwZShxcCkgPT0gSUJfUVBU X1VDKSkNCsKgCQlyZXR1cm4gcXAtPm10dTsNCsKgDQotCWF2ID0gJndxZS0+YXY7DQotCXBvcnQg PSAmcnhlLT5wb3J0Ow0KLQ0KLQlyZXR1cm4gcG9ydC0+bXR1X2NhcDsNCisJcmV0dXJuIHJ4ZS0+ cG9ydC5tdHVfY2FwOw0KwqB9DQrCoA0KwqBzdGF0aWMgc3RydWN0IHNrX2J1ZmYgKmluaXRfcmVx X3BhY2tldChzdHJ1Y3QgcnhlX3FwICpxcCwNCi0twqANCjIuMTEuMA0K
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 04/15] IB/rxe: Remove an unused variable
Quoted 5 lines · Bart Van Assche
The variable 'av' is not used so remove it.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>
Thanks,
Re: [PATCH 04/15] IB/rxe: Remove an unused variable
In reply to a message not in the archiveHi Bart,
Additionally, since struct rxe_send_wqe is not used in get_mtu() function, Can you please update signature to just have rxe_qp* as input argument?
Parav
On Jan 2, 2017 5:05 AM, "Bart Van Assche" <[email protected]> wrote:
The variable 'av' is not used so remove it.
--- drivers/infiniband/sw/rxe/rxe_req.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
(quoted diff) +0 -0
b/drivers/infiniband/sw/rxe/rxe_req.c
index 73d4a97603a1..b95b6035e988 100644
drivers/infiniband/sw/rxe/rxe_req.c +0 -0
@@ -364,16 +364,11 @@ static inline int check_init_depth(struct rxe_qp
*qp, struct rxe_send_wqe *wqe)
static inline int get_mtu(struct rxe_qp *qp, struct rxe_send_wqe *wqe)
{
struct rxe_dev *rxe = to_rdev(qp->ibqp.device);- struct rxe_port *port;
- struct rxe_av *av;
if ((qp_type(qp) == IB_QPT_RC) || (qp_type(qp) == IB_QPT_UC))
return qp->mtu;- av = &wqe->av;
- port = &rxe->port;
-
- return port->mtu_cap;
+ return rxe->port.mtu_cap;
}
static struct sk_buff *init_req_packet(struct rxe_qp *qp,
Signature · 5 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): CAG53R5WnJy1cLdEZOpzk03aAE2L6v86n_-qEBpoaG+arymCxPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Re: [PATCH 04/15] IB/rxe: Remove an unused variable
Quoted 2 lines · Parav Pandit
Additionally, since struct
rxe_send_wqeis not used inget_mtu()function, Can you please update signature to just have rxe_qp* as input argument?
Thanks for the feedback Leon and Parav. BTW, feedback for the other patches of this series would also be welcome.
Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 04/15] IB/rxe: Remove an unused variable
Quoted 6 lines · Bart Van Assche
Quoted 2 lines · Parav Pandit
Additionally, since struct
rxe_send_wqeis not used inget_mtu()function, Can you please update signature to just have rxe_qp* as input argument?Thanks for the feedback Leon and Parav. BTW, feedback for the other patches of this series would also be welcome.
I will try to do my best.
Thanks
Quoted 5 lines
Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Boyer, Andrew
Reviewed-byRe: [PATCH 04/15] IB/rxe: Remove an unused variable
In reply to a message not in the archiveQuoted 8 lines · Bart Van Assche
The variable 'av' is not used so remove it.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_req.c| 7 +------1 file changed, 1 insertion(+), 6 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 5/15 IB/rxe: Remove superfluous casts
In reply to a message not in the archiveQ2FzdGluZyBhIHBvaW50ZXIgdG8gJ3ZvaWQgKicgZXhwbGljaXRseSBpcyBub3QgbmVjZXNzYXJ5 IGluIEMgY29kZS4NCg0KU2lnbmVkLW9mZi1ieTogQmFydCBWYW4gQXNzY2hlIDxiYXJ0LnZhbmFz c2NoZUBzYW5kaXNrLmNvbT4NCkNjOiBNb25pIFNob3VhIDxtb25pc0BtZWxsYW5veC5jb20+DQpD YzogQW5kcmV3IEJveWVyIDxhbmRyZXcuYm95ZXJAZGVsbC5jb20+DQotLS0NCsKgZHJpdmVycy9p bmZpbmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5jIHwgNCArKy0tDQrCoDEgZmlsZSBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2lu ZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmMgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4 ZV9wb29sLmMNCmluZGV4IDRmZTExMTQ4YjMwNC4uN2QxZTI4NjJiOTI4IDEwMDY0NA0KLS0tIGEv ZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5jDQorKysgYi9kcml2ZXJzL2luZmlu aWJhbmQvc3cvcnhlL3J4ZV9wb29sLmMNCkBAIC00NTQsNyArNDU0LDcgQEAgdm9pZCAqcnhlX3Bv b2xfZ2V0X2luZGV4KHN0cnVjdCByeGVfcG9vbCAqcG9vbCwgdTMyIGluZGV4KQ0KwqANCsKgb3V0 Og0KwqAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmcG9vbC0+cG9vbF9sb2NrLCBmbGFncyk7DQot CXJldHVybiBub2RlID8gKHZvaWQgKillbGVtIDogTlVMTDsNCisJcmV0dXJuIG5vZGUgPyBlbGVt IDogTlVMTDsNCsKgfQ0KwqANCsKgdm9pZCAqcnhlX3Bvb2xfZ2V0X2tleShzdHJ1Y3QgcnhlX3Bv b2wgKnBvb2wsIHZvaWQgKmtleSkNCkBAIC00OTAsNSArNDkwLDUgQEAgdm9pZCAqcnhlX3Bvb2xf Z2V0X2tleShzdHJ1Y3QgcnhlX3Bvb2wgKnBvb2wsIHZvaWQgKmtleSkNCsKgDQrCoG91dDoNCsKg CXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnBvb2wtPnBvb2xfbG9jaywgZmxhZ3MpOw0KLQlyZXR1 cm4gbm9kZSA/ICgodm9pZCAqKWVsZW0pIDogTlVMTDsNCisJcmV0dXJuIG5vZGUgPyBlbGVtIDog TlVMTDsNCsKgfQ0KLS3CoA0KMi4xMS4wDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 05/15] IB/rxe: Remove superfluous casts
Quoted 5 lines · Bart Van Assche
Casting a pointer to 'void *' explicitly is not necessary in C code.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>
Thanks,
Boyer, Andrew
Reviewed-byRe: [PATCH 05/15] IB/rxe: Remove superfluous casts
In reply to a message not in the archiveQuoted 8 lines · Bart Van Assche
Casting a pointer to 'void *' explicitly is not necessary in C code.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_pool.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 6/15 IB/rxe: Enable type checking on SKB_TO_PKT() and PKT_TO_SKB() arguments
In reply to a message not in the archiveTGV0IHRoZSBjb21waWxlciBjaGVjayB0aGUgdHlwZSBvZiB0aGUgYXJndW1lbnRzIHBhc3NlZCB0 byBTS0JfVE9fUEtUKCkNCmFuZCBQS1RfVE9fU0tCKCkuDQoNClNpZ25lZC1vZmYtYnk6IEJhcnQg VmFuIEFzc2NoZSA8YmFydC52YW5hc3NjaGVAc2FuZGlzay5jb20+DQpDYzogTW9uaSBTaG91YSA8 bW9uaXNAbWVsbGFub3guY29tPg0KQ2M6IEFuZHJldyBCb3llciA8YW5kcmV3LmJveWVyQGRlbGwu Y29tPg0KLS0tDQrCoGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2hkci5oIHwgMTIgKysr KysrKysrKy0tDQrCoDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfaGRyLmgg Yi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9oZHIuaA0KaW5kZXggZDU3YjVlOTU2Y2Vi Li42Y2IxODQwNmY1YjggMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4 ZV9oZHIuaA0KKysrIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfaGRyLmgNCkBAIC01 Myw4ICs1MywxNiBAQCBzdHJ1Y3QgcnhlX3BrdF9pbmZvIHsNCsKgfTsNCsKgDQrCoC8qIE1hY3Jv cyBzaG91bGQgYmUgdXNlZCBvbmx5IGZvciByZWNlaXZlZCBza2IgKi8NCi0jZGVmaW5lIFNLQl9U T19QS1Qoc2tiKSAoKHN0cnVjdCByeGVfcGt0X2luZm8gKikoc2tiKS0+Y2IpDQotI2RlZmluZSBQ S1RfVE9fU0tCKHBrdCkgY29udGFpbmVyX29mKCh2b2lkICopKHBrdCksIHN0cnVjdCBza19idWZm LCBjYikNCitzdGF0aWMgaW5saW5lIHN0cnVjdCByeGVfcGt0X2luZm8gKlNLQl9UT19QS1Qoc3Ry dWN0IHNrX2J1ZmYgKnNrYikNCit7DQorCUJVSUxEX0JVR19PTihzaXplb2Yoc3RydWN0IHJ4ZV9w a3RfaW5mbykgPiBzaXplb2Yoc2tiLT5jYikpOw0KKwlyZXR1cm4gKHZvaWQgKilza2ItPmNiOw0K K30NCisNCitzdGF0aWMgaW5saW5lIHN0cnVjdCBza19idWZmICpQS1RfVE9fU0tCKHN0cnVjdCBy eGVfcGt0X2luZm8gKnBrdCkNCit7DQorCXJldHVybiBjb250YWluZXJfb2YoKHZvaWQgKilwa3Qs IHN0cnVjdCBza19idWZmLCBjYik7DQorfQ0KwqANCsKgLyoNCsKgICogSUJBIGhlYWRlciB0eXBl cyBhbmQgbWV0aG9kcw0KLS3CoA0KMi4xMS4wDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 06/15] IB/rxe: Enable type checking on SKB_TO_PKT() and PKT_TO_SKB() arguments
Quoted 18 lines · Bart Van Assche
Let the compiler check the type of the arguments passed to
SKB_TO_PKT()andPKT_TO_SKB().Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_hdr.h | 12 ++++++++++--1 file changed, 10 insertions(+), 2 deletions(-)drivers/infiniband/sw/rxe/rxe_hdr.h +0
-0@@ -53,8 +53,16 @@ struct rxe_pkt_info { };
/* Macros should be used only for received skb */
drivers/infiniband/sw/rxe/rxe_hdr.h
Quoted 5 lines
drivers/infiniband/sw/rxe/rxe_hdr.h +3
-2-#define SKB_TO_PKT (skb) ((struct rxe_pkt_info *)(skb)->cb) -#define PKT_TO_SKB (pkt) container_of((void *)(pkt), struct sk_buff, cb) +static inline struct rxe_pkt_info *SKB_TO_PKT (struct sk_buff *skb) +{ +BUILD_BUG_ON (sizeof (struct rxe_pkt_info ) >sizeof (skb->cb));
It is very good check, thanks for catching it.
drivers/infiniband/sw/rxe/rxe_hdr.h
Quoted 3 lines
drivers/infiniband/sw/rxe/rxe_hdr.h +3
-0+return (void *)skb->cb; +} +
Thanks,
Boyer, Andrew
Reviewed-byRe: [PATCH 06/15] IB/rxe: Enable type checking on SKB_TO_PKT() and PKT_TO_SKB() arguments
In reply to a message not in the archiveQuoted 9 lines · On 1/2/17, 5:40 AM, "[email protected]…
Let the compiler check the type of the arguments passed to
SKB_TO_PKT()andPKT_TO_SKB().Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_hdr.h| 12 ++++++++++--1 file changed, 10 insertions(+), 2 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 7/15 IB/rxe: Let the compiler check the type of the cleanup functions
In reply to a message not in the archiveQ2hhbmdlIHRoZSBhcmd1bWVudCB0eXBlIG9mIHRoZXNlIGZ1bmN0aW9ucyBmcm9tIHZvaWQgKiBp bnRvDQpzdHJ1Y3QgcnhlX3Bvb2xfZW50cnkgKi4NCg0KU2lnbmVkLW9mZi1ieTogQmFydCBWYW4g QXNzY2hlIDxiYXJ0LnZhbmFzc2NoZUBzYW5kaXNrLmNvbT4NCkNjOiBNb25pIFNob3VhIDxtb25p c0BtZWxsYW5veC5jb20+DQpDYzogQW5kcmV3IEJveWVyIDxhbmRyZXcuYm95ZXJAZGVsbC5jb20+ DQotLS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfY3EuY8KgwqDCoMKgfCA0ICsr LS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbG9jLmjCoMKgwqB8IDggKysrKy0t LS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbWNhc3QuYyB8IDQgKystLQ0KwqBk cml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9tci5jwqDCoMKgwqB8IDQgKystLQ0KwqBkcml2 ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9wb29sLmjCoMKgfCA2ICsrKystLQ0KwqBkcml2ZXJz L2luZmluaWJhbmQvc3cvcnhlL3J4ZV9xcC5jwqDCoMKgwqB8IDQgKystLQ0KwqBkcml2ZXJzL2lu ZmluaWJhbmQvc3cvcnhlL3J4ZV92ZXJicy5oIHwgMiArLQ0KwqA3IGZpbGVzIGNoYW5nZWQsIDE3 IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9p bmZpbmliYW5kL3N3L3J4ZS9yeGVfY3EuYyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhl X2NxLmMNCmluZGV4IGU1ZTZhNWU3ZGVlOS4uNDlmZTQyYzIzZjRkIDEwMDY0NA0KLS0tIGEvZHJp dmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfY3EuYw0KKysrIGIvZHJpdmVycy9pbmZpbmliYW5k L3N3L3J4ZS9yeGVfY3EuYw0KQEAgLTE1Niw5ICsxNTYsOSBAQCBpbnQgcnhlX2NxX3Bvc3Qoc3Ry dWN0IHJ4ZV9jcSAqY3EsIHN0cnVjdCByeGVfY3FlICpjcWUsIGludCBzb2xpY2l0ZWQpDQrCoAly ZXR1cm4gMDsNCsKgfQ0KwqANCi12b2lkIHJ4ZV9jcV9jbGVhbnVwKHZvaWQgKmFyZykNCit2b2lk IHJ4ZV9jcV9jbGVhbnVwKHN0cnVjdCByeGVfcG9vbF9lbnRyeSAqYXJnKQ0KwqB7DQotCXN0cnVj dCByeGVfY3EgKmNxID0gYXJnOw0KKwlzdHJ1Y3QgcnhlX2NxICpjcSA9IGNvbnRhaW5lcl9vZihh cmcsIHR5cGVvZigqY3EpLCBwZWxlbSk7DQrCoA0KwqAJaWYgKGNxLT5xdWV1ZSkNCsKgCQlyeGVf cXVldWVfY2xlYW51cChjcS0+cXVldWUpOw0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5maW5pYmFu ZC9zdy9yeGUvcnhlX2xvYy5oIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbG9jLmgN CmluZGV4IGVmZTRjNmEzNTQ0Mi4uZGExOTFkN2FjYjZmIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9p bmZpbmliYW5kL3N3L3J4ZS9yeGVfbG9jLmgNCisrKyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9y eGUvcnhlX2xvYy5oDQpAQCAtNjQsNyArNjQsNyBAQCBpbnQgcnhlX2NxX3Jlc2l6ZV9xdWV1ZShz dHJ1Y3QgcnhlX2NxICpjcSwgaW50IG5ld19jcWUsIHN0cnVjdCBpYl91ZGF0YSAqdWRhdGEpOw0K wqANCsKgaW50IHJ4ZV9jcV9wb3N0KHN0cnVjdCByeGVfY3EgKmNxLCBzdHJ1Y3QgcnhlX2NxZSAq Y3FlLCBpbnQgc29saWNpdGVkKTsNCsKgDQotdm9pZCByeGVfY3FfY2xlYW51cCh2b2lkICphcmcp Ow0KK3ZvaWQgcnhlX2NxX2NsZWFudXAoc3RydWN0IHJ4ZV9wb29sX2VudHJ5ICphcmcpOw0KwqAN CsKgLyogcnhlX21jYXN0LmMgKi8NCsKgaW50IHJ4ZV9tY2FzdF9nZXRfZ3JwKHN0cnVjdCByeGVf ZGV2ICpyeGUsIHVuaW9uIGliX2dpZCAqbWdpZCwNCkBAIC03OCw3ICs3OCw3IEBAIGludCByeGVf bWNhc3RfZHJvcF9ncnBfZWxlbShzdHJ1Y3QgcnhlX2RldiAqcnhlLCBzdHJ1Y3QgcnhlX3FwICpx cCwNCsKgDQrCoHZvaWQgcnhlX2Ryb3BfYWxsX21jYXN0X2dyb3VwcyhzdHJ1Y3QgcnhlX3FwICpx cCk7DQrCoA0KLXZvaWQgcnhlX21jX2NsZWFudXAodm9pZCAqYXJnKTsNCit2b2lkIHJ4ZV9tY19j bGVhbnVwKHN0cnVjdCByeGVfcG9vbF9lbnRyeSAqYXJnKTsNCsKgDQrCoC8qIHJ4ZV9tbWFwLmMg Ki8NCsKgc3RydWN0IHJ4ZV9tbWFwX2luZm8gew0KQEAgLTEzNyw3ICsxMzcsNyBAQCBpbnQgbWVt X2NoZWNrX3JhbmdlKHN0cnVjdCByeGVfbWVtICptZW0sIHU2NCBpb3ZhLCBzaXplX3QgbGVuZ3Ro KTsNCsKgaW50IHJ4ZV9tZW1fbWFwX3BhZ2VzKHN0cnVjdCByeGVfZGV2ICpyeGUsIHN0cnVjdCBy eGVfbWVtICptZW0sDQrCoAkJwqDCoMKgwqDCoMKgdTY0ICpwYWdlLCBpbnQgbnVtX3BhZ2VzLCB1 NjQgaW92YSk7DQrCoA0KLXZvaWQgcnhlX21lbV9jbGVhbnVwKHZvaWQgKmFyZyk7DQordm9pZCBy eGVfbWVtX2NsZWFudXAoc3RydWN0IHJ4ZV9wb29sX2VudHJ5ICphcmcpOw0KwqANCsKgaW50IGFk dmFuY2VfZG1hX2RhdGEoc3RydWN0IHJ4ZV9kbWFfaW5mbyAqZG1hLCB1bnNpZ25lZCBpbnQgbGVu Z3RoKTsNCsKgDQpAQCAtMTYyLDcgKzE2Miw3IEBAIHZvaWQgcnhlX3FwX2Vycm9yKHN0cnVjdCBy eGVfcXAgKnFwKTsNCsKgDQrCoHZvaWQgcnhlX3FwX2Rlc3Ryb3koc3RydWN0IHJ4ZV9xcCAqcXAp Ow0KwqANCi12b2lkIHJ4ZV9xcF9jbGVhbnVwKHZvaWQgKmFyZyk7DQordm9pZCByeGVfcXBfY2xl YW51cChzdHJ1Y3QgcnhlX3Bvb2xfZW50cnkgKmFyZyk7DQrCoA0KwqBzdGF0aWMgaW5saW5lIGlu dCBxcF9udW0oc3RydWN0IHJ4ZV9xcCAqcXApDQrCoHsNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2lu ZmluaWJhbmQvc3cvcnhlL3J4ZV9tY2FzdC5jIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9y eGVfbWNhc3QuYw0KaW5kZXggZmE5NTU0NGNhN2UwLi5lMGZiNjc1MmY5MGUgMTAwNjQ0DQotLS0g YS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9tY2FzdC5jDQorKysgYi9kcml2ZXJzL2lu ZmluaWJhbmQvc3cvcnhlL3J4ZV9tY2FzdC5jDQpAQCAtMTgwLDkgKzE4MCw5IEBAIHZvaWQgcnhl X2Ryb3BfYWxsX21jYXN0X2dyb3VwcyhzdHJ1Y3QgcnhlX3FwICpxcCkNCsKgCX0NCsKgfQ0KwqAN Ci12b2lkIHJ4ZV9tY19jbGVhbnVwKHZvaWQgKmFyZykNCit2b2lkIHJ4ZV9tY19jbGVhbnVwKHN0 cnVjdCByeGVfcG9vbF9lbnRyeSAqYXJnKQ0KwqB7DQotCXN0cnVjdCByeGVfbWNfZ3JwICpncnAg PSBhcmc7DQorCXN0cnVjdCByeGVfbWNfZ3JwICpncnAgPSBjb250YWluZXJfb2YoYXJnLCB0eXBl b2YoKmdycCksIHBlbGVtKTsNCsKgCXN0cnVjdCByeGVfZGV2ICpyeGUgPSBncnAtPnJ4ZTsNCsKg DQrCoAlyeGVfZHJvcF9rZXkoZ3JwKTsNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQv c3cvcnhlL3J4ZV9tci5jIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbXIuYw0KaW5k ZXggZDBmYWNhMjk0MDA2Li44Y2EzYWNkMzI3YjMgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmlu aWJhbmQvc3cvcnhlL3J4ZV9tci5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4 ZV9tci5jDQpAQCAtODksOSArODksOSBAQCBzdGF0aWMgdm9pZCByeGVfbWVtX2luaXQoaW50IGFj Y2Vzcywgc3RydWN0IHJ4ZV9tZW0gKm1lbSkNCsKgCW1lbS0+bWFwX3NoaWZ0CQk9IGlsb2cyKFJY RV9CVUZfUEVSX01BUCk7DQrCoH0NCsKgDQotdm9pZCByeGVfbWVtX2NsZWFudXAodm9pZCAqYXJn KQ0KK3ZvaWQgcnhlX21lbV9jbGVhbnVwKHN0cnVjdCByeGVfcG9vbF9lbnRyeSAqYXJnKQ0KwqB7 DQotCXN0cnVjdCByeGVfbWVtICptZW0gPSBhcmc7DQorCXN0cnVjdCByeGVfbWVtICptZW0gPSBj b250YWluZXJfb2YoYXJnLCB0eXBlb2YoKm1lbSksIHBlbGVtKTsNCsKgCWludCBpOw0KwqANCsKg CWlmIChtZW0tPnVtZW0pDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9y eGVfcG9vbC5oIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5oDQppbmRleCA3 ODQ2Y2NjNThiMjUuLjQ3ZGYyOGU0M2FjZiAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvaW5maW5pYmFu ZC9zdy9yeGUvcnhlX3Bvb2wuaA0KKysrIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVf cG9vbC5oDQpAQCAtNTcsMTAgKzU3LDEyIEBAIGVudW0gcnhlX2VsZW1fdHlwZSB7DQrCoAlSWEVf TlVNX1RZUEVTLAkJLyoga2VlcCBtZSBsYXN0ICovDQrCoH07DQrCoA0KK3N0cnVjdCByeGVfcG9v bF9lbnRyeTsNCisNCsKgc3RydWN0IHJ4ZV90eXBlX2luZm8gew0KwqAJY29uc3QgY2hhcgkJKm5h bWU7DQrCoAlzaXplX3QJCQlzaXplOw0KLQl2b2lkCQkJKCpjbGVhbnVwKSh2b2lkICpvYmopOw0K Kwl2b2lkCQkJKCpjbGVhbnVwKShzdHJ1Y3QgcnhlX3Bvb2xfZW50cnkgKm9iaik7DQrCoAllbnVt IHJ4ZV9wb29sX2ZsYWdzCWZsYWdzOw0KwqAJdTMyCQkJbWF4X2luZGV4Ow0KwqAJdTMyCQkJbWlu X2luZGV4Ow0KQEAgLTkxLDcgKzkzLDcgQEAgc3RydWN0IHJ4ZV9wb29sIHsNCsKgCXNwaW5sb2Nr X3TCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcG9vbF9sb2NrOyAvKiBwb29sIHNwaW5sb2Nr ICovDQrCoAlzaXplX3QJCQllbGVtX3NpemU7DQrCoAlzdHJ1Y3Qga3JlZgkJcmVmX2NudDsNCi0J dm9pZAkJCSgqY2xlYW51cCkodm9pZCAqb2JqKTsNCisJdm9pZAkJCSgqY2xlYW51cCkoc3RydWN0 IHJ4ZV9wb29sX2VudHJ5ICpvYmopOw0KwqAJZW51bSByeGVfcG9vbF9zdGF0ZQlzdGF0ZTsNCsKg CWVudW0gcnhlX3Bvb2xfZmxhZ3MJZmxhZ3M7DQrCoAllbnVtIHJ4ZV9lbGVtX3R5cGUJdHlwZTsN CmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9xcC5jIGIvZHJpdmVy cy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcXAuYw0KaW5kZXggNDg2ZDU3NmU1NWJjLi45MTcxNDdj ZTRjZjkgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9xcC5jDQor KysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9xcC5jDQpAQCAtODI1LDkgKzgyNSw5 IEBAIHZvaWQgcnhlX3FwX2Rlc3Ryb3koc3RydWN0IHJ4ZV9xcCAqcXApDQrCoH0NCsKgDQrCoC8q IGNhbGxlZCB3aGVuIHRoZSBsYXN0IHJlZmVyZW5jZSB0byB0aGUgcXAgaXMgZHJvcHBlZCAqLw0K LXZvaWQgcnhlX3FwX2NsZWFudXAodm9pZCAqYXJnKQ0KK3ZvaWQgcnhlX3FwX2NsZWFudXAoc3Ry dWN0IHJ4ZV9wb29sX2VudHJ5ICphcmcpDQrCoHsNCi0Jc3RydWN0IHJ4ZV9xcCAqcXAgPSBhcmc7 DQorCXN0cnVjdCByeGVfcXAgKnFwID0gY29udGFpbmVyX29mKGFyZywgdHlwZW9mKCpxcCksIHBl bGVtKTsNCsKgDQrCoAlyeGVfZHJvcF9hbGxfbWNhc3RfZ3JvdXBzKHFwKTsNCsKgDQpkaWZmIC0t Z2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfdmVyYnMuaCBiL2RyaXZlcnMvaW5m aW5pYmFuZC9zdy9yeGUvcnhlX3ZlcmJzLmgNCmluZGV4IGNhYzFkNTJhMDhmMC4uNTM2OTc0YjY5 ZWQ5IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfdmVyYnMuaA0K KysrIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfdmVyYnMuaA0KQEAgLTQ3NSw2ICs0 NzUsNiBAQCBzdGF0aWMgaW5saW5lIHN0cnVjdCByeGVfbWVtICp0b19ybXcoc3RydWN0IGliX213 ICptdykNCsKgaW50IHJ4ZV9yZWdpc3Rlcl9kZXZpY2Uoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSk7DQrC oGludCByeGVfdW5yZWdpc3Rlcl9kZXZpY2Uoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSk7DQrCoA0KLXZv aWQgcnhlX21jX2NsZWFudXAodm9pZCAqYXJnKTsNCit2b2lkIHJ4ZV9tY19jbGVhbnVwKHN0cnVj dCByeGVfcG9vbF9lbnRyeSAqYXJnKTsNCsKgDQrCoCNlbmRpZiAvKiBSWEVfVkVSQlNfSCAqLw0K LS3CoA0KMi4xMS4wDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 07/15] IB/rxe: Let the compiler check the type of the cleanup functions
Quoted 14 lines · Bart Van Assche
Change the argument type of these functions from void * into struct
rxe_pool_entry*.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_cq.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_loc.h | 8 ++++----drivers/infiniband/sw/rxe/rxe_mcast.c| 4 ++-- drivers/infiniband/sw/rxe/rxe_mr.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_pool.h | 6 ++++-- drivers/infiniband/sw/rxe/rxe_qp.c | 4 ++--drivers/infiniband/sw/rxe/rxe_verbs.h| 2 +-
Quoted 2 lines
7 files changed, 17 insertions(+), 15 deletions(-)
Thanks,
Boyer, Andrew
Reviewed-byRe: [PATCH 07/15] IB/rxe: Let the compiler check the type of the cleanup functions
In reply to a message not in the archiveQuoted 7 lines · Bart Van Assche
Change the argument type of these functions from void * into struct
rxe_pool_entry*.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
Quoted 8 lines
drivers/infiniband/sw/rxe/rxe_cq.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_loc.h | 8 ++++---- drivers/infiniband/sw/rxe/rxe_mcast.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_mr.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_pool.h | 6 ++++-- drivers/infiniband/sw/rxe/rxe_qp.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_verbs.h | 2 +- 7 files changed, 17 insertions(+), 15 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 8/15 IB/rxe: Issue warnings once
In reply to a message not in the archiveSXQgaXMgc3Ryb25nbHkgcmVjb21tZW5kZWQgdG8gcmVwb3J0IGtlcm5lbCB3YXJuaW5ncyBvbmNl IGluc3RlYWQNCm9mIGV2ZXJ5IHRpbWUgYSBjb25kaXRpb24gaXMgaGl0LiBIZW5jZSBjaGFuZ2Ug V0FSTl9PTigpIGludG8NCldBUk5fT05fT05DRSgpIC8gQlVJTERfQlVHX09OKCkgYXMNCmFwcHJv cHJpYXRlLg0KDQpTaWduZWQtb2ZmLWJ5OiBCYXJ0IFZhbiBBc3NjaGUgPGJhcnQudmFuYXNzY2hl QHNhbmRpc2suY29tPg0KQ2M6IE1vbmkgU2hvdWEgPG1vbmlzQG1lbGxhbm94LmNvbT4NCkNjOiBB bmRyZXcgQm95ZXIgPGFuZHJldy5ib3llckBkZWxsLmNvbT4NCi0tLQ0KwqBkcml2ZXJzL2luZmlu aWJhbmQvc3cvcnhlL3J4ZV9jb21wLmMgfMKgwqAyICstDQrCoGRyaXZlcnMvaW5maW5pYmFuZC9z dy9yeGUvcnhlX21yLmPCoMKgwqB8wqDCoDYgKysrLS0tDQrCoGRyaXZlcnMvaW5maW5pYmFuZC9z dy9yeGUvcnhlX3Jlc3AuYyB8IDExICsrKysrKy0tLS0tDQrCoDMgZmlsZXMgY2hhbmdlZCwgMTAg aW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5m aW5pYmFuZC9zdy9yeGUvcnhlX2NvbXAuYyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhl X2NvbXAuYw0KaW5kZXggZDM2OWYyNDQyNWY5Li5lOTEyZTUzOTZlOGMgMTAwNjQ0DQotLS0gYS9k cml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9jb21wLmMNCisrKyBiL2RyaXZlcnMvaW5maW5p YmFuZC9zdy9yeGUvcnhlX2NvbXAuYw0KQEAgLTI1NCw3ICsyNTQsNyBAQCBzdGF0aWMgaW5saW5l IGVudW0gY29tcF9zdGF0ZSBjaGVja19hY2soc3RydWN0IHJ4ZV9xcCAqcXAsDQrCoAkJfQ0KwqAJ CWJyZWFrOw0KwqAJZGVmYXVsdDoNCi0JCVdBUk5fT04oMSk7DQorCQlXQVJOX09OX09OQ0UoMSk7 DQrCoAl9DQrCoA0KwqAJLyogQ2hlY2sgb3BlcmF0aW9uIHZhbGlkaXR5LiAqLw0KZGlmZiAtLWdp dCBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX21yLmMgYi9kcml2ZXJzL2luZmluaWJh bmQvc3cvcnhlL3J4ZV9tci5jDQppbmRleCA4Y2EzYWNkMzI3YjMuLjhjZjM4YjI1M2MzNyAxMDA2 NDQNCi0tLSBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX21yLmMNCisrKyBiL2RyaXZl cnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX21yLmMNCkBAIC0xMjMsNyArMTIzLDcgQEAgc3RhdGlj IGludCByeGVfbWVtX2FsbG9jKHN0cnVjdCByeGVfZGV2ICpyeGUsIHN0cnVjdCByeGVfbWVtICpt ZW0sIGludCBudW1fYnVmKQ0KwqAJCQlnb3RvIGVycjI7DQrCoAl9DQrCoA0KLQlXQVJOX09OKCFp c19wb3dlcl9vZl8yKFJYRV9CVUZfUEVSX01BUCkpOw0KKwlCVUlMRF9CVUdfT04oIWlzX3Bvd2Vy X29mXzIoUlhFX0JVRl9QRVJfTUFQKSk7DQrCoA0KwqAJbWVtLT5tYXBfc2hpZnQJPSBpbG9nMihS WEVfQlVGX1BFUl9NQVApOw0KwqAJbWVtLT5tYXBfbWFzawk9IFJYRV9CVUZfUEVSX01BUCAtIDE7 DQpAQCAtMTg5LDcgKzE4OSw3IEBAIGludCByeGVfbWVtX2luaXRfdXNlcihzdHJ1Y3QgcnhlX2Rl diAqcnhlLCBzdHJ1Y3QgcnhlX3BkICpwZCwgdTY0IHN0YXJ0LA0KwqAJCWdvdG8gZXJyMTsNCsKg CX0NCsKgDQotCVdBUk5fT04oIWlzX3Bvd2VyX29mXzIodW1lbS0+cGFnZV9zaXplKSk7DQorCVdB Uk5fT05fT05DRSghaXNfcG93ZXJfb2ZfMih1bWVtLT5wYWdlX3NpemUpKTsNCsKgDQrCoAltZW0t PnBhZ2Vfc2hpZnQJCT0gaWxvZzIodW1lbS0+cGFnZV9zaXplKTsNCsKgCW1lbS0+cGFnZV9tYXNr CQk9IHVtZW0tPnBhZ2Vfc2l6ZSAtIDE7DQpAQCAtMzc1LDcgKzM3NSw3IEBAIGludCByeGVfbWVt X2NvcHkoc3RydWN0IHJ4ZV9tZW0gKm1lbSwgdTY0IGlvdmEsIHZvaWQgKmFkZHIsIGludCBsZW5n dGgsDQrCoAkJcmV0dXJuIDA7DQrCoAl9DQrCoA0KLQlXQVJOX09OKCFtZW0tPm1hcCk7DQorCVdB Uk5fT05fT05DRSghbWVtLT5tYXApOw0KwqANCsKgCWVyciA9IG1lbV9jaGVja19yYW5nZShtZW0s IGlvdmEsIGxlbmd0aCk7DQrCoAlpZiAoZXJyKSB7DQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9pbmZp bmliYW5kL3N3L3J4ZS9yeGVfcmVzcC5jIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVf cmVzcC5jDQppbmRleCAzNDM1ZWZmZjg3OTkuLjZkYmQwNjk2ODlmYyAxMDA2NDQNCi0tLSBhL2Ry aXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuYw0KKysrIGIvZHJpdmVycy9pbmZpbmli YW5kL3N3L3J4ZS9yeGVfcmVzcC5jDQpAQCAtMzA3LDcgKzMwNyw3IEBAIHN0YXRpYyBlbnVtIHJl c3Bfc3RhdGVzIGNoZWNrX29wX3ZhbGlkKHN0cnVjdCByeGVfcXAgKnFwLA0KwqAJCWJyZWFrOw0K wqANCsKgCWRlZmF1bHQ6DQotCQlXQVJOX09OKDEpOw0KKwkJV0FSTl9PTl9PTkNFKDEpOw0KwqAJ CWJyZWFrOw0KwqAJfQ0KwqANCkBAIC00OTUsNyArNDk1LDcgQEAgc3RhdGljIGVudW0gcmVzcF9z dGF0ZXMgY2hlY2tfcmtleShzdHJ1Y3QgcnhlX3FwICpxcCwNCsKgCQl9DQrCoAl9DQrCoA0KLQlX QVJOX09OKHFwLT5yZXNwLm1yKTsNCisJV0FSTl9PTl9PTkNFKHFwLT5yZXNwLm1yKTsNCsKgDQrC oAlxcC0+cmVzcC5tciA9IG1lbTsNCsKgCXJldHVybiBSRVNQU1RfRVhFQ1VURTsNCkBAIC04MDgs OSArODA4LDEwIEBAIHN0YXRpYyBlbnVtIHJlc3Bfc3RhdGVzIGV4ZWN1dGUoc3RydWN0IHJ4ZV9x cCAqcXAsIHN0cnVjdCByeGVfcGt0X2luZm8gKnBrdCkNCsKgCQllcnIgPSBwcm9jZXNzX2F0b21p YyhxcCwgcGt0KTsNCsKgCQlpZiAoZXJyKQ0KwqAJCQlyZXR1cm4gZXJyOw0KLQl9IGVsc2UNCisJ fSBlbHNlIHsNCsKgCQkvKiBVbnJlYWNoYWJsZSAqLw0KLQkJV0FSTl9PTigxKTsNCisJCVdBUk5f T05fT05DRSgxKTsNCisJfQ0KwqANCsKgCS8qIFdlIHN1Y2Nlc3NmdWxseSBwcm9jZXNzZWQgdGhp cyBuZXcgcmVxdWVzdC4gKi8NCsKgCXFwLT5yZXNwLm1zbisrOw0KQEAgLTEzOTYsNyArMTM5Nyw3 IEBAIGludCByeGVfcmVzcG9uZGVyKHZvaWQgKmFyZykNCsKgCQkJZ290byBleGl0Ow0KwqANCsKg CQlkZWZhdWx0Og0KLQkJCVdBUk5fT04oMSk7DQorCQkJV0FSTl9PTl9PTkNFKDEpOw0KwqAJCX0N CsKgCX0NCsKgDQotLcKgDQoyLjExLjANCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 08/15] IB/rxe: Issue warnings once
Quoted 81 lines · Bart Van Assche
It is strongly recommended to report kernel warnings once instead of every time a condition is hit. Hence change
WARN_ON()intoWARN_ON_ONCE()/BUILD_BUG_ON()as
appropriate.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_comp.c | 2 +- drivers/infiniband/sw/rxe/rxe_mr.c | 6 +++---drivers/infiniband/sw/rxe/rxe_resp.c| 11 ++++++-----3 files changed, 10 insertions(+), 9 deletions(-)drivers/infiniband/sw/rxe/rxe_comp.c +0
-0@@ -254,7 +254,7 @@ static inline enum comp_state check_ack(struct rxe_qp *qp, } break;default:
drivers/infiniband/sw/rxe/rxe_comp.c +1
-1-WARN_ON (1 ); +WARN_ON_ONCE (1 );}
/* Check operation validity. */drivers/infiniband/sw/rxe/rxe_mr.c +0
-0@@ -123,7 +123,7 @@ static int rxe_mem_alloc(struct rxe_dev *rxe, struct rxe_mem *mem, int num_buf) goto err2; }drivers/infiniband/sw/rxe/rxe_mr.c +1
-1-WARN_ON (!is_power_of_2 (RXE_BUF_PER_MAP )); +BUILD_BUG_ON (!is_power_of_2 (RXE_BUF_PER_MAP ));
mem->map_shift=ilog2(RXE_BUF_PER_MAP);
mem->map_mask=RXE_BUF_PER_MAP- 1;drivers/infiniband/sw/rxe/rxe_mr.c +0
-0@@ -189,7 +189,7 @@ int rxe_mem_init_user(struct rxe_dev *rxe, struct rxe_pd *pd, u64 start, goto err1; }drivers/infiniband/sw/rxe/rxe_mr.c +1
-1-WARN_ON (!is_power_of_2 (umem->page_size)); +WARN_ON_ONCE (!is_power_of_2 (umem->page_size));
mem->page_shift=ilog2(umem->page_size);
mem->page_mask=umem->page_size- 1;drivers/infiniband/sw/rxe/rxe_mr.c +0
-0@@ -375,7 +375,7 @@ int rxe_mem_copy(struct rxe_mem *mem, u64 iova, void *addr, int length, return 0; }drivers/infiniband/sw/rxe/rxe_mr.c +1
-1-WARN_ON (!mem->map); +WARN_ON_ONCE (!mem->map);
err =mem_check_range(mem, iova, length);
if (err) {drivers/infiniband/sw/rxe/rxe_resp.c +0
-0@@ -307,7 +307,7 @@ static enum resp_states check_op_valid(struct rxe_qp *qp, break;
default:drivers/infiniband/sw/rxe/rxe_resp.c +1
-1-WARN_ON (1 ); +WARN_ON_ONCE (1 );break;
}drivers/infiniband/sw/rxe/rxe_resp.c +0
-0@@ -495,7 +495,7 @@ static enum resp_states check_rkey(struct rxe_qp *qp, } }drivers/infiniband/sw/rxe/rxe_resp.c +1
-1-WARN_ON (qp->resp.mr); +WARN_ON_ONCE (qp->resp.mr);
qp->resp.mr= mem;
returnRESPST_EXECUTE;
drivers/infiniband/sw/rxe/rxe_resp.c static enum resp_states execute(struct rxe_qp *qp, struct rxe_pkt_info *pkt) · line 814
Quoted 9 lines
drivers/infiniband/sw/rxe/rxe_resp.c +3
-2@@ -808,9 +808,10 @@ static enum resp_states execute(struct rxe_qp *qp, struct rxe_pkt_info *pkt) err = process_atomic(qp, pkt); if (err) return err; - }else + }else { /* Unreachable */ -WARN_ON (1 ); +WARN_ON_ONCE (1 ); + }
This function (execute(..)) and the comment looks very suspicious to me. It seems that the orginal author had intention to check if mask has specific bit on, but current implmentation allows multiple bits and has execution priority between bits in mask.
Moni,
Did you do it on purpose?
Quoted 14 lines
/* We successfully processed this new request. */ qp->resp.msn++;drivers/infiniband/sw/rxe/rxe_resp.c +0
-0@@ -1396,7 +1397,7 @@ int rxe_responder(void *arg) goto exit;
default:drivers/infiniband/sw/rxe/rxe_resp.c +1
-1-WARN_ON (1 ); +WARN_ON_ONCE (1 );}
}
--
2.11.0
PATCH 9/15 IB/rxe: Add a runtime check in alloc_index()
In reply to a message not in the archiveU2luY2UgaW5kZXggdmFsdWVzIGVxdWFsIHRvIG9yIGFib3ZlICdyYW5nZScgY2FuIHRyaWdnZXIg bWVtb3J5DQpjb3JydXB0aW9uLCBjb21wbGFpbiBpZiBpbmRleCA+PSByYW5nZS4NCg0KU2lnbmVk LW9mZi1ieTogQmFydCBWYW4gQXNzY2hlIDxiYXJ0LnZhbmFzc2NoZUBzYW5kaXNrLmNvbT4NCkNj OiBNb25pIFNob3VhIDxtb25pc0BtZWxsYW5veC5jb20+DQpDYzogQW5kcmV3IEJveWVyIDxhbmRy ZXcuYm95ZXJAZGVsbC5jb20+DQotLS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVf cG9vbC5jIHwgMSArDQrCoDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQ0KDQpkaWZmIC0t Z2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5jIGIvZHJpdmVycy9pbmZp bmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5jDQppbmRleCA3ZDFlMjg2MmI5MjguLjc1ZDExZWU2MzVl YyAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Bvb2wuYw0KKysr IGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcG9vbC5jDQpAQCAtMjY2LDYgKzI2Niw3 IEBAIHN0YXRpYyB1MzIgYWxsb2NfaW5kZXgoc3RydWN0IHJ4ZV9wb29sICpwb29sKQ0KwqAJaWYg KGluZGV4ID49IHJhbmdlKQ0KwqAJCWluZGV4ID0gZmluZF9maXJzdF96ZXJvX2JpdChwb29sLT50 YWJsZSwgcmFuZ2UpOw0KwqANCisJV0FSTl9PTl9PTkNFKGluZGV4ID49IHJhbmdlKTsNCsKgCXNl dF9iaXQoaW5kZXgsIHBvb2wtPnRhYmxlKTsNCsKgCXBvb2wtPmxhc3QgPSBpbmRleDsNCsKgCXJl dHVybiBpbmRleCArIHBvb2wtPm1pbl9pbmRleDsNCi0twqANCjIuMTEuMA0K
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 09/15] IB/rxe: Add a runtime check in alloc_index()
Quoted 2 lines · Bart Van Assche
Since index values equal to or above 'range' can trigger memory corruption, complain if index >= range.
It looks like severe bug and the proper error folding is needed, if it is a real situation.
Quoted 23 lines
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_pool.c | 1 +1 file changed, 1 insertion(+)drivers/infiniband/sw/rxe/rxe_pool.c +0
-0@@ -266,6 +266,7 @@ static u32 alloc_index(struct rxe_pool *pool) if (index >= range) index = find_first_zero_bit(pool->table, range);drivers/infiniband/sw/rxe/rxe_pool.c +1
-0+WARN_ON_ONCE (index >= range);
set_bit(index, pool->table);
pool->last= index;
return index +pool->min_index;
--
2.11.0
N?????r??y????b?X??ǧv?^?){.n?+????{??ٚ?{ay?ʇڙ?,j??f???h???z??w??????j:+v???w?j?m????????zZ+?????ݢj"??!
A message that is not in the archive (sent off-list or not yet received): 20170104172704.GU12077-U/[email protected]
Re: [PATCH 09/15] IB/rxe: Add a runtime check in alloc_index()
Quoted 6 lines · Leon Romanovsky
Quoted 2 lines · Bart Van Assche
Since index values equal to or above 'range' can trigger memory corruption, complain if index >= range.
It looks like severe bug and the proper error folding is needed, if it is a real situation.
Code in other functions guarantees that this condition won't be hit. The warning I added is intended to catch bugs if that other code would ever be modified.
Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 09/15] IB/rxe: Add a runtime check in alloc_index()
Quoted 10 lines · Bart Van Assche
Quoted 6 lines · Leon Romanovsky
Quoted 2 lines · Bart Van Assche
Since index values equal to or above 'range' can trigger memory corruption, complain if index >= range.
It looks like severe bug and the proper error folding is needed, if it is a real situation.
Code in other functions guarantees that this condition won't be hit. The warning I added is intended to catch bugs if that other code would ever be modified.
It sounds reasonable.
Thanks.
Quoted 2 lines
Bart.
Boyer, Andrew
Reviewed-byRe: [PATCH 09/15] IB/rxe: Add a runtime check in alloc_index()
In reply to a message not in the archiveQuoted 9 lines · Bart Van Assche
Since index values equal to or above 'range' can trigger memory corruption, complain if index >= range.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_pool.c| 1 +1 file changed, 1 insertion(+)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 10/15 IB/rxe: Introduce functions for queue draining
In reply to a message not in the archiveVGhpcyBjaGFuZ2UgbWFrZXMgdGhlIGNvZGUgZWFzaWVyIHRvIHJlYWQgYW5kIGF2b2lkcyB0aGF0 IGNvZGUgaXMNCmR1cGxpY2F0ZWQuDQoNClNpZ25lZC1vZmYtYnk6IEJhcnQgVmFuIEFzc2NoZSA8 YmFydC52YW5hc3NjaGVAc2FuZGlzay5jb20+DQpDYzogTW9uaSBTaG91YSA8bW9uaXNAbWVsbGFu b3guY29tPg0KQ2M6IEFuZHJldyBCb3llciA8YW5kcmV3LmJveWVyQGRlbGwuY29tPg0KLS0tDQrC oGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2NvbXAuYyB8IDYzICsrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9y ZXNwLmMgfCAyOCArKysrKysrKy0tLS0tLS0tDQrCoDIgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0 aW9ucygrKSwgNTMgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJh bmQvc3cvcnhlL3J4ZV9jb21wLmMgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9jb21w LmMNCmluZGV4IGU5MTJlNTM5NmU4Yy4uNjc2OWEwNzU1MDFlIDEwMDY0NA0KLS0tIGEvZHJpdmVy cy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfY29tcC5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQv c3cvcnhlL3J4ZV9jb21wLmMNCkBAIC01MDMsNTcgKzUwMyw0MCBAQCBzdGF0aWMgaW5saW5lIGVu dW0gY29tcF9zdGF0ZSBjb21wbGV0ZV93cWUoc3RydWN0IHJ4ZV9xcCAqcXAsDQrCoAlyZXR1cm4g Q09NUFNUX0dFVF9XUUU7DQrCoH0NCsKgDQotaW50IHJ4ZV9jb21wbGV0ZXIodm9pZCAqYXJnKQ0K K3N0YXRpYyB2b2lkIHJ4ZV9kcmFpbl9yZXNwX3BrdHMoc3RydWN0IHJ4ZV9xcCAqcXAsIGJvb2wg bm90aWZ5KQ0KwqB7DQotCXN0cnVjdCByeGVfcXAgKnFwID0gKHN0cnVjdCByeGVfcXAgKilhcmc7 DQotCXN0cnVjdCByeGVfc2VuZF93cWUgKndxZSA9IHdxZTsNCi0Jc3RydWN0IHNrX2J1ZmYgKnNr YiA9IE5VTEw7DQotCXN0cnVjdCByeGVfcGt0X2luZm8gKnBrdCA9IE5VTEw7DQotCWVudW0gY29t cF9zdGF0ZSBzdGF0ZTsNCi0NCi0JcnhlX2FkZF9yZWYocXApOw0KLQ0KLQlpZiAoIXFwLT52YWxp ZCkgew0KLQkJd2hpbGUgKChza2IgPSBza2JfZGVxdWV1ZSgmcXAtPnJlc3BfcGt0cykpKSB7DQot CQkJcnhlX2Ryb3BfcmVmKHFwKTsNCi0JCQlrZnJlZV9za2Ioc2tiKTsNCi0JCX0NCi0JCXNrYiA9 IE5VTEw7DQotCQlwa3QgPSBOVUxMOw0KLQ0KLQkJd2hpbGUgKHF1ZXVlX2hlYWQocXAtPnNxLnF1 ZXVlKSkNCi0JCQlhZHZhbmNlX2NvbnN1bWVyKHFwLT5zcS5xdWV1ZSk7DQorCXN0cnVjdCBza19i dWZmICpza2I7DQorCXN0cnVjdCByeGVfc2VuZF93cWUgKndxZTsNCsKgDQotCQlnb3RvIGV4aXQ7 DQorCXdoaWxlICgoc2tiID0gc2tiX2RlcXVldWUoJnFwLT5yZXNwX3BrdHMpKSkgew0KKwkJcnhl X2Ryb3BfcmVmKHFwKTsNCisJCWtmcmVlX3NrYihza2IpOw0KwqAJfQ0KwqANCi0JaWYgKHFwLT5y ZXEuc3RhdGUgPT0gUVBfU1RBVEVfRVJST1IpIHsNCi0JCXdoaWxlICgoc2tiID0gc2tiX2RlcXVl dWUoJnFwLT5yZXNwX3BrdHMpKSkgew0KLQkJCXJ4ZV9kcm9wX3JlZihxcCk7DQotCQkJa2ZyZWVf c2tiKHNrYik7DQotCQl9DQotCQlza2IgPSBOVUxMOw0KLQkJcGt0ID0gTlVMTDsNCi0NCi0JCXdo aWxlICgod3FlID0gcXVldWVfaGVhZChxcC0+c3EucXVldWUpKSkgew0KKwl3aGlsZSAoKHdxZSA9 IHF1ZXVlX2hlYWQocXAtPnNxLnF1ZXVlKSkpIHsNCisJCWlmIChub3RpZnkpIHsNCsKgCQkJd3Fl LT5zdGF0dXMgPSBJQl9XQ19XUl9GTFVTSF9FUlI7DQrCoAkJCWRvX2NvbXBsZXRlKHFwLCB3cWUp Ow0KKwkJfSBlbHNlIHsNCisJCQlhZHZhbmNlX2NvbnN1bWVyKHFwLT5zcS5xdWV1ZSk7DQrCoAkJ fQ0KLQ0KLQkJZ290byBleGl0Ow0KwqAJfQ0KK30NCsKgDQotCWlmIChxcC0+cmVxLnN0YXRlID09 IFFQX1NUQVRFX1JFU0VUKSB7DQotCQl3aGlsZSAoKHNrYiA9IHNrYl9kZXF1ZXVlKCZxcC0+cmVz cF9wa3RzKSkpIHsNCi0JCQlyeGVfZHJvcF9yZWYocXApOw0KLQkJCWtmcmVlX3NrYihza2IpOw0K LQkJfQ0KLQkJc2tiID0gTlVMTDsNCi0JCXBrdCA9IE5VTEw7DQoraW50IHJ4ZV9jb21wbGV0ZXIo dm9pZCAqYXJnKQ0KK3sNCisJc3RydWN0IHJ4ZV9xcCAqcXAgPSAoc3RydWN0IHJ4ZV9xcCAqKWFy ZzsNCisJc3RydWN0IHJ4ZV9zZW5kX3dxZSAqd3FlID0gd3FlOw0KKwlzdHJ1Y3Qgc2tfYnVmZiAq c2tiID0gTlVMTDsNCisJc3RydWN0IHJ4ZV9wa3RfaW5mbyAqcGt0ID0gTlVMTDsNCisJZW51bSBj b21wX3N0YXRlIHN0YXRlOw0KwqANCi0JCXdoaWxlIChxdWV1ZV9oZWFkKHFwLT5zcS5xdWV1ZSkp DQotCQkJYWR2YW5jZV9jb25zdW1lcihxcC0+c3EucXVldWUpOw0KKwlyeGVfYWRkX3JlZihxcCk7 DQrCoA0KKwlpZiAoIXFwLT52YWxpZCB8fCBxcC0+cmVxLnN0YXRlID09IFFQX1NUQVRFX0VSUk9S IHx8DQorCcKgwqDCoMKgcXAtPnJlcS5zdGF0ZSA9PSBRUF9TVEFURV9SRVNFVCkgew0KKwkJcnhl X2RyYWluX3Jlc3BfcGt0cyhxcCwgcXAtPnZhbGlkICYmDQorCQkJCcKgwqDCoMKgcXAtPnJlcS5z dGF0ZSA9PSBRUF9TVEFURV9FUlJPUik7DQrCoAkJZ290byBleGl0Ow0KwqAJfQ0KwqANCmRpZmYg LS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXNwLmMgYi9kcml2ZXJzL2lu ZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXNwLmMNCmluZGV4IDZkYmQwNjk2ODlmYy4uMjU5NTFlOTQx M2I4IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcmVzcC5jDQor KysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXNwLmMNCkBAIC0xMjA3LDYgKzEy MDcsMTkgQEAgc3RhdGljIGVudW0gcmVzcF9zdGF0ZXMgZG9fY2xhc3NfZDFlX2Vycm9yKHN0cnVj dCByeGVfcXAgKnFwKQ0KwqAJfQ0KwqB9DQrCoA0KK3N0YXRpYyB2b2lkIHJ4ZV9kcmFpbl9yZXFf cGt0cyhzdHJ1Y3QgcnhlX3FwICpxcCwgYm9vbCBub3RpZnkpDQorew0KKwlzdHJ1Y3Qgc2tfYnVm ZiAqc2tiOw0KKw0KKwl3aGlsZSAoKHNrYiA9IHNrYl9kZXF1ZXVlKCZxcC0+cmVxX3BrdHMpKSkg ew0KKwkJcnhlX2Ryb3BfcmVmKHFwKTsNCisJCWtmcmVlX3NrYihza2IpOw0KKwl9DQorDQorCXdo aWxlICghcXAtPnNycSAmJiBxcC0+cnEucXVldWUgJiYgcXVldWVfaGVhZChxcC0+cnEucXVldWUp KQ0KKwkJYWR2YW5jZV9jb25zdW1lcihxcC0+cnEucXVldWUpOw0KK30NCisNCsKgaW50IHJ4ZV9y ZXNwb25kZXIodm9pZCAqYXJnKQ0KwqB7DQrCoAlzdHJ1Y3QgcnhlX3FwICpxcCA9IChzdHJ1Y3Qg cnhlX3FwICopYXJnOw0KQEAgLTEzNzQsMjEgKzEzODcsMTAgQEAgaW50IHJ4ZV9yZXNwb25kZXIo dm9pZCAqYXJnKQ0KwqANCsKgCQkJZ290byBleGl0Ow0KwqANCi0JCWNhc2UgUkVTUFNUX1JFU0VU OiB7DQotCQkJc3RydWN0IHNrX2J1ZmYgKnNrYjsNCi0NCi0JCQl3aGlsZSAoKHNrYiA9IHNrYl9k ZXF1ZXVlKCZxcC0+cmVxX3BrdHMpKSkgew0KLQkJCQlyeGVfZHJvcF9yZWYocXApOw0KLQkJCQlr ZnJlZV9za2Ioc2tiKTsNCi0JCQl9DQotDQotCQkJd2hpbGUgKCFxcC0+c3JxICYmIHFwLT5ycS5x dWV1ZSAmJg0KLQkJCcKgwqDCoMKgwqDCoMKgcXVldWVfaGVhZChxcC0+cnEucXVldWUpKQ0KLQkJ CQlhZHZhbmNlX2NvbnN1bWVyKHFwLT5ycS5xdWV1ZSk7DQotDQorCQljYXNlIFJFU1BTVF9SRVNF VDoNCisJCQlyeGVfZHJhaW5fcmVxX3BrdHMocXAsIGZhbHNlKTsNCsKgCQkJcXAtPnJlc3Aud3Fl ID0gTlVMTDsNCsKgCQkJZ290byBleGl0Ow0KLQkJfQ0KwqANCsKgCQljYXNlIFJFU1BTVF9FUlJP UjoNCsKgCQkJcXAtPnJlc3AuZ290b19lcnJvciA9IDA7DQotLcKgDQoyLjExLjANCg== --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 10/15] IB/rxe: Introduce functions for queue draining
Quoted 105 lines · Bart Van Assche
This change makes the code easier to read and avoids that code is duplicated.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_comp.c| 63
+++++++++++++-----------------------drivers/infiniband/sw/rxe/rxe_resp.c| 28 ++++++++--------2 files changed, 38 insertions(+), 53 deletions(-)drivers/infiniband/sw/rxe/rxe_comp.c +23
-40@@ -503,57 +503,40 @@ static inline enum comp_state complete_wqe(structrxe_qp *qp, return COMPST_GET_WQE; } -int rxe_completer (void *arg) +static void rxe_drain_resp_pkts (struct rxe_qp *qp,bool notify) { -struct rxe_qp *qp = (struct rxe_qp *)arg; -struct rxe_send_wqe *wqe = wqe; -struct sk_buff *skb =NULL ; -struct rxe_pkt_info *pkt =NULL ; -enum comp_state state; - -rxe_add_ref (qp); - -if (!qp->valid) { -while ((skb =skb_dequeue (&qp->resp_pkts))) { -rxe_drop_ref (qp); -kfree_skb (skb); - } - skb =NULL ; - pkt =NULL ; - -while (queue_head (qp->sq.queue)) -advance_consumer (qp->sq.queue); +struct sk_buff *skb; +struct rxe_send_wqe *wqe; - goto exit; +while ((skb =skb_dequeue (&qp->resp_pkts))) { +rxe_drop_ref (qp); +kfree_skb (skb); } -if (qp->req.state ==QP_STATE_ERROR ) { -while ((skb =skb_dequeue (&qp->resp_pkts))) { -rxe_drop_ref (qp); -kfree_skb (skb); - } - skb =NULL ; - pkt =NULL ; - -while ((wqe =queue_head (qp->sq.queue))) { +while ((wqe =queue_head (qp->sq.queue))) { +if (notify) { wqe->status =IB_WC_WR_FLUSH_ERR ;do_complete (qp, wqe); + }else { +advance_consumer (qp->sq.queue); } - - goto exit; } +} -if (qp->req.state ==QP_STATE_RESET ) { -while ((skb =skb_dequeue (&qp->resp_pkts))) { -rxe_drop_ref (qp); -kfree_skb (skb); - } - skb =NULL ; - pkt =NULL ; +int rxe_completer (void *arg) +{ +struct rxe_qp *qp = (struct rxe_qp *)arg; +struct rxe_send_wqe *wqe = wqe; +struct sk_buff *skb =NULL ; +struct rxe_pkt_info *pkt =NULL ; +enum comp_state state; -while (queue_head (qp->sq.queue)) -advance_consumer (qp->sq.queue); +rxe_add_ref (qp); +if (!qp->valid || qp->req.state ==QP_STATE_ERROR || + qp->req.state ==QP_STATE_RESET ) { +rxe_drain_resp_pkts (qp, qp->valid && + qp->req.state ==QP_STATE_ERROR ); goto exit; }drivers/infiniband/sw/rxe/rxe_resp.c +0
-0
drivers/infiniband/sw/rxe/rxe_resp.c static enum resp_states do_class_d1e_error(struct · line 1211
Quoted 5 lines
drivers/infiniband/sw/rxe/rxe_resp.c +1
-0@@ -1207,6 +1207,19 @@ static enum resp_states do_class_d1e_error(struct rxe_qp *qp) } } +static void rxe_drain_req_pkts (struct rxe_qp *qp,bool notify)
Is notify unused? Is it here just for symmetry with the responder?
Quoted 41 lines
drivers/infiniband/sw/rxe/rxe_resp.c +12
-0+{ +struct sk_buff *skb; + +while ((skb =skb_dequeue (&qp->req_pkts))) { +rxe_drop_ref (qp); +kfree_skb (skb); + } + +while (!qp->srq && qp->rq.queue &&queue_head (qp->rq.queue)) +advance_consumer (qp->rq.queue); +} +int rxe_responder (void *arg) {struct rxe_qp *qp = (struct rxe_qp *)arg;drivers/infiniband/sw/rxe/rxe_resp.c +2
-13@@ -1374,21 +1387,10 @@ int rxe_responder(void *arg) goto exit; -case RESPST_RESET : { -struct sk_buff *skb; - -while ((skb =skb_dequeue (&qp->req_pkts))) { -rxe_drop_ref (qp); -kfree_skb (skb); - } - -while (!qp->srq && qp->rq.queue && -queue_head (qp->rq.queue)) -advance_consumer (qp->rq.queue); - +case RESPST_RESET : +rxe_drain_req_pkts (qp, false); qp->resp.wqe =NULL ; goto exit; - }case RESPST_ERROR : qp->resp.goto_error =0 ;Signature · 1 line
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): D49910D0.9088%[email protected]
Boyer, Andrew
Reviewed-byRe: [PATCH 10/15] IB/rxe: Introduce functions for queue draining
Quoted 13 lines · Andrew
Quoted 11 lines · Bart Van Assche
This change makes the code easier to read and avoids that code is duplicated.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_comp.c| 63
+++++++++++++-----------------------drivers/infiniband/sw/rxe/rxe_resp.c| 28 ++++++++--------2 files changed, 38 insertions(+), 53 deletions(-)
...
Quoted 6 lines
Quoted 4 lines
}
+static void
rxe_drain_req_pkts(struct rxe_qp *qp, bool notify)Is notify unused? Is it here just for symmetry with the responder?
Never mind, I see it used in patch 11.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 11/15 IB/rxe: Generate a completion for all failed work requests
In reply to a message not in the archiveQ2hhbmdlIGRvX2NvbXBsZXRlKCkgc3VjaCB0aGF0IGFuIGVycm9yIGNvbXBsZXRpb24gaXMgbm90 IG9ubHkNCmdlbmVyYXRlZCBpZiBhIFFQIGlzIGluIHRoZSBlcnJvciBzdGF0ZSBidXQgYWxzbyBp ZiBhIHdvcmsgcmVxdWVzdA0KZmFpbGVkLg0KDQpTaWduZWQtb2ZmLWJ5OiBCYXJ0IFZhbiBBc3Nj aGUgPGJhcnQudmFuYXNzY2hlQHNhbmRpc2suY29tPg0KQ2M6IE1vbmkgU2hvdWEgPG1vbmlzQG1l bGxhbm94LmNvbT4NCkNjOiBBbmRyZXcgQm95ZXIgPGFuZHJldy5ib3llckBkZWxsLmNvbT4NCi0t LQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9jb21wLmMgfMKgwqAzICsrLQ0KwqBk cml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9sb2MuaMKgwqB8wqDCoDEgKw0KwqBkcml2ZXJz L2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXEuY8KgwqB8IDE4ICsrKysrKystLS0tLS0tLS0tLQ0K wqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXNwLmMgfMKgwqAyICstDQrCoDQgZmls ZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1n aXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9jb21wLmMgYi9kcml2ZXJzL2luZmlu aWJhbmQvc3cvcnhlL3J4ZV9jb21wLmMNCmluZGV4IDY3NjlhMDc1NTAxZS4uZDFjMzQxMWM1NDc4 IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfY29tcC5jDQorKysg Yi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9jb21wLmMNCkBAIC00MTgsNyArNDE4LDcg QEAgc3RhdGljIHZvaWQgZG9fY29tcGxldGUoc3RydWN0IHJ4ZV9xcCAqcXAsIHN0cnVjdCByeGVf c2VuZF93cWUgKndxZSkNCsKgDQrCoAlpZiAoKHFwLT5zcV9zaWdfdHlwZSA9PSBJQl9TSUdOQUxf QUxMX1dSKSB8fA0KwqAJwqDCoMKgwqAod3FlLT53ci5zZW5kX2ZsYWdzICYgSUJfU0VORF9TSUdO QUxFRCkgfHwNCi0JwqDCoMKgwqAocXAtPnJlcS5zdGF0ZSA9PSBRUF9TVEFURV9FUlJPUikpIHsN CisJwqDCoMKgwqB3cWUtPnN0YXR1cyAhPSBJQl9XQ19TVUNDRVNTKSB7DQrCoAkJbWFrZV9zZW5k X2NxZShxcCwgd3FlLCAmY3FlKTsNCsKgCQlhZHZhbmNlX2NvbnN1bWVyKHFwLT5zcS5xdWV1ZSk7 DQrCoAkJcnhlX2NxX3Bvc3QocXAtPnNjcSwgJmNxZSwgMCk7DQpAQCAtNzA5LDYgKzcwOSw3IEBA IGludCByeGVfY29tcGxldGVyKHZvaWQgKmFyZykNCsKgCQkJYnJlYWs7DQrCoA0KwqAJCWNhc2Ug Q09NUFNUX0VSUk9SOg0KKwkJCVdBUk5fT05fT05DRSh3cWUtPnN0YXR1cyA9PSBJQl9XQ19TVUND RVNTKTsNCsKgCQkJZG9fY29tcGxldGUocXAsIHdxZSk7DQrCoAkJCXJ4ZV9xcF9lcnJvcihxcCk7 DQrCoA0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2xvYy5oIGIv ZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbG9jLmgNCmluZGV4IGRhMTkxZDdhY2I2Zi4u YmRlYzQ2MGYxZmNlIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVf bG9jLmgNCisrKyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2xvYy5oDQpAQCAtMjI1 LDYgKzIyNSw3IEBAIGV4dGVybiBzdHJ1Y3QgaWJfZG1hX21hcHBpbmdfb3BzIHJ4ZV9kbWFfbWFw cGluZ19vcHM7DQrCoA0KwqB2b2lkIHJ4ZV9yZWxlYXNlKHN0cnVjdCBrcmVmICprcmVmKTsNCsKg DQordm9pZCByeGVfZHJhaW5fcmVxX3BrdHMoc3RydWN0IHJ4ZV9xcCAqcXAsIGJvb2wgbm90aWZ5 KTsNCsKgaW50IHJ4ZV9jb21wbGV0ZXIodm9pZCAqYXJnKTsNCsKgaW50IHJ4ZV9yZXF1ZXN0ZXIo dm9pZCAqYXJnKTsNCsKgaW50IHJ4ZV9yZXNwb25kZXIodm9pZCAqYXJnKTsNCmRpZmYgLS1naXQg YS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXEuYyBiL2RyaXZlcnMvaW5maW5pYmFu ZC9zdy9yeGUvcnhlX3JlcS5jDQppbmRleCBiOTViNjAzNWU5ODguLjY0OTk5ZjUyOTk4MSAxMDA2 NDQNCi0tLSBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3JlcS5jDQorKysgYi9kcml2 ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXEuYw0KQEAgLTU5NCw5ICs1OTQsMTQgQEAgaW50 IHJ4ZV9yZXF1ZXN0ZXIodm9pZCAqYXJnKQ0KwqAJcnhlX2FkZF9yZWYocXApOw0KwqANCsKgbmV4 dF93cWU6DQotCWlmICh1bmxpa2VseSghcXAtPnZhbGlkIHx8IHFwLT5yZXEuc3RhdGUgPT0gUVBf U1RBVEVfRVJST1IpKQ0KKwlpZiAodW5saWtlbHkoIXFwLT52YWxpZCkpDQrCoAkJZ290byBleGl0 Ow0KwqANCisJaWYgKHVubGlrZWx5KHFwLT5yZXEuc3RhdGUgPT0gUVBfU1RBVEVfRVJST1IpKSB7 DQorCQlyeGVfZHJhaW5fcmVxX3BrdHMocXAsIHRydWUpOw0KKwkJZ290byBleGl0Ow0KKwl9DQor DQrCoAlpZiAodW5saWtlbHkocXAtPnJlcS5zdGF0ZSA9PSBRUF9TVEFURV9SRVNFVCkpIHsNCsKg CQlxcC0+cmVxLndxZV9pbmRleCA9IGNvbnN1bWVyX2luZGV4KHFwLT5zcS5xdWV1ZSk7DQrCoAkJ cXAtPnJlcS5vcGNvZGUgPSAtMTsNCkBAIC03NDMsMTcgKzc0OCw4IEBAIGludCByeGVfcmVxdWVz dGVyKHZvaWQgKmFyZykNCsKgCWtmcmVlX3NrYihza2IpOw0KwqAJd3FlLT5zdGF0dXMgPSBJQl9X Q19MT0NfUFJPVF9FUlI7DQrCoAl3cWUtPnN0YXRlID0gd3FlX3N0YXRlX2Vycm9yOw0KLQ0KLQkv Kg0KLQnCoCogSUJBIFNwZWMuIFNlY3Rpb24gMTAuNy4zLjEgU0lHTkFMRUQgQ09NUExFVElPTlMN Ci0JwqAqIC0tLS0tLS0tLTg8LS0tLS0tLS0tODwtLS0tLS0tLS0tLS0tDQotCcKgKiAuLi5Ob3Rl IHRoYXQgaWYgYSBjb21wbGV0aW9uIGVycm9yIG9jY3VycywgYSBXb3JrIENvbXBsZXRpb24NCi0J wqAqIHdpbGwgYWx3YXlzIGJlIGdlbmVyYXRlZCwgZXZlbiBpZiB0aGUgc2lnbmFsaW5nDQotCcKg KiBpbmRpY2F0b3IgcmVxdWVzdHMgYW4gVW5zaWduYWxlZCBDb21wbGV0aW9uLg0KLQnCoCogLS0t LS0tLS0tODwtLS0tLS0tLS04PC0tLS0tLS0tLS0tLS0NCi0JwqAqLw0KLQl3cWUtPndyLnNlbmRf ZmxhZ3MgfD0gSUJfU0VORF9TSUdOQUxFRDsNCsKgCV9fcnhlX2RvX3Rhc2soJnFwLT5jb21wLnRh c2spOw0KKw0KwqBleGl0Og0KwqAJcnhlX2Ryb3BfcmVmKHFwKTsNCsKgCXJldHVybiAtRUFHQUlO Ow0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuYyBiL2Ry aXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuYw0KaW5kZXggMjU5NTFlOTQxM2I4Li4z M2RlZmFkZGMwMDAgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9y ZXNwLmMNCisrKyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuYw0KQEAgLTEy MDcsNyArMTIwNyw3IEBAIHN0YXRpYyBlbnVtIHJlc3Bfc3RhdGVzIGRvX2NsYXNzX2QxZV9lcnJv cihzdHJ1Y3QgcnhlX3FwICpxcCkNCsKgCX0NCsKgfQ0KwqANCi1zdGF0aWMgdm9pZCByeGVfZHJh aW5fcmVxX3BrdHMoc3RydWN0IHJ4ZV9xcCAqcXAsIGJvb2wgbm90aWZ5KQ0KK3ZvaWQgcnhlX2Ry YWluX3JlcV9wa3RzKHN0cnVjdCByeGVfcXAgKnFwLCBib29sIG5vdGlmeSkNCsKgew0KwqAJc3Ry dWN0IHNrX2J1ZmYgKnNrYjsNCsKgDQotLcKgDQoyLjExLjANCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Boyer, Andrew
Reviewed-byRe: [PATCH 11/15] IB/rxe: Generate a completion for all failed work requests
Quoted 74 lines · Bart Van Assche
Change
do_complete()such that an error completion is not only generated if a QP is in the error state but also if a work request failed.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_comp.c | 3 ++- drivers/infiniband/sw/rxe/rxe_loc.h | 1 + drivers/infiniband/sw/rxe/rxe_req.c | 18 +++++++----------- drivers/infiniband/sw/rxe/rxe_resp.c | 2 +- 4 files changed, 11 insertions(+), 13 deletions(-)drivers/infiniband/sw/rxe/rxe_comp.c +1
-1@@ -418,7 +418,7 @@ static void do_complete(struct rxe_qp *qp, struct rxe_send_wqe *wqe)if ((qp->sq_sig_type ==IB_SIGNAL_ALL_WR ) || (wqe->wr.send_flags &IB_SEND_SIGNALED ) || - (qp->req.state ==QP_STATE_ERROR )) { + wqe->status !=IB_WC_SUCCESS ) {make_send_cqe (qp, wqe, &cqe);advance_consumer (qp->sq.queue);rxe_cq_post(qp->scq, &cqe, 0);drivers/infiniband/sw/rxe/rxe_comp.c +1
-0@@ -709,6 +709,7 @@ int rxe_completer(void *arg)break ;case COMPST_ERROR : +WARN_ON_ONCE (wqe->status ==IB_WC_SUCCESS );do_complete (qp, wqe);rxe_qp_error (qp);drivers/infiniband/sw/rxe/rxe_loc.h +1
-0@@ -225,6 +225,7 @@ extern struct ib_dma_mapping_ops rxe_dma_mapping_ops;void rxe_release (struct kref *kref); +void rxe_drain_req_pkts (struct rxe_qp *qp,bool notify);int rxe_completer (void *arg);int rxe_requester (void *arg);int rxe_responder (void *arg);drivers/infiniband/sw/rxe/rxe_req.c +0
-0@@ -594,9 +594,14 @@ int rxe_requester(void *arg)rxe_add_ref (qp);
next_wqe:drivers/infiniband/sw/rxe/rxe_req.c +1
-1-if (unlikely (!qp->valid || qp->req.state ==QP_STATE_ERROR )) +if (unlikely (!qp->valid))goto exit;drivers/infiniband/sw/rxe/rxe_req.c +5
-0+if (unlikely (qp->req.state ==QP_STATE_ERROR )) { +rxe_drain_req_pkts (qp, true); + goto exit; + } +if (unlikely(qp->req.state == QP_STATE_RESET)) { qp->req.wqe_index = consumer_index(qp->sq.queue); qp->req.opcode = -1;drivers/infiniband/sw/rxe/rxe_req.c +0
-0@@ -743,17 +748,8 @@ int rxe_requester(void *arg)kfree_skb (skb); wqe->status =IB_WC_LOC_PROT_ERR ;
drivers/infiniband/sw/rxe/rxe_req.c int rxe_requester(void *arg) · line 754
Quoted 10 lines
drivers/infiniband/sw/rxe/rxe_req.c +0
-9wqe->state = wqe_state_error; - -/* -* IBA Spec. Section 10.7.3.1 SIGNALED COMPLETIONS -* ---------8<---------8<------------- -* ...Note that if a completion error occurs, a Work Completion -* will always be generated, even if the signaling -* indicator requests an Unsignaled Completion. -* ---------8<---------8<------------- -*/
It wouldn¹t hurt to move this comment over to the top of do_complete() to explain the wqe->status != IB_WC_SUCCESS test.
Quoted 23 lines
drivers/infiniband/sw/rxe/rxe_req.c +1
-1- wqe->wr.send_flags |=IB_SEND_SIGNALED ;__rxe_do_task (&qp->comp.task); +exit:
rxe_drop_ref(qp); return -EAGAIN;drivers/infiniband/sw/rxe/rxe_resp.c +1
-1@@ -1207,7 +1207,7 @@ static enum resp_states do_class_d1e_error(struct rxe_qp *qp) } } -static void rxe_drain_req_pkts (struct rxe_qp *qp,bool notify) +void rxe_drain_req_pkts (struct rxe_qp *qp,bool notify) {struct sk_buff *skb;Signature · 2 lines
-- 2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 12/15 IB/rxe: Fix a MR reference leak in check_rkey()
In reply to a message not in the archiveQXZvaWQgdGhhdCBjYWxsaW5nIGNoZWNrX3JrZXkoKSBmb3IgbWVtLT5zdGF0ZSA9PSBSWEVfTUVN X1NUQVRFX0ZSRUUNCnRyaWdnZXJzIGFuIE1SIHJlZmVyZW5jZSBsZWFrLg0KDQpTaWduZWQtb2Zm LWJ5OiBCYXJ0IFZhbiBBc3NjaGUgPGJhcnQudmFuYXNzY2hlQHNhbmRpc2suY29tPg0KQ2M6IE1v bmkgU2hvdWEgPG1vbmlzQG1lbGxhbm94LmNvbT4NCkNjOiBBbmRyZXcgQm95ZXIgPGFuZHJldy5i b3llckBkZWxsLmNvbT4NCi0tLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXNw LmMgfCAyMCArKysrKysrKysrLS0tLS0tLS0tLQ0KwqAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0 aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJh bmQvc3cvcnhlL3J4ZV9yZXNwLmMgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXNw LmMNCmluZGV4IDMzZGVmYWRkYzAwMC4uNjBkNzhmNDVhYTA0IDEwMDY0NA0KLS0tIGEvZHJpdmVy cy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcmVzcC5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQv c3cvcnhlL3J4ZV9yZXNwLmMNCkBAIC00MTgsNyArNDE4LDcgQEAgc3RhdGljIGVudW0gcmVzcF9z dGF0ZXMgY2hlY2tfbGVuZ3RoKHN0cnVjdCByeGVfcXAgKnFwLA0KwqBzdGF0aWMgZW51bSByZXNw X3N0YXRlcyBjaGVja19ya2V5KHN0cnVjdCByeGVfcXAgKnFwLA0KwqAJCQkJwqDCoMKgc3RydWN0 IHJ4ZV9wa3RfaW5mbyAqcGt0KQ0KwqB7DQotCXN0cnVjdCByeGVfbWVtICptZW07DQorCXN0cnVj dCByeGVfbWVtICptZW0gPSBOVUxMOw0KwqAJdTY0IHZhOw0KwqAJdTMyIHJrZXk7DQrCoAl1MzIg cmVzaWQ7DQpAQCAtNDU5LDM4ICs0NTksMzggQEAgc3RhdGljIGVudW0gcmVzcF9zdGF0ZXMgY2hl Y2tfcmtleShzdHJ1Y3QgcnhlX3FwICpxcCwNCsKgCW1lbSA9IGxvb2t1cF9tZW0ocXAtPnBkLCBh Y2Nlc3MsIHJrZXksIGxvb2t1cF9yZW1vdGUpOw0KwqAJaWYgKCFtZW0pIHsNCsKgCQlzdGF0ZSA9 IFJFU1BTVF9FUlJfUktFWV9WSU9MQVRJT047DQotCQlnb3RvIGVycjE7DQorCQlnb3RvIGVycjsN CsKgCX0NCsKgDQrCoAlpZiAodW5saWtlbHkobWVtLT5zdGF0ZSA9PSBSWEVfTUVNX1NUQVRFX0ZS RUUpKSB7DQrCoAkJc3RhdGUgPSBSRVNQU1RfRVJSX1JLRVlfVklPTEFUSU9OOw0KLQkJZ290byBl cnIxOw0KKwkJZ290byBlcnI7DQrCoAl9DQrCoA0KwqAJaWYgKG1lbV9jaGVja19yYW5nZShtZW0s IHZhLCByZXNpZCkpIHsNCsKgCQlzdGF0ZSA9IFJFU1BTVF9FUlJfUktFWV9WSU9MQVRJT047DQot CQlnb3RvIGVycjI7DQorCQlnb3RvIGVycjsNCsKgCX0NCsKgDQrCoAlpZiAocGt0LT5tYXNrICYg UlhFX1dSSVRFX01BU0spCcKgew0KwqAJCWlmIChyZXNpZCA+IG10dSkgew0KwqAJCQlpZiAocGt0 bGVuICE9IG10dSB8fCBidGhfcGFkKHBrdCkpIHsNCsKgCQkJCXN0YXRlID0gUkVTUFNUX0VSUl9M RU5HVEg7DQotCQkJCWdvdG8gZXJyMjsNCisJCQkJZ290byBlcnI7DQrCoAkJCX0NCsKgDQrCoAkJ CXJlc2lkID0gbXR1Ow0KwqAJCX0gZWxzZSB7DQrCoAkJCWlmIChwa3RsZW4gIT0gcmVzaWQpIHsN CsKgCQkJCXN0YXRlID0gUkVTUFNUX0VSUl9MRU5HVEg7DQotCQkJCWdvdG8gZXJyMjsNCisJCQkJ Z290byBlcnI7DQrCoAkJCX0NCsKgCQkJaWYgKChidGhfcGFkKHBrdCkgIT0gKDB4MyAmICgtcmVz aWQpKSkpIHsNCsKgCQkJCS8qIFRoaXMgY2FzZSBtYXkgbm90IGJlIGV4YWN0bHkgdGhhdA0KwqAJ CQkJwqAqIGJ1dCBub3RoaW5nIGVsc2UgZml0cy4NCsKgCQkJCcKgKi8NCsKgCQkJCXN0YXRlID0g UkVTUFNUX0VSUl9MRU5HVEg7DQotCQkJCWdvdG8gZXJyMjsNCisJCQkJZ290byBlcnI7DQrCoAkJ CX0NCsKgCQl9DQrCoAl9DQpAQCAtNTAwLDkgKzUwMCw5IEBAIHN0YXRpYyBlbnVtIHJlc3Bfc3Rh dGVzIGNoZWNrX3JrZXkoc3RydWN0IHJ4ZV9xcCAqcXAsDQrCoAlxcC0+cmVzcC5tciA9IG1lbTsN CsKgCXJldHVybiBSRVNQU1RfRVhFQ1VURTsNCsKgDQotZXJyMjoNCi0JcnhlX2Ryb3BfcmVmKG1l bSk7DQotZXJyMToNCitlcnI6DQorCWlmIChtZW0pDQorCQlyeGVfZHJvcF9yZWYobWVtKTsNCsKg CXJldHVybiBzdGF0ZTsNCsKgfQ0KwqANCi0twqANCjIuMTEuMA0K
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Boyer, Andrew
Reviewed-byRe: [PATCH 12/15] IB/rxe: Fix a MR reference leak in check_rkey()
Quoted 16 lines · Bart Van Assche
Avoid that calling
check_rkey()formem->state==RXE_MEM_STATE_FREEtriggers an MR reference leak.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_resp.c| 20 ++++++++++----------1 file changed, 10 insertions(+), 10 deletions(-)drivers/infiniband/sw/rxe/rxe_resp.c +0
-0
drivers/infiniband/sw/rxe/rxe_resp.c static enum resp_states check_length(struct rxe_qp · line 422
Quoted 6 lines
drivers/infiniband/sw/rxe/rxe_resp.c +1
-1@@ -418,7 +418,7 @@ static enum resp_states check_length(struct rxe_qp *qp, static enum resp_states check_rkey(struct rxe_qp *qp,struct rxe_pkt_info *pkt) { -struct rxe_mem *mem; +struct rxe_mem *mem =NULL ;
I like having this extra load for clarity, but the general sentiment around here seems to be that it should be avoided. There¹s no path I can see that touches mem before lookup_mem() sets it.
Otherwise
Quoted 64 lines
drivers/infiniband/sw/rxe/rxe_resp.c +0
-0u64 va;u32 rkey;u32 resid;drivers/infiniband/sw/rxe/rxe_resp.c +6
-6@@ -459,38 +459,38 @@ static enum resp_states check_rkey(struct rxe_qp *qp, mem =lookup_mem (qp->pd, access, rkey, lookup_remote);if (!mem) { state =RESPST_ERR_RKEY_VIOLATION ; - goto err1; + goto err; }if (unlikely (mem->state ==RXE_MEM_STATE_FREE )) { state =RESPST_ERR_RKEY_VIOLATION ; - goto err1; + goto err; }if (mem_check_range (mem, va, resid)) { state =RESPST_ERR_RKEY_VIOLATION ; - goto err2; + goto err; }if (pkt->mask &RXE_WRITE_MASK ) {if (resid > mtu) {if (pktlen != mtu ||bth_pad (pkt)) { state =RESPST_ERR_LENGTH ; - goto err2; + goto err; } resid = mtu; }else {if (pktlen != resid) { state =RESPST_ERR_LENGTH ; - goto err2; + goto err; }if ((bth_pad (pkt) != (0x3 & (-resid)))) {/* This case may not be exactly that * but nothing else fits. */ state =RESPST_ERR_LENGTH ; - goto err2; + goto err; } }}drivers/infiniband/sw/rxe/rxe_resp.c +3
-3@@ -500,9 +500,9 @@ static enum resp_states check_rkey(struct rxe_qp *qp, qp->resp.mr = mem;return RESPST_EXECUTE ; -err2: -rxe_drop_ref (mem); -err1: +err: +if (mem) +rxe_drop_ref (mem);return state; }Signature · 1 line
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 13/15 IB/rxe: Fix reference leaks in memory key invalidation code
In reply to a message not in the archiveU2lnbmVkLW9mZi1ieTogQmFydCBWYW4gQXNzY2hlIDxiYXJ0LnZhbmFzc2NoZUBzYW5kaXNrLmNv bT4NCkNjOiBNb25pIFNob3VhIDxtb25pc0BtZWxsYW5veC5jb20+DQpDYzogQW5kcmV3IEJveWVy IDxhbmRyZXcuYm95ZXJAZGVsbC5jb20+DQotLS0NCsKgZHJpdmVycy9pbmZpbmliYW5kL3N3Lw0K cnhlL3J4ZV9yZXEuY8KgwqB8IDEgKw0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9y ZXNwLmMgfCAxICsNCsKgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykNCg0KZGlmZiAt LWdpdCBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3JlcS5jIGIvZHJpdmVycy9pbmZp bmliYW5kL3N3L3J4ZS9yeGVfcmVxLmMNCmluZGV4IDY0OTk5ZjUyOTk4MS4uMWJiYTRhNzM0ZTcz IDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcmVxLmMNCisrKyBi L2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3JlcS5jDQpAQCAtNjM1LDYgKzYzNSw3IEBA IGludCByeGVfcmVxdWVzdGVyKHZvaWQgKmFyZykNCsKgCQkJCWdvdG8gZXhpdDsNCsKgCQkJfQ0K wqAJCQlybXItPnN0YXRlID0gUlhFX01FTV9TVEFURV9GUkVFOw0KKwkJCXJ4ZV9kcm9wX3JlZihy bXIpOw0KwqAJCQl3cWUtPnN0YXRlID0gd3FlX3N0YXRlX2RvbmU7DQrCoAkJCXdxZS0+c3RhdHVz ID0gSUJfV0NfU1VDQ0VTUzsNCsKgCQl9IGVsc2UgaWYgKHdxZS0+d3Iub3Bjb2RlID09IElCX1dS X1JFR19NUikgew0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jl c3AuYyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuYw0KaW5kZXggNjBkNzhm NDVhYTA0Li4wNWYzNzQ5ODZjZWEgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQvc3cv cnhlL3J4ZV9yZXNwLmMNCisrKyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3Au Yw0KQEAgLTkwNyw2ICs5MDcsNyBAQCBzdGF0aWMgZW51bSByZXNwX3N0YXRlcyBkb19jb21wbGV0 ZShzdHJ1Y3QgcnhlX3FwICpxcCwNCsKgCQkJCQlyZXR1cm4gUkVTUFNUX0VSUk9SOw0KwqAJCQkJ fQ0KwqAJCQkJcm1yLT5zdGF0ZSA9IFJYRV9NRU1fU1RBVEVfRlJFRTsNCisJCQkJcnhlX2Ryb3Bf cmVmKHJtcik7DQrCoAkJCX0NCsKgDQrCoAkJCXdjLT5xcAkJCT0gJnFwLT5pYnFwOw0KLS3CoA0K Mi4xMS4wDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Boyer, Andrew
Reviewed-byRe: [PATCH 13/15] IB/rxe: Fix reference leaks in memory key invalidation code
Quoted 8 lines · Bart Van Assche
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_req.c| 1 +drivers/infiniband/sw/rxe/rxe_resp.c| 1 +2 files changed, 2 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 14/15 IB/rxe: Remove a pointless indirection layer
In reply to a message not in the archiveTmVpdGhlciByeGUtPmlmY19vcHMgbm9yIGFueSBvZiB0aGUgZnVuY3Rpb24gcG9pbnRlcnMgaW4g c3RydWN0DQpzdHJ1Y3QgcnhlX2lmY19vcHMgZXZlciBjaGFuZ2UuIEhlbmNlIHJlbW92ZSB0aGUg cnhlLT5pZmNfb3BzDQppbmRpcmVjdGlvbiBtZWNoYW5pc20uDQoNClNpZ25lZC1vZmYtYnk6IEJh cnQgVmFuIEFzc2NoZSA8YmFydC52YW5hc3NjaGVAc2FuZGlzay5jb20+DQpDYzogTW9uaSBTaG91 YSA8bW9uaXNAbWVsbGFub3guY29tPg0KQ2M6IEFuZHJldyBCb3llciA8YW5kcmV3LmJveWVyQGRl bGwuY29tPg0KLS0tDQrCoGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlLmPCoMKgwqDCoMKg wqDCoHzCoMKgMiArLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9sb2MuaMKgwqDC oHwgMjAgKysrKysrKysrKysrKystLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9t Y2FzdC5jIHzCoMKgNCArKy0tDQrCoGRyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX25ldC5j wqDCoMKgfCA0MyArKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KwqBkcml2ZXJz L2luZmluaWJhbmQvc3cvcnhlL3J4ZV9yZXEuY8KgwqDCoHzCoMKgNCArKy0tDQrCoGRyaXZlcnMv aW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuY8KgwqB8wqDCoDQgKystLQ0KwqBkcml2ZXJzL2lu ZmluaWJhbmQvc3cvcnhlL3J4ZV92ZXJicy5jIHwgMTAgKysrKy0tLS0NCsKgZHJpdmVycy9pbmZp bmliYW5kL3N3L3J4ZS9yeGVfdmVyYnMuaCB8IDIyIC0tLS0tLS0tLS0tLS0tLS0tLQ0KwqA4IGZp bGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDY3IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0t Z2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGUuYyBiL2RyaXZlcnMvaW5maW5pYmFu ZC9zdy9yeGUvcnhlLmMNCmluZGV4IGFiNmMzYzI1ZDdmZi4uYjEyZGQ5YjVhODlkIDEwMDY0NA0K LS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGUuYw0KKysrIGIvZHJpdmVycy9pbmZp bmliYW5kL3N3L3J4ZS9yeGUuYw0KQEAgLTE3OCw3ICsxNzgsNyBAQCBzdGF0aWMgaW50IHJ4ZV9p bml0X3BvcnRzKHN0cnVjdCByeGVfZGV2ICpyeGUpDQrCoAkJcmV0dXJuIC1FTk9NRU07DQrCoA0K wqAJcG9ydC0+cGtleV90YmxbMF0gPSAweGZmZmY7DQotCXBvcnQtPnBvcnRfZ3VpZCA9IHJ4ZS0+ aWZjX29wcy0+cG9ydF9ndWlkKHJ4ZSk7DQorCXBvcnQtPnBvcnRfZ3VpZCA9IHJ4ZV9wb3J0X2d1 aWQocnhlKTsNCsKgDQrCoAlzcGluX2xvY2tfaW5pdCgmcG9ydC0+cG9ydF9sb2NrKTsNCsKgDQpk aWZmIC0tZ2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbG9jLmggYi9kcml2ZXJz L2luZmluaWJhbmQvc3cvcnhlL3J4ZV9sb2MuaA0KaW5kZXggYmRlYzQ2MGYxZmNlLi4yNzIzMzdl NWU5NDggMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9sb2MuaA0K KysrIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbG9jLmgNCkBAIC0xNDEsNiArMTQx LDIyIEBAIHZvaWQgcnhlX21lbV9jbGVhbnVwKHN0cnVjdCByeGVfcG9vbF9lbnRyeSAqYXJnKTsN CsKgDQrCoGludCBhZHZhbmNlX2RtYV9kYXRhKHN0cnVjdCByeGVfZG1hX2luZm8gKmRtYSwgdW5z aWduZWQgaW50IGxlbmd0aCk7DQrCoA0KKy8qIHJ4ZV9uZXQuYyAqLw0KK2ludCByeGVfbG9vcGJh Y2soc3RydWN0IHNrX2J1ZmYgKnNrYik7DQoraW50IHJ4ZV9zZW5kKHN0cnVjdCByeGVfZGV2ICpy eGUsIHN0cnVjdCByeGVfcGt0X2luZm8gKnBrdCwNCisJwqDCoMKgwqDCoHN0cnVjdCBza19idWZm ICpza2IpOw0KK19fYmU2NCByeGVfcG9ydF9ndWlkKHN0cnVjdCByeGVfZGV2ICpyeGUpOw0KK3N0 cnVjdCBza19idWZmICpyeGVfaW5pdF9wYWNrZXQoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSwgc3RydWN0 IHJ4ZV9hdiAqYXYsDQorCQkJCWludCBwYXlsZW4sIHN0cnVjdCByeGVfcGt0X2luZm8gKnBrdCk7 DQoraW50IHJ4ZV9wcmVwYXJlKHN0cnVjdCByeGVfZGV2ICpyeGUsIHN0cnVjdCByeGVfcGt0X2lu Zm8gKnBrdCwNCisJCXN0cnVjdCBza19idWZmICpza2IsIHUzMiAqY3JjKTsNCitlbnVtIHJkbWFf bGlua19sYXllciByeGVfbGlua19sYXllcihzdHJ1Y3QgcnhlX2RldiAqcnhlLCB1bnNpZ25lZCBp bnQgcG9ydF9udW0pOw0KK2NvbnN0IGNoYXIgKnJ4ZV9wYXJlbnRfbmFtZShzdHJ1Y3QgcnhlX2Rl diAqcnhlLCB1bnNpZ25lZCBpbnQgcG9ydF9udW0pOw0KK3N0cnVjdCBkZXZpY2UgKnJ4ZV9kbWFf ZGV2aWNlKHN0cnVjdCByeGVfZGV2ICpyeGUpOw0KK19fYmU2NCByeGVfbm9kZV9ndWlkKHN0cnVj dCByeGVfZGV2ICpyeGUpOw0KK2ludCByeGVfbWNhc3RfYWRkKHN0cnVjdCByeGVfZGV2ICpyeGUs IHVuaW9uIGliX2dpZCAqbWdpZCk7DQoraW50IHJ4ZV9tY2FzdF9kZWxldGUoc3RydWN0IHJ4ZV9k ZXYgKnJ4ZSwgdW5pb24gaWJfZ2lkICptZ2lkKTsNCisNCsKgLyogcnhlX3FwLmMgKi8NCsKgaW50 IHJ4ZV9xcF9jaGtfaW5pdChzdHJ1Y3QgcnhlX2RldiAqcnhlLCBzdHJ1Y3QgaWJfcXBfaW5pdF9h dHRyICppbml0KTsNCsKgDQpAQCAtMjU3LDkgKzI3Myw5IEBAIHN0YXRpYyBpbmxpbmUgaW50IHJ4 ZV94bWl0X3BhY2tldChzdHJ1Y3QgcnhlX2RldiAqcnhlLCBzdHJ1Y3QgcnhlX3FwICpxcCwNCsKg DQrCoAlpZiAocGt0LT5tYXNrICYgUlhFX0xPT1BCQUNLX01BU0spIHsNCsKgCQltZW1jcHkoU0tC X1RPX1BLVChza2IpLCBwa3QsIHNpemVvZigqcGt0KSk7DQotCQllcnIgPSByeGUtPmlmY19vcHMt Pmxvb3BiYWNrKHNrYik7DQorCQllcnIgPSByeGVfbG9vcGJhY2soc2tiKTsNCsKgCX0gZWxzZSB7 DQotCQllcnIgPSByeGUtPmlmY19vcHMtPnNlbmQocnhlLCBwa3QsIHNrYik7DQorCQllcnIgPSBy eGVfc2VuZChyeGUsIHBrdCwgc2tiKTsNCsKgCX0NCsKgDQrCoAlpZiAoZXJyKSB7DQpkaWZmIC0t Z2l0IGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbWNhc3QuYyBiL2RyaXZlcnMvaW5m aW5pYmFuZC9zdy9yeGUvcnhlX21jYXN0LmMNCmluZGV4IGUwZmI2NzUyZjkwZS4uNTIyYTc5NDJj NTZjIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbWNhc3QuYw0K KysrIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfbWNhc3QuYw0KQEAgLTYxLDcgKzYx LDcgQEAgaW50IHJ4ZV9tY2FzdF9nZXRfZ3JwKHN0cnVjdCByeGVfZGV2ICpyeGUsIHVuaW9uIGli X2dpZCAqbWdpZCwNCsKgDQrCoAlyeGVfYWRkX2tleShncnAsIG1naWQpOw0KwqANCi0JZXJyID0g cnhlLT5pZmNfb3BzLT5tY2FzdF9hZGQocnhlLCBtZ2lkKTsNCisJZXJyID0gcnhlX21jYXN0X2Fk ZChyeGUsIG1naWQpOw0KwqAJaWYgKGVycikNCsKgCQlnb3RvIGVycjI7DQrCoA0KQEAgLTE4Niw1 ICsxODYsNSBAQCB2b2lkIHJ4ZV9tY19jbGVhbnVwKHN0cnVjdCByeGVfcG9vbF9lbnRyeSAqYXJn KQ0KwqAJc3RydWN0IHJ4ZV9kZXYgKnJ4ZSA9IGdycC0+cnhlOw0KwqANCsKgCXJ4ZV9kcm9wX2tl eShncnApOw0KLQlyeGUtPmlmY19vcHMtPm1jYXN0X2RlbGV0ZShyeGUsICZncnAtPm1naWQpOw0K KwlyeGVfbWNhc3RfZGVsZXRlKHJ4ZSwgJmdycC0+bWdpZCk7DQrCoH0NCmRpZmYgLS1naXQgYS9k cml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9uZXQuYyBiL2RyaXZlcnMvaW5maW5pYmFuZC9z dy9yeGUvcnhlX25ldC5jDQppbmRleCAxNTFmNjM5YWJlYmYuLjUwMTQ0YzMwN2ViNCAxMDA2NDQN Ci0tLSBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX25ldC5jDQorKysgYi9kcml2ZXJz L2luZmluaWJhbmQvc3cvcnhlL3J4ZV9uZXQuYw0KQEAgLTEwMiwxNyArMTAyLDE3IEBAIHN0YXRp YyBfX2JlNjQgcnhlX21hY190b19ldWk2NChzdHJ1Y3QgbmV0X2RldmljZSAqbmRldikNCsKgCXJl dHVybiBldWk2NDsNCsKgfQ0KwqANCi1zdGF0aWMgX19iZTY0IG5vZGVfZ3VpZChzdHJ1Y3Qgcnhl X2RldiAqcnhlKQ0KK19fYmU2NCByeGVfbm9kZV9ndWlkKHN0cnVjdCByeGVfZGV2ICpyeGUpDQrC oHsNCsKgCXJldHVybiByeGVfbWFjX3RvX2V1aTY0KHJ4ZS0+bmRldik7DQrCoH0NCsKgDQotc3Rh dGljIF9fYmU2NCBwb3J0X2d1aWQoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSkNCitfX2JlNjQgcnhlX3Bv cnRfZ3VpZChzdHJ1Y3QgcnhlX2RldiAqcnhlKQ0KwqB7DQrCoAlyZXR1cm4gcnhlX21hY190b19l dWk2NChyeGUtPm5kZXYpOw0KwqB9DQrCoA0KLXN0YXRpYyBzdHJ1Y3QgZGV2aWNlICpkbWFfZGV2 aWNlKHN0cnVjdCByeGVfZGV2ICpyeGUpDQorc3RydWN0IGRldmljZSAqcnhlX2RtYV9kZXZpY2Uo c3RydWN0IHJ4ZV9kZXYgKnJ4ZSkNCsKgew0KwqAJc3RydWN0IG5ldF9kZXZpY2UgKm5kZXY7DQrC oA0KQEAgLTEyNCw3ICsxMjQsNyBAQCBzdGF0aWMgc3RydWN0IGRldmljZSAqZG1hX2RldmljZShz dHJ1Y3QgcnhlX2RldiAqcnhlKQ0KwqAJcmV0dXJuIG5kZXYtPmRldi5wYXJlbnQ7DQrCoH0NCsKg DQotc3RhdGljIGludCBtY2FzdF9hZGQoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSwgdW5pb24gaWJfZ2lk ICptZ2lkKQ0KK2ludCByeGVfbWNhc3RfYWRkKHN0cnVjdCByeGVfZGV2ICpyeGUsIHVuaW9uIGli X2dpZCAqbWdpZCkNCsKgew0KwqAJaW50IGVycjsNCsKgCXVuc2lnbmVkIGNoYXIgbGxfYWRkcltF VEhfQUxFTl07DQpAQCAtMTM1LDcgKzEzNSw3IEBAIHN0YXRpYyBpbnQgbWNhc3RfYWRkKHN0cnVj dCByeGVfZGV2ICpyeGUsIHVuaW9uIGliX2dpZCAqbWdpZCkNCsKgCXJldHVybiBlcnI7DQrCoH0N CsKgDQotc3RhdGljIGludCBtY2FzdF9kZWxldGUoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSwgdW5pb24g aWJfZ2lkICptZ2lkKQ0KK2ludCByeGVfbWNhc3RfZGVsZXRlKHN0cnVjdCByeGVfZGV2ICpyeGUs IHVuaW9uIGliX2dpZCAqbWdpZCkNCsKgew0KwqAJaW50IGVycjsNCsKgCXVuc2lnbmVkIGNoYXIg bGxfYWRkcltFVEhfQUxFTl07DQpAQCAtMzk3LDggKzM5Nyw4IEBAIHN0YXRpYyBpbnQgcHJlcGFy ZTYoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSwgc3RydWN0IHJ4ZV9wa3RfaW5mbyAqcGt0LA0KwqAJcmV0 dXJuIDA7DQrCoH0NCsKgDQotc3RhdGljIGludCBwcmVwYXJlKHN0cnVjdCByeGVfZGV2ICpyeGUs IHN0cnVjdCByeGVfcGt0X2luZm8gKnBrdCwNCi0JCcKgwqDCoHN0cnVjdCBza19idWZmICpza2Is IHUzMiAqY3JjKQ0KK2ludCByeGVfcHJlcGFyZShzdHJ1Y3QgcnhlX2RldiAqcnhlLCBzdHJ1Y3Qg cnhlX3BrdF9pbmZvICpwa3QsDQorCQlzdHJ1Y3Qgc2tfYnVmZiAqc2tiLCB1MzIgKmNyYykNCsKg ew0KwqAJaW50IGVyciA9IDA7DQrCoAlzdHJ1Y3QgcnhlX2F2ICphdiA9IHJ4ZV9nZXRfYXYocGt0 KTsNCkBAIC00MjQsOCArNDI0LDcgQEAgc3RhdGljIHZvaWQgcnhlX3NrYl90eF9kdG9yKHN0cnVj dCBza19idWZmICpza2IpDQrCoAkJcnhlX3J1bl90YXNrKCZxcC0+cmVxLnRhc2ssIDEpOw0KwqB9 DQrCoA0KLXN0YXRpYyBpbnQgc2VuZChzdHJ1Y3QgcnhlX2RldiAqcnhlLCBzdHJ1Y3QgcnhlX3Br dF9pbmZvICpwa3QsDQotCQlzdHJ1Y3Qgc2tfYnVmZiAqc2tiKQ0KK2ludCByeGVfc2VuZChzdHJ1 Y3QgcnhlX2RldiAqcnhlLCBzdHJ1Y3QgcnhlX3BrdF9pbmZvICpwa3QsIHN0cnVjdCBza19idWZm ICpza2IpDQrCoHsNCsKgCXN0cnVjdCBza19idWZmICpuc2tiOw0KwqAJc3RydWN0IHJ4ZV9hdiAq YXY7DQpAQCAtNDYxLDcgKzQ2MCw3IEBAIHN0YXRpYyBpbnQgc2VuZChzdHJ1Y3QgcnhlX2RldiAq cnhlLCBzdHJ1Y3QgcnhlX3BrdF9pbmZvICpwa3QsDQrCoAlyZXR1cm4gMDsNCsKgfQ0KwqANCi1z dGF0aWMgaW50IGxvb3BiYWNrKHN0cnVjdCBza19idWZmICpza2IpDQoraW50IHJ4ZV9sb29wYmFj ayhzdHJ1Y3Qgc2tfYnVmZiAqc2tiKQ0KwqB7DQrCoAlyZXR1cm4gcnhlX3Jjdihza2IpOw0KwqB9 DQpAQCAtNDcxLDggKzQ3MCw4IEBAIHN0YXRpYyBpbmxpbmUgaW50IGFkZHJfc2FtZShzdHJ1Y3Qg cnhlX2RldiAqcnhlLCBzdHJ1Y3QgcnhlX2F2ICphdikNCsKgCXJldHVybiByeGUtPnBvcnQucG9y dF9ndWlkID09IGF2LT5ncmguZGdpZC5nbG9iYWwuaW50ZXJmYWNlX2lkOw0KwqB9DQrCoA0KLXN0 YXRpYyBzdHJ1Y3Qgc2tfYnVmZiAqaW5pdF9wYWNrZXQoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSwgc3Ry dWN0IHJ4ZV9hdiAqYXYsDQotCQkJCcKgwqDCoGludCBwYXlsZW4sIHN0cnVjdCByeGVfcGt0X2lu Zm8gKnBrdCkNCitzdHJ1Y3Qgc2tfYnVmZiAqcnhlX2luaXRfcGFja2V0KHN0cnVjdCByeGVfZGV2 ICpyeGUsIHN0cnVjdCByeGVfYXYgKmF2LA0KKwkJCQlpbnQgcGF5bGVuLCBzdHJ1Y3QgcnhlX3Br dF9pbmZvICpwa3QpDQrCoHsNCsKgCXVuc2lnbmVkIGludCBoZHJfbGVuOw0KwqAJc3RydWN0IHNr X2J1ZmYgKnNrYjsNCkBAIC01MTEsMzEgKzUxMCwxNiBAQCBzdGF0aWMgc3RydWN0IHNrX2J1ZmYg KmluaXRfcGFja2V0KHN0cnVjdCByeGVfZGV2ICpyeGUsIHN0cnVjdCByeGVfYXYgKmF2LA0KwqAg KiB0aGlzIGlzIHJlcXVpcmVkIGJ5IHJ4ZV9jZmcgdG8gbWF0Y2ggcnhlIGRldmljZXMgaW4NCsKg ICogL3N5cy9jbGFzcy9pbmZpbmliYW5kIHVwIHdpdGggdGhlaXIgdW5kZXJseWluZyBldGhlcm5l dCBkZXZpY2VzDQrCoCAqLw0KLXN0YXRpYyBjaGFyICpwYXJlbnRfbmFtZShzdHJ1Y3QgcnhlX2Rl diAqcnhlLCB1bnNpZ25lZCBpbnQgcG9ydF9udW0pDQorY29uc3QgY2hhciAqcnhlX3BhcmVudF9u YW1lKHN0cnVjdCByeGVfZGV2ICpyeGUsIHVuc2lnbmVkIGludCBwb3J0X251bSkNCsKgew0KwqAJ cmV0dXJuIHJ4ZS0+bmRldi0+bmFtZTsNCsKgfQ0KwqANCi1zdGF0aWMgZW51bSByZG1hX2xpbmtf bGF5ZXIgbGlua19sYXllcihzdHJ1Y3QgcnhlX2RldiAqcnhlLA0KLQkJCQnCoMKgwqDCoMKgwqDC oHVuc2lnbmVkIGludCBwb3J0X251bSkNCitlbnVtIHJkbWFfbGlua19sYXllciByeGVfbGlua19s YXllcihzdHJ1Y3QgcnhlX2RldiAqcnhlLCB1bnNpZ25lZCBpbnQgcG9ydF9udW0pDQrCoHsNCsKg CXJldHVybiBJQl9MSU5LX0xBWUVSX0VUSEVSTkVUOw0KwqB9DQrCoA0KLXN0YXRpYyBzdHJ1Y3Qg cnhlX2lmY19vcHMgaWZjX29wcyA9IHsNCi0JLm5vZGVfZ3VpZAk9IG5vZGVfZ3VpZCwNCi0JLnBv cnRfZ3VpZAk9IHBvcnRfZ3VpZCwNCi0JLmRtYV9kZXZpY2UJPSBkbWFfZGV2aWNlLA0KLQkubWNh c3RfYWRkCT0gbWNhc3RfYWRkLA0KLQkubWNhc3RfZGVsZXRlCT0gbWNhc3RfZGVsZXRlLA0KLQku cHJlcGFyZQk9IHByZXBhcmUsDQotCS5zZW5kCQk9IHNlbmQsDQotCS5sb29wYmFjawk9IGxvb3Bi YWNrLA0KLQkuaW5pdF9wYWNrZXQJPSBpbml0X3BhY2tldCwNCi0JLnBhcmVudF9uYW1lCT0gcGFy ZW50X25hbWUsDQotCS5saW5rX2xheWVyCT0gbGlua19sYXllciwNCi19Ow0KLQ0KwqBzdHJ1Y3Qg cnhlX2RldiAqcnhlX25ldF9hZGQoc3RydWN0IG5ldF9kZXZpY2UgKm5kZXYpDQrCoHsNCsKgCWlu dCBlcnI7DQpAQCAtNTQ1LDcgKzUyOSw2IEBAIHN0cnVjdCByeGVfZGV2ICpyeGVfbmV0X2FkZChz dHJ1Y3QgbmV0X2RldmljZSAqbmRldikNCsKgCWlmICghcnhlKQ0KwqAJCXJldHVybiBOVUxMOw0K wqANCi0JcnhlLT5pZmNfb3BzID0gJmlmY19vcHM7DQrCoAlyeGUtPm5kZXYgPSBuZGV2Ow0KwqAN CsKgCWVyciA9IHJ4ZV9hZGQocnhlLCBuZGV2LT5tdHUpOw0KZGlmZiAtLWdpdCBhL2RyaXZlcnMv aW5maW5pYmFuZC9zdy9yeGUvcnhlX3JlcS5jIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9y eGVfcmVxLmMNCmluZGV4IDFiYmE0YTczNGU3My4uNTIyYTRlNGEyMWNlIDEwMDY0NA0KLS0tIGEv ZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcmVxLmMNCisrKyBiL2RyaXZlcnMvaW5maW5p YmFuZC9zdy9yeGUvcnhlX3JlcS5jDQpAQCAtNDA0LDcgKzQwNCw3IEBAIHN0YXRpYyBzdHJ1Y3Qg c2tfYnVmZiAqaW5pdF9yZXFfcGFja2V0KHN0cnVjdCByeGVfcXAgKnFwLA0KwqANCsKgCS8qIGlu aXQgc2tiICovDQrCoAlhdiA9IHJ4ZV9nZXRfYXYocGt0KTsNCi0Jc2tiID0gcnhlLT5pZmNfb3Bz LT5pbml0X3BhY2tldChyeGUsIGF2LCBwYXlsZW4sIHBrdCk7DQorCXNrYiA9IHJ4ZV9pbml0X3Bh Y2tldChyeGUsIGF2LCBwYXlsZW4sIHBrdCk7DQrCoAlpZiAodW5saWtlbHkoIXNrYikpDQrCoAkJ cmV0dXJuIE5VTEw7DQrCoA0KQEAgLTQ3NSw3ICs0NzUsNyBAQCBzdGF0aWMgaW50IGZpbGxfcGFj a2V0KHN0cnVjdCByeGVfcXAgKnFwLCBzdHJ1Y3QgcnhlX3NlbmRfd3FlICp3cWUsDQrCoAl1MzIg KnA7DQrCoAlpbnQgZXJyOw0KwqANCi0JZXJyID0gcnhlLT5pZmNfb3BzLT5wcmVwYXJlKHJ4ZSwg cGt0LCBza2IsICZjcmMpOw0KKwllcnIgPSByeGVfcHJlcGFyZShyeGUsIHBrdCwgc2tiLCAmY3Jj KTsNCsKgCWlmIChlcnIpDQrCoAkJcmV0dXJuIGVycjsNCsKgDQpkaWZmIC0tZ2l0IGEvZHJpdmVy cy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfcmVzcC5jIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4 ZS9yeGVfcmVzcC5jDQppbmRleCAwNWYzNzQ5ODZjZWEuLjdiZjIwY2VkMjA3OCAxMDA2NDQNCi0t LSBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3Jlc3AuYw0KKysrIGIvZHJpdmVycy9p bmZpbmliYW5kL3N3L3J4ZS9yeGVfcmVzcC5jDQpAQCAtNjA4LDcgKzYwOCw3IEBAIHN0YXRpYyBz dHJ1Y3Qgc2tfYnVmZiAqcHJlcGFyZV9hY2tfcGFja2V0KHN0cnVjdCByeGVfcXAgKnFwLA0KwqAJ cGFkID0gKC1wYXlsb2FkKSAmIDB4MzsNCsKgCXBheWxlbiA9IHJ4ZV9vcGNvZGVbb3Bjb2RlXS5s ZW5ndGggKyBwYXlsb2FkICsgcGFkICsgUlhFX0lDUkNfU0laRTsNCsKgDQotCXNrYiA9IHJ4ZS0+ aWZjX29wcy0+aW5pdF9wYWNrZXQocnhlLCAmcXAtPnByaV9hdiwgcGF5bGVuLCBhY2spOw0KKwlz a2IgPSByeGVfaW5pdF9wYWNrZXQocnhlLCAmcXAtPnByaV9hdiwgcGF5bGVuLCBhY2spOw0KwqAJ aWYgKCFza2IpDQrCoAkJcmV0dXJuIE5VTEw7DQrCoA0KQEAgLTYzNyw3ICs2MzcsNyBAQCBzdGF0 aWMgc3RydWN0IHNrX2J1ZmYgKnByZXBhcmVfYWNrX3BhY2tldChzdHJ1Y3QgcnhlX3FwICpxcCwN CsKgCWlmIChhY2stPm1hc2sgJiBSWEVfQVRNQUNLX01BU0spDQrCoAkJYXRtYWNrX3NldF9vcmln KGFjaywgcXAtPnJlc3AuYXRvbWljX29yaWcpOw0KwqANCi0JZXJyID0gcnhlLT5pZmNfb3BzLT5w cmVwYXJlKHJ4ZSwgYWNrLCBza2IsICZjcmMpOw0KKwllcnIgPSByeGVfcHJlcGFyZShyeGUsIGFj aywgc2tiLCAmY3JjKTsNCsKgCWlmIChlcnIpIHsNCsKgCQlrZnJlZV9za2Ioc2tiKTsNCsKgCQly ZXR1cm4gTlVMTDsNCmRpZmYgLS1naXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV92 ZXJicy5jIGIvZHJpdmVycy9pbmZpbmliYW5kL3N3L3J4ZS9yeGVfdmVyYnMuYw0KaW5kZXggYmVi NzAyMWZmMThhLi5lNGRlMzdmYjlhYWIgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQv c3cvcnhlL3J4ZV92ZXJicy5jDQorKysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV92 ZXJicy5jDQpAQCAtMjM0LDcgKzIzNCw3IEBAIHN0YXRpYyBlbnVtIHJkbWFfbGlua19sYXllciBy eGVfZ2V0X2xpbmtfbGF5ZXIoc3RydWN0IGliX2RldmljZSAqZGV2LA0KwqB7DQrCoAlzdHJ1Y3Qg cnhlX2RldiAqcnhlID0gdG9fcmRldihkZXYpOw0KwqANCi0JcmV0dXJuIHJ4ZS0+aWZjX29wcy0+ bGlua19sYXllcihyeGUsIHBvcnRfbnVtKTsNCisJcmV0dXJuIHJ4ZV9saW5rX2xheWVyKHJ4ZSwg cG9ydF9udW0pOw0KwqB9DQrCoA0KwqBzdGF0aWMgc3RydWN0IGliX3Vjb250ZXh0ICpyeGVfYWxs b2NfdWNvbnRleHQoc3RydWN0IGliX2RldmljZSAqZGV2LA0KQEAgLTEyMDksMTAgKzEyMDksOCBA QCBzdGF0aWMgc3NpemVfdCByeGVfc2hvd19wYXJlbnQoc3RydWN0IGRldmljZSAqZGV2aWNlLA0K wqB7DQrCoAlzdHJ1Y3QgcnhlX2RldiAqcnhlID0gY29udGFpbmVyX29mKGRldmljZSwgc3RydWN0 IHJ4ZV9kZXYsDQrCoAkJCQkJwqDCoMKgaWJfZGV2LmRldik7DQotCWNoYXIgKm5hbWU7DQrCoA0K LQluYW1lID0gcnhlLT5pZmNfb3BzLT5wYXJlbnRfbmFtZShyeGUsIDEpOw0KLQlyZXR1cm4gc25w cmludGYoYnVmLCAxNiwgIiVzXG4iLCBuYW1lKTsNCisJcmV0dXJuIHNucHJpbnRmKGJ1ZiwgMTYs ICIlc1xuIiwgcnhlX3BhcmVudF9uYW1lKHJ4ZSwgMSkpOw0KwqB9DQrCoA0KwqBzdGF0aWMgREVW SUNFX0FUVFIocGFyZW50LCBTX0lSVUdPLCByeGVfc2hvd19wYXJlbnQsIE5VTEwpOw0KQEAgLTEy MzQsOSArMTIzMiw5IEBAIGludCByeGVfcmVnaXN0ZXJfZGV2aWNlKHN0cnVjdCByeGVfZGV2ICpy eGUpDQrCoAlkZXYtPm5vZGVfdHlwZSA9IFJETUFfTk9ERV9JQl9DQTsNCsKgCWRldi0+cGh5c19w b3J0X2NudCA9IDE7DQrCoAlkZXYtPm51bV9jb21wX3ZlY3RvcnMgPSBSWEVfTlVNX0NPTVBfVkVD VE9SUzsNCi0JZGV2LT5kbWFfZGV2aWNlID0gcnhlLT5pZmNfb3BzLT5kbWFfZGV2aWNlKHJ4ZSk7 DQorCWRldi0+ZG1hX2RldmljZSA9IHJ4ZV9kbWFfZGV2aWNlKHJ4ZSk7DQrCoAlkZXYtPmxvY2Fs X2RtYV9sa2V5ID0gMDsNCi0JZGV2LT5ub2RlX2d1aWQgPSByeGUtPmlmY19vcHMtPm5vZGVfZ3Vp ZChyeGUpOw0KKwlkZXYtPm5vZGVfZ3VpZCA9IHJ4ZV9ub2RlX2d1aWQocnhlKTsNCsKgCWRldi0+ ZG1hX29wcyA9ICZyeGVfZG1hX21hcHBpbmdfb3BzOw0KwqANCsKgCWRldi0+dXZlcmJzX2FiaV92 ZXIgPSBSWEVfVVZFUkJTX0FCSV9WRVJTSU9OOw0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5maW5p YmFuZC9zdy9yeGUvcnhlX3ZlcmJzLmggYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV92 ZXJicy5oDQppbmRleCA1MzY5NzRiNjllZDkuLmUxMDBjNTAwYWU4NSAxMDA2NDQNCi0tLSBhL2Ry aXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX3ZlcmJzLmgNCisrKyBiL2RyaXZlcnMvaW5maW5p YmFuZC9zdy9yeGUvcnhlX3ZlcmJzLmgNCkBAIC0zNzIsMjYgKzM3Miw2IEBAIHN0cnVjdCByeGVf cG9ydCB7DQrCoAl1MzIJCQlxcF9nc2lfaW5kZXg7DQrCoH07DQrCoA0KLS8qIGNhbGxiYWNrcyBm cm9tIHJkbWFfcnhlIHRvIG5ldHdvcmsgaW50ZXJmYWNlIGxheWVyICovDQotc3RydWN0IHJ4ZV9p ZmNfb3BzIHsNCi0Jdm9pZCAoKnJlbGVhc2UpKHN0cnVjdCByeGVfZGV2ICpyeGUpOw0KLQlfX2Jl NjQgKCpub2RlX2d1aWQpKHN0cnVjdCByeGVfZGV2ICpyeGUpOw0KLQlfX2JlNjQgKCpwb3J0X2d1 aWQpKHN0cnVjdCByeGVfZGV2ICpyeGUpOw0KLQlzdHJ1Y3QgZGV2aWNlICooKmRtYV9kZXZpY2Up KHN0cnVjdCByeGVfZGV2ICpyeGUpOw0KLQlpbnQgKCptY2FzdF9hZGQpKHN0cnVjdCByeGVfZGV2 ICpyeGUsIHVuaW9uIGliX2dpZCAqbWdpZCk7DQotCWludCAoKm1jYXN0X2RlbGV0ZSkoc3RydWN0 IHJ4ZV9kZXYgKnJ4ZSwgdW5pb24gaWJfZ2lkICptZ2lkKTsNCi0JaW50ICgqcHJlcGFyZSkoc3Ry dWN0IHJ4ZV9kZXYgKnJ4ZSwgc3RydWN0IHJ4ZV9wa3RfaW5mbyAqcGt0LA0KLQkJwqDCoMKgwqDC oMKgwqBzdHJ1Y3Qgc2tfYnVmZiAqc2tiLCB1MzIgKmNyYyk7DQotCWludCAoKnNlbmQpKHN0cnVj dCByeGVfZGV2ICpyeGUsIHN0cnVjdCByeGVfcGt0X2luZm8gKnBrdCwNCi0JCcKgwqDCoMKgc3Ry dWN0IHNrX2J1ZmYgKnNrYik7DQotCWludCAoKmxvb3BiYWNrKShzdHJ1Y3Qgc2tfYnVmZiAqc2ti KTsNCi0Jc3RydWN0IHNrX2J1ZmYgKigqaW5pdF9wYWNrZXQpKHN0cnVjdCByeGVfZGV2ICpyeGUs IHN0cnVjdCByeGVfYXYgKmF2LA0KLQkJCQnCoMKgwqDCoMKgwqDCoGludCBwYXlsZW4sIHN0cnVj dCByeGVfcGt0X2luZm8gKnBrdCk7DQotCWNoYXIgKigqcGFyZW50X25hbWUpKHN0cnVjdCByeGVf ZGV2ICpyeGUsIHVuc2lnbmVkIGludCBwb3J0X251bSk7DQotCWVudW0gcmRtYV9saW5rX2xheWVy ICgqbGlua19sYXllcikoc3RydWN0IHJ4ZV9kZXYgKnJ4ZSwNCi0JCQkJCcKgwqDCoHVuc2lnbmVk IGludCBwb3J0X251bSk7DQotfTsNCi0NCsKgc3RydWN0IHJ4ZV9kZXYgew0KwqAJc3RydWN0IGli X2RldmljZQlpYl9kZXY7DQrCoAlzdHJ1Y3QgaWJfZGV2aWNlX2F0dHIJYXR0cjsNCkBAIC00MDAs OCArMzgwLDYgQEAgc3RydWN0IHJ4ZV9kZXYgew0KwqAJc3RydWN0IGtyZWYJCXJlZl9jbnQ7DQrC oAlzdHJ1Y3QgbXV0ZXgJdXNkZXZfbG9jazsNCsKgDQotCXN0cnVjdCByeGVfaWZjX29wcwkqaWZj X29wczsNCi0NCsKgCXN0cnVjdCBuZXRfZGV2aWNlCSpuZGV2Ow0KwqANCsKgCWludAkJCXhtaXRf ZXJyb3JzOw0KLS3CoA0KMi4xMS4wDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 14/15] IB/rxe: Remove a pointless indirection layer
Quoted 16 lines · Bart Van Assche
Neither
rxe->ifc_opsnor any of the function pointers in struct structrxe_ifc_opsever change. Hence remove therxe->ifc_opsindirection mechanism.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe.c | 2 +- drivers/infiniband/sw/rxe/rxe_loc.h | 20 ++++++++++++++--drivers/infiniband/sw/rxe/rxe_mcast.c| 4 ++-- drivers/infiniband/sw/rxe/rxe_net.c | 43 +++++++++++------------------------ drivers/infiniband/sw/rxe/rxe_req.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_resp.c | 4 ++--drivers/infiniband/sw/rxe/rxe_verbs.c| 10 ++++----drivers/infiniband/sw/rxe/rxe_verbs.h| 22 ------------------
Quoted 2 lines
8 files changed, 42 insertions(+), 67 deletions(-)
Thanks,
Boyer, Andrew
Reviewed-byRe: [PATCH 14/15] IB/rxe: Remove a pointless indirection layer
In reply to a message not in the archiveQuoted 8 lines · Bart Van Assche
Neither
rxe->ifc_opsnor any of the function pointers in struct structrxe_ifc_opsever change. Hence remove therxe->ifc_opsindirection mechanism.Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
Quoted 10 lines
drivers/infiniband/sw/rxe/rxe.c | 2 +- drivers/infiniband/sw/rxe/rxe_loc.h | 20 ++++++++++++++-- drivers/infiniband/sw/rxe/rxe_mcast.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_net.c | 43 +++++++++++------------------------ drivers/infiniband/sw/rxe/rxe_req.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_resp.c | 4 ++-- drivers/infiniband/sw/rxe/rxe_verbs.c | 10 ++++---- drivers/infiniband/sw/rxe/rxe_verbs.h | 22 ------------------ 8 files changed, 42 insertions(+), 67 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 15/15 IB/rxe: Fix an skb leak
In reply to a message not in the archiveQWRkaXRpb25hbGx5LCBtYWtlIGl0IGVhc2llciB0byBkZXRlY3Qgc2tiIGxlYWtzIGJ5IGlzc3Vp bmcgYSB3YXJuaW5nDQppZiBhIGxlYWsgb2NjdXJzLg0KDQpTaWduZWQtb2ZmLWJ5OiBCYXJ0IFZh biBBc3NjaGUgPGJhcnQudmFuYXNzY2hlQHNhbmRpc2suY29tPg0KQ2M6IE1vbmkgU2hvdWEgPG1v bmlzQG1lbGxhbm94LmNvbT4NCkNjOiBBbmRyZXcgQm95ZXIgPGFuZHJldy5ib3llckBkZWxsLmNv bT4NCi0tLQ0KwqBkcml2ZXJzL2luZmluaWJhbmQvc3cvcnhlL3J4ZV9jb21wLmMgfCAxNSArKysr KysrKysrKysrKy0NCsKgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkNCg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2NvbXAu YyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2NvbXAuYw0KaW5kZXggZDFjMzQxMWM1 NDc4Li5iYmM3Y2QzOWY5NzggMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvcnhl L3J4ZV9jb21wLmMNCisrKyBiL2RyaXZlcnMvaW5maW5pYmFuZC9zdy9yeGUvcnhlX2NvbXAuYw0K QEAgLTYyMiw2ICs2MjIsNyBAQCBpbnQgcnhlX2NvbXBsZXRlcih2b2lkICphcmcpDQrCoAkJCWlm IChwa3QpIHsNCsKgCQkJCXJ4ZV9kcm9wX3JlZihwa3QtPnFwKTsNCsKgCQkJCWtmcmVlX3NrYihz a2IpOw0KKwkJCQlza2IgPSBOVUxMOw0KwqAJCQl9DQrCoAkJCWdvdG8gZG9uZTsNCsKgDQpAQCAt NjQ1LDYgKzY0Niw3IEBAIGludCByeGVfY29tcGxldGVyKHZvaWQgKmFyZykNCsKgCQkJwqDCoMKg wqBxcC0+cXBfdGltZW91dF9qaWZmaWVzKQ0KwqAJCQkJbW9kX3RpbWVyKCZxcC0+cmV0cmFuc190 aW1lciwNCsKgCQkJCQnCoMKgamlmZmllcyArIHFwLT5xcF90aW1lb3V0X2ppZmZpZXMpOw0KKwkJ CVdBUk5fT05fT05DRShza2IpOw0KwqAJCQlnb3RvIGV4aXQ7DQrCoA0KwqAJCWNhc2UgQ09NUFNU X0VSUk9SX1JFVFJZOg0KQEAgLTY1Nyw4ICs2NTksMTAgQEAgaW50IHJ4ZV9jb21wbGV0ZXIodm9p ZCAqYXJnKQ0KwqAJCQnCoCovDQrCoA0KwqAJCQkvKiB0aGVyZSBpcyBub3RoaW5nIHRvIHJldHJ5 IGluIHRoaXMgY2FzZSAqLw0KLQkJCWlmICghd3FlIHx8ICh3cWUtPnN0YXRlID09IHdxZV9zdGF0 ZV9wb3N0ZWQpKQ0KKwkJCWlmICghd3FlIHx8ICh3cWUtPnN0YXRlID09IHdxZV9zdGF0ZV9wb3N0 ZWQpKSB7DQorCQkJCVdBUk5fT05fT05DRShza2IpOw0KwqAJCQkJZ290byBleGl0Ow0KKwkJCX0N CsKgDQrCoAkJCWlmIChxcC0+Y29tcC5yZXRyeV9jbnQgPiAwKSB7DQrCoAkJCQlpZiAocXAtPmNv bXAucmV0cnlfY250ICE9IDcpDQpAQCAtNjgwLDggKzY4NCwxMCBAQCBpbnQgcnhlX2NvbXBsZXRl cih2b2lkICphcmcpDQrCoAkJCQlpZiAocGt0KSB7DQrCoAkJCQkJcnhlX2Ryb3BfcmVmKHBrdC0+ cXApOw0KwqAJCQkJCWtmcmVlX3NrYihza2IpOw0KKwkJCQkJc2tiID0gTlVMTDsNCsKgCQkJCX0N CsKgDQorCQkJCVdBUk5fT05fT05DRShza2IpOw0KwqAJCQkJZ290byBleGl0Ow0KwqANCsKgCQkJ fSBlbHNlIHsNCkBAIC03MDEsNiArNzA3LDkgQEAgaW50IHJ4ZV9jb21wbGV0ZXIodm9pZCAqYXJn KQ0KwqAJCQkJbW9kX3RpbWVyKCZxcC0+cm5yX25ha190aW1lciwNCsKgCQkJCQnCoMKgamlmZmll cyArIHJucm5ha19qaWZmaWVzKGFldGhfc3luKHBrdCkNCsKgCQkJCQkJJiB+QUVUSF9UWVBFX01B U0spKTsNCisJCQkJcnhlX2Ryb3BfcmVmKHBrdC0+cXApOw0KKwkJCQlrZnJlZV9za2Ioc2tiKTsN CisJCQkJc2tiID0gTlVMTDsNCsKgCQkJCWdvdG8gZXhpdDsNCsKgCQkJfSBlbHNlIHsNCsKgCQkJ CXdxZS0+c3RhdHVzID0gSUJfV0NfUk5SX1JFVFJZX0VYQ19FUlI7DQpAQCAtNzE2LDggKzcyNSwx MCBAQCBpbnQgcnhlX2NvbXBsZXRlcih2b2lkICphcmcpDQrCoAkJCWlmIChwa3QpIHsNCsKgCQkJ CXJ4ZV9kcm9wX3JlZihwa3QtPnFwKTsNCsKgCQkJCWtmcmVlX3NrYihza2IpOw0KKwkJCQlza2Ig PSBOVUxMOw0KwqAJCQl9DQrCoA0KKwkJCVdBUk5fT05fT05DRShza2IpOw0KwqAJCQlnb3RvIGV4 aXQ7DQrCoAkJfQ0KwqAJfQ0KQEAgLTcyNiw2ICs3MzcsNyBAQCBpbnQgcnhlX2NvbXBsZXRlcih2 b2lkICphcmcpDQrCoAkvKiB3ZSBjb21lIGhlcmUgaWYgd2UgYXJlIGRvbmUgd2l0aCBwcm9jZXNz aW5nIGFuZCB3YW50IHRoZSB0YXNrIHRvDQrCoAnCoCogZXhpdCBmcm9tIHRoZSBsb29wIGNhbGxp bmcgdXMNCsKgCcKgKi8NCisJV0FSTl9PTl9PTkNFKHNrYik7DQrCoAlyeGVfZHJvcF9yZWYocXAp Ow0KwqAJcmV0dXJuIC1FQUdBSU47DQrCoA0KQEAgLTczMyw2ICs3NDUsNyBAQCBpbnQgcnhlX2Nv bXBsZXRlcih2b2lkICphcmcpDQrCoAkvKiB3ZSBjb21lIGhlcmUgaWYgd2UgaGF2ZSBwcm9jZXNz ZWQgYSBwYWNrZXQgd2Ugd2FudCB0aGUgdGFzayB0byBjYWxsDQrCoAnCoCogdXMgYWdhaW4gdG8g c2VlIGlmIHRoZXJlIGlzIGFueXRoaW5nIGVsc2UgdG8gZG8NCsKgCcKgKi8NCisJV0FSTl9PTl9P TkNFKHNrYik7DQrCoAlyeGVfZHJvcF9yZWYocXApOw0KwqAJcmV0dXJuIDA7DQrCoH0NCi0twqAN CjIuMTEuMA0K
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): [email protected]
Leon Romanovsky
Reviewed-byRe: [PATCH 15/15] IB/rxe: Fix an skb leak
Quoted 10 lines · Bart Van Assche
Additionally, make it easier to detect skb leaks by issuing a warning if a leak occurs.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_comp.c | 15 ++++++++++++++-1 file changed, 14 insertions(+), 1 deletion(-)
Thanks,
Re: [PATCH 15/15] IB/rxe: Fix an skb leak
In reply to a message not in the archiveQuoted 9 lines · Bart Van Assche
Additionally, make it easier to detect skb leaks by issuing a warning if a leak occurs.
Signed-off-by Bart Van Assche <[email protected]>Cc Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/[email protected]>Cc Andrew Boyer <[email protected]>---
drivers/infiniband/sw/rxe/rxe_comp.c| 15 ++++++++++++++-1 file changed, 14 insertions(+), 1 deletion(-)
I liked this better when it was doing the rxe_drop_ref() and kfree_skb() after exit: and done:, if pkt was set.
Maybe that was just in our private patchset, I don¹t remember, but it would be fewer lines and fewer chances to miss something.
Quoted 84 lines
drivers/infiniband/sw/rxe/rxe_comp.c +14
-1@@ -622,6 +622,7 @@ int rxe_completer(void *arg)if (pkt) {rxe_drop_ref (pkt->qp);kfree_skb (skb); + skb =NULL ; } goto done;@@ -645,6 +646,7 @@ int rxe_completer(void *arg) qp->qp_timeout_jiffies)mod_timer (&qp->retrans_timer, jiffies + qp->qp_timeout_jiffies); +WARN_ON_ONCE (skb); goto exit;case COMPST_ERROR_RETRY :@@ -657,8 +659,10 @@ int rxe_completer(void *arg)*/ /* there is nothing to retry in this case */ -if (!wqe || (wqe->state == wqe_state_posted)) +if (!wqe || (wqe->state == wqe_state_posted)) { +WARN_ON_ONCE (skb); goto exit; + }if (qp->comp.retry_cnt >0 ) {if (qp->comp.retry_cnt !=7 )@@ -680,8 +684,10 @@ int rxe_completer(void *arg)if (pkt) {rxe_drop_ref (pkt->qp);kfree_skb (skb); + skb =NULL ; } +WARN_ON_ONCE (skb); goto exit; }else {@@ -701,6 +707,9 @@ int rxe_completer(void *arg)mod_timer (&qp->rnr_nak_timer, jiffies +rnrnak_jiffies (aeth_syn (pkt) & ~AETH_TYPE_MASK )); +rxe_drop_ref (pkt->qp); +kfree_skb (skb); + skb =NULL ; goto exit; }else { wqe->status =IB_WC_RNR_RETRY_EXC_ERR ;@@ -716,8 +725,10 @@ int rxe_completer(void *arg)if (pkt) {rxe_drop_ref (pkt->qp);kfree_skb (skb); + skb =NULL ; } +WARN_ON_ONCE (skb); goto exit; } }@@ -726,6 +737,7 @@ int rxe_completer(void *arg)/* we come here if we are done with processing and want the task to * exit from the loop calling us */ +WARN_ON_ONCE (skb);rxe_drop_ref (qp);return -EAGAIN ;@@ -733,6 +745,7 @@ int rxe_completer(void *arg)/* we come here if we have processed a packet we want the task to call * us again to see if there is anything else to do */ +WARN_ON_ONCE (skb);rxe_drop_ref (qp);return 0 ; }Signature · 1 line
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Bart Van Assche
Hello Doug,
The patches in this series are what I came up with by reviewing and testing
therdma_rxedriver. Please consider these patches for kernel v4.11.
Hi Bart,
This patch set, as a whole, did not make it to patchworks properly. The patches themselves are in DOS file format and require a run of dos2unix to fix them up, and patchworks didn't even grab 4 of the patches out of the series. Can you please gather your Reviewed-by:
tags, then resubmit the series with Unix formatting? That should help ensure they all get captured by patchworks.
Signature · 4 lines
Doug Ledford <[email protected]> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD