patch "iio: 104-quad-8: Fix off-by-one errors when addressing IOR" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio: 104-quad-8: Fix off-by-one errors when addressing IOR
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
7e1c4058e741c781b262b15a2e86a40602aaa6b6Mon Sep 17 00:00:00 2001
From: William Breathitt Gray <[email protected]>
Date: Mon, 28 Nov 2016 16:55:34 -0500
Subject: iio: 104-quad-8: Fix off-by-one errors when addressing IOR
The Input/Output Control register (IOR) is offset by 1 from the respective channel data register. This patch fixes off-by-one errors when attempting to write to a channel IOR where the base address was not properly offset.
--- drivers/iio/counter/104-quad-8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/counter/104-quad-8.c +2 -2
@@ -153,7 +153,7 @@ static int quad8_write_raw(struct iio_dev *indio_dev, ior_cfg = val | priv->preset_enable[chan->channel] <<1 ;/* Load I/O control configuration */ -outb (0x40 | ior_cfg, base_offset); +outb (0x40 | ior_cfg, base_offset +1 );return 0 ;case IIO_CHAN_INFO_SCALE :
@@ -241,7 +241,7 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev, size_t len) {struct quad8_iio *const priv =iio_priv (indio_dev); -const int base_offset = priv->base +2 * chan->channel; +const int base_offset = priv->base +2 * chan->channel +1 ;bool preset_enable;int ret;unsigned int ior_cfg;
Signature · 1 line
2.11.0