patch "iio: 104-quad-8: Fix active level mismatch for the preset enable" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
iio: 104-quad-8: Fix active level mismatch for the preset enable
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
e91c3dfcd3ff88218c972cb24f932c4d434bbb09Mon Sep 17 00:00:00 2001
From: William Breathitt Gray <[email protected]>
Date: Tue, 29 Nov 2016 10:51:48 -0500
Subject: iio: 104-quad-8: Fix active level mismatch for the preset enable
option
The set_to_preset_on_index sysfs attribute provides a boolean configuration option to enable a preset operation on the respective channel's counter when Index occurs. However, the corresponding configuration bit on the Input/Output Control register must be set low to enable the preset operation.
This patch inverts the internal driver boolean logic exposed via the set_to_preset_on_index attribute in order to correctly configure the device which expects an active low bit.
--- drivers/iio/counter/104-quad-8.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/iio/counter/104-quad-8.c +4 -1
@@ -233,7 +233,7 @@ static ssize_t quad8_read_set_to_preset_on_index(struct iio_dev *indio_dev,const struct quad8_iio *const priv =iio_priv (indio_dev);return snprintf (buf,PAGE_SIZE ,"%u\n" , - priv->preset_enable[chan->channel]); + !priv->preset_enable[chan->channel]); } static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,
@@ -250,6 +250,9 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev,if (ret)return ret; +/* Preset enable is active low in Input/Output Control register */ + preset_enable = !preset_enable; + priv->preset_enable[chan->channel] = preset_enable; ior_cfg = priv->ab_enable[chan->channel] |
Signature · 1 line
2.11.0