Skip to contentSkip to conversation

Patch "watchdog: mei_wdt: request stop on reboot to prevent false positive event" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jan 4, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

watchdog: mei_wdt: request stop on reboot to prevent false positive event

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
watchdog-mei_wdt-request-stop-on-reboot-to-prevent-false-positive-event.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9eff1140a82db8c5520f76e51c21827b4af670b3 Mon Sep 17 00:00:00 2001

From: Alexander Usyskin <[email protected]>
Date: Tue, 8 Nov 2016 17:55:52 +0200
Subject: watchdog: mei_wdt: request stop on reboot to prevent false positive event

From: Alexander Usyskin <[email protected]>

commit 9eff1140a82db8c5520f76e51c21827b4af670b3 upstream.

Systemd on reboot enables shutdown watchdog that leaves the watchdog device open to ensure that even if power down process get stuck the platform reboots nonetheless.
The iamt_wdt is an alarm-only watchdog and can't reboot system, but the FW will generate an alarm event reboot was completed in time, as the watchdog is not automatically disabled during power cycle. So we should request stop watchdog on reboot to eliminate wrong alarm from the FW.

---
 drivers/watchdog/mei_wdt.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/watchdog/mei_wdt.c +2 -0
@@ -389,6 +389,8 @@ static int mei_wdt_register(struct mei_w
 	wdt->wdd.max_timeout = MEI_WDT_MAX_TIMEOUT;
 
 	watchdog_set_drvdata(&wdt->wdd, wdt);
+	watchdog_stop_on_reboot(&wdt->wdd);
+
 	ret = watchdog_register_device(&wdt->wdd);
 	if (ret) {
 		dev_err(dev, "unable to register watchdog device = %d.\n", ret);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/watchdog-mei_wdt-request-stop-on-reboot-to-prevent-false-positive-event.patch