patch "USB: serial: iuu_phoenix: fix NULL-deref at open" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: iuu_phoenix: fix NULL-deref at open
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
90507d54f712d81b74815ef3a4bbb555cd9fab2fMon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 3 Jan 2017 16:39:47 +0100
Subject: USB: serial: iuu_phoenix: fix NULL-deref at open
Fix NULL-pointer dereference at open should the device lack a bulk-in or bulk-out endpoint:
Unable to handle kernel NULL pointer dereference at virtual address 00000030
...
PC is at iuu_open+0x78/0x59c [iuu_phoenix]
check")
--- drivers/usb/serial/iuu_phoenix.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/usb/serial/iuu_phoenix.c +11 -0
@@ -68,6 +68,16 @@ struct iuu_private {u32 clk; }; +static int iuu_attach (struct usb_serial *serial) +{ +unsigned char num_ports = serial->num_ports; + +if (serial->num_bulk_in < num_ports || serial->num_bulk_out < num_ports) +return -ENODEV ; + +return 0 ; +} +static int iuu_port_probe (struct usb_serial_port *port) {struct iuu_private *priv;
@@ -1196,6 +1206,7 @@ static struct usb_serial_driver iuu_device = { .tiocmset = iuu_tiocmset, .set_termios = iuu_set_termios, .init_termios = iuu_init_termios, + .attach = iuu_attach, .port_probe = iuu_port_probe, .port_remove = iuu_port_remove, };
Signature · 1 line
2.11.0