patch "USB: serial: pl2303: fix NULL-deref at open" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: pl2303: fix NULL-deref at open
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
76ab439ed1b68778e9059c79ecc5d14de76c89a8Mon Sep 17 00:00:00 2001
From: Johan Hovold <[email protected]>
Date: Tue, 3 Jan 2017 16:40:00 +0100
Subject: USB: serial: pl2303: fix NULL-deref at open
Fix NULL-pointer dereference in open() should a type-0 or type-1 device lack the expected endpoints:
Unable to handle kernel NULL pointer dereference at virtual address 00000030
...
PC is at pl2303_open+0x38/0xec [pl2303]
Note that a missing interrupt-in endpoint would have caused open() to fail.
--- drivers/usb/serial/pl2303.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/usb/serial/pl2303.c +8 -0
@@ -220,9 +220,17 @@ static int pl2303_probe(struct usb_serial *serial,static int pl2303_startup (struct usb_serial *serial) {struct pl2303_serial_private *spriv; +unsigned char num_ports = serial->num_ports;enum pl2303_type type =TYPE_01 ;unsigned char *buf; +if (serial->num_bulk_in < num_ports || + serial->num_bulk_out < num_ports || + serial->num_interrupt_in < num_ports) { +dev_err (&serial->interface->dev,"missing endpoints\n" ); +return -ENODEV ; + } + spriv =kzalloc (sizeof (*spriv),GFP_KERNEL );if (!spriv)return -ENOMEM ;
Signature · 1 line
2.11.0