Skip to contentSkip to conversation

package/mpd: needs GCC >= 4.9

PATCH New Jörg Krause 2 participants 3 messages Jan 6, 2017

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH 1/1 package/mpd: needs GCC >= 4.9

The version 0.20 of mpd uses C++14 language features and therefor requires at least GCC version 4.9.

Fixes:
http://autobuild.buildroot.net/results/3fe/3fe440c0b9d05acb44553a8f02f688570e06bca9/
http://autobuild.buildroot.net/results/d33/d3309bea9411fca70d61d07c36f58718bc87e6d1/
http://autobuild.buildroot.net/results/208/208bb987f52b8ba65e3c6fc9b6e917dbd44c0fbd/
http://autobuild.buildroot.net/results/9b9/9b9659ba30afde49912276fe7f9c282953a352ab/
.. and more.

Signed-off-by J?rg Krause <[email protected]>
---
 package/mpd/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/mpd/Config.in +3 -3
index 82bbd8d21..e0bb60447 100644
@@ -4,7 +4,7 @@ menuconfig BR2_PACKAGE_MPD
 	depends on BR2_USE_WCHAR # libglib2, flac
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # libglib2
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBGLIB2

@@ -315,8 +315,8 @@ config BR2_PACKAGE_MPD_UPNP
 
 endif
 
-comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6"
+comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/mpd: needs GCC >= 4.9

Hi J?rg,

Quoted 11 lines · J?rg Krause

The version 0.20 of mpd uses C++14 language features and therefor requires at least GCC version 4.9.

Fixes:
http://autobuild.buildroot.net/results/3fe/3fe440c0b9d05acb44553a8f02f688570e06bca9/
http://autobuild.buildroot.net/results/d33/d3309bea9411fca70d61d07c36f58718bc87e6d1/
http://autobuild.buildroot.net/results/208/208bb987f52b8ba65e3c6fc9b6e917dbd44c0fbd/
http://autobuild.buildroot.net/results/9b9/9b9659ba30afde49912276fe7f9c282953a352ab/
.. and more.

Signed-off-by J?rg Krause <[email protected]>

This is identical to http://patchwork.ozlabs.org/patch/711567/.

baruch

Quoted 28 lines
---
 package/mpd/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/mpd/Config.in +3 -3
index 82bbd8d21..e0bb60447 100644
@@ -4,7 +4,7 @@ menuconfig BR2_PACKAGE_MPD
 	depends on BR2_USE_WCHAR # libglib2, flac
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # libglib2
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBGLIB2

@@ -315,8 +315,8 @@ config BR2_PACKAGE_MPD_UPNP
 
 endif
 
-comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6"
+comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#2 lore raw

PATCH 1/1 package/mpd: needs GCC >= 4.9

Quoted 17 lines · Baruch Siach

Hi J?rg,

Quoted 14 lines · J?rg Krause

The version 0.20 of mpd uses C++14 language features and therefor requires at least GCC version 4.9.

Fixes:
http://autobuild.buildroot.net/results/3fe/3fe440c0b9d05acb44553a8f
02f688570e06bca9/
http://autobuild.buildroot.net/results/d33/d3309bea9411fca70d61d07c
36f58718bc87e6d1/
http://autobuild.buildroot.net/results/208/208bb987f52b8ba65e3c6fc9
b6e917dbd44c0fbd/
http://autobuild.buildroot.net/results/9b9/9b9659ba30afde49912276fe
7f9c282953a352ab/
.. and more.

Quoted 4 lines
Quoted 1 line
Signed-off-by J?rg Krause <[email protected]>

This is identical to http://patchwork.ozlabs.org/patch/711567/.

Looks like our patches overlaped by a few minutes. I'll remove my patch from patchwork.

J?rg

Quoted 33 lines
Quoted 31 lines

---
?package/mpd/Config.in | 6 +++---
?1 file changed, 3 insertions(+), 3 deletions(-)

package/mpd/Config.in +0 -0
index 82bbd8d21..e0bb60447 100644
@@ -4,7 +4,7 @@ menuconfig BR2_PACKAGE_MPD

? depends on BR2_USE_WCHAR # libglib2, flac
? depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
? depends on BR2_USE_MMU # libglib2

package/mpd/Config.in +1 -1
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_6
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14

? depends on BR2_TOOLCHAIN_HAS_ATOMIC
? select BR2_PACKAGE_BOOST
? select BR2_PACKAGE_LIBGLIB2

package/mpd/Config.in +0 -0
@@ -315,8 +315,8 @@ config BR2_PACKAGE_MPD_UPNP

?
?endif
?

package/mpd/Config.in +1 -1
-comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.6"
+comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9"

? depends on BR2_USE_MMU
? depends on BR2_TOOLCHAIN_HAS_ATOMIC
? depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \

package/mpd/Config.in +0 -1
-		!BR2_TOOLCHAIN_HAS_THREADS ||

!BR2_TOOLCHAIN_GCC_AT_LEAST_4_6

package/mpd/Config.in +1 -0
+		!BR2_TOOLCHAIN_HAS_THREADS ||

!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9