Skip to contentSkip to conversation

Patch "ssb: Fix error routine when fallback SPROM fails" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jan 6, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ssb: Fix error routine when fallback SPROM fails

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ssb-fix-error-routine-when-fallback-sprom-fails.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8052d7245b6089992343c80b38b14dbbd8354651 Mon Sep 17 00:00:00 2001

From: Larry Finger <[email protected]>
Date: Sat, 5 Nov 2016 14:08:57 -0500
Subject: ssb: Fix error routine when fallback SPROM fails

From: Larry Finger <[email protected]>

commit 8052d7245b6089992343c80b38b14dbbd8354651 upstream.

When there is a CRC error in the SPROM read from the device, the code attempts to handle a fallback SPROM. When this also fails, the driver returns zero rather than an error code.

---
 drivers/ssb/pci.c |    1 +
 1 file changed, 1 insertion(+)
drivers/ssb/pci.c +1 -0
@@ -909,6 +909,7 @@ static int ssb_pci_sprom_get(struct ssb_
 			if (err) {
 				ssb_warn("WARNING: Using fallback SPROM failed (err %d)\n",
 					 err);
+				goto out_free;
 			} else {
 				ssb_dbg("Using SPROM revision %d provided by platform\n",
 					sprom->revision);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/rtlwifi-fix-enter-exit-power_save.patch queue-4.4/ssb-fix-error-routine-when-fallback-sprom-fails.patch