Skip to contentSkip to conversation

Patch "ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jan 6, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     ath9k-fix-ath9k_hw_gpio_get-to-return-0-or-1-on-success.patch

and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 91851cc7a939039bd401adb6ca3da4402bec1d0c Mon Sep 17 00:00:00 2001

From: Matthias Schiffer <[email protected]>
Date: Tue, 15 Nov 2016 18:47:21 +0100
Subject: ath9k: fix ath9k_hw_gpio_get() to return 0 or 1 on success

From: Matthias Schiffer <[email protected]>

commit 91851cc7a939039bd401adb6ca3da4402bec1d0c upstream.

Commit b2d70d4944c1 ("ath9k: make GPIO API to support both of WMAC and SOC") refactored ath9k_hw_gpio_get() to support both WMAC and SOC GPIOs, changing the return on success from 1 to BIT(gpio). This broke some callers like ath_is_rfkill_set(). This doesn't fix any known bug in mainline at the moment, but should be fixed anyway.

Instead of fixing all callers, change ath9k_hw_gpio_get() back to only return 0 or 1.

Fixes b2d70d4944c1 ("ath9k: make GPIO API to support both of WMAC and SOC")
[[email protected]: mention that doesn't fix any known bug]
---
 drivers/net/wireless/ath/ath9k/hw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath9k/hw.c +1 -1
@@ -2792,7 +2792,7 @@ u32 ath9k_hw_gpio_get(struct ath_hw *ah,
 		WARN_ON(1);
 	}
 
-	return val;
+	return !!val;
 }
 EXPORT_SYMBOL(ath9k_hw_gpio_get);
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/ath9k-fix-ath9k_hw_gpio_get-to-return-0-or-1-on-success.patch