Skip to contentSkip to conversation

Patch "Input: drv260x - fix input device's parent assignment" has been added to the 4.8-stable tree

PATCH [email protected] 1 participant 1 message Jan 6, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    Input: drv260x - fix input device's parent assignment

to the 4.8-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     input-drv260x-fix-input-device-s-parent-assignment.patch

and it can be found in the queue-4.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5a8a6b89c15766446d845671d574a9243b6d8786 Mon Sep 17 00:00:00 2001

From: Jingkui Wang <[email protected]>
Date: Mon, 12 Dec 2016 13:51:46 -0800
Subject: Input: drv260x - fix input device's parent assignment

From: Jingkui Wang <[email protected]>

commit 5a8a6b89c15766446d845671d574a9243b6d8786 upstream.

We were assigning I2C bus controller instead of client as parent device. Besides being logically wrong, it messed up with devm handling of input device. As a result we were leaving input device and event node behind after rmmod-ing the driver, which lead to a kernel oops if one were to access the event node later.

Let's remove the assignment and rely on devm_input_allocate_device() to set it up properly for us.

Fixes 7132fe4f5687 ("Input: drv260x - add TI drv260x haptics driver")
---
 drivers/input/misc/drv260x.c |    1 -
 1 file changed, 1 deletion(-)
drivers/input/misc/drv260x.c +0 -1
@@ -592,7 +592,6 @@ static int drv260x_probe(struct i2c_clie
 	}
 
 	haptics->input_dev->name = "drv260x:haptics";
-	haptics->input_dev->dev.parent = client->dev.parent;
 	haptics->input_dev->close = drv260x_close;
 	input_set_drvdata(haptics->input_dev, haptics);
 	input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);

Patches currently in stable-queue which might be from [email protected] are

queue-4.8/input-drv260x-fix-input-device-s-parent-assignment.patch