Skip to contentSkip to conversation

drm/i915/psr: enable psr2 for y cordinate panels

PATCH In review vathsala nagaraju 2 participants 4 messages Jan 6, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 8/10 drm/i915/psr: enable psr2 for y cordinate panels

Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2
can work on panels without y cordinate support.

v2: (Rodrigo)
- Move the check to intel_psr_match_conditions

v3: (Rodrigo)
- add return false

---
 drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/intel_psr.c +9 -0
index 05efd4e..fc32b04 100644
@@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
 		return false;
 	}
 
+	/*
+	 * FIXME:enable psr2 only for y-cordinate psr2 panels
+	 * After gtc implementation , remove this restriction.
+	 */
+	if (!dev_priv->psr.y_cord_support &&  dev_priv->psr.psr2_support) {
+		DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");
+		return false;
+	}
+
 	dev_priv->psr.source_ok = true;
 	return true;
 }
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#1 lore raw

I was going to write the rv-b,
but something came to my mind...

In this case where y_cord_support but we don't have gtc yet, couldn't we enable PSR1 instead?
in this case instead of return false we would do dev_priv->psr.psr2_support = false;

what do you think/advise?

Quoted 28 lines · vathsala nagaraju

Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2
can work on panels without y cordinate support.

v2: (Rodrigo)
- Move the check to intel_psr_match_conditions

v3: (Rodrigo)
- add return false

---
 drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/intel_psr.c +2 -0
index 05efd4e..fc32b04 100644
@@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
 		return false;
 	}
 
+	/*
+	 * FIXME:enable psr2 only for y-cordinate psr2 panels

drivers/gpu/drm/i915/intel_psr.c static bool intel_psr_match_conditions(struct intel_dp *intel_dp) · line 447

Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +7 -0
+	 * After gtc implementation , remove this restriction.
+	 */
+	if (!dev_priv->psr.y_cord_support &&  dev_priv->psr.psr2_support) {
+		DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");
+		return false;
+	}
+
 	dev_priv->psr.source_ok = true;
 	return true;
 }

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

1) I am still not able to get psr1 working on y-cordinate panels. Only psr2 works.
2) I haven't got a GTC panel to test this scenario. Once we test psr1 on psr2 GTC panel, we could add dev_priv->psr.psr2_support = false; till GTC is implemented.

-----Original Message-----
From: Vivi, Rodrigo
Sent: Friday, January 6, 2017 11:08 PM
To: Nagaraju, Vathsala <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Patil, Deepti <[email protected]>
Subject: Re: [PATCH 08/10] drm/i915/psr: enable psr2 for y cordinate panels

I was going to write the rv-b,
but something came to my mind...

In this case where y_cord_support but we don't have gtc yet, couldn't we enable PSR1 instead? in this case instead of return false we would do dev_priv->psr.psr2_support = false;

what do you think/advise?

Quoted 29 lines · vathsala nagaraju

Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2 can work on panels without y cordinate support.

v2: (Rodrigo)
- Move the check to intel_psr_match_conditions

v3: (Rodrigo)
- add return false

---
 drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/intel_psr.c +2 -0
index 05efd4e..fc32b04 100644
@@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
 		return false;
 	}
 
+	/*
+	 * FIXME:enable psr2 only for y-cordinate psr2 panels

drivers/gpu/drm/i915/intel_psr.c static bool intel_psr_match_conditions(struct intel_dp *intel_dp) · line 447

Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +7 -0
+	 * After gtc implementation , remove this restriction.
+	 */
+	if (!dev_priv->psr.y_cord_support &&  dev_priv->psr.psr2_support) {
+		DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");
+		return false;
+	}
+
 	dev_priv->psr.source_ok = true;
 	return true;
 }

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Reviewed-by
#3 lore raw
Quoted 2 lines · Vathsala

1) I am still not able to get psr1 working on y-cordinate panels. Only psr2 works.
2) I haven't got a GTC panel to test this scenario. Once we test psr1 on psr2 GTC panel, we could add dev_priv->psr.psr2_support = false; till GTC is implemented.

Agree!

Quoted 44 lines

-----Original Message-----
From: Vivi, Rodrigo
Sent: Friday, January 6, 2017 11:08 PM
To: Nagaraju, Vathsala <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Patil, Deepti <[email protected]>
Subject: Re: [PATCH 08/10] drm/i915/psr: enable psr2 for y cordinate panels

I was going to write the rv-b,
but something came to my mind...

In this case where y_cord_support but we don't have gtc yet, couldn't we enable PSR1 instead? in this case instead of return false we would do dev_priv->psr.psr2_support = false;

what do you think/advise?

Quoted 27 lines · vathsala nagaraju

Psr2 is enabled only for y cordinate panels.Once GTC (global time code) is implemented,this restriction is removed so that psr2 can work on panels without y cordinate support.

v2: (Rodrigo)
- Move the check to intel_psr_match_conditions

v3: (Rodrigo)
- add return false

---
 drivers/gpu/drm/i915/intel_psr.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/gpu/drm/i915/intel_psr.c +0 -0
index 05efd4e..fc32b04 100644
@@ -433,6 +433,15 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
 		return false;
 	}
 
Quoted 13 lines

drivers/gpu/drm/i915/intel_psr.c static bool intel_psr_match_conditions(struct intel_dp *intel_dp) · line 447

Quoted 12 lines
drivers/gpu/drm/i915/intel_psr.c +9 -0
+	/*
+	 * FIXME:enable psr2 only for y-cordinate psr2 panels
+	 * After gtc implementation , remove this restriction.
+	 */
+	if (!dev_priv->psr.y_cord_support &&  dev_priv->psr.psr2_support) {
+		DRM_DEBUG_KMS("PSR2 disabled, panel does not support Y coordinate\n");
+		return false;
+	}
+
 	dev_priv->psr.source_ok = true;
 	return true;
 }

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx