Patch "ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-usb-audio-fix-bogus-error-return-in-snd_usb_create_stream.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
4763601a56f155ddf94ef35fc2c41504a2de15f5Mon Sep 17 00:00:00 2001
From: Takashi Iwai <[email protected]>
Date: Tue, 29 Nov 2016 22:28:40 +0100
Subject: ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()
From: Takashi Iwai <[email protected]>
commit 4763601a56f155ddf94ef35fc2c41504a2de15f5 upstream.
The function returns -EINVAL even if it builds the stream properly. The bogus error code sneaked in during the code refactoring, but it wasn't noticed until now since the returned error code itself is ignored in anyway. Kill it here, but there is no behavior change by this patch, obviously.
--- sound/usb/card.c | 1 - 1 file changed, 1 deletion(-)
sound/usb/card.c +0 -1
@@ -202,7 +202,6 @@ static int snd_usb_create_stream(structif (!snd_usb_parse_audio_interface (chip, interface)) {usb_set_interface (dev, interface,0 );/* reset the current interface */ usb_driver_claim_interface (&usb_audio_driver, iface, (void *)-1L ); -return -EINVAL ; }return 0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/alsa-hda-fix-up-gpio-for-asus-rog-ranger.patch queue-4.4/alsa-hda-apply-asus-mode8-fixup-to-asus-x71sl.patch queue-4.4/alsa-usb-audio-fix-bogus-error-return-in-snd_usb_create_stream.patch queue-4.4/alsa-usb-audio-fix-irq-process-data-synchronization.patch