soc: dove: constify reset_control_ops structures
PATCH 1/1 soc: dove: constify reset_control_ops structures
Declare reset_control_ops as const as they are only stored in the ops field of a reset_controller_dev structure. This field is of type const struct reset_control_ops *, so reset_control_ops structures having this property can be declared as const.
Done using Coccinelle:
@r1 disable optional_qualifier@
identifier i;
position p;
@@
static struct reset_control_ops i@p={...};
@ok1@
identifier r1.i;
position p;
struct reset_controller_dev x;
@@
x.ops=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct reset_control_ops i;
File size before: drivers/soc/dove/pmu.o
text data bss dec hex filename
2447 112 16 2575 a0f drivers/soc/dove/pmu.o
File size after: drivers/soc/dove/pmu.o
text data bss dec hex filename
2479 80 16 2575 a0f drivers/soc/dove/pmu.o
--- drivers/soc/dove/pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/dove/pmu.c +1 -1
@@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id)return 0 ; } -static struct reset_control_ops pmu_reset_ops = { +static const struct reset_control_ops pmu_reset_ops = { .reset = pmu_reset_reset, .assert = pmu_reset_assert, .deassert = pmu_reset_deassert,
Signature · 1 line
1.9.1
Hi Sebastian,
Quoted 31 lines · Bhumika Goyal
Declare
reset_control_opsas const as they are only stored in the ops field of areset_controller_devstructure. This field is of type const structreset_control_ops*, soreset_control_opsstructures having this property can be declared as const.
Done using Coccinelle:@r1 disable optional_qualifier@
identifier i;
position p;
@@
static structreset_control_opsi@p={...};@ok1@
identifier r1.i;
position p;
structreset_controller_devx;
@@
x.ops=&i@p;@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
structreset_control_opsi;
Quoted 8 lines
File size before:
drivers/soc/dove/pmu.o
text data bss dec hex filename
2447 112 16 2575 a0fdrivers/soc/dove/pmu.oFile size after:
drivers/soc/dove/pmu.o
text data bss dec hex filename
2479 80 16 2575 a0fdrivers/soc/dove/pmu.o
If you agree with this patch I will apply it on mvebu/soc.
Thanks,
Gregory
Quoted 21 lines
Signed-off-by Bhumika Goyal <[email protected]>--- drivers/soc/dove/pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/dove/pmu.c +1
-1@@ -87,7 +87,7 @@ static int pmu_reset_deassert(struct reset_controller_dev *rc, unsigned long id)return 0 ; } -static struct reset_control_ops pmu_reset_ops = { +static const struct reset_control_ops pmu_reset_ops = { .reset = pmu_reset_reset, .assert = pmu_reset_assert, .deassert = pmu_reset_deassert,Signature · 1 line
1.9.1
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
Russell King - ARM Linux
Acked-by Russell KingQuoted 39 lines · Gregory CLEMENT
Hi Sebastian,
Quoted 35 lines · Bhumika Goyal
Declare
reset_control_opsas const as they are only stored in the ops field of areset_controller_devstructure. This field is of type const structreset_control_ops*, soreset_control_opsstructures having this property can be declared as const.
Done using Coccinelle:@r1 disable optional_qualifier@
identifier i;
position p;
@@
static structreset_control_opsi@p={...};@ok1@
identifier r1.i;
position p;
structreset_controller_devx;
@@
x.ops=&i@p;@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
structreset_control_opsi;File size before:
drivers/soc/dove/pmu.o
text data bss dec hex filename
2447 112 16 2575 a0fdrivers/soc/dove/pmu.o
Quoted 6 lines
Quoted 4 lines
File size after:
drivers/soc/dove/pmu.o
text data bss dec hex filename
2479 80 16 2575 a0fdrivers/soc/dove/pmu.oIf you agree with this patch I will apply it on mvebu/soc.
You really ought to be asking me...
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Hi Russell King,
Quoted 40 lines · Russell King - ARM Linux
Quoted 39 lines · Gregory CLEMENT
Hi Sebastian,
Quoted 35 lines · Bhumika Goyal
Declare
reset_control_opsas const as they are only stored in the ops field of areset_controller_devstructure. This field is of type const structreset_control_ops*, soreset_control_opsstructures having this property can be declared as const.
Done using Coccinelle:@r1 disable optional_qualifier@
identifier i;
position p;
@@
static structreset_control_opsi@p={...};@ok1@
identifier r1.i;
position p;
structreset_controller_devx;
@@
x.ops=&i@p;@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
structreset_control_opsi;File size before:
drivers/soc/dove/pmu.o
text data bss dec hex filename
2447 112 16 2575 a0fdrivers/soc/dove/pmu.o
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
File size after:
drivers/soc/dove/pmu.o
text data bss dec hex filename
2479 80 16 2575 a0fdrivers/soc/dove/pmu.oIf you agree with this patch I will apply it on mvebu/soc.
You really ought to be asking me...
Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he would have redirect me to you :)
Quoted 2 lines
Acked-by Russell King <[email protected]>
Applied on mvebu/soc
Thanks,
Gregory
Quoted 5 lines
Signature · 4 lines
-- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 2 lines · Gregory CLEMENT
Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he would have redirect me to you :)
Should I change the MAINTAINERS entry, as it seems that I'm more involved with Dove than Sebastian is now? Sebastian?
Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
Quoted 7 lines · Russell King - ARM Linux
Quoted 2 lines · Gregory CLEMENT
Sorry when I saw SoC and Dove I though to Sebastian. And I ma sure he would have redirect me to you :)
Should I change the
MAINTAINERSentry, as it seems that I'm more involved with Dove than Sebastian is now? Sebastian?
Uhm, yeah, please change the MAINTAINERS entry.
I haven't been able to follow neither Dove nor mvebu discussion lately.
If you want to take over, feel free to add my
Sebastian