drm/i915/psr: disable psr2 for resolution greater than 32X20
Subsystems (2)
PATCH 1/1 drm/i915/psr: disable psr2 for resolution greater than 32X20
PSR2 is restricted to work with panel resolutions upto 3200x2000, move the check to intel_psr_match_conditions and fully block psr.
--- drivers/gpu/drm/i915/intel_psr.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/intel_psr.c +8 -7
@@ -387,6 +387,13 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)return false; } +/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */ +if (intel_crtc->config->pipe_src_w >3200 || + intel_crtc->config->pipe_src_h >2000 ) { + dev_priv->psr.psr2_support = false; +return false; + } + dev_priv->psr.source_ok = true;return true; }
@@ -425,7 +432,6 @@ void intel_psr_enable(struct intel_dp *intel_dp)struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); -struct intel_crtc *crtc =to_intel_crtc (intel_dig_port->base.base.crtc);if (!HAS_PSR (dev_priv)) {DRM_DEBUG_KMS ("PSR not supported on this platform\n" );
@@ -452,12 +458,7 @@ void intel_psr_enable(struct intel_dp *intel_dp)hsw_psr_setup_vsc (intel_dp);if (dev_priv->psr.psr2_support) { -/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */ -if (crtc->config->pipe_src_w >3200 || - crtc->config->pipe_src_h >2000 ) - dev_priv->psr.psr2_support = false; -else -skl_psr_setup_su_vsc (intel_dp); +skl_psr_setup_su_vsc (intel_dp); }/*
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/psr: disable psr2 for resolution greater than 32X20
== Series Details ==
== Series Details ==
Series: drm/i915/psr: disable psr2 for resolution greater than 32X20
URL : https://patchwork.freedesktop.org/series/17737/
State : success
== Summary ==
Series 17737v1 drm/i915/psr: disable psr2 for resolution greater than 32X20
https://patchwork.freedesktop.org/api/1.0/series/17737/revisions/1/mbox/
Test kms_force_connector_basic:
Subgroup force-connector-state:
dmesg-warn -> PASS (fi-snb-2520m)
Subgroup prune-stale-modes:
skip -> PASS (fi-ivb-3520m)fi-bdw-5557u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14 fi-bsw-n3050 total:246 pass:207 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22 fi-bxt-t5700 total:82 pass:69 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:246 pass:219 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19 fi-hsw-4770r total:246 pass:227 dwarn:0 dfail:0 fail:0 skip:19 fi-ivb-3520m total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21 fi-ivb-3770 total:246 pass:225 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6260u total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13 fi-skl-6700hq total:246 pass:226 dwarn:0 dfail:0 fail:0 skip:20 fi-skl-6700k total:246 pass:222 dwarn:3 dfail:0 fail:0 skip:21 fi-skl-6770hq total:246 pass:233 dwarn:0 dfail:0 fail:0 skip:13 fi-snb-2520m total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31 fi-snb-2600 total:246 pass:214 dwarn:0 dfail:0 fail:0 skip:32
9ea6a075c23ea914695d57944c0e74cff0c6bff4 drm-tip: 2017y-01m-09d-16h-11m-21s UTC integration manifest f3ad5a5 drm/i915/psr: disable psr2 for resolution greater than 32X20
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3460/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 41 lines · vathsala nagaraju
PSR2 is restricted to work with panel resolutions upto 3200x2000, move the check to
intel_psr_match_conditionsand fully block psr.Cc Rodrigo Vivi <[email protected]>Cc Jim Bride <[email protected]>Suggested-by Rodrigo Vivi <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>--- drivers/gpu/drm/i915/intel_psr.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/intel_psr.c +7
-1@@ -387,6 +387,13 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)return false; } +/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */ +if (intel_crtc->config->pipe_src_w >3200 || + intel_crtc->config->pipe_src_h >2000 ) { + dev_priv->psr.psr2_support = false; +return false; + } + dev_priv->psr.source_ok = true;return true; }@@ -425,7 +432,6 @@ void intel_psr_enable(struct intel_dp *intel_dp)struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); -struct intel_crtc *crtc =to_intel_crtc (intel_dig_port->base.base.crtc);if (!HAS_PSR (dev_priv)) {DRM_DEBUG_KMS ("PSR not supported on this platform\n" );@@ -452,12 +458,7 @@ void intel_psr_enable(struct intel_dp *intel_dp)hsw_psr_setup_vsc (intel_dp);if (dev_priv->psr.psr2_support) {
drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 464
Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +1
-6-/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */ -if (crtc->config->pipe_src_w >3200 || - crtc->config->pipe_src_h >2000 ) - dev_priv->psr.psr2_support = false; -else -skl_psr_setup_su_vsc (intel_dp); +skl_psr_setup_su_vsc (intel_dp); }/*
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
patch merged to dinq. thanks for the patch
Quoted 59 lines · Rodrigo
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 7 lines · vathsala nagaraju
PSR2 is restricted to work with panel resolutions upto 3200x2000, move the check to
intel_psr_match_conditionsand fully block psr.Cc Rodrigo Vivi <[email protected]>Cc Jim Bride <[email protected]>Suggested-by Rodrigo Vivi <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>Review
Quoted 5 lines
--- drivers/gpu/drm/i915/intel_psr.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_psr.cdrivers/gpu/drm/i915/intel_psr.c static bool intel_psr_match_conditions(struct
Quoted 4 lines
index 6aca8ff..f2ca2a9 100644
drivers/gpu/drm/i915/intel_psr.c +0
-0@@ -387,6 +387,13 @@ static bool intel_psr_match_conditions(struct
intel_dp*intel_dp)drivers/gpu/drm/i915/intel_psr.c static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
Quoted 4 lines
drivers/gpu/drm/i915/intel_psr.c +1
-0return false; } +/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */
drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 432
Quoted 11 lines
drivers/gpu/drm/i915/intel_psr.c +6
-0+if (intel_crtc->config->pipe_src_w >3200 || + intel_crtc->config->pipe_src_h >2000 ) { + dev_priv->psr.psr2_support = false; +return false; + } + dev_priv->psr.source_ok = true;return true; }@@ -425,7 +432,6 @@ void intel_psr_enable(struct intel_dp *intel_dp) struct intel_digital_port *intel_dig_port =
dp_to_dig_port(intel_dp);drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp)
Quoted 3 lines
drivers/gpu/drm/i915/intel_psr.c +0
-1struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); - struct intel_crtc *crtc =
to_intel_crtc(intel_dig_port->base.base.crtc);drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 455
Quoted 8 lines
drivers/gpu/drm/i915/intel_psr.c +0
-1if (!HAS_PSR (dev_priv)) {DRM_DEBUG_KMS ("PSR not supported on this platform\n" );@@ -452,12 +458,7 @@ void intel_psr_enable(struct intel_dp *intel_dp)hsw_psr_setup_vsc (intel_dp);if (dev_priv->psr.psr2_support) { -/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */
Quoted 8 lines
drivers/gpu/drm/i915/intel_psr.c +1
-5-if (crtc->config->pipe_src_w >3200 || - crtc->config->pipe_src_h >2000 ) - dev_priv->psr.psr2_support = false; -else -skl_psr_setup_su_vsc (intel_dp); +skl_psr_setup_su_vsc (intel_dp); }
Quoted 7 lines
drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 464
Quoted 1 line
drivers/gpu/drm/i915/intel_psr.c +0
-0/* _______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx