Skip to contentSkip to conversation

drm/i915/psr: set CHICKEN_TRANS for psr2

PATCH In review vathsala nagaraju 4 participants 9 messages Jan 11, 2017 – Jan 19, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 6/10 drm/i915/psr: set CHICKEN_TRANS for psr2

As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence.
bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for

        PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable
        header packet.

bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit 15 if Y coordinate is supported

v2: (Rodrigo)
- move CHICKEN_TRANS_EDP bit set logic right after setup_vsc

v3:(Rodrigo)
- initialize chicken_trans to CHICKEN_TRANS_BIT12 instead of 0

v4:(chris wilson)
- use BIT(12), remove CHICKEN_TRANS_BIT12
- remove unnecessary comments
- update commit message

v5:
- rename bit 12 PSR2_VSC_ENABLE_PROG_HEADER
- rename bit 15 PSR2_ADD_VERTICAL_LINE_COUNT

---
 drivers/gpu/drm/i915/i915_reg.h  | 7 +++++++
 drivers/gpu/drm/i915/intel_psr.c | 5 +++++
 2 files changed, 12 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +7 -0
index 7830e6e..7a325fb 100644
@@ -6449,6 +6449,13 @@ enum {
 #define  BDW_DPRS_MASK_VBLANK_SRD	(1 << 0)
 #define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
 
+#define CHICKEN_TRANS_A         0x420c0
+#define CHICKEN_TRANS_B         0x420c4
+#define CHICKEN_TRANS(trans) _MMIO_TRANS(trans, CHICKEN_TRANS_A, CHICKEN_TRANS_B)
+#define TRANS_EDP              3
+#define PSR2_VSC_ENABLE_PROG_HEADER    (1<<12)
+#define PSR2_ADD_VERTICAL_LINE_COUNT   (1<<15)
+
 #define DISP_ARB_CTL	_MMIO(0x45000)
 #define  DISP_FBC_MEMORY_WAKE		(1<<31)
 #define  DISP_TILE_SURFACE_SWIZZLING	(1<<13)
drivers/gpu/drm/i915/intel_psr.c +5 -0
index 3cf5cc4..b582220 100644
@@ -480,6 +480,7 @@ void intel_psr_enable(struct intel_dp *intel_dp)
 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 	struct drm_device *dev = intel_dig_port->base.base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
+	u32 chicken;
 
 	if (!HAS_PSR(dev_priv)) {
 		DRM_DEBUG_KMS("PSR not supported on this platform\n");
@@ -505,6 +506,10 @@ void intel_psr_enable(struct intel_dp *intel_dp)
 	if (HAS_DDI(dev_priv)) {
 		if (dev_priv->psr.psr2_support) {
 			skl_psr_setup_su_vsc(intel_dp);
+			chicken = PSR2_VSC_ENABLE_PROG_HEADER;
+			if (dev_priv->psr.y_cord_support)
+				chicken |= PSR2_ADD_VERTICAL_LINE_COUNT;
+			I915_WRITE(CHICKEN_TRANS(TRANS_EDP), chicken);
 		} else {
 			/* set up vsc header for psr1 */
 			hsw_psr_setup_vsc(intel_dp);
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 6/10 drm/i915/psr: set CHICKEN_TRANS for psr2

As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence.
bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for

        PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable
        header packet.

bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit 15 if Y coordinate is supported

v2: (Rodrigo)
- move CHICKEN_TRANS_EDP bit set logic right after setup_vsc

v3:(Rodrigo)
- initialize chicken_trans to CHICKEN_TRANS_BIT12 instead of 0

v4:(chris wilson)
- use BIT(12), remove CHICKEN_TRANS_BIT12
- remove unnecessary comments
- update commit message

v5:
- rename bit 12 PSR2_VSC_ENABLE_PROG_HEADER
- rename bit 15 PSR2_ADD_VERTICAL_LINE_COUNT

v6:(Rodrigo)
- remove TRANS_EDP=3, use cpu_transcoder

---
 drivers/gpu/drm/i915/i915_reg.h  | 6 ++++++
 drivers/gpu/drm/i915/intel_psr.c | 7 +++++++
 2 files changed, 13 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +6 -0
index 7830e6e..c9c1ccd 100644
@@ -6449,6 +6449,12 @@ enum {
 #define  BDW_DPRS_MASK_VBLANK_SRD	(1 << 0)
 #define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
 
+#define CHICKEN_TRANS_A         0x420c0
+#define CHICKEN_TRANS_B         0x420c4
+#define CHICKEN_TRANS(trans) _MMIO_TRANS(trans, CHICKEN_TRANS_A, CHICKEN_TRANS_B)
+#define PSR2_VSC_ENABLE_PROG_HEADER    (1<<12)
+#define PSR2_ADD_VERTICAL_LINE_COUNT   (1<<15)
+
 #define DISP_ARB_CTL	_MMIO(0x45000)
 #define  DISP_FBC_MEMORY_WAKE		(1<<31)
 #define  DISP_TILE_SURFACE_SWIZZLING	(1<<13)
drivers/gpu/drm/i915/intel_psr.c +7 -0
index 36c4045..935402e 100644
@@ -480,6 +480,9 @@ void intel_psr_enable(struct intel_dp *intel_dp)
 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 	struct drm_device *dev = intel_dig_port->base.base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct intel_crtc *crtc = to_intel_crtc(intel_dig_port->base.base.crtc);
+	enum transcoder cpu_transcoder = crtc->config->cpu_transcoder;
+	u32 chicken;
 
 	if (!HAS_PSR(dev_priv)) {
 		DRM_DEBUG_KMS("PSR not supported on this platform\n");
@@ -505,6 +508,10 @@ void intel_psr_enable(struct intel_dp *intel_dp)
 	if (HAS_DDI(dev_priv)) {
 		if (dev_priv->psr.psr2_support) {
 			skl_psr_setup_su_vsc(intel_dp);
+			chicken = PSR2_VSC_ENABLE_PROG_HEADER;
+			if (dev_priv->psr.y_cord_support)
+				chicken |= PSR2_ADD_VERTICAL_LINE_COUNT;
+			I915_WRITE(CHICKEN_TRANS(cpu_transcoder), chicken);
 		} else {
 			/* set up vsc header for psr1 */
 			hsw_psr_setup_vsc(intel_dp);
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Reviewed-by on v1 6/10
#2 lore raw
Quoted 66 lines · vathsala nagaraju

As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence.
bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for

        PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable
        header packet.

bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit 15 if Y coordinate is supported

v2: (Rodrigo)
- move CHICKEN_TRANS_EDP bit set logic right after setup_vsc

v3:(Rodrigo)
- initialize chicken_trans to CHICKEN_TRANS_BIT12 instead of 0

v4:(chris wilson)
- use BIT(12), remove CHICKEN_TRANS_BIT12
- remove unnecessary comments
- update commit message

v5:
- rename bit 12 PSR2_VSC_ENABLE_PROG_HEADER
- rename bit 15 PSR2_ADD_VERTICAL_LINE_COUNT

v6:(Rodrigo)
- remove TRANS_EDP=3, use cpu_transcoder

---
 drivers/gpu/drm/i915/i915_reg.h  | 6 ++++++
 drivers/gpu/drm/i915/intel_psr.c | 7 +++++++
 2 files changed, 13 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +6 -0
index 7830e6e..c9c1ccd 100644
@@ -6449,6 +6449,12 @@ enum {
 #define  BDW_DPRS_MASK_VBLANK_SRD	(1 << 0)
 #define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
 
+#define CHICKEN_TRANS_A         0x420c0
+#define CHICKEN_TRANS_B         0x420c4
+#define CHICKEN_TRANS(trans) _MMIO_TRANS(trans, CHICKEN_TRANS_A, CHICKEN_TRANS_B)
+#define PSR2_VSC_ENABLE_PROG_HEADER    (1<<12)
+#define PSR2_ADD_VERTICAL_LINE_COUNT   (1<<15)
+
 #define DISP_ARB_CTL	_MMIO(0x45000)
 #define  DISP_FBC_MEMORY_WAKE		(1<<31)
 #define  DISP_TILE_SURFACE_SWIZZLING	(1<<13)
drivers/gpu/drm/i915/intel_psr.c +3 -0
index 36c4045..935402e 100644
@@ -480,6 +480,9 @@ void intel_psr_enable(struct intel_dp *intel_dp)
 	struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
 	struct drm_device *dev = intel_dig_port->base.base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct intel_crtc *crtc = to_intel_crtc(intel_dig_port->base.base.crtc);
+	enum transcoder cpu_transcoder = crtc->config->cpu_transcoder;
+	u32 chicken;
 
 	if (!HAS_PSR(dev_priv)) {
 		DRM_DEBUG_KMS("PSR not supported on this platform\n");

drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 517

Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +4 -0
@@ -505,6 +508,10 @@ void intel_psr_enable(struct intel_dp *intel_dp)
 	if (HAS_DDI(dev_priv)) {
 		if (dev_priv->psr.psr2_support) {
 			skl_psr_setup_su_vsc(intel_dp);
+			chicken = PSR2_VSC_ENABLE_PROG_HEADER;
+			if (dev_priv->psr.y_cord_support)
+				chicken |= PSR2_ADD_VERTICAL_LINE_COUNT;
+			I915_WRITE(CHICKEN_TRANS(cpu_transcoder), chicken);
 		} else {
 			/* set up vsc header for psr1 */
 			hsw_psr_setup_vsc(intel_dp);

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

This and all the remaining patches on this series (6,7,8 and 9) got merged to dinq.

Thanks for the patches.

Quoted 84 lines · Rodrigo
Quoted 66 lines · vathsala nagaraju

As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence.
bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for

        PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable
        header packet.

bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit 15 if Y coordinate is supported

v2: (Rodrigo)
- move CHICKEN_TRANS_EDP bit set logic right after setup_vsc

v3:(Rodrigo)
- initialize chicken_trans to CHICKEN_TRANS_BIT12 instead of 0

v4:(chris wilson)
- use BIT(12), remove CHICKEN_TRANS_BIT12
- remove unnecessary comments
- update commit message

v5:
- rename bit 12 PSR2_VSC_ENABLE_PROG_HEADER
- rename bit 15 PSR2_ADD_VERTICAL_LINE_COUNT

v6:(Rodrigo)
- remove TRANS_EDP=3, use cpu_transcoder

---
 drivers/gpu/drm/i915/i915_reg.h  | 6 ++++++
 drivers/gpu/drm/i915/intel_psr.c | 7 +++++++
 2 files changed, 13 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +6 -0
index 7830e6e..c9c1ccd 100644
@@ -6449,6 +6449,12 @@ enum {
 #define  BDW_DPRS_MASK_VBLANK_SRD    (1 << 0)
 #define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
 
+#define CHICKEN_TRANS_A         0x420c0
+#define CHICKEN_TRANS_B         0x420c4
+#define CHICKEN_TRANS(trans) _MMIO_TRANS(trans, CHICKEN_TRANS_A, CHICKEN_TRANS_B)
+#define PSR2_VSC_ENABLE_PROG_HEADER    (1<<12)
+#define PSR2_ADD_VERTICAL_LINE_COUNT   (1<<15)
+
 #define DISP_ARB_CTL _MMIO(0x45000)
 #define  DISP_FBC_MEMORY_WAKE                (1<<31)
 #define  DISP_TILE_SURFACE_SWIZZLING (1<<13)
drivers/gpu/drm/i915/intel_psr.c +3 -0
index 36c4045..935402e 100644
@@ -480,6 +480,9 @@ void intel_psr_enable(struct intel_dp *intel_dp)
      struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
      struct drm_device *dev = intel_dig_port->base.base.dev;
      struct drm_i915_private *dev_priv = to_i915(dev);
+     struct intel_crtc *crtc = to_intel_crtc(intel_dig_port->base.base.crtc);
+     enum transcoder cpu_transcoder = crtc->config->cpu_transcoder;
+     u32 chicken;
 
      if (!HAS_PSR(dev_priv)) {
              DRM_DEBUG_KMS("PSR not supported on this platform\n");

drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 517

Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +4 -0
@@ -505,6 +508,10 @@ void intel_psr_enable(struct intel_dp *intel_dp)
      if (HAS_DDI(dev_priv)) {
              if (dev_priv->psr.psr2_support) {
                      skl_psr_setup_su_vsc(intel_dp);
+                     chicken = PSR2_VSC_ENABLE_PROG_HEADER;
+                     if (dev_priv->psr.y_cord_support)
+                             chicken |= PSR2_ADD_VERTICAL_LINE_COUNT;
+                     I915_WRITE(CHICKEN_TRANS(cpu_transcoder), chicken);
              } else {
                      /* set up vsc header for psr1 */
                      hsw_psr_setup_vsc(intel_dp);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer
#4 lore raw
Quoted 2 lines · Rodrigo Vivi

This and all the remaining patches on this series (6,7,8 and 9) got merged to dinq.

Given that this patch series was not properly sent as a thread, I don't think our CI ran it as a whole, and it should not have been pushed before that.

BR,
Jani.

Quoted 88 lines

Thanks for the patches.

Quoted 84 lines · Rodrigo
Quoted 66 lines · vathsala nagaraju

As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence.
bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for

        PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable
        header packet.

bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit 15 if Y coordinate is supported

v2: (Rodrigo)
- move CHICKEN_TRANS_EDP bit set logic right after setup_vsc

v3:(Rodrigo)
- initialize chicken_trans to CHICKEN_TRANS_BIT12 instead of 0

v4:(chris wilson)
- use BIT(12), remove CHICKEN_TRANS_BIT12
- remove unnecessary comments
- update commit message

v5:
- rename bit 12 PSR2_VSC_ENABLE_PROG_HEADER
- rename bit 15 PSR2_ADD_VERTICAL_LINE_COUNT

v6:(Rodrigo)
- remove TRANS_EDP=3, use cpu_transcoder

---
 drivers/gpu/drm/i915/i915_reg.h  | 6 ++++++
 drivers/gpu/drm/i915/intel_psr.c | 7 +++++++
 2 files changed, 13 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +6 -0
index 7830e6e..c9c1ccd 100644
@@ -6449,6 +6449,12 @@ enum {
 #define  BDW_DPRS_MASK_VBLANK_SRD    (1 << 0)
 #define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
 
+#define CHICKEN_TRANS_A         0x420c0
+#define CHICKEN_TRANS_B         0x420c4
+#define CHICKEN_TRANS(trans) _MMIO_TRANS(trans, CHICKEN_TRANS_A, CHICKEN_TRANS_B)
+#define PSR2_VSC_ENABLE_PROG_HEADER    (1<<12)
+#define PSR2_ADD_VERTICAL_LINE_COUNT   (1<<15)
+
 #define DISP_ARB_CTL _MMIO(0x45000)
 #define  DISP_FBC_MEMORY_WAKE                (1<<31)
 #define  DISP_TILE_SURFACE_SWIZZLING (1<<13)
drivers/gpu/drm/i915/intel_psr.c +3 -0
index 36c4045..935402e 100644
@@ -480,6 +480,9 @@ void intel_psr_enable(struct intel_dp *intel_dp)
      struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
      struct drm_device *dev = intel_dig_port->base.base.dev;
      struct drm_i915_private *dev_priv = to_i915(dev);
+     struct intel_crtc *crtc = to_intel_crtc(intel_dig_port->base.base.crtc);
+     enum transcoder cpu_transcoder = crtc->config->cpu_transcoder;
+     u32 chicken;
 
      if (!HAS_PSR(dev_priv)) {
              DRM_DEBUG_KMS("PSR not supported on this platform\n");

drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 517

Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +4 -0
@@ -505,6 +508,10 @@ void intel_psr_enable(struct intel_dp *intel_dp)
      if (HAS_DDI(dev_priv)) {
              if (dev_priv->psr.psr2_support) {
                      skl_psr_setup_su_vsc(intel_dp);
+                     chicken = PSR2_VSC_ENABLE_PROG_HEADER;
+                     if (dev_priv->psr.y_cord_support)
+                             chicken |= PSR2_ADD_VERTICAL_LINE_COUNT;
+                     I915_WRITE(CHICKEN_TRANS(cpu_transcoder), chicken);
              } else {
                      /* set up vsc header for psr1 */
                      hsw_psr_setup_vsc(intel_dp);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw
Quoted 7 lines · Jani Nikula
Quoted 2 lines · Rodrigo Vivi

This and all the remaining patches on this series (6,7,8 and 9) got merged to dinq.

Given that this patch series was not properly sent as a thread, I don't think our CI ran it as a whole, and it should not have been pushed before that.

I assumed "[Intel-gfx] ✓ Fi.CI.BAT: success for enable psr2 for idle_screen on y-cordinate panel"
was enough, giving the patches haven't drastically changed after.

Quoted 95 lines

BR,
Jani.

Quoted 88 lines

Thanks for the patches.

Quoted 84 lines · Rodrigo
Quoted 66 lines · vathsala nagaraju

As per bpsec, CHICKEN_TRANS_EDP bit 12 ,15 must be programmed in psr2 enable sequence.
bit 12 : Program Transcoder EDP VSC DIP header with a valid setting for

        PSR2 and Set CHICKEN_TRANS_EDP(0x420cc) bit 12 for programmable
        header packet.

bit 15 : Set CHICKEN_TRANS_EDP(0x420cc) bit 15 if Y coordinate is supported

v2: (Rodrigo)
- move CHICKEN_TRANS_EDP bit set logic right after setup_vsc

v3:(Rodrigo)
- initialize chicken_trans to CHICKEN_TRANS_BIT12 instead of 0

v4:(chris wilson)
- use BIT(12), remove CHICKEN_TRANS_BIT12
- remove unnecessary comments
- update commit message

v5:
- rename bit 12 PSR2_VSC_ENABLE_PROG_HEADER
- rename bit 15 PSR2_ADD_VERTICAL_LINE_COUNT

v6:(Rodrigo)
- remove TRANS_EDP=3, use cpu_transcoder

---
 drivers/gpu/drm/i915/i915_reg.h  | 6 ++++++
 drivers/gpu/drm/i915/intel_psr.c | 7 +++++++
 2 files changed, 13 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +6 -0
index 7830e6e..c9c1ccd 100644
@@ -6449,6 +6449,12 @@ enum {
 #define  BDW_DPRS_MASK_VBLANK_SRD    (1 << 0)
 #define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
 
+#define CHICKEN_TRANS_A         0x420c0
+#define CHICKEN_TRANS_B         0x420c4
+#define CHICKEN_TRANS(trans) _MMIO_TRANS(trans, CHICKEN_TRANS_A, CHICKEN_TRANS_B)
+#define PSR2_VSC_ENABLE_PROG_HEADER    (1<<12)
+#define PSR2_ADD_VERTICAL_LINE_COUNT   (1<<15)
+
 #define DISP_ARB_CTL _MMIO(0x45000)
 #define  DISP_FBC_MEMORY_WAKE                (1<<31)
 #define  DISP_TILE_SURFACE_SWIZZLING (1<<13)
drivers/gpu/drm/i915/intel_psr.c +3 -0
index 36c4045..935402e 100644
@@ -480,6 +480,9 @@ void intel_psr_enable(struct intel_dp *intel_dp)
      struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
      struct drm_device *dev = intel_dig_port->base.base.dev;
      struct drm_i915_private *dev_priv = to_i915(dev);
+     struct intel_crtc *crtc = to_intel_crtc(intel_dig_port->base.base.crtc);
+     enum transcoder cpu_transcoder = crtc->config->cpu_transcoder;
+     u32 chicken;
 
      if (!HAS_PSR(dev_priv)) {
              DRM_DEBUG_KMS("PSR not supported on this platform\n");

drivers/gpu/drm/i915/intel_psr.c void intel_psr_enable(struct intel_dp *intel_dp) · line 517

Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +4 -0
@@ -505,6 +508,10 @@ void intel_psr_enable(struct intel_dp *intel_dp)
      if (HAS_DDI(dev_priv)) {
              if (dev_priv->psr.psr2_support) {
                      skl_psr_setup_su_vsc(intel_dp);
+                     chicken = PSR2_VSC_ENABLE_PROG_HEADER;
+                     if (dev_priv->psr.y_cord_support)
+                             chicken |= PSR2_ADD_VERTICAL_LINE_COUNT;
+                     I915_WRITE(CHICKEN_TRANS(cpu_transcoder), chicken);
              } else {
                      /* set up vsc header for psr1 */
                      hsw_psr_setup_vsc(intel_dp);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#6 lore raw
Quoted 6 lines · Rodrigo Vivi
Quoted 4 lines · Jani Nikula
Quoted 2 lines · Rodrigo Vivi

This and all the remaining patches on this series (6,7,8 and 9) got merged to dinq.

Quoted 7 lines
Quoted 3 lines

Given that this patch series was not properly sent as a thread, I don't think our CI ran it as a whole, and it should not have been pushed before that.

I assumed "[Intel-gfx] ✓ Fi.CI.BAT: success for enable psr2 for idle_screen on y-cordinate panel"
was enough, giving the patches haven't drastically changed after.

The idea is to test the code that gets pushed...

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer
#7 lore raw
Quoted 11 lines · Jani Nikula
Quoted 10 lines · Rodrigo Vivi
Quoted 7 lines · Jani Nikula
Quoted 2 lines · Rodrigo Vivi

This and all the remaining patches on this series (6,7,8 and 9) got merged to dinq.

Given that this patch series was not properly sent as a thread, I don't think our CI ran it as a whole, and it should not have been pushed before that.

Quoted 5 lines
Quoted 3 lines

I assumed "[Intel-gfx] ✓ Fi.CI.BAT: success for enable psr2 for idle_screen on y-cordinate panel"
was enough, giving the patches haven't drastically changed after.

The idea is to test the code that gets pushed...

Yep, this makes sense, although I'm sure that BAT doesn't test any of the code touched...
But this is another problem.

Anyway, that won't happen again. But question:
should it be resent to mailing list or try-bot is fine?

Quoted 5 lines

BR,
Jani.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#8 lore raw
Quoted 12 lines · Rodrigo
Quoted 11 lines · Jani Nikula
Quoted 10 lines · Rodrigo Vivi
Quoted 7 lines · Jani Nikula
Quoted 2 lines · Rodrigo Vivi

This and all the remaining patches on this series (6,7,8 and 9) got merged to dinq.

Given that this patch series was not properly sent as a thread, I don't think our CI ran it as a whole, and it should not have been pushed before that.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I assumed "[Intel-gfx] ✓ Fi.CI.BAT: success for enable psr2 for idle_screen on y-cordinate panel"
was enough, giving the patches haven't drastically changed after.

The idea is to test the code that gets pushed...

Yep, this makes sense, although I'm sure that BAT doesn't test any of the code touched...

Perhaps so. But the point of CI is more about ensuring you don't break existing stuff and less about testing the stuff you submit.

Quoted 4 lines

But this is another problem.

Anyway, that won't happen again. But question:
should it be resent to mailing list or try-bot is fine?

Ideally we should test the patches that get pushed and push the patches that were posted on the list. For transparency, our CI replies with results to the series that were posted on the (intel-gfx) mailing list, and we add a Link: tag back to the patches in the commit message. They all tie in together.

Trybot tests patches that were posted to it privately, and if you apply the patches that were tested by trybot, you apply patches that weren't posted on the list. Or you apply patches that weren't tested.

I'd prefer the patches were posted both for testing and pushing.

BR,
Jani.

Quoted 7 lines
Quoted 6 lines

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel