Skip to contentSkip to conversation

xserver-xorg: Enable glamor by default

PATCH Superseded Saul Wold 3 participants 3 messages Jan 12, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 xserver-xorg: Enable glamor by default

To enable glamor, we need to also enable both dri3 and xshmfence as dependencies.

---
 meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +1 -0
index 6a13380..16d9747 100644
@@ -122,6 +122,7 @@ EXTRA_OECONF += "--with-fop=no \
 EXTRA_OECONF[vardepsexclude] = "MACHINE"
 
 PACKAGECONFIG ??= "dri2 udev ${XORG_CRYPTO} \
+                   xshmfence dri3 glamor \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'dri glx', '', d)} \
                    ${@bb.utils.contains("DISTRO_FEATURES", "wayland", "xwayland", "", d)} \
                    ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "systemd", "", d)} \
Signature · 1 line
2.7.4
#1 lore raw
Quoted 12 lines · Saul Wold

To enable glamor, we need to also enable both dri3 and xshmfence as dependencies.

---
 meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +0 -0
index 6a13380..16d9747 100644

meta/recipes-graphics/xorg-xserver/xserver-xorg.inc EXTRA_OECONF += "--with-fop=no \ · line 128

Quoted 7 lines
meta/recipes-graphics/xorg-xserver/xserver-xorg.inc +1 -0
@@ -122,6 +122,7 @@ EXTRA_OECONF += "--with-fop=no \
 EXTRA_OECONF[vardepsexclude] = "MACHINE"
 
 PACKAGECONFIG ??= "dri2 udev ${XORG_CRYPTO} \
+                   xshmfence dri3 glamor \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'dri glx', '', d)} \
                    ${@bb.utils.contains("DISTRO_FEATURES", "wayland", "xwayland", "", d)} \
                    ${@bb.utils.contains("DISTRO_FEATURES", "systemd", "systemd", "", d)} \

I fully agree with this change, and I am definitely willing to have glamor enabled by default (I even thought I had sent that patch already..)

however i think you need it done this way:

${@bb.utils.contains('DISTRO_FEATURES', 'opengl', ' dri3 xshmfence glamor', '', d)}"

Quoted 8 lines

--
2.7.4

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 3 lines · Nicolas Dechesne

${@bb.utils.contains('DISTRO_FEATURES', 'opengl', ' dri3 xshmfence glamor', '', d)}"

Yes, glamor is obviously triggered by opengl.

Ross