drm/i915/huc: Support HuC authentication
Subsystems (2)
PATCH 1/1 drm/i915/huc: Support HuC authentication
From: Peter Antoine <[email protected]>
The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication.
v2: rebased on top of drm-intel-nightly.
changed name format and upped version 1.7.
v3: rebased on top of drm-intel-nightly.
v4: changed wait_for_automic to wait_for
v5: rebased.
v7: rebased.
v8: rebased.
v9: rebased. Rename intel_huc_auh() to intel_guc_auth_huc() and place the prototype in intel_guc.h,correct the comments.
v10: rebased.
v11: rebased.
v12: rebased on top of drm-tip
v13: rebased. Moved intel_guc_auth_huc from i915_guc_submission.c to intel_uc.c.Update dev to dev_priv in intel_guc_auth_huc(). Renamed HOST2GUC_ACTION_AUTHENTICATE_HUC TO INTEL_GUC_ACTION_ AUTHENTICATE_HUC
v14: rebased.
v15: rebased. Add newline on DRM_ERRORs that already dont have one.
v16: rebased. Replace wait_for with intel_wait_for_register() since the latter employs sleep optimisations for quick responses- as pointed out by Chris Wilson.
v17: rebased. Cleanup the intel_guc_auth_huc() by removing checks already performed in earlier functions. Make comments more descriptive.
v18: rebased. Changed the bias for pinning the HuC object.Add return values with errors.
--- drivers/gpu/drm/i915/intel_guc_fwif.h | 1 + drivers/gpu/drm/i915/intel_guc_loader.c | 2 ++ drivers/gpu/drm/i915/intel_uc.c | 55 ++++++++++++++++++++++++++++++++- drivers/gpu/drm/i915/intel_uc.h | 1 + 4 files changed, 58 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_guc_fwif.h +1 -0
@@ -505,6 +505,7 @@ enum intel_guc_action {INTEL_GUC_ACTION_ENTER_S_STATE =0x501 ,INTEL_GUC_ACTION_EXIT_S_STATE =0x502 ,INTEL_GUC_ACTION_SLPC_REQUEST =0x3003 , +INTEL_GUC_ACTION_AUTHENTICATE_HUC =0x4000 ,INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING =0x0E000 , INTEL_GUC_ACTION_LIMIT };
drivers/gpu/drm/i915/intel_guc_loader.c +2 -0
@@ -530,6 +530,8 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)intel_uc_fw_status_repr (guc_fw->fetch_status), intel_uc_fw_status_repr(guc_fw->load_status)); +intel_guc_auth_huc (dev_priv); +if (i915.enable_guc_submission) {if (i915.guc_log_level >=0 )gen9_enable_guc_interrupts (dev_priv);
drivers/gpu/drm/i915/intel_uc.c +54 -1
64 lines not on this page · raw message
drivers/gpu/drm/i915/intel_uc.h +1 -0
@@ -190,6 +190,7 @@ int intel_guc_sample_forcewake(struct intel_guc *guc);int intel_guc_log_flush_complete (struct intel_guc *guc);int intel_guc_log_flush (struct intel_guc *guc);int intel_guc_log_control (struct intel_guc *guc,u32 control_val); +void intel_guc_auth_huc (struct drm_i915_private *dev_priv);/* intel_guc_loader.c */ extern void intel_guc_init (struct drm_i915_private *dev_priv);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 75 lines · Anusha Srivatsa
From: Peter Antoine <[email protected]>
The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication.
v2: rebased on top of drm-intel-nightly.
changed name format and upped version 1.7.
v3: rebased on top of drm-intel-nightly.
v4: changedwait_for_automictowait_for
v5: rebased.
v7: rebased.
v8: rebased.
v9: rebased. Renameintel_huc_auh()tointel_guc_auth_huc()and place the prototype in intel_guc.h,correct the comments.
v10: rebased.
v11: rebased.
v12: rebased on top of drm-tip
v13: rebased. Movedintel_guc_auth_hucfromi915_guc_submission.cto intel_uc.c.Update dev todev_privinintel_guc_auth_huc(). RenamedHOST2GUC_ACTION_AUTHENTICATE_HUCTOINTEL_GUC_ACTION_AUTHENTICATE_HUC
v14: rebased.
v15: rebased. Add newline onDRM_ERRORsthat already dont have one.
v16: rebased. Replacewait_forwithintel_wait_for_register()since the latter employs sleep optimisations for quick responses- as pointed out by Chris Wilson.
v17: rebased. Cleanup theintel_guc_auth_huc()by removing checks already performed in earlier functions. Make comments more descriptive.
v18: rebased. Changed the bias for pinning the HuC object.Add return values with errors.Cc Chris Wilson <[email protected]>Cc Arkadiusz Hiler <[email protected]>Cc Michal Wajdeczko <[email protected]>Tested-by Xiang Haihao <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Alex Dai <[email protected]>Signed-off-by Peter Antoine <[email protected]>--- drivers/gpu/drm/i915/intel_guc_fwif.h | 1 + drivers/gpu/drm/i915/intel_guc_loader.c | 2 ++ drivers/gpu/drm/i915/intel_uc.c | 55 ++++++++++++++++++++++++++++++++- drivers/gpu/drm/i915/intel_uc.h | 1 + 4 files changed, 58 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_guc_fwif.h +1
-0@@ -505,6 +505,7 @@ enum intel_guc_action {INTEL_GUC_ACTION_ENTER_S_STATE =0x501 ,INTEL_GUC_ACTION_EXIT_S_STATE =0x502 ,INTEL_GUC_ACTION_SLPC_REQUEST =0x3003 , +INTEL_GUC_ACTION_AUTHENTICATE_HUC =0x4000 ,INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING =0x0E000 , INTEL_GUC_ACTION_LIMIT };drivers/gpu/drm/i915/intel_guc_loader.c +2
-0@@ -530,6 +530,8 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)intel_uc_fw_status_repr (guc_fw->fetch_status), intel_uc_fw_status_repr(guc_fw->load_status)); +intel_guc_auth_huc (dev_priv); +if (i915.enable_guc_submission) {if (i915.guc_log_level >=0 )gen9_enable_guc_interrupts (dev_priv);drivers/gpu/drm/i915/intel_uc.c +0
-0
drivers/gpu/drm/i915/intel_uc.c static bool intel_guc_recv(struct intel_guc *guc, u32 *status) · line 49
Quoted 4 lines
drivers/gpu/drm/i915/intel_uc.c +0
-1@@ -46,7 +46,6 @@ static bool intel_guc_recv(struct intel_guc *guc, u32 *status)int intel_guc_send (struct intel_guc *guc,const u32 *action,u32 len) {struct drm_i915_private *dev_priv =guc_to_i915 (guc); -u32 status;
Why have you removed this variable? It won't even compile.
Cheers,
Arek
drivers/gpu/drm/i915/intel_uc.c int intel_guc_log_control(struct intel_guc *guc, u32 control_val) · line 141
Quoted 7 lines
drivers/gpu/drm/i915/intel_uc.c +0
-0int i;int ret;@@ -140,3 +139,57 @@ int intel_guc_log_control(struct intel_guc *guc, u32 control_val)return intel_guc_send (guc, action,ARRAY_SIZE (action)); }
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx