Skip to contentSkip to conversation

Patch "arm64: hugetlb: fix the wrong return value for huge_ptep_set_access_flags" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jan 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

arm64: hugetlb: fix the wrong return value for huge_ptep_set_access_flags

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arm64-hugetlb-fix-the-wrong-return-value-for-huge_ptep_set_access_flags.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 69d012345a1a32d3f03957f14d972efccc106a98 Mon Sep 17 00:00:00 2001

From: Huang Shijie <[email protected]>
Date: Wed, 11 Jan 2017 14:02:00 +0800
Subject: arm64: hugetlb: fix the wrong return value for huge_ptep_set_access_flags

From: Huang Shijie <[email protected]>

commit 69d012345a1a32d3f03957f14d972efccc106a98 upstream.

In current code, the @changed always returns the last one's status for the huge page with the contiguous bit set. This is really not what we want. Even one of the PTEs is changed, we should tell it to the caller.

This patch fixes this issue.

Fixes 66b3923a1a0f ("arm64: hugetlb: add support for PTE contiguous bit")
---
 arch/arm64/mm/hugetlbpage.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/mm/hugetlbpage.c +1 -1
@@ -239,7 +239,7 @@ int huge_ptep_set_access_flags(struct vm
 		ncontig = find_num_contig(vma->vm_mm, addr, cpte,
 					  *cpte, &pgsize);
 		for (i = 0; i < ncontig; ++i, ++cpte, addr += pgsize) {
-			changed = ptep_set_access_flags(vma, addr, cpte,
+			changed |= ptep_set_access_flags(vma, addr, cpte,
 							pfn_pte(pfn,
 								hugeprot),
 							dirty);

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/arm64-hugetlb-fix-the-wrong-address-for-several-functions.patch queue-4.9/arm64-hugetlb-remove-the-wrong-pmd-check-in-find_num_contig.patch queue-4.9/arm64-hugetlb-fix-the-wrong-return-value-for-huge_ptep_set_access_flags.patch