Patch "pinctrl: sh-pfc: Do not unconditionally support PIN_CONFIG_BIAS_DISABLE" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
pinctrl: sh-pfc: Do not unconditionally support PIN_CONFIG_BIAS_DISABLE
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pinctrl-sh-pfc-do-not-unconditionally-support-pin_config_bias_disable.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
5d7400c4acbf7fe633a976a89ee845f7333de3e4Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niklas=20S=C3=B6derlund?=
<[email protected]>
Date: Sat, 12 Nov 2016 17:04:24 +0100
Subject: pinctrl: sh-pfc: Do not unconditionally support PIN_CONFIG_BIAS_DISABLE
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Niklas Söderlund <[email protected]>
commit 5d7400c4acbf7fe633a976a89ee845f7333de3e4 upstream.
Always stating PIN_CONFIG_BIAS_DISABLE is supported gives untrue output when examining /sys/kernel/debug/pinctrl/e6060000.pfc/pinconf-pins if the operation get_bias() is implemented but the pin is not handled by the get_bias() implementation. In that case the output will state that "input bias disabled" indicating that this pin has bias control support.
Make support for PIN_CONFIG_BIAS_DISABLE depend on that the pin either supports SH_PFC_PIN_CFG_PULL_UP or SH_PFC_PIN_CFG_PULL_DOWN. This also solves the issue where SoC specific implementations print error messages if their particular implementation of {set,get}_bias() is called with a pin it does not know about.
--- drivers/pinctrl/sh-pfc/pinctrl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/pinctrl/sh-pfc/pinctrl.c +2 -1
@@ -570,7 +570,8 @@ static bool sh_pfc_pinconf_validate(struswitch (param) {case PIN_CONFIG_BIAS_DISABLE : -return true; +return pin->configs & + (SH_PFC_PIN_CFG_PULL_UP |SH_PFC_PIN_CFG_PULL_DOWN );case PIN_CONFIG_BIAS_PULL_UP :return pin->configs &SH_PFC_PIN_CFG_PULL_UP ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/pinctrl-sh-pfc-do-not-unconditionally-support-pin_config_bias_disable.patch queue-4.9/pinctrl-sh-pfc-add-helper-to-handle-bias-lookup-table.patch queue-4.9/pinctrl-sh-pfc-r8a7795-use-lookup-function-for-bias-data.patch