ASoC: arizona: Propagate errors from arizona_spk_init
Subsystems (5)
PATCH 1/1 ASoC: arizona: Propagate errors from arizona_spk_init
arizona_spk_init uses snd_soc_dapm_new_control which since commit 37e1df8c95e2 ("ASoC: dapm: handle probe deferrals") will occasionally request a probe deferral. Which means we should propagate the error out of our driver from it.
--- sound/soc/codecs/cs47l24.c | 5 ++++- sound/soc/codecs/wm5102.c | 5 ++++- sound/soc/codecs/wm5110.c | 5 ++++- sound/soc/codecs/wm8997.c | 6 +++++- sound/soc/codecs/wm8998.c | 6 +++++- 5 files changed, 22 insertions(+), 5 deletions(-)
sound/soc/codecs/cs47l24.c +4 -1
@@ -1124,7 +1124,10 @@ static int cs47l24_codec_probe(struct snd_soc_codec *codec) priv->core.arizona->dapm = dapm; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_mono (codec);arizona_init_notifiers (codec);
sound/soc/codecs/wm5102.c +4 -1
@@ -1946,7 +1946,10 @@ static int wm5102_codec_probe(struct snd_soc_codec *codec)if (ret) goto err_adsp2_codec_probe; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_notifiers (codec);
sound/soc/codecs/wm5110.c +4 -1
@@ -2284,7 +2284,10 @@ static int wm5110_codec_probe(struct snd_soc_codec *codec) priv->core.arizona->dapm = dapm; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_mono (codec);arizona_init_notifiers (codec);
sound/soc/codecs/wm8997.c +5 -1
@@ -1062,8 +1062,12 @@ static int wm8997_codec_probe(struct snd_soc_codec *codec)struct snd_soc_dapm_context *dapm =snd_soc_codec_get_dapm (codec);struct snd_soc_component *component =snd_soc_dapm_to_component (dapm);struct wm8997_priv *priv =snd_soc_codec_get_drvdata (codec); +int ret; + + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; -arizona_init_spk (codec);arizona_init_notifiers (codec);snd_soc_component_disable_pin (component,"HAPTICS" );
sound/soc/codecs/wm8998.c +5 -1
@@ -1321,10 +1321,14 @@ static int wm8998_codec_probe(struct snd_soc_codec *codec)struct wm8998_priv *priv =snd_soc_codec_get_drvdata (codec);struct snd_soc_dapm_context *dapm =snd_soc_codec_get_dapm (codec);struct snd_soc_component *component =snd_soc_dapm_to_component (dapm); +int ret; priv->core.arizona->dapm = dapm; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_notifiers (codec);
Signature · 1 line
2.1.4
Mark Brown
maintainerApplied "ASoC: arizona: Propagate errors from arizona_spk_init" to the asoc tree
The patch
ASoC: arizona: Propagate errors from arizona_spk_init
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
acff07d060d8175b2b54c5bc2d9bb910a6db1049Mon Sep 17 00:00:00 2001
From: Charles Keepax <[email protected]>
Date: Wed, 18 Jan 2017 15:27:05 +0000
Subject: [PATCH] ASoC: arizona: Propagate errors from arizona_spk_init
arizona_spk_init uses snd_soc_dapm_new_control which since commit 37e1df8c95e2 ("ASoC: dapm: handle probe deferrals") will occasionally request a probe deferral. Which means we should propagate the error out of our driver from it.
--- sound/soc/codecs/cs47l24.c | 5 ++++- sound/soc/codecs/wm5102.c | 5 ++++- sound/soc/codecs/wm5110.c | 5 ++++- sound/soc/codecs/wm8997.c | 6 +++++- sound/soc/codecs/wm8998.c | 6 +++++- 5 files changed, 22 insertions(+), 5 deletions(-)
sound/soc/codecs/cs47l24.c +4 -1
@@ -1121,7 +1121,10 @@ static int cs47l24_codec_probe(struct snd_soc_codec *codec) priv->core.arizona->dapm = dapm; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_mono (codec);arizona_init_notifiers (codec);
sound/soc/codecs/wm5102.c +4 -1
@@ -1944,7 +1944,10 @@ static int wm5102_codec_probe(struct snd_soc_codec *codec)if (ret) goto err_adsp2_codec_probe; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_notifiers (codec);
sound/soc/codecs/wm5110.c +4 -1
@@ -2279,7 +2279,10 @@ static int wm5110_codec_probe(struct snd_soc_codec *codec) priv->core.arizona->dapm = dapm; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_mono (codec);arizona_init_notifiers (codec);
sound/soc/codecs/wm8997.c +5 -1
@@ -1062,8 +1062,12 @@ static int wm8997_codec_probe(struct snd_soc_codec *codec)struct snd_soc_dapm_context *dapm =snd_soc_codec_get_dapm (codec);struct snd_soc_component *component =snd_soc_dapm_to_component (dapm);struct wm8997_priv *priv =snd_soc_codec_get_drvdata (codec); +int ret; + + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; -arizona_init_spk (codec);arizona_init_notifiers (codec);snd_soc_component_disable_pin (component,"HAPTICS" );
sound/soc/codecs/wm8998.c +5 -1
@@ -1321,10 +1321,14 @@ static int wm8998_codec_probe(struct snd_soc_codec *codec)struct wm8998_priv *priv =snd_soc_codec_get_drvdata (codec);struct snd_soc_dapm_context *dapm =snd_soc_codec_get_dapm (codec);struct snd_soc_component *component =snd_soc_dapm_to_component (dapm); +int ret; priv->core.arizona->dapm = dapm; -arizona_init_spk (codec); + ret =arizona_init_spk (codec); +if (ret <0 ) +return ret; +arizona_init_gpio (codec);arizona_init_notifiers (codec);
Signature · 1 line
2.11.0