Skip to contentSkip to conversation

2.4.0-pre10: svclock: missing unlock_kernel()

PATCH Trond Myklebust 1 participant 1 message Nov 1, 2000

lore
Share & tools
lore
#0 lore raw

Linus,

I missed a conditional return in nlmsvc_notify_blocked() when we
should be releasing the BKL. Thanks to Jim Castleberry for pointing it out.

Please note, however, that there remain serious bugs in 2.4.0-pre10
fs/locks.c w.r.t. notification of the filesystem/lockd that need to be fixed before the 2.4.0 release.

Cheers,
Trond

lockd/svclock.c renamed from lockd/svclock.c.orig +1 -0
@@ -473,6 +473,7 @@
 		if (nlm_compare_locks(&block->b_call.a_args.lock.fl, fl)) {
 			nlmsvc_insert_block(block, 0);
 			svc_wake_up(block->b_daemon);
+			unlock_kernel();
 			return;
 		}
 	}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
Please read the FAQ at http://www.tux.org/lkml/