Skip to contentSkip to conversation

Patch "mtd: nand: lpc32xx: fix invalid error handling of a requested irq" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Jan 23, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mtd: nand: lpc32xx: fix invalid error handling of a requested irq

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mtd-nand-lpc32xx-fix-invalid-error-handling-of-a-requested-irq.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cf9e1672a66c49ed8903c01b4c380a2f2dc91b40 Mon Sep 17 00:00:00 2001

From: Vladimir Zapolskiy <[email protected]>
Date: Mon, 5 Dec 2016 03:47:10 +0200
Subject: mtd: nand: lpc32xx: fix invalid error handling of a requested irq

From: Vladimir Zapolskiy <[email protected]>

commit cf9e1672a66c49ed8903c01b4c380a2f2dc91b40 upstream.

Semantics of NR_IRQS is different on machines with SPARSE_IRQ option disabled or enabled, in the latter case IRQs are allocated starting at least from the value specified by NR_IRQS and going upwards, so the check of (irq >= NR_IRQ) to decide about an error code returned by platform_get_irq() is completely invalid, don't attempt to overrule irq subsystem in the driver.

The change fixes LPC32xx NAND MLC driver initialization on boot.

Fixes 8cb17b5ed017 ("irqchip: Add LPC32xx interrupt controller driver")
---
 drivers/mtd/nand/lpc32xx_mlc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/lpc32xx_mlc.c +1 -1
@@ -776,7 +776,7 @@ static int lpc32xx_nand_probe(struct pla
 	init_completion(&host->comp_controller);
 
 	host->irq = platform_get_irq(pdev, 0);
-	if ((host->irq < 0) || (host->irq >= NR_IRQS)) {
+	if (host->irq < 0) {
 		dev_err(&pdev->dev, "failed to get platform irq\n");
 		res = -EINVAL;
 		goto err_exit3;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/mtd-nand-lpc32xx-fix-invalid-error-handling-of-a-requested-irq.patch queue-4.9/arm-dts-imx31-fix-clock-control-module-interrupts-description.patch queue-4.9/arm-dts-imx31-move-ccm-device-node-to-aips2-bus-devices.patch