Patch "[media] st-hva: fix some error handling in hva_hw_probe()" has been added to the 4.9-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
[media] st-hva: fix some error handling in hva_hw_probe()
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
st-hva-fix-some-error-handling-in-hva_hw_probe.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
6b2bed891253c08e7f4c17dbd46b71fc87f22eefMon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Fri, 14 Oct 2016 04:32:24 -0300
Subject: [media] st-hva: fix some error handling in hva_hw_probe()
From: Dan Carpenter <[email protected]>
commit 6b2bed891253c08e7f4c17dbd46b71fc87f22eef upstream.
The devm_ioremap_resource() returns error pointers, never NULL. The platform_get_resource() returns NULL on error, never error pointers. The error code needs to be set, as well. The current code returns PTR_ERR(NULL) which is success.
--- drivers/media/platform/sti/hva/hva-hw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/platform/sti/hva/hva-hw.c +3 -3
@@ -305,16 +305,16 @@ int hva_hw_probe(struct platform_device/* get memory for registers */ regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); hva->regs =devm_ioremap_resource (dev, regs); -if (IS_ERR_OR_NULL (hva->regs)) { +if (IS_ERR (hva->regs)) {dev_err (dev,"%s failed to get regs\n" ,HVA_PREFIX );return PTR_ERR (hva->regs); }/* get memory for esram */ esram =platform_get_resource (pdev,IORESOURCE_MEM ,1 ); -if (IS_ERR_OR_NULL (esram)) { +if (!esram) {dev_err (dev,"%s failed to get esram\n" ,HVA_PREFIX ); -return PTR_ERR (esram); +return -ENODEV ; } hva->esram_addr = esram->start; hva->esram_size =resource_size (esram);
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/st-hva-fix-some-error-handling-in-hva_hw_probe.patch queue-4.9/mtd-spi-nor-fix-some-error-codes-in-cqspi_setup_flash.patch queue-4.9/blackfin-check-devm_pinctrl_get-for-errors.patch queue-4.9/mtd-spi-nor-off-by-one-in-cqspi_setup_flash.patch queue-4.9/ieee802154-atusb-do-not-use-the-stack-for-buffers-to-make-them-dma-able.patch