Skip to contentSkip to conversation

Patch "[media] ite-cir: initialize use_demodulator before using it" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Jan 23, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

[media] ite-cir: initialize use_demodulator before using it

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ite-cir-initialize-use_demodulator-before-using-it.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7ec03e60ef81c19b5d3a46dd070ee966774b860f Mon Sep 17 00:00:00 2001

From: Nicolas Iooss <[email protected]>
Date: Sat, 10 Sep 2016 13:59:49 -0300
Subject: [media] ite-cir: initialize use_demodulator before using it

From: Nicolas Iooss <[email protected]>

commit 7ec03e60ef81c19b5d3a46dd070ee966774b860f upstream.

Function ite_set_carrier_params() uses variable use_demodulator after having initialized it to false in some if branches, but this variable is never set to true otherwise.

This bug has been found using clang -Wsometimes-uninitialized warning flag.

Fixes 620a32bba4a2 ("[media] rc: New rc-based ite-cir driver for

several ITE CIRs")

---
 drivers/media/rc/ite-cir.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/media/rc/ite-cir.c +2 -0
@@ -263,6 +263,8 @@ static void ite_set_carrier_params(struc
 
 			if (allowance > ITE_RXDCR_MAX)
 				allowance = ITE_RXDCR_MAX;
+
+			use_demodulator = true;
 		}
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ite-cir-initialize-use_demodulator-before-using-it.patch