Skip to contentSkip to conversation

qt3d: Add assimp dependency

PATCH In review Tom Hochstein 3 participants 6 messages Jan 28, 2017 – Feb 9, 2017

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 qt3d: Add assimp dependency

Fix build error:

fatal error: assimp/Importer.hpp: No such file or directory

---
 recipes-qt/qt5/qt3d_git.bb | 1 +
 1 file changed, 1 insertion(+)
recipes-qt/qt5/qt3d_git.bb +1 -0
index 2276c36..7c31213 100644
@@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG_class-native ??= "tools-only"
 PACKAGECONFIG_class-nativesdk ??= "tools-only"
 PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
+PACKAGECONFIG[assimp] = ",,assimp"
 
 EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Tom Hochstein

Fix build error:

fatal error: assimp/Importer.hpp: No such file or directory

I'm was able to build qt3d without this dependency, is there something in your config which enabled it? Or is it autodetected from sysroot which wont be an issue anymore with master and RSS, but your change doesn't fix the autodetection for older branches.

Quoted 25 lines
---
 recipes-qt/qt5/qt3d_git.bb | 1 +
 1 file changed, 1 insertion(+)
recipes-qt/qt5/qt3d_git.bb +1 -0
index 2276c36..7c31213 100644
@@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG_class-native ??= "tools-only"
 PACKAGECONFIG_class-nativesdk ??= "tools-only"
 PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
+PACKAGECONFIG[assimp] = ",,assimp"
 
 EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
 
Signature · 7 lines
1.9.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Martin Jansa
Sent: Tuesday, February 07, 2017 6:01 AM
To: [email protected]
Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency

On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:

Quoted 8 lines
Quoted 3 lines

Fix build error:

fatal error: assimp/Importer.hpp: No such file or directory

I'm was able to build qt3d without this dependency, is there something in your config which enabled it? Or is it autodetected from sysroot which wont be an issue anymore with master and RSS, but your change doesn't fix the autodetection for older branches.

We do enable assimp from another recipe.

I am unable to reproduce the original problem either.

Without the explicit dependency, it would seem that the build would at best be non-deterministic, enabling or disabling assimp support based solely on the timing of the Yocto tasks. I'm not aware of the technologies you allude to. Do they provide some determinism for this case?

Quoted 33 lines
Quoted 21 lines
---
 recipes-qt/qt5/qt3d_git.bb | 1 +
 1 file changed, 1 insertion(+)
recipes-qt/qt5/qt3d_git.bb +1 -1
index 2276c36..7c31213 100644
@@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG_class-native ??= "tools-only"
 PACKAGECONFIG_class-nativesdk ??= "tools-only"
 PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
+PACKAGECONFIG[assimp] = ",,assimp"
 
 EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
 
--

1.9.1

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]

https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
d- devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635 %7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0

--
Martin 'JaMa' Jansa jabber: [email protected]

#3 lore raw

RSS:
http://git.openembedded.org/openembedded-core/commit/?id=809746f56df4b91af014bf6a3f28997d6698ac78
http://lists.openembedded.org/pipermail/openembedded-architecture/2017-January/000384.html
and following threads

For morty and older releases you need to disable autodetection in qt3d sources when the assimp PACKAGECONFIG is not enabled (see PACKAGECONFIG in other recipes for some examples how to do it - but for qt5 it's often tricky as it rarely has enable/disable options usable in configure and has to be patched).

Otherwise assimp can still be detected when it's built as a dependency of some other recipe and might be removed from sysroot while qt3d build is already running and causing the issues you were trying to fix.

Quoted 70 lines · Tom Hochstein
Quoted 4 lines

-----Original Message-----
From: [email protected] [mailto:

[email protected]] On

Quoted 6 lines

Behalf Of Martin Jansa
Sent: Tuesday, February 07, 2017 6:01 AM
To: [email protected]
Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency

On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:

Quoted 8 lines
Quoted 3 lines

Fix build error:

fatal error: assimp/Importer.hpp: No such file or directory

I'm was able to build qt3d without this dependency, is there something in your config which enabled it? Or is it autodetected from sysroot which wont be an issue anymore with master and RSS, but your change doesn't fix the autodetection for older branches.

We do enable assimp from another recipe.

I am unable to reproduce the original problem either.

Without the explicit dependency, it would seem that the build would at best be non-deterministic, enabling or disabling assimp support based solely on the timing of the Yocto tasks. I'm not aware of the technologies you allude to. Do they provide some determinism for this case?

Quoted 21 lines
Quoted 21 lines
---
 recipes-qt/qt5/qt3d_git.bb | 1 +
 1 file changed, 1 insertion(+)
recipes-qt/qt5/qt3d_git.bb +1 -1
index 2276c36..7c31213 100644
@@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG_class-native ??= "tools-only"
 PACKAGECONFIG_class-nativesdk ??= "tools-only"
 PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
+PACKAGECONFIG[assimp] = ",,assimp"
 
 EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
 
--

1.9.1

Quoted 6 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]

https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.

openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde

Quoted 2 lines

d-
devel&data=01%7C01%7Ctom.hochstein%40nxp.com%

7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635

Quoted 4 lines

%7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0

--
Martin 'JaMa' Jansa jabber: [email protected]

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw

In 5.8 (master), there is now a "system-assimp" PACKAGECONFIG option that correctly enables/disables assimp dependency.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

fatal error: assimp/Importer.hpp: No such file or directory

Is this really a fatal build error or a config test error?
In case qt3d doesn't find system assimp, it will use its internal copy of it.

Quoted 87 lines · Martin Jansa

RSS:
http://git.openembedded.org/openembedded-core/commit/?id=809746f56df4b91af014bf6a3f28997d6698ac78
http://lists.openembedded.org/pipermail/openembedded-architecture/2017-January/000384.html
and following threads

For morty and older releases you need to disable autodetection in qt3d sources when the assimp PACKAGECONFIG is not enabled (see PACKAGECONFIG in other recipes for some examples how to do it - but for qt5 it's often tricky as it rarely has enable/disable options usable in configure and has to be patched).

Otherwise assimp can still be detected when it's built as a dependency of some other recipe and might be removed from sysroot while qt3d build is already running and causing the issues you were trying to fix.

Quoted 70 lines · Tom Hochstein
Quoted 4 lines

-----Original Message-----
From: [email protected] [mailto:

[email protected]] On

Quoted 6 lines

Behalf Of Martin Jansa
Sent: Tuesday, February 07, 2017 6:01 AM
To: [email protected]
Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency

On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:

Quoted 8 lines
Quoted 3 lines

Fix build error:

fatal error: assimp/Importer.hpp: No such file or directory

I'm was able to build qt3d without this dependency, is there something in your config which enabled it? Or is it autodetected from sysroot which wont be an issue anymore with master and RSS, but your change doesn't fix the autodetection for older branches.

We do enable assimp from another recipe.

I am unable to reproduce the original problem either.

Without the explicit dependency, it would seem that the build would at best be non-deterministic, enabling or disabling assimp support based solely on the timing of the Yocto tasks. I'm not aware of the technologies you allude to. Do they provide some determinism for this case?

Quoted 21 lines
Quoted 21 lines
---
 recipes-qt/qt5/qt3d_git.bb | 1 +
 1 file changed, 1 insertion(+)
recipes-qt/qt5/qt3d_git.bb +1 -1
index 2276c36..7c31213 100644
@@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG_class-native ??= "tools-only"
 PACKAGECONFIG_class-nativesdk ??= "tools-only"
 PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
+PACKAGECONFIG[assimp] = ",,assimp"
 
 EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
 
--

1.9.1

Quoted 6 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]

https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.

openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde

Quoted 2 lines

d-
devel&data=01%7C01%7Ctom.hochstein%40nxp.com%

7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635

Quoted 4 lines

%7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0

--
Martin 'JaMa' Jansa jabber: [email protected]

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw
Quoted 9 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Samuli Piippo
Sent: Thursday, February 09, 2017 2:39 AM
To: [email protected]
Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency

Quoted 8 lines

In 5.8 (master), there is now a "system-assimp" PACKAGECONFIG option that correctly enables/disables assimp dependency.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

fatal error: assimp/Importer.hpp: No such file or directory

Is this really a fatal build error or a config test error? In case qt3d doesn't find system assimp, it will use its internal copy of it.

As I remember it was a build error, but unfortunately I don't have the surrounding error text to confirm this and cannot reproduce the error.

Quoted 108 lines · Martin Jansa
Quoted 2 lines

RSS:
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.openembedded.org%2Fopenembedded-

core%2Fcommit%2F%3Fid%3D809746f56df4b91af014bf6a3f28997d6698ac78&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04 444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=slwG0AloaQo4oRoDA3GHD6BmPdQ7bzw02GkRJHlp aWQ%3D&reserved=0

Quoted 1 line

https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fpipermail%2Fopenembedded-

architecture%2F2017- January%2F000384.html&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6f a92cd99c5c301635%7C0&sdata=NL7A%2B0Dj6Mgt4osVT10RGZM3Iz0jpLzTwQemNqD%2BYgA%3D&reserved=0

Quoted 8 lines

and following threads

For morty and older releases you need to disable autodetection in qt3d sources when the assimp PACKAGECONFIG is not enabled (see PACKAGECONFIG in other recipes for some examples how to do it - but for qt5 it's often tricky as it rarely has enable/disable options usable in configure and has to be patched).

Quoted 75 lines

Otherwise assimp can still be detected when it's built as a dependency of some other recipe and might be removed from sysroot while qt3d build is already running and causing the issues you were trying to fix.

Quoted 69 lines · Tom Hochstein
Quoted 4 lines

-----Original Message-----
From: [email protected] [mailto:

[email protected]] On

Quoted 6 lines

Behalf Of Martin Jansa
Sent: Tuesday, February 07, 2017 6:01 AM
To: [email protected]
Subject: Re: [oe] [meta-qt5][PATCH v2] qt3d: Add assimp dependency

On Fri, Jan 27, 2017 at 04:54:00PM -0600, Tom Hochstein wrote:

Quoted 8 lines
Quoted 3 lines

Fix build error:

fatal error: assimp/Importer.hpp: No such file or directory

I'm was able to build qt3d without this dependency, is there something in your config which enabled it? Or is it autodetected from sysroot which wont be an issue anymore with master and RSS, but your change doesn't fix the autodetection for older branches.

We do enable assimp from another recipe.

I am unable to reproduce the original problem either.

Without the explicit dependency, it would seem that the build would at best be non-deterministic, enabling or disabling assimp support based solely on the timing of the Yocto tasks. I'm not aware of the technologies you allude to. Do they provide some determinism for this case?

Quoted 21 lines
Quoted 21 lines
---
 recipes-qt/qt5/qt3d_git.bb | 1 +
 1 file changed, 1 insertion(+)
recipes-qt/qt5/qt3d_git.bb +1 -1
index 2276c36..7c31213 100644
@@ -19,6 +19,7 @@ PACKAGECONFIG ??= ""
 PACKAGECONFIG_class-native ??= "tools-only"
 PACKAGECONFIG_class-nativesdk ??= "tools-only"
 PACKAGECONFIG[tools-only] = "CONFIG+=tools-only"
+PACKAGECONFIG[assimp] = ",,assimp"
 
 EXTRA_QMAKEVARS_PRE += "${PACKAGECONFIG_CONFARGS}"
 
--

1.9.1

Quoted 6 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]

https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.

openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde

Quoted 2 lines

d-
devel&data=01%7C01%7Ctom.hochstein%40nxp.com%

7Cfa462298ac744a52797808d44f50f020%7C686ea1d3bc2b4c6fa92cd99c5c301635

Quoted 4 lines

%7C0&sdata=mLf9Lt9hQ5Rn8Ygbq7PczLY4Ix%2BscnMCbhC%2BDyUwLLM%3D&reserved=0

--
Martin 'JaMa' Jansa jabber: [email protected]

--
_______________________________________________
Openembedded-devel mailing list
[email protected]

https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
d- devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635 %7C0&sdata=gs5n%2FZqFAO8HLTQOrOi4nql3wTRykYUUhM9BCGb9sRY%3D&reserved=0

Quoted 1 line
Quoted 1 line

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openembedded.org%2Fmailman%2Flistinfo%2Fopenembedde
d- devel&data=01%7C01%7Ctom.hochstein%40nxp.com%7Ca8f9c04444d8432f897808d450c73559%7C686ea1d3bc2b4c6fa92cd99c5c301635 %7C0&sdata=gs5n%2FZqFAO8HLTQOrOi4nql3wTRykYUUhM9BCGb9sRY%3D&reserved=0