hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet
PATCH v2 1/1 hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet
The "or-irq" device needs to be wired up in source code, there is no way the user can add this device with the "-device" parameter or the "device_add" monitor command yet.
---
v2: Changed patch description and comment
hw/core/or-irq.c | 3 +++ 1 file changed, 3 insertions(+)
hw/core/or-irq.c +3 -0
@@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) dc->props = or_irq_properties; dc->realize = or_irq_realize; dc->vmsd = &vmstate_or_irq; + +/* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */ + dc->cannot_instantiate_with_device_add_yet = true; }static const TypeInfo or_irq_type_info = {
Signature · 1 line
1.8.3.1
Quoted 16 lines · Thomas Huth
The "or-irq" device needs to be wired up in source code, there is no way the user can add this device with the "-device" parameter or the "
device_add" monitor command yet.Signed-off-by Thomas Huth <[email protected]>---
v2: Changed patch description and commenthw/core/or-irq.c | 3 +++ 1 file changed, 3 insertions(+)hw/core/or-irq.c +0
-0
hw/core/or-irq.c static void or_irq_class_init(ObjectClass *klass, void *data) · line 93
Quoted 5 lines
hw/core/or-irq.c +2
-0@@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) dc->props = or_irq_properties; dc->realize = or_irq_realize; dc->vmsd = &vmstate_or_irq; + +/* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */
This line is a bit long, and it could be shortened easily: drop "in source code", or replace it by "to work". This is how similar comments elsewhere are phrased.
hw/core/or-irq.c static void or_irq_class_init(ObjectClass *klass, void *data) · line 97
Quoted 4 lines
hw/core/or-irq.c +1
-0+ dc->cannot_instantiate_with_device_add_yet = true; }static const TypeInfo or_irq_type_info = {
Preferably with the comment touched up:
Quoted 5 lines · Markus Armbruster
Quoted 3 lines · Thomas Huth
The "or-irq" device needs to be wired up in source code, there is no way the user can add this device with the "-device" parameter or the "
device_add" monitor command yet.
Well, the user can (I tried), but it won't do squat then.
Quoted 22 lines
Quoted 12 lines
Signed-off-by Thomas Huth <[email protected]>---
v2: Changed patch description and commenthw/core/or-irq.c | 3 +++ 1 file changed, 3 insertions(+)hw/core/or-irq.c +0
-0hw/core/or-irq.c static void or_irq_class_init(ObjectClass *klass, void *data) · line 93
Quoted 5 lines
hw/core/or-irq.c +2
-0@@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) dc->props = or_irq_properties; dc->realize = or_irq_realize; dc->vmsd = &vmstate_or_irq; + +/* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */ This line is a bit long, and it could be shortened easily: drop "in source code", or replace it by "to work". This is how similar comments elsewhere are phrased.
Quoted 6 lines
hw/core/or-irq.c static void or_irq_class_init(ObjectClass *klass, void *data) · line 97
Quoted 4 lines
hw/core/or-irq.c +1
-0+ dc->cannot_instantiate_with_device_add_yet = true; }static const TypeInfo or_irq_type_info = {Preferably with the comment touched up:
Commit message, too.
Quoted 1 line
Reviewed-by Markus Armbruster <[email protected]>