Skip to contentSkip to conversation

remoteproc: Drop qcom_scm_pas_supported() from adsp_probe()

PATCH Applied Sarangdhar Joshi 2 participants 2 messages Feb 3, 2017 – Feb 6, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remoteproc: Drop qcom_scm_pas_supported() from adsp_probe()

SCM call to check whether Peripheral Authentication Service (PAS) is supported returns false for ADSP. Drop this call from the driver so that the probe() function succeeds for ADSP PIL device.

---
 drivers/remoteproc/qcom_adsp_pil.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/remoteproc/qcom_adsp_pil.c +0 -5
index 43a4ed2..94cd4b8 100644
@@ -318,11 +318,6 @@ static int adsp_probe(struct platform_device *pdev)
 	if (!qcom_scm_is_available())
 		return -EPROBE_DEFER;
 
-	if (!qcom_scm_pas_supported(ADSP_PAS_ID)) {
-		dev_err(&pdev->dev, "PAS is not available for ADSP\n");
-		return -ENXIO;
-	}
-
 	rproc = rproc_alloc(&pdev->dev, pdev->name, &adsp_ops,
 			    ADSP_FIRMWARE_NAME, sizeof(*adsp));
 	if (!rproc) {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
#1 lore raw
Quoted 4 lines · Sarangdhar Joshi

SCM call to check whether Peripheral Authentication Service (PAS) is supported returns false for ADSP. Drop this call from the driver so that the probe() function succeeds for ADSP PIL device.

Applied, thanks

Regards,
Bjorn

Quoted 25 lines
---
 drivers/remoteproc/qcom_adsp_pil.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/remoteproc/qcom_adsp_pil.c +0 -5
index 43a4ed2..94cd4b8 100644
@@ -318,11 +318,6 @@ static int adsp_probe(struct platform_device *pdev)
 	if (!qcom_scm_is_available())
 		return -EPROBE_DEFER;
 
-	if (!qcom_scm_pas_supported(ADSP_PAS_ID)) {
-		dev_err(&pdev->dev, "PAS is not available for ADSP\n");
-		return -ENXIO;
-	}
-
 	rproc = rproc_alloc(&pdev->dev, pdev->name, &adsp_ops,
 			    ADSP_FIRMWARE_NAME, sizeof(*adsp));
 	if (!rproc) {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project