Skip to contentSkip to conversation

ARM: dts: aspeed: witherspoon: Add fsi-master GPIO bindings

PATCH In review Christopher Bostic 2 participants 2 messages Feb 3, 2017 – Feb 6, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: aspeed: witherspoon: Add fsi-master GPIO bindings

Define the pins used on Witherspoon by the FSI GPIO master.

---
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +12 -0
index 6064afa..4b2d8aa 100644
@@ -46,6 +46,18 @@
 			gpios = <&gpio ASPEED_GPIO(N, 3) GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	fsi-master {
+		compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
+
+		status = "disabled";
+
+		clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
+		data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
+		mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
+		trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
+	};
 };
 
 &fmc {
Signature · 1 line
1.8.2.2
#1 lore raw
Quoted 12 lines · Christopher Bostic

Define the pins used on Witherspoon by the FSI GPIO master.

Quoted 1 line

---
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++

 1 file changed, 12 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +0 -0
index 6064afa..4b2d8aa 100644

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts line 51

Quoted 6 lines
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +2 -0
@@ -46,6 +46,18 @@
 >  			gpios = <&gpio ASPEED_GPIO(N, 3) GPIO_ACTIVE_LOW>;
 >  		};
 >  	};
+
 > +	fsi-master {
+		compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";

I think these compatibles should be the other way around if we generalise [1] to device compatible strings:

The 'compatible' property contains a sorted list of strings starting with the exact name of the machine, followed by an optional list of boards it is compatible with sorted from most compatible to least. For example, the root compatible properties for the TI BeagleBoard and its successor, the BeagleBoard xM board might look like, respectively:

compatible = "ti,omap3-beagleboard", "ti,omap3450", "ti,omap3"; compatible = "ti,omap3-beagleboard-xm", "ti,omap3450", "ti,omap3";

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/usage-model.txt#n116

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts line 53

Quoted 2 lines
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +2 -0
+
+		status = "disabled";

This is disabled because we need to improve userspace support?

arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts line 60

Quoted 7 lines
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +1 -0
+
 > +		clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
 > +		data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
Quoted 3 lines
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +3 -0
+		mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
+		enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
+		trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +1 -0
+	};

These look fine to me.

Andrew

Quoted 3 lines

 };

 &fmc {