Skip to contentSkip to conversation

net/i40e: fix link update delay

PATCH Applied Qiming Yang 2 participants 3 messages Feb 8, 2017 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/i40e: fix link update delay

This patch fixed the redundant delay in function link update. There is no need to call rte_delay_ms and hold CPU for 100ms when link status is up.

Fixes 263333bbb7a9 ("i40e: fix link status timeout")
---
 drivers/net/i40e/i40e_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -2
index 4492bcc..75d092f 100644
@@ -2220,11 +2220,11 @@ i40e_dev_link_update(struct rte_eth_dev *dev,
 		}
 
 		link.link_status = link_status.link_info & I40E_AQ_LINK_UP;
-		if (!wait_to_complete)
+		if (!wait_to_complete || link.link_status)
 			break;
 
 		rte_delay_ms(CHECK_INTERVAL);
-	} while (!link.link_status && rep_cnt--);
+	} while (--rep_cnt);
 
 	if (!link.link_status)
 		goto out;
Signature · 1 line
2.7.4
Applied
#2 lore raw
Quoted 9 lines · Ferruh Yigit
Quoted 6 lines · Qiming Yang

This patch fixed the redundant delay in function link update. There is no need to call rte_delay_ms and hold CPU for 100ms when link status is up.

Fixes 263333bbb7a9 ("i40e: fix link status timeout")

Applied to dpdk-next-net/master, thanks.