Skip to contentSkip to conversation

mtk-vcodec: remove redundant return value check of platform_get_resource()

PATCH New Wei Yongjun 2 participants 2 messages Feb 7, 2017 – Feb 10, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtk-vcodec: remove redundant return value check of platform_get_resource()

From: Wei Yongjun <[email protected]>

Remove unneeded error handling on the result of a call to platform_get_resource() when the value is passed to devm_ioremap_resource().

---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c +0 -5
index aa81f3c..83f859e 100644
@@ -269,11 +269,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
 
 	for (i = VENC_SYS, j = 0; i < NUM_MAX_VCODEC_REG_BASE; i++, j++) {
 		res = platform_get_resource(pdev, IORESOURCE_MEM, j);
-		if (res == NULL) {
-			dev_err(&pdev->dev, "get memory resource failed.");
-			ret = -ENXIO;
-			goto err_res;
-		}
 		dev->reg_base[i] = devm_ioremap_resource(&pdev->dev, res);
 		if (IS_ERR((__force void *)dev->reg_base[i])) {
 			ret = PTR_ERR((__force void *)dev->reg_base[i]);
#1 lore raw

PATCH 1/1 mtk-vcodec: remove redundant return value check of platform_get_resource()

Quoted 7 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

Remove unneeded error handling on the result of a call to platform_get_resource() when the value is passed to devm_ioremap_resource().

Quoted 23 lines
---
 drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c +0 -5
index aa81f3c..83f859e 100644
@@ -269,11 +269,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
 
 	for (i = VENC_SYS, j = 0; i < NUM_MAX_VCODEC_REG_BASE; i++, j++) {
 		res = platform_get_resource(pdev, IORESOURCE_MEM, j);
-		if (res == NULL) {
-			dev_err(&pdev->dev, "get memory resource failed.");
-			ret = -ENXIO;
-			goto err_res;
-		}
 		dev->reg_base[i] = devm_ioremap_resource(&pdev->dev, res);
 		if (IS_ERR((__force void *)dev->reg_base[i])) {
 			ret = PTR_ERR((__force void *)dev->reg_base[i]);