net: ethernet: intel: e1000: msleep() is unreliable for anything <20ms
Subsystems (3)
PATCH 1/1 net: ethernet: intel: e1000: msleep() is unreliable for anything <20ms
Fix the checkpatch.pl issue:
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
Signed-off-by Saber Rezvani <[email protected]>
--- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/net/ethernet/intel/e1000/e1000_ethtool.c +8 -8
@@ -207,7 +207,7 @@ static int e1000_set_settings(struct net_device *netdev, }while (test_and_set_bit (__E1000_RESETTING, &adapter->flags)) -msleep (1 ); +usleep_range (1000 ,5000 );if (ecmd->autoneg ==AUTONEG_ENABLE ) { hw->autoneg =1 ;
@@ -294,7 +294,7 @@ static int e1000_set_pauseparam(struct net_device *netdev, adapter->fc_autoneg = pause->autoneg;while (test_and_set_bit (__E1000_RESETTING, &adapter->flags)) -msleep (1 ); +usleep_range (1000 ,5000 );if (pause->rx_pause && pause->tx_pause) hw->fc =E1000_FC_FULL ;
@@ -592,7 +592,7 @@ static int e1000_set_ringparam(struct net_device *netdev,return -EINVAL ;while (test_and_set_bit (__E1000_RESETTING, &adapter->flags)) -msleep (1 ); +usleep_range (1000 ,5000 );if (netif_running (adapter->netdev))e1000_down (adapter);
@@ -869,7 +869,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)/* Disable all the interrupts */ ew32 (IMC ,0xFFFFFFFF );E1000_WRITE_FLUSH (); -msleep (10 ); +usleep_range (10000 ,11000 );/* Test each interrupt */ for (; i <10 ; i++) {
@@ -887,7 +887,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)ew32 (IMC , mask);ew32 (ICS , mask);E1000_WRITE_FLUSH (); -msleep (10 ); +usleep_range (10000 ,11000 );if (adapter->test_icr & mask) { *data =3 ;
@@ -905,7 +905,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)ew32 (IMS , mask);ew32 (ICS , mask);E1000_WRITE_FLUSH (); -msleep (10 ); +usleep_range (10000 ,11000 );if (!(adapter->test_icr & mask)) { *data =4 ;
@@ -923,7 +923,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)ew32 (IMC , ~mask &0x00007FFF );ew32 (ICS , ~mask &0x00007FFF );E1000_WRITE_FLUSH (); -msleep (10 ); +usleep_range (10000 ,11000 );if (adapter->test_icr) { *data =5 ;
@@ -935,7 +935,7 @@ static int e1000_intr_test(struct e1000_adapter *adapter, u64 *data)/* Disable all the interrupts */ ew32 (IMC ,0xFFFFFFFF );E1000_WRITE_FLUSH (); -msleep (10 ); +usleep_range (10000 ,11000 );/* Unhook test interrupt handler */ free_irq (irq, netdev);
Signature · 1 line
2.7.4