Skip to contentSkip to conversation

dts: aspeed: witherspoon: Enable FSI master

PATCH In review Eddie James 2 participants 2 messages Feb 10, 2017 – Feb 11, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dts: aspeed: witherspoon: Enable FSI master

From: "Edward A. James" <[email protected]>

set status to "okay"

---
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +1 -1
index 4b2d8aa..e532737 100644
@@ -50,7 +50,7 @@
 	fsi-master {
 		compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
 
-		status = "disabled";
+		status = "okay";
 
 		clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
 		data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 3 lines · Eddie James

From: "Edward A. James" <[email protected]>

set status to "okay"

Did you successfully boot a p9 with this?

I found that it did work, but we have two separate bits of software poking at FSI - pdbg via /dev/mem, and the kernel driver. So it's a bit of luck that it still works.

In order to not have this, pdbg needs to use the kernel driver. I started doing this work but hit the issues that you and Chris have been debugging for us.

On Monday I will re-test pdbg with your fixes, and if that works, we can push the pdbg OpenFSI backend and at that point change the device tree to bind to the driver. We will need to make sure we can use the kernel driver to perform the DD1 workarounds on both p9 sockets.

Cheers,

Joel

Quoted 22 lines
---
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +1 -2
index 4b2d8aa..e532737 100644
@@ -50,7 +50,7 @@
        fsi-master {
                compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
 
-               status = "disabled";
+               status = "okay";
 
                clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
                data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
--

1.8.3.1