Skip to contentSkip to conversation

Staging: setup.c: fixed ERROR: trailing whitespace

PATCH In review Kishore Karanala 2 participants 2 messages Feb 12, 2017 x86

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Staging: setup.c: fixed ERROR: trailing whitespace

Fixed ERROR: trailing whitespace issues

---
 arch/x86/kernel/setup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/setup.c +2 -2
index 5fa3194..1a1e986 100644
@@ -723,7 +723,7 @@ static void __init trim_snb_memory(void)
 	 * already been reserved.
 	 */
 	memblock_reserve(0, 1<<20);
-	
+
 	for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
 		if (memblock_reserve(bad_pages[i], PAGE_SIZE))
 			printk(KERN_WARNING "failed to reserve 0x%08lx\n",
@@ -815,7 +815,7 @@ static void __init trim_low_memory_range(void)
 {
 	memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
 }
-	
+
 /*
  * Dump out kernel offset information on panic.
  */
Signature · 1 line
2.7.4
#1 lore raw

On Sun, 12 Feb 2017, Kishore Karanala wrote:

You're not listening at all. I told you before:

The proper subsystem for x86 is x86 and not staging.

You can chose to ignore my review comments, but then you don't have to wonder that I'm going to ignore you as well.

Aside of that, you got at least TWO messages from your mail server, that mail to '[email protected]' cannot be delivered, but that seems to be information to ignore as well.

Quoted 1 line

Fixed ERROR: trailing whitespace issues

What's the point of this?

You used checkpatch.pl on that file. Can you figure out from the name of that script what's the purpose of that script?

The purpose is obviously to check patches for correctness. The fact that you can run checkpatch.pl with the -f commandline option on an existing file does not change that.

And trailing whitespace is the least of our worries, really.

Thanks,

tglx