Skip to contentSkip to conversation

Staging: media: bcm2048: Fixed coding style issue.

PATCH In review Ran Algawi 2 participants 2 messages Feb 12, 2017 – Feb 13, 2017

Subsystems (2)
Media (V4L/DVB) Staging
lore
Share & tools
lore

Ran Algawi

author
#0 lore raw

PATCH 1/1 Staging: media: bcm2048: Fixed coding style issue.

Fixed a coding style issue, where an octal value was needed insted of decimal.

Signed-off-by Ran Algawi <[email protected]>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/bcm2048/radio-bcm2048.c +1 -1
index 37bd439..d605c41 100644
@@ -300,7 +300,7 @@ struct bcm2048_device {
 };
 
 static int radio_nr = -1;	/* radio device minor (-1 ==> auto assign) */
-module_param(radio_nr, int, 0);
+module_param(radio_nr, int, 0000);
 MODULE_PARM_DESC(radio_nr,
 		 "Minor number for radio device (-1 ==> auto assign)");
Signature · 1 line
2.7.4
#1 lore raw
Quoted 12 lines · Ran Algawi

Fixed a coding style issue, where an octal value was needed insted of decimal.

Signed-off-by Ran Algawi <[email protected]>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/bcm2048/radio-bcm2048.c +0 -0
index 37bd439..d605c41 100644

drivers/staging/media/bcm2048/radio-bcm2048.c struct bcm2048_device { · line 303

Quoted 5 lines
drivers/staging/media/bcm2048/radio-bcm2048.c +1 -1
@@ -300,7 +300,7 @@ struct bcm2048_device {
 };
 
 static int radio_nr = -1;	/* radio device minor (-1 ==> auto assign) */
-module_param(radio_nr, int, 0);
+module_param(radio_nr, int, 0000);

Let's make this 0444, just like most other media drivers with a radio_nr param.

In fact, I propose that you make this patch more useful by looking at the output of:

git grep module_param drivers/media/|grep '\(video_nr\)\|\(radio_nr\)\|\(vbi_nr\)'

and change all to 0444. I see a mix of 0000, 0444 and 0644 being used, but 0444 is really the only sensible one.

Hans

Quoted 4 lines
drivers/staging/media/bcm2048/radio-bcm2048.c +0 -0
 MODULE_PARM_DESC(radio_nr,
 		 "Minor number for radio device (-1 ==> auto assign)");