Skip to contentSkip to conversation

Patch "Revert "ALSA: line6: Only determine control port properties if needed"" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Feb 12, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Revert "ALSA: line6: Only determine control port properties if needed"

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
revert-alsa-line6-only-determine-control-port-properties-if-needed.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f3d83317a69e7d658e7c83e24f8b31ac533c39e3 Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Tue, 7 Feb 2017 09:32:30 +0100
Subject: Revert "ALSA: line6: Only determine control port properties if needed"

From: Takashi Iwai <[email protected]>

commit f3d83317a69e7d658e7c83e24f8b31ac533c39e3 upstream.

This reverts commit f6a0dd107ad0c8b59d1c9735eea4b8cb9f460949.

The commit caused a regression on LINE6 Transport that has no control caps. Although reverting the commit may result back in a spurious error message for some device again, it's the simplest regression fix, hence it's taken as is at first. The further code fix will follow later.

Fixes f6a0dd107ad0 ("ALSA: line6: Only determine control port properties if needed")
---
 sound/usb/line6/driver.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/usb/line6/driver.c +2 -1
@@ -754,8 +754,9 @@ int line6_probe(struct usb_interface *in
 		goto error;
 	}
 
+	line6_get_interval(line6);
+
 	if (properties->capabilities & LINE6_CAP_CONTROL) {
-		line6_get_interval(line6);
 		ret = line6_init_cap_control(line6);
 		if (ret < 0)
 			goto error;

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/alsa-seq-don-t-handle-loop-timeout-at-snd_seq_pool_done.patch queue-4.9/alsa-hda-adding-a-new-nv-hdmi-dp-codec-id-in-the-driver.patch queue-4.9/revert-alsa-line6-only-determine-control-port-properties-if-needed.patch queue-4.9/alsa-seq-fix-race-at-creating-a-queue.patch