Skip to contentSkip to conversation

crypto: brcm - Avoid double free in ahash_finup()

PATCH In review Rob Rice 2 participants 2 messages Feb 14, 2017 – Feb 15, 2017 Crypto API

lore
Share & tools
lore

Rob Rice

author
#0 lore raw

PATCH 1/1 crypto: brcm - Avoid double free in ahash_finup()

In Broadcom SPU driver, in case where incremental hash is done in software in ahash_finup(), tmpbuf was freed twice.

---
 drivers/crypto/bcm/cipher.c | 1 -
 1 file changed, 1 deletion(-)
drivers/crypto/bcm/cipher.c +0 -1
index a654a01..cc0d5b9 100644
@@ -2331,7 +2331,6 @@ static int ahash_finup(struct ahash_request *req)
 		/* Call synchronous update */
 		ret = crypto_shash_finup(ctx->shash, tmpbuf, req->nbytes,
 					 req->result);
-		kfree(tmpbuf);
 	} else {
 		/* Otherwise call the internal function which uses SPU hw */
 		return __ahash_finup(req);
Signature · 1 line
2.1.0