Skip to contentSkip to conversation

staging: xgifb: function definition argument should also have an identifier name

PATCH In review Arushi Singhal 2 participants 3 messages Feb 14, 2017 – Feb 15, 2017 1 message not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: xgifb: function definition argument should also have an identifier name

function definition argument 'struct vb_device_info *' should also have an identifier name.

---
 drivers/staging/xgifb/vb_init.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/xgifb/vb_init.h +1 -1
index 500cabe41a3c..022486a516d6 100644
@@ -1,6 +1,6 @@
 #ifndef _VBINIT_
 #define _VBINIT_
 unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long);
 #endif
 
Signature · 1 line
2.11.0
#1 lore raw
Quoted 2 lines · Arushi Singhal

function definition argument 'struct vb_device_info *' should also have an identifier name.

[]

drivers/staging/xgifb/vb_init.h

Quoted 1 line
drivers/staging/xgifb/vb_init.h +0 -0

[]

drivers/staging/xgifb/vb_init.h line 4

Quoted 6 lines
drivers/staging/xgifb/vb_init.h +1 -1
@@ -1,6 +1,6 @@
 #ifndef _VBINIT_
 #define _VBINIT_
 unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long);

Why do one argument but not the other?

A message that is not in the archive (sent off-list or not yet received): CA+XqjF-btw9=_jWVtdHDq9NSh5SizaZthuM4jsfWkXnRHfn9DQ@mail.gmail.com

#3 lore raw
Quoted 5 lines · Arushi Singhal

Hi Joe
Sorry but I am unable to find the identifier of "unsigned long" .Shall you please help me in how to find the identifier.
Thanks
Arushi Singhal

$ git grep -w XGIRegInit
drivers/staging/xgifb/XGI_main_26.c:void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr)
Quoted 21 lines · Joe Perches
Quoted 20 lines · Arushi Singhal
Quoted 2 lines

function definition argument 'struct vb_device_info *' should also have an identifier name.

[]

drivers/staging/xgifb/vb_

Quoted 1 line
drivers/staging/xgifb/vb_ renamed from drivers/staging/xgifb/vb_init.h +0 -0

init.h
[]

drivers/staging/xgifb/vb_ line 4

Quoted 6 lines
drivers/staging/xgifb/vb_ renamed from drivers/staging/xgifb/vb_init.h +1 -1
@@ -1,6 +1,6 @@
 #ifndef _VBINIT_
 #define _VBINIT_
 unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long);

Why do one argument but not the other?