staging: fbtft: Fix buffer overflow vulnerability
Subsystems (2)
PATCH 1/1 staging: fbtft: Fix buffer overflow vulnerability
Module copies a user supplied string (module parameter) into a buffer using strncpy() and does not check that the buffer is null terminated.
Replace call to strncpy() with call to strlcpy() ensuring that the buffer is null terminated.
Signed-off-by Tobin C. Harding <[email protected]>
--- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fbtft_device.c +1 -1
@@ -1483,7 +1483,7 @@ static int __init fbtft_device_init(void) displays[i].pdev->name = name; displays[i].spi =NULL ; }else { -strncpy (displays[i].spi->modalias, name,SPI_NAME_SIZE ); +strlcpy (displays[i].spi->modalias, name,SPI_NAME_SIZE ); displays[i].pdev =NULL ; } }
Signature · 1 line
2.7.4
Greg Kroah-Hartman
maintainerQuoted 16 lines · Tobin C. Harding
Module copies a user supplied string (module parameter) into a buffer using
strncpy()and does not check that the buffer is null terminated.Replace call to
strncpy()with call tostrlcpy()ensuring that the buffer is null terminated.Signed-off-by Tobin C. Harding <[email protected]>--- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/fbtft/fbtft_device.c +0
-0
drivers/staging/fbtft/fbtft_device.c static int __init fbtft_device_init(void) · line 1486
Quoted 5 lines
drivers/staging/fbtft/fbtft_device.c +1
-1@@ -1483,7 +1483,7 @@ static int __init fbtft_device_init(void) displays[i].pdev->name = name; displays[i].spi =NULL ; }else { -strncpy (displays[i].spi->modalias, name,SPI_NAME_SIZE ); +strlcpy (displays[i].spi->modalias, name,SPI_NAME_SIZE );
Shouldn't we properly check the return value here to know if the buffer did get truncated? Or do we really care?
thanks,
greg k-h