Skip to contentSkip to conversation

extcon: palmas/usb-gpio: Don't miss events during suspend/resume

PATCH In review Roger Quadros 2 participants 4 messages Feb 15, 2017 – Feb 16, 2017 External connector subsystem (extcon)

lore
Share & tools
lore
#0 lore raw

cover extcon: palmas/usb-gpio: Don't miss events during suspend/resume

Hi,

This series ensures that we don't miss USB VBUS/ID event changes across system suspend/resume.

cheers,
-roger

Roger Quadros (2):
extcon: usb-gpio: Don't miss event during suspend/resume
extcon: palmas: Don't miss GPIO events during suspend/resume

 drivers/extcon/extcon-palmas.c   | 6 ++++++
 drivers/extcon/extcon-usb-gpio.c | 5 ++---
 2 files changed, 8 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/2 extcon: usb-gpio: Don't miss event during suspend/resume

We must check for ID/VBUS changes during resume irrespective of whether our device wakeup is enabled or not.

Without this we seem to be missing ID/VBUS events after system suspend/resume.

---
 drivers/extcon/extcon-usb-gpio.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/extcon/extcon-usb-gpio.c +2 -3
index d589c5f..71ac427 100644
@@ -275,9 +275,8 @@ static int usb_extcon_resume(struct device *dev)
 	if (info->vbus_gpiod)
 		enable_irq(info->vbus_irq);
 
-	if (!device_may_wakeup(dev))
-		queue_delayed_work(system_power_efficient_wq,
-				   &info->wq_detcable, 0);
+	queue_delayed_work(system_power_efficient_wq,
+			   &info->wq_detcable, 0);
 
 	return ret;
 }
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 extcon: palmas: Don't miss GPIO events during suspend/resume

In reply to Roger Quadros

The USB cable state can change during suspend/resume so be sure to check and update the extcon state.

---
 drivers/extcon/extcon-palmas.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/extcon/extcon-palmas.c +6 -0
index 634ba70..97bacb4 100644
@@ -408,6 +408,12 @@ static int palmas_usb_resume(struct device *dev)
 		if (palmas_usb->enable_gpio_id_detection)
 			disable_irq_wake(palmas_usb->gpio_id_irq);
 	}
+
+	/* check if GPIO states changed while suspend/resume */
+	if (palmas_usb->enable_gpio_vbus_detection)
+		palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
+	palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
+
 	return 0;
 };
 #endif
Signature · 1 line
2.7.4
maintainer
#3 lore raw
In reply to Roger Quadros
Quoted 8 lines · Roger Quadros

Hi,

This series ensures that we don't miss USB VBUS/ID event changes across system suspend/resume.

cheers,
-roger

Quoted 8 lines

Roger Quadros (2):
extcon: usb-gpio: Don't miss event during suspend/resume
extcon: palmas: Don't miss GPIO events during suspend/resume

 drivers/extcon/extcon-palmas.c   | 6 ++++++
 drivers/extcon/extcon-usb-gpio.c | 5 ++---
 2 files changed, 8 insertions(+), 3 deletions(-)

Applied all patches in this series.
Thanks.

Signature · 3 lines
Best Regards,
Chanwoo Choi
Samsung Electronics