Patch "net/mlx5: Don't unlock fte while still using it" has been added to the 4.9-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
net/mlx5: Don't unlock fte while still using it
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-mlx5-don-t-unlock-fte-while-still-using-it.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
0fd758d6112f867b2cc6df0f6a856048ff99b211Mon Sep 17 00:00:00 2001
From: Mark Bloch <[email protected]>
Date: Mon, 5 Sep 2016 10:58:04 +0000
Subject: net/mlx5: Don't unlock fte while still using it
From: Mark Bloch <[email protected]>
commit 0fd758d6112f867b2cc6df0f6a856048ff99b211 upstream.
When adding a new rule to an fte, we need to hold the fte lock until we add that rule to the fte and increase the fte ref count.
--- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c +4 -2
@@ -1110,9 +1110,8 @@ static struct mlx5_flow_rule *add_rule_freturn rule; } rule =add_rule_fte (fte, fg, dest); -unlock_ref_node (&fte->node);if (IS_ERR (rule)) - goto unlock_fg; + goto unlock_fte;else goto add_rule; }
@@ -1130,6 +1129,7 @@ static struct mlx5_flow_rule *add_rule_f goto unlock_fg; }tree_init_node (&fte->node,0 , del_fte); +nested_lock_ref_node (&fte->node,FS_MUTEX_CHILD ); rule =add_rule_fte (fte, fg, dest);if (IS_ERR (rule)) {kfree (fte);
@@ -1142,6 +1142,8 @@ static struct mlx5_flow_rule *add_rule_flist_add (&fte->node.list, prev); add_rule:tree_add_node (&rule->node, &fte->node); +unlock_fte: +unlock_ref_node (&fte->node); unlock_fg:unlock_ref_node (&fg->node);return rule;
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/net-mlx5-don-t-unlock-fte-while-still-using-it.patch