drm: Add DPCD definitions for DP 1.4 DSC feature
Subsystems (2)
PATCH v2 1/1 drm: Add DPCD definitions for DP 1.4 DSC feature
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC.
v2:
* Rebased on drm-tip
--- include/drm/drm_dp_helper.h | 102 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+)
include/drm/drm_dp_helper.h +102 -0
@@ -179,6 +179,108 @@#define DP_GUID 0x030/* 1.2 */ +#define DP_DSC_SUPPORT 0x060/* DP 1.4 */ +# define DP_DSC_DECOMPRESSION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_REV 0x061 +# define DP_DSC_MAJOR_MASK (15 << 0) +# define DP_DSC_MINOR_MASK (15 << 4) +# define DP_DSC_MINOR_SHIFT 4 + +#define DP_DSC_RC_BUF_BLK_SIZE 0x062 +# define DP_DSC_RC_BUF_BLK_SIZE_1 0x0 +# define DP_DSC_RC_BUF_BLK_SIZE_4 0x1 +# define DP_DSC_RC_BUF_BLK_SIZE_16 0x2 +# define DP_DSC_RC_BUF_BLK_SIZE_64 0x3 + +#define DP_DSC_RC_BUF_SIZE 0x063 + +#define DP_DSC_SLICE_CAP_1 0x064 +# define DP_DSC_1_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_2_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_4_PER_DP_DSC_SINK (1 << 3) +# define DP_DSC_6_PER_DP_DSC_SINK (1 << 4) +# define DP_DSC_8_PER_DP_DSC_SINK (1 << 5) +# define DP_DSC_10_PER_DP_DSC_SINK (1 << 6) +# define DP_DSC_12_PER_DP_DSC_SINK (1 << 7) + +#define DP_DSC_LINE_BUF_BIT_DEPTH 0x065 +# define DP_DSC_LINE_BUF_BIT_DEPTH_MASK (15 << 0) +# define DP_DSC_LINE_BUF_BIT_DEPTH_9 0x0 +# define DP_DSC_LINE_BUF_BIT_DEPTH_10 0x1 +# define DP_DSC_LINE_BUF_BIT_DEPTH_11 0x2 +# define DP_DSC_LINE_BUF_BIT_DEPTH_12 0x3 +# define DP_DSC_LINE_BUF_BIT_DEPTH_13 0x4 +# define DP_DSC_LINE_BUF_BIT_DEPTH_14 0x5 +# define DP_DSC_LINE_BUF_BIT_DEPTH_15 0x6 +# define DP_DSC_LINE_BUF_BIT_DEPTH_16 0x7 +# define DP_DSC_LINE_BUF_BIT_DEPTH_8 0x8 + +#define DP_DSC_BLK_PREDICTION_SUPPORT 0x066 +# define DP_DSC_BLK_PREDICTION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067/* eDP 1.4 */ + +#define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068/* eDP 1.4 */ + +#define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069 +# define DP_DSC_RGB (1 << 0) +# define DP_DSC_YCbCr444 (1 << 1) +# define DP_DSC_YCbCr422_Simple (1 << 2) +# define DP_DSC_YCbCr422_Native (1 << 3) +# define DP_DSC_YCbCr420_Native (1 << 4) + +#define DP_DSC_DEC_COLOR_DEPTH_CAP 0x06A +# define DP_DSC_8_BPC (1 << 1) +# define DP_DSC_10_BPC (1 << 2) +# define DP_DSC_12_BPC (1 >> 3) + +#define DP_DSC_PEAK_THROUGHPUT 0x06B +# define DP_DSC_THROUGHPUT_MODE_0_340 0x1 +# define DP_DSC_THROUGHPUT_MODE_0_400 0x2 +# define DP_DSC_THROUGHPUT_MODE_0_450 0x3 +# define DP_DSC_THROUGHPUT_MODE_0_500 0x4 +# define DP_DSC_THROUGHPUT_MODE_0_550 0x5 +# define DP_DSC_THROUGHPUT_MODE_0_600 0x6 +# define DP_DSC_THROUGHPUT_MODE_0_650 0x7 +# define DP_DSC_THROUGHPUT_MODE_0_700 0x8 +# define DP_DSC_THROUGHPUT_MODE_0_750 0x9 +# define DP_DSC_THROUGHPUT_MODE_0_800 0xA +# define DP_DSC_THROUGHPUT_MODE_0_850 0xB +# define DP_DSC_THROUGHPUT_MODE_0_900 0xC +# define DP_DSC_THROUGHPUT_MODE_0_950 0xD +# define DP_DSC_THROUGHPUT_MODE_0_1000 0xE +# define DP_DSC_THROUGHPUT_MODE_1_MASK (15 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4 +# define DP_DSC_THROUGHPUT_MODE_1_340 (1 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_400 (2 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_450 (3 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_500 (4 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_550 (5 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_600 (6 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_650 (7 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_700 (8 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_750 (9 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_800 (10 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_850 (11 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_900 (12 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_950 (13 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4) + +#define DP_DSC_MAX_SLICE_WIDTH 0x06C + +#define DP_DSC_SLICE_CAP_2 0x06D +# define DP_DSC_16_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_20_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_24_PER_DP_DSC_SINK (1 << 2) + +#define DP_DSC_BITS_PER_PIXEL_INC 0x06F +# define DP_DSC_BITS_PER_PIXEL_1_16 0x0 +# define DP_DSC_BITS_PER_PIXEL_1_8 0x1 +# define DP_DSC_BITS_PER_PIXEL_1_4 0x2 +# define DP_DSC_BITS_PER_PIXEL_1_2 0x3 +# define DP_DSC_BITS_PER_PIXEL_1 0x4 +#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 DSC feature (rev3)
== Series Details ==
== Series Details ==
Series: drm: Add DPCD definitions for DP 1.4 DSC feature (rev3)
URL : https://patchwork.freedesktop.org/series/19666/
State : success
== Summary ==
Series 19666v3 drm: Add DPCD definitions for DP 1.4 DSC feature
https://patchwork.freedesktop.org/api/1.0/series/19666/revisions/3/mbox/
fi-bdw-5557u total:252 pass:241 dwarn:0 dfail:0 fail:0 skip:11 fi-bsw-n3050 total:252 pass:213 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19 fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12 fi-byt-j1900 total:252 pass:225 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:252 pass:236 dwarn:0 dfail:0 fail:0 skip:16 fi-hsw-4770r total:252 pass:236 dwarn:0 dfail:0 fail:0 skip:16 fi-ilk-650 total:252 pass:202 dwarn:0 dfail:0 fail:0 skip:50 fi-ivb-3520m total:252 pass:234 dwarn:0 dfail:0 fail:0 skip:18 fi-ivb-3770 total:252 pass:234 dwarn:0 dfail:0 fail:0 skip:18 fi-kbl-7500u total:252 pass:234 dwarn:0 dfail:0 fail:0 skip:18 fi-skl-6260u total:252 pass:242 dwarn:0 dfail:0 fail:0 skip:10 fi-skl-6700hq total:252 pass:235 dwarn:0 dfail:0 fail:0 skip:17 fi-skl-6700k total:252 pass:230 dwarn:4 dfail:0 fail:0 skip:18 fi-skl-6770hq total:252 pass:242 dwarn:0 dfail:0 fail:0 skip:10 fi-snb-2520m total:252 pass:224 dwarn:0 dfail:0 fail:0 skip:28 fi-snb-2600 total:252 pass:223 dwarn:0 dfail:0 fail:0 skip:29
c2033e7aa383d062000e024c5fac5f46560327cd drm-tip: 2017y-02m-16d-20h-42m-04s UTC integration manifest eb47d5f drm: Add DPCD definitions for DP 1.4 DSC feature
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3867/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Manasi Navare
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC.
v2:
* Rebased on drm-tipSigned-off-by Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Paulo Zanoni <[email protected]>
Tedious work to cross check this stuff against the spec... found one real issue; while at it please fix a few nitpicks that I would otherwise have ignored.
BR,
Jani.
Quoted 9 lines
--- include/drm/drm_dp_helper.h | 102 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+)include/drm/drm_dp_helper.h +0
-0
include/drm/drm_dp_helper.h line 188
Quoted 10 lines
include/drm/drm_dp_helper.h +7
-0@@ -179,6 +179,108 @@#define DP_GUID 0x030/* 1.2 */ +#define DP_DSC_SUPPORT 0x060/* DP 1.4 */ +# define DP_DSC_DECOMPRESSION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_REV 0x061 +# define DP_DSC_MAJOR_MASK (15 << 0) +# define DP_DSC_MINOR_MASK (15 << 4) +# define DP_DSC_MINOR_SHIFT 4
Nitpick: Hex is preferred for masks. Same for all masks below. MAJOR_SHIFT for completeness.
Quoted 38 lines
include/drm/drm_dp_helper.h +38
-0+ +#define DP_DSC_RC_BUF_BLK_SIZE 0x062 +# define DP_DSC_RC_BUF_BLK_SIZE_1 0x0 +# define DP_DSC_RC_BUF_BLK_SIZE_4 0x1 +# define DP_DSC_RC_BUF_BLK_SIZE_16 0x2 +# define DP_DSC_RC_BUF_BLK_SIZE_64 0x3 + +#define DP_DSC_RC_BUF_SIZE 0x063 + +#define DP_DSC_SLICE_CAP_1 0x064 +# define DP_DSC_1_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_2_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_4_PER_DP_DSC_SINK (1 << 3) +# define DP_DSC_6_PER_DP_DSC_SINK (1 << 4) +# define DP_DSC_8_PER_DP_DSC_SINK (1 << 5) +# define DP_DSC_10_PER_DP_DSC_SINK (1 << 6) +# define DP_DSC_12_PER_DP_DSC_SINK (1 << 7) + +#define DP_DSC_LINE_BUF_BIT_DEPTH 0x065 +# define DP_DSC_LINE_BUF_BIT_DEPTH_MASK (15 << 0) +# define DP_DSC_LINE_BUF_BIT_DEPTH_9 0x0 +# define DP_DSC_LINE_BUF_BIT_DEPTH_10 0x1 +# define DP_DSC_LINE_BUF_BIT_DEPTH_11 0x2 +# define DP_DSC_LINE_BUF_BIT_DEPTH_12 0x3 +# define DP_DSC_LINE_BUF_BIT_DEPTH_13 0x4 +# define DP_DSC_LINE_BUF_BIT_DEPTH_14 0x5 +# define DP_DSC_LINE_BUF_BIT_DEPTH_15 0x6 +# define DP_DSC_LINE_BUF_BIT_DEPTH_16 0x7 +# define DP_DSC_LINE_BUF_BIT_DEPTH_8 0x8 + +#define DP_DSC_BLK_PREDICTION_SUPPORT 0x066 +# define DP_DSC_BLK_PREDICTION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067/* eDP 1.4 */ + +#define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068/* eDP 1.4 */ + +#define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069
include/drm/drm_dp_helper.h line 236
Quoted 10 lines
include/drm/drm_dp_helper.h +10
-0+# define DP_DSC_RGB (1 << 0) +# define DP_DSC_YCbCr444 (1 << 1) +# define DP_DSC_YCbCr422_Simple (1 << 2) +# define DP_DSC_YCbCr422_Native (1 << 3) +# define DP_DSC_YCbCr420_Native (1 << 4) + +#define DP_DSC_DEC_COLOR_DEPTH_CAP 0x06A +# define DP_DSC_8_BPC (1 << 1) +# define DP_DSC_10_BPC (1 << 2) +# define DP_DSC_12_BPC (1 >> 3)
Oops, shifting to wrong direction!
Quoted 6 lines
include/drm/drm_dp_helper.h +6
-0+ +#define DP_DSC_PEAK_THROUGHPUT 0x06B +# define DP_DSC_THROUGHPUT_MODE_0_340 0x1 +# define DP_DSC_THROUGHPUT_MODE_0_400 0x2 +# define DP_DSC_THROUGHPUT_MODE_0_450 0x3 +# define DP_DSC_THROUGHPUT_MODE_0_500 0x4
include/drm/drm_dp_helper.h line 252
Quoted 10 lines
include/drm/drm_dp_helper.h +10
-0+# define DP_DSC_THROUGHPUT_MODE_0_550 0x5 +# define DP_DSC_THROUGHPUT_MODE_0_600 0x6 +# define DP_DSC_THROUGHPUT_MODE_0_650 0x7 +# define DP_DSC_THROUGHPUT_MODE_0_700 0x8 +# define DP_DSC_THROUGHPUT_MODE_0_750 0x9 +# define DP_DSC_THROUGHPUT_MODE_0_800 0xA +# define DP_DSC_THROUGHPUT_MODE_0_850 0xB +# define DP_DSC_THROUGHPUT_MODE_0_900 0xC +# define DP_DSC_THROUGHPUT_MODE_0_950 0xD +# define DP_DSC_THROUGHPUT_MODE_0_1000 0xE
Nitpick: MODE_0_MASK and MODE_0_SHIFT for completeness. Seems inconsistent to use hex for MODE_0 values and dec for MODE_1 values.
Quoted 34 lines
include/drm/drm_dp_helper.h +31
-0+# define DP_DSC_THROUGHPUT_MODE_1_MASK (15 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4 +# define DP_DSC_THROUGHPUT_MODE_1_340 (1 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_400 (2 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_450 (3 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_500 (4 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_550 (5 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_600 (6 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_650 (7 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_700 (8 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_750 (9 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_800 (10 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_850 (11 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_900 (12 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_950 (13 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4) + +#define DP_DSC_MAX_SLICE_WIDTH 0x06C + +#define DP_DSC_SLICE_CAP_2 0x06D +# define DP_DSC_16_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_20_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_24_PER_DP_DSC_SINK (1 << 2) + +#define DP_DSC_BITS_PER_PIXEL_INC 0x06F +# define DP_DSC_BITS_PER_PIXEL_1_16 0x0 +# define DP_DSC_BITS_PER_PIXEL_1_8 0x1 +# define DP_DSC_BITS_PER_PIXEL_1_4 0x2 +# define DP_DSC_BITS_PER_PIXEL_1_2 0x3 +# define DP_DSC_BITS_PER_PIXEL_1 0x4 +#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Manasi Navare
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC.
v2:
* Rebased on drm-tipSigned-off-by Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Paulo Zanoni <[email protected]>
Tedious work to cross check this stuff against the spec... found one real issue; while at it please fix a few nitpicks that I would otherwise have ignored.
BR,
Jani.
Quoted 10 lines
--- include/drm/drm_dp_helper.h | 102 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+)include/drm/drm_dp_helper.h +0
-0
include/drm/drm_dp_helper.h line 188
Quoted 10 lines
include/drm/drm_dp_helper.h +7
-0@@ -179,6 +179,108 @@#define DP_GUID 0x030/* 1.2 */ +#define DP_DSC_SUPPORT 0x060/* DP 1.4 */ +# define DP_DSC_DECOMPRESSION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_REV 0x061 +# define DP_DSC_MAJOR_MASK (15 << 0) +# define DP_DSC_MINOR_MASK (15 << 4) +# define DP_DSC_MINOR_SHIFT 4
Nitpick: Hex is preferred for masks. Same for all masks below. MAJOR_SHIFT for completeness.
So should I add the MAJOR_SHIFT as well even though it will just 0?
Quoted 38 lines
include/drm/drm_dp_helper.h +38
-0+ +#define DP_DSC_RC_BUF_BLK_SIZE 0x062 +# define DP_DSC_RC_BUF_BLK_SIZE_1 0x0 +# define DP_DSC_RC_BUF_BLK_SIZE_4 0x1 +# define DP_DSC_RC_BUF_BLK_SIZE_16 0x2 +# define DP_DSC_RC_BUF_BLK_SIZE_64 0x3 + +#define DP_DSC_RC_BUF_SIZE 0x063 + +#define DP_DSC_SLICE_CAP_1 0x064 +# define DP_DSC_1_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_2_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_4_PER_DP_DSC_SINK (1 << 3) +# define DP_DSC_6_PER_DP_DSC_SINK (1 << 4) +# define DP_DSC_8_PER_DP_DSC_SINK (1 << 5) +# define DP_DSC_10_PER_DP_DSC_SINK (1 << 6) +# define DP_DSC_12_PER_DP_DSC_SINK (1 << 7) + +#define DP_DSC_LINE_BUF_BIT_DEPTH 0x065 +# define DP_DSC_LINE_BUF_BIT_DEPTH_MASK (15 << 0) +# define DP_DSC_LINE_BUF_BIT_DEPTH_9 0x0 +# define DP_DSC_LINE_BUF_BIT_DEPTH_10 0x1 +# define DP_DSC_LINE_BUF_BIT_DEPTH_11 0x2 +# define DP_DSC_LINE_BUF_BIT_DEPTH_12 0x3 +# define DP_DSC_LINE_BUF_BIT_DEPTH_13 0x4 +# define DP_DSC_LINE_BUF_BIT_DEPTH_14 0x5 +# define DP_DSC_LINE_BUF_BIT_DEPTH_15 0x6 +# define DP_DSC_LINE_BUF_BIT_DEPTH_16 0x7 +# define DP_DSC_LINE_BUF_BIT_DEPTH_8 0x8 + +#define DP_DSC_BLK_PREDICTION_SUPPORT 0x066 +# define DP_DSC_BLK_PREDICTION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067/* eDP 1.4 */ + +#define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068/* eDP 1.4 */ + +#define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069
include/drm/drm_dp_helper.h line 236
Quoted 10 lines
include/drm/drm_dp_helper.h +10
-0+# define DP_DSC_RGB (1 << 0) +# define DP_DSC_YCbCr444 (1 << 1) +# define DP_DSC_YCbCr422_Simple (1 << 2) +# define DP_DSC_YCbCr422_Native (1 << 3) +# define DP_DSC_YCbCr420_Native (1 << 4) + +#define DP_DSC_DEC_COLOR_DEPTH_CAP 0x06A +# define DP_DSC_8_BPC (1 << 1) +# define DP_DSC_10_BPC (1 << 2) +# define DP_DSC_12_BPC (1 >> 3)
Oops, shifting to wrong direction!
Oops, yes that is my mistake, I will fix the shift direction.
Quoted 6 lines
include/drm/drm_dp_helper.h +6
-0+ +#define DP_DSC_PEAK_THROUGHPUT 0x06B +# define DP_DSC_THROUGHPUT_MODE_0_340 0x1 +# define DP_DSC_THROUGHPUT_MODE_0_400 0x2 +# define DP_DSC_THROUGHPUT_MODE_0_450 0x3 +# define DP_DSC_THROUGHPUT_MODE_0_500 0x4
include/drm/drm_dp_helper.h line 252
Quoted 10 lines
include/drm/drm_dp_helper.h +10
-0+# define DP_DSC_THROUGHPUT_MODE_0_550 0x5 +# define DP_DSC_THROUGHPUT_MODE_0_600 0x6 +# define DP_DSC_THROUGHPUT_MODE_0_650 0x7 +# define DP_DSC_THROUGHPUT_MODE_0_700 0x8 +# define DP_DSC_THROUGHPUT_MODE_0_750 0x9 +# define DP_DSC_THROUGHPUT_MODE_0_800 0xA +# define DP_DSC_THROUGHPUT_MODE_0_850 0xB +# define DP_DSC_THROUGHPUT_MODE_0_900 0xC +# define DP_DSC_THROUGHPUT_MODE_0_950 0xD +# define DP_DSC_THROUGHPUT_MODE_0_1000 0xE
Nitpick: MODE_0_MASK and MODE_0_SHIFT for completeness. Seems inconsistent to use hex for MODE_0 values and dec for MODE_1 values.
For Mode 0, it would be all these values shifted by 0, should I add the shifts by 0 for consistency with MODE_1?
And yes I will add MODE_0 MASK and SHIFT.
Regards
Manasi
Quoted 24 lines
include/drm/drm_dp_helper.h +24
-0+# define DP_DSC_THROUGHPUT_MODE_1_MASK (15 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4 +# define DP_DSC_THROUGHPUT_MODE_1_340 (1 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_400 (2 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_450 (3 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_500 (4 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_550 (5 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_600 (6 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_650 (7 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_700 (8 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_750 (9 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_800 (10 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_850 (11 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_900 (12 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_950 (13 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4) + +#define DP_DSC_MAX_SLICE_WIDTH 0x06C + +#define DP_DSC_SLICE_CAP_2 0x06D +# define DP_DSC_16_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_20_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_24_PER_DP_DSC_SINK (1 << 2) +
include/drm/drm_dp_helper.h line 286
Quoted 10 lines
include/drm/drm_dp_helper.h +7
-0+#define DP_DSC_BITS_PER_PIXEL_INC 0x06F +# define DP_DSC_BITS_PER_PIXEL_1_16 0x0 +# define DP_DSC_BITS_PER_PIXEL_1_8 0x1 +# define DP_DSC_BITS_PER_PIXEL_1_4 0x2 +# define DP_DSC_BITS_PER_PIXEL_1_2 0x3 +# define DP_DSC_BITS_PER_PIXEL_1 0x4 +#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[Your MUA messed up the quoting, FTFY below.]
Quoted 44 lines · Manasi D
Quoted 33 lines · Manasi Navare
Quoted 10 lines
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC.
v2:
* Rebased on drm-tipSigned-off-by Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Paulo Zanoni <[email protected]>Tedious work to cross check this stuff against the spec... found one real issue; while at it please fix a few nitpicks that I would otherwise have ignored.
BR,
Jani.Quoted 13 lines
--- include/drm/drm_dp_helper.h | 102 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+)include/drm/drm_dp_helper.h +0
-0@@ -179,6 +179,108 @@#define DP_GUID 0x030/* 1.2 */ Quoted 11 lines
include/drm/drm_dp_helper.h line 188
Quoted 7 lines
include/drm/drm_dp_helper.h +7
-0+#define DP_DSC_SUPPORT 0x060/* DP 1.4 */ +# define DP_DSC_DECOMPRESSION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_REV 0x061 +# define DP_DSC_MAJOR_MASK (15 << 0) +# define DP_DSC_MINOR_MASK (15 << 4) +# define DP_DSC_MINOR_SHIFT 4Nitpick: Hex is preferred for masks. Same for all masks below.
MAJOR_SHIFTfor completeness.
Quoted 1 line
So should I add the
MAJOR_SHIFTas well even though it will just 0?
Yes, 0 is not special here. Having it is also self-documenting, so you don't have to look up the DP spec to check.
Quoted 75 lines
Quoted 44 lines
Quoted 44 lines
include/drm/drm_dp_helper.h +42
-0+ +#define DP_DSC_RC_BUF_BLK_SIZE 0x062 +# define DP_DSC_RC_BUF_BLK_SIZE_1 0x0 +# define DP_DSC_RC_BUF_BLK_SIZE_4 0x1 +# define DP_DSC_RC_BUF_BLK_SIZE_16 0x2 +# define DP_DSC_RC_BUF_BLK_SIZE_64 0x3 + +#define DP_DSC_RC_BUF_SIZE 0x063 + +#define DP_DSC_SLICE_CAP_1 0x064 +# define DP_DSC_1_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_2_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_4_PER_DP_DSC_SINK (1 << 3) +# define DP_DSC_6_PER_DP_DSC_SINK (1 << 4) +# define DP_DSC_8_PER_DP_DSC_SINK (1 << 5) +# define DP_DSC_10_PER_DP_DSC_SINK (1 << 6) +# define DP_DSC_12_PER_DP_DSC_SINK (1 << 7) + +#define DP_DSC_LINE_BUF_BIT_DEPTH 0x065 +# define DP_DSC_LINE_BUF_BIT_DEPTH_MASK (15 << 0) +# define DP_DSC_LINE_BUF_BIT_DEPTH_9 0x0 +# define DP_DSC_LINE_BUF_BIT_DEPTH_10 0x1 +# define DP_DSC_LINE_BUF_BIT_DEPTH_11 0x2 +# define DP_DSC_LINE_BUF_BIT_DEPTH_12 0x3 +# define DP_DSC_LINE_BUF_BIT_DEPTH_13 0x4 +# define DP_DSC_LINE_BUF_BIT_DEPTH_14 0x5 +# define DP_DSC_LINE_BUF_BIT_DEPTH_15 0x6 +# define DP_DSC_LINE_BUF_BIT_DEPTH_16 0x7 +# define DP_DSC_LINE_BUF_BIT_DEPTH_8 0x8 + +#define DP_DSC_BLK_PREDICTION_SUPPORT 0x066 +# define DP_DSC_BLK_PREDICTION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067/* eDP 1.4 */ + +#define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068/* eDP 1.4 */ + +#define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069 +# define DP_DSC_RGB (1 << 0) +# define DP_DSC_YCbCr444 (1 << 1) +# define DP_DSC_YCbCr422_Simple (1 << 2) +# define DP_DSC_YCbCr422_Native (1 << 3)Quoted 8 lines
include/drm/drm_dp_helper.h line 236
Quoted 6 lines
include/drm/drm_dp_helper.h +6
-0+# define DP_DSC_YCbCr420_Native (1 << 4) + +#define DP_DSC_DEC_COLOR_DEPTH_CAP 0x06A +# define DP_DSC_8_BPC (1 << 1) +# define DP_DSC_10_BPC (1 << 2) +# define DP_DSC_12_BPC (1 >> 3)Oops, shifting to wrong direction!
Oops, yes that is my mistake, I will fix the shift direction.
Quoted 11 lines
Quoted 11 lines
include/drm/drm_dp_helper.h +11
-0+ +#define DP_DSC_PEAK_THROUGHPUT 0x06B +# define DP_DSC_THROUGHPUT_MODE_0_340 0x1 +# define DP_DSC_THROUGHPUT_MODE_0_400 0x2 +# define DP_DSC_THROUGHPUT_MODE_0_450 0x3 +# define DP_DSC_THROUGHPUT_MODE_0_500 0x4 +# define DP_DSC_THROUGHPUT_MODE_0_550 0x5 +# define DP_DSC_THROUGHPUT_MODE_0_600 0x6 +# define DP_DSC_THROUGHPUT_MODE_0_650 0x7 +# define DP_DSC_THROUGHPUT_MODE_0_700 0x8 +# define DP_DSC_THROUGHPUT_MODE_0_750 0x9Quoted 8 lines
include/drm/drm_dp_helper.h line 252
Quoted 5 lines
include/drm/drm_dp_helper.h +5
-0+# define DP_DSC_THROUGHPUT_MODE_0_800 0xA +# define DP_DSC_THROUGHPUT_MODE_0_850 0xB +# define DP_DSC_THROUGHPUT_MODE_0_900 0xC +# define DP_DSC_THROUGHPUT_MODE_0_950 0xD +# define DP_DSC_THROUGHPUT_MODE_0_1000 0xENitpick:
MODE_0_MASKandMODE_0_SHIFTfor completeness. Seems inconsistent to use hex forMODE_0values and dec forMODE_1values.
Quoted 2 lines
For Mode 0, it would be all these values shifted by 0, should I add the shifts by 0 for consistency with
MODE_1?
Nah, that I think is not needed, but I could go both ways. (However for defining bits we usually use BIT(0) or (1 << 0) rather than plain 1.)
Quoted 1 line
And yes I will add
MODE_0MASK and SHIFT.
Thanks.
BR,
Jani.
Quoted 33 lines
Regards
ManasiQuoted 30 lines
Quoted 30 lines
include/drm/drm_dp_helper.h +29
-0+# define DP_DSC_THROUGHPUT_MODE_1_MASK (15 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4 +# define DP_DSC_THROUGHPUT_MODE_1_340 (1 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_400 (2 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_450 (3 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_500 (4 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_550 (5 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_600 (6 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_650 (7 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_700 (8 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_750 (9 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_800 (10 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_850 (11 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_900 (12 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_950 (13 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4) + +#define DP_DSC_MAX_SLICE_WIDTH 0x06C + +#define DP_DSC_SLICE_CAP_2 0x06D +# define DP_DSC_16_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_20_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_24_PER_DP_DSC_SINK (1 << 2) + +#define DP_DSC_BITS_PER_PIXEL_INC 0x06F +# define DP_DSC_BITS_PER_PIXEL_1_16 0x0 +# define DP_DSC_BITS_PER_PIXEL_1_8 0x1 +# define DP_DSC_BITS_PER_PIXEL_1_4 0x2 +# define DP_DSC_BITS_PER_PIXEL_1_2 0x3
Quoted 12 lines
Quoted 8 lines
include/drm/drm_dp_helper.h line 286
Quoted 5 lines
include/drm/drm_dp_helper.h +2
-0+# define DP_DSC_BITS_PER_PIXEL_1 0x4 +#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */ --
Jani Nikula, Intel Open Source Technology CenterSignature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 128 lines · Jani Nikula
[Your MUA messed up the quoting, FTFY below.]
Quoted 44 lines · Manasi D
Quoted 33 lines · Manasi Navare
Quoted 10 lines
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC.
v2:
* Rebased on drm-tipSigned-off-by Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Paulo Zanoni <[email protected]>Tedious work to cross check this stuff against the spec... found one real issue; while at it please fix a few nitpicks that I would otherwise have ignored.
BR,
Jani.Quoted 13 lines
--- include/drm/drm_dp_helper.h | 102 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+)include/drm/drm_dp_helper.h +0
-0@@ -179,6 +179,108 @@#define DP_GUID 0x030/* 1.2 */ Quoted 11 lines
include/drm/drm_dp_helper.h line 188
Quoted 7 lines
include/drm/drm_dp_helper.h +7
-0+#define DP_DSC_SUPPORT 0x060/* DP 1.4 */ +# define DP_DSC_DECOMPRESSION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_REV 0x061 +# define DP_DSC_MAJOR_MASK (15 << 0) +# define DP_DSC_MINOR_MASK (15 << 4) +# define DP_DSC_MINOR_SHIFT 4Nitpick: Hex is preferred for masks. Same for all masks below.
MAJOR_SHIFTfor completeness.Quoted 1 line
So should I add the
MAJOR_SHIFTas well even though it will just 0?Yes, 0 is not special here. Having it is also self-documenting, so you don't have to look up the DP spec to check.
Quoted 75 lines
Quoted 44 lines
Quoted 44 lines
include/drm/drm_dp_helper.h +42
-0+ +#define DP_DSC_RC_BUF_BLK_SIZE 0x062 +# define DP_DSC_RC_BUF_BLK_SIZE_1 0x0 +# define DP_DSC_RC_BUF_BLK_SIZE_4 0x1 +# define DP_DSC_RC_BUF_BLK_SIZE_16 0x2 +# define DP_DSC_RC_BUF_BLK_SIZE_64 0x3 + +#define DP_DSC_RC_BUF_SIZE 0x063 + +#define DP_DSC_SLICE_CAP_1 0x064 +# define DP_DSC_1_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_2_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_4_PER_DP_DSC_SINK (1 << 3) +# define DP_DSC_6_PER_DP_DSC_SINK (1 << 4) +# define DP_DSC_8_PER_DP_DSC_SINK (1 << 5) +# define DP_DSC_10_PER_DP_DSC_SINK (1 << 6) +# define DP_DSC_12_PER_DP_DSC_SINK (1 << 7) + +#define DP_DSC_LINE_BUF_BIT_DEPTH 0x065 +# define DP_DSC_LINE_BUF_BIT_DEPTH_MASK (15 << 0) +# define DP_DSC_LINE_BUF_BIT_DEPTH_9 0x0 +# define DP_DSC_LINE_BUF_BIT_DEPTH_10 0x1 +# define DP_DSC_LINE_BUF_BIT_DEPTH_11 0x2 +# define DP_DSC_LINE_BUF_BIT_DEPTH_12 0x3 +# define DP_DSC_LINE_BUF_BIT_DEPTH_13 0x4 +# define DP_DSC_LINE_BUF_BIT_DEPTH_14 0x5 +# define DP_DSC_LINE_BUF_BIT_DEPTH_15 0x6 +# define DP_DSC_LINE_BUF_BIT_DEPTH_16 0x7 +# define DP_DSC_LINE_BUF_BIT_DEPTH_8 0x8 + +#define DP_DSC_BLK_PREDICTION_SUPPORT 0x066 +# define DP_DSC_BLK_PREDICTION_IS_SUPPORTED (1 << 0) + +#define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067/* eDP 1.4 */ + +#define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068/* eDP 1.4 */ + +#define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069 +# define DP_DSC_RGB (1 << 0) +# define DP_DSC_YCbCr444 (1 << 1) +# define DP_DSC_YCbCr422_Simple (1 << 2) +# define DP_DSC_YCbCr422_Native (1 << 3)Quoted 8 lines
include/drm/drm_dp_helper.h line 236
Quoted 6 lines
include/drm/drm_dp_helper.h +6
-0+# define DP_DSC_YCbCr420_Native (1 << 4) + +#define DP_DSC_DEC_COLOR_DEPTH_CAP 0x06A +# define DP_DSC_8_BPC (1 << 1) +# define DP_DSC_10_BPC (1 << 2) +# define DP_DSC_12_BPC (1 >> 3)Oops, shifting to wrong direction!
Oops, yes that is my mistake, I will fix the shift direction.
Quoted 19 lines
Quoted 6 lines
include/drm/drm_dp_helper.h +6
-0+ +#define DP_DSC_PEAK_THROUGHPUT 0x06B +# define DP_DSC_THROUGHPUT_MODE_0_340 0x1 +# define DP_DSC_THROUGHPUT_MODE_0_400 0x2 +# define DP_DSC_THROUGHPUT_MODE_0_450 0x3 +# define DP_DSC_THROUGHPUT_MODE_0_500 0x4include/drm/drm_dp_helper.h line 252
Quoted 10 lines
include/drm/drm_dp_helper.h +10
-0+# define DP_DSC_THROUGHPUT_MODE_0_550 0x5 +# define DP_DSC_THROUGHPUT_MODE_0_600 0x6 +# define DP_DSC_THROUGHPUT_MODE_0_650 0x7 +# define DP_DSC_THROUGHPUT_MODE_0_700 0x8 +# define DP_DSC_THROUGHPUT_MODE_0_750 0x9 +# define DP_DSC_THROUGHPUT_MODE_0_800 0xA +# define DP_DSC_THROUGHPUT_MODE_0_850 0xB +# define DP_DSC_THROUGHPUT_MODE_0_900 0xC +# define DP_DSC_THROUGHPUT_MODE_0_950 0xD +# define DP_DSC_THROUGHPUT_MODE_0_1000 0xENitpick:
MODE_0_MASKandMODE_0_SHIFTfor completeness. Seems inconsistent to use hex forMODE_0values and dec forMODE_1values.
Quoted 6 lines
Quoted 2 lines
For Mode 0, it would be all these values shifted by 0, should I add the shifts by 0 for consistency with
MODE_1?Nah, that I think is not needed, but I could go both ways. (However for defining bits we usually use BIT(0) or (1 << 0) rather than plain 1.)
So in case of throughput mode 0, its not bit defs but values
Eg: mode 400 is 2 and mode 450 is 3, so in this case should it be (1 << 0) and (2 << 0) and (3 << 0) so that its consistent with the Mode1 decimals with shift of 0?
Regards
Manasi
Quoted 52 lines
Quoted 1 line
And yes I will add
MODE_0MASK and SHIFT.Thanks.
BR,
Jani.Quoted 45 lines
Regards
ManasiQuoted 38 lines
Quoted 25 lines
include/drm/drm_dp_helper.h +24
-0+# define DP_DSC_THROUGHPUT_MODE_1_MASK (15 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_SHIFT 4 +# define DP_DSC_THROUGHPUT_MODE_1_340 (1 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_400 (2 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_450 (3 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_500 (4 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_550 (5 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_600 (6 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_650 (7 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_700 (8 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_750 (9 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_800 (10 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_850 (11 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_900 (12 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_950 (13 << 4) +# define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4) + +#define DP_DSC_MAX_SLICE_WIDTH 0x06C + +#define DP_DSC_SLICE_CAP_2 0x06D +# define DP_DSC_16_PER_DP_DSC_SINK (1 << 0) +# define DP_DSC_20_PER_DP_DSC_SINK (1 << 1) +# define DP_DSC_24_PER_DP_DSC_SINK (1 << 2) +include/drm/drm_dp_helper.h line 286
Quoted 10 lines
include/drm/drm_dp_helper.h +7
-0+#define DP_DSC_BITS_PER_PIXEL_INC 0x06F +# define DP_DSC_BITS_PER_PIXEL_1_16 0x0 +# define DP_DSC_BITS_PER_PIXEL_1_8 0x1 +# define DP_DSC_BITS_PER_PIXEL_1_4 0x2 +# define DP_DSC_BITS_PER_PIXEL_1_2 0x3 +# define DP_DSC_BITS_PER_PIXEL_1 0x4 +#define DP_PSR_SUPPORT 0x070/* XXX 1.2? */ # define DP_PSR_IS_SUPPORTED 1# define DP_PSR2_IS_SUPPORTED 2/* eDP 1.4 */ --
Jani Nikula, Intel Open Source Technology CenterSignature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel