acpi: acpica: fix acpi operand cache leak
Subsystems (2)
PATCH v2 1/1 acpi: acpica: fix acpi operand cache leak
I'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.
Boot log of ACPI operand cache leak is as follows:
Quoted 18 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler (20160930/evevent-131) [ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf
Quoted 8 lines
[ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30
When early abort is occurred due to invalid ACPI information, Linux kernel terminates ACPI by calling acpi_terminate() function.
The function calls acpi_ns_terminate() function to delete namespace data and ACPI operand cache (acpi_gbl_module_code_list).
But the deletion code in acpi_ns_terminate() function is wrapped in ACPI_EXEC_APP definition, therefore the code is only executed when the definition exists.
If the define doesn't exist, ACPI operand cache (acpi_gbl_module_code_list) is leaked, and stack dump is shown in kernel log.
This causes a security threat because the old kernel (<= 4.9) shows memory locations of kernel functions in stack dump, therefore kernel ASLR can be neutralized.
To fix ACPI operand leak for enhancing security, I made a patch which removes the ACPI_EXEC_APP define in acpi_ns_terminate() function for executing the deletion code unconditionally.
I hope that this patch improves the security of Linux kernel.
Thank you.
---
Changes since v1: move position of variables to remove compile warning.
drivers/acpi/acpica/nsutils.c | 23 +++++++++--------------
1 file changed, 9 insertions(+), 14 deletions(-)
drivers/acpi/acpica/nsutils.c +9 -14
@@ -594,25 +594,20 @@ struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle)void acpi_ns_terminate (void ) {acpi_status status; +union acpi_operand_object *prev; +union acpi_operand_object *next;ACPI_FUNCTION_TRACE (ns_terminate); -#ifdef ACPI_EXEC_APP - { -union acpi_operand_object *prev; -union acpi_operand_object *next; +/* Delete any module-level code blocks */ -/* Delete any module-level code blocks */ - - next = acpi_gbl_module_code_list; -while (next) { - prev = next; - next = next->method.mutex; - prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ -acpi_ut_remove_reference (prev); - } + next = acpi_gbl_module_code_list; +while (next) { + prev = next; + next = next->method.mutex; + prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ +acpi_ut_remove_reference (prev); } -#endif /* * Free the entire namespace -- all nodes and all objects
Signature · 1 line
2.1.4
Zheng
Hi,
Quoted 13 lines
From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.
Quoted 28 lines
Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30
I'm more interested in the way of triggering AE_NOT_ACQUIRED error.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?
Quoted 6 lines
When early abort is occurred due to invalid ACPI information, Linux kernel terminates ACPI by calling
acpi_terminate()function.
The function callsacpi_ns_terminate()function to delete namespace data and ACPI operand cache (acpi_gbl_module_code_list).
Quoted 6 lines
But the deletion code in
acpi_ns_terminate()function is wrapped inACPI_EXEC_APPdefinition, therefore the code is only executed when the definition exists.
If the define doesn't exist, ACPI operand cache (acpi_gbl_module_code_list) is leaked, and stack dump is shown in kernel log.
acpi_ns_terminate() actually shouldn't be invoked by Linux. It's not fully functioning in Linux kernel environment.
Quoted 7 lines
This causes a security threat because the old kernel (<= 4.9) shows memory locations of kernel functions in stack dump, therefore kernel ASLR can be neutralized.
To fix ACPI operand leak for enhancing security, I made a patch which removes the
ACPI_EXEC_APPdefine inacpi_ns_terminate()function for executing the deletion code unconditionally.
However acpi_gbl_module_code_list deletion shouldn't be dependent on ACPI_EXEC_APP. So your change is acceptable.
Quoted 38 lines
I hope that this patch improves the security of Linux kernel.
Thank you.
Signed-off-by Seunghun Han <kkamagui(a)gmail.com>---
Changes since v1: move position of variables to remove compile warning.
drivers/acpi/acpica/nsutils.c| 23 +++++++++--------------1 file changed, 9 insertions(+), 14 deletions(-)drivers/acpi/acpica/nsutils.c +3
-11@@ -594,25 +594,20 @@ struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle)void acpi_ns_terminate (void ) {acpi_status status; +union acpi_operand_object *prev; +union acpi_operand_object *next;ACPI_FUNCTION_TRACE (ns_terminate); -#ifdef ACPI_EXEC_APP - { -union acpi_operand_object *prev; -union acpi_operand_object *next; +/* Delete any module-level code blocks */ -/* Delete any module-level code blocks */ - - next = acpi_gbl_module_code_list; -while (next) { - prev = next; - next = next->method.mutex; - prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */
drivers/acpi/acpica/nsutils.c struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle) · line 615
Quoted 10 lines
drivers/acpi/acpica/nsutils.c +6
-3- acpi_ut_remove_reference(prev); - } + next = acpi_gbl_module_code_list; +while (next) { + prev = next; + next = next->method.mutex; + prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ +acpi_ut_remove_reference (prev); } -#endif
Thus this looks OK to me.
Quoted 10 lines
drivers/acpi/acpica/nsutils.c +0
-1/* * Free the entire namespace -- all nodes and all objects -- 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 116 lines · Lv
Hi,
Quoted 13 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Quoted 28 lines
Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?Quoted 6 lines
When early abort is occurred due to invalid ACPI information, Linux kernel terminates ACPI by calling
acpi_terminate()function.
The function callsacpi_ns_terminate()function to delete namespace data and ACPI operand cache (acpi_gbl_module_code_list).Quoted 6 lines
But the deletion code in
acpi_ns_terminate()function is wrapped inACPI_EXEC_APPdefinition, therefore the code is only executed when the definition exists.
If the define doesn't exist, ACPI operand cache (acpi_gbl_module_code_list) is leaked, and stack dump is shown in kernel log.
acpi_ns_terminate()actually shouldn't be invoked by Linux. It's not fully functioning in Linux kernel environment.Quoted 7 lines
This causes a security threat because the old kernel (<= 4.9) shows memory locations of kernel functions in stack dump, therefore kernel ASLR can be neutralized.
To fix ACPI operand leak for enhancing security, I made a patch which removes the
ACPI_EXEC_APPdefine inacpi_ns_terminate()function for executing the deletion code unconditionally.However
acpi_gbl_module_code_listdeletion shouldn't be dependent onACPI_EXEC_APP. So your change is acceptable.Quoted 42 lines
I hope that this patch improves the security of Linux kernel.
Thank you.
Signed-off-by Seunghun Han <[email protected]>---
Changes since v1: move position of variables to remove compile warning.
drivers/acpi/acpica/nsutils.c| 23 +++++++++--------------1 file changed, 9 insertions(+), 14 deletions(-)drivers/acpi/acpica/nsutils.c +5
-13@@ -594,25 +594,20 @@ struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle)void acpi_ns_terminate (void ) {acpi_status status; +union acpi_operand_object *prev; +union acpi_operand_object *next;ACPI_FUNCTION_TRACE (ns_terminate); -#ifdef ACPI_EXEC_APP - { -union acpi_operand_object *prev; -union acpi_operand_object *next; +/* Delete any module-level code blocks */ -/* Delete any module-level code blocks */ - - next = acpi_gbl_module_code_list; -while (next) { - prev = next; - next = next->method.mutex; - prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ -acpi_ut_remove_reference (prev); - } + next = acpi_gbl_module_code_list; +while (next) {
Quoted 14 lines
drivers/acpi/acpica/nsutils.c struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle) · line 615
Quoted 6 lines
drivers/acpi/acpica/nsutils.c +4
-1+ prev = next; + next = next->method.mutex; + prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ +acpi_ut_remove_reference (prev); } -#endif Thus this looks OK to me.
Quoted 5 lines
drivers/acpi/acpica/nsutils.c +0
-1/* * Free the entire namespace -- all nodes and all objects -- 2.1.4
I still would prefer it to go in via the upstream.
Thanks,
Rafael
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?
Because of the ACPI interpreter error, ACPI function were terminated, so there is no directory "/proc/acpi".
And when I typed the acpidump command, errors were shown.
The error are as follows.
root@debian:/proc# acpidump -c on Cannot open directory - /sys/firmware/acpi/tables Could not get ACPI tables, AE_NOT_FOUND
root@debian:/proc# acpidump -c off Cannot open directory - /sys/firmware/acpi/tables Could not get ACPI tables, AE_NOT_FOUND
Could you tell me another way to get information for you? Thank you.
Best regards.
Quoted 89 lines
Quoted 69 lines
Quoted 6 lines
When early abort is occurred due to invalid ACPI information, Linux kernel terminates ACPI by calling
acpi_terminate()function.
The function callsacpi_ns_terminate()function to delete namespace data and ACPI operand cache (acpi_gbl_module_code_list).Quoted 6 lines
But the deletion code in
acpi_ns_terminate()function is wrapped inACPI_EXEC_APPdefinition, therefore the code is only executed when the definition exists.
If the define doesn't exist, ACPI operand cache (acpi_gbl_module_code_list) is leaked, and stack dump is shown in kernel log.
acpi_ns_terminate()actually shouldn't be invoked by Linux. It's not fully functioning in Linux kernel environment.Quoted 7 lines
This causes a security threat because the old kernel (<= 4.9) shows memory locations of kernel functions in stack dump, therefore kernel ASLR can be neutralized.
To fix ACPI operand leak for enhancing security, I made a patch which removes the
ACPI_EXEC_APPdefine inacpi_ns_terminate()function for executing the deletion code unconditionally.However
acpi_gbl_module_code_listdeletion shouldn't be dependent onACPI_EXEC_APP. So your change is acceptable.Quoted 42 lines
I hope that this patch improves the security of Linux kernel.
Thank you.
Signed-off-by Seunghun Han <[email protected]>---
Changes since v1: move position of variables to remove compile warning.
drivers/acpi/acpica/nsutils.c| 23 +++++++++--------------1 file changed, 9 insertions(+), 14 deletions(-)drivers/acpi/acpica/nsutils.c +5
-13@@ -594,25 +594,20 @@ struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle)void acpi_ns_terminate (void ) {acpi_status status; +union acpi_operand_object *prev; +union acpi_operand_object *next;ACPI_FUNCTION_TRACE (ns_terminate); -#ifdef ACPI_EXEC_APP - { -union acpi_operand_object *prev; -union acpi_operand_object *next; +/* Delete any module-level code blocks */ -/* Delete any module-level code blocks */ - - next = acpi_gbl_module_code_list; -while (next) { - prev = next; - next = next->method.mutex; - prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ -acpi_ut_remove_reference (prev); - } + next = acpi_gbl_module_code_list; +while (next) {Quoted 14 lines
drivers/acpi/acpica/nsutils.c struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle) · line 615
Quoted 6 lines
drivers/acpi/acpica/nsutils.c +4
-1+ prev = next; + next = next->method.mutex; + prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ +acpi_ut_remove_reference (prev); } -#endif Thus this looks OK to me.
Quoted 5 lines
drivers/acpi/acpica/nsutils.c +0
-1/* * Free the entire namespace -- all nodes and all objects -- 2.1.4
I still would prefer it to go in via the upstream.
Thanks,
Rafael
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 52 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 47 lines · Lv
Quoted 46 lines
Hi,
Quoted 13 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Quoted 28 lines
Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?
I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
[ 0.000000] ACPI: FACP 0x00000000DFFF00F0 0000F4 (v04 VBOX VBOXFACP 00000001 ASL 00000061) [ 0.000000] FACP DUMP [ 0.000000] 0x0000: 46 41 43 50 F4 00 00 00 04 60 56 42 4F 58 20 20 [ 0.000000] 0x0010: 56 42 4F 58 46 41 43 50 01 00 00 00 41 53 4C 20 [ 0.000000] 0x0020: 61 00 00 00 00 02 FF DF 80 04 FF DF 41 41 41 41 [ 0.000000] 0x0030: 2E 44 00 00 A1 A0 00 00 00 40 00 00 00 00 00 00 [ 0.000000] 0x0040: 04 40 00 00 00 00 00 00 00 00 00 00 08 40 00 00 [ 0.000000] 0x0050: 20 40 00 00 00 00 00 00 04 02 00 04 02 00 00 00 [ 0.000000] 0x0060: 65 00 E9 03 00 00 00 00 00 00 00 00 00 03 00 00 [ 0.000000] 0x0070: 41 05 00 00 01 08 00 01 50 40 00 00 00 00 00 00 [ 0.000000] 0x0080: 10 00 00 00 00 02 FF DF 00 00 00 00 80 04 FF DF [ 0.000000] 0x0090: 00 00 00 00 01 20 00 02 00 40 00 00 00 00 00 00 [ 0.000000] 0x00A0: 00 00 00 00 00 00 00 00 00 00 00 00 01 10 00 02 [ 0.000000] 0x00B0: 04 40 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 0.000000] 0x00C0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 0.000000] 0x00D0: 01 20 00 03 08 40 00 00 00 00 00 00 01 10 00 01 [ 0.000000] 0x00E0: 20 40 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 0.000000] 0x00F0: 00 00 00 00
[ 0.000000] ACPI: FACS 0x00000000DFFF0200 000040 [ 0.000000] FACS DUMP [ 0.000000] 0x0000: 46 41 43 53 40 00 00 00 00 00 00 00 00 00 00 00 [ 0.000000] 0x0010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 0.000000] 0x0020: 01 00 00 00 00 00 00 00 00 41 00 00 00 00 00 00 [ 0.000000] 0x0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 0.000000] ACPI: FACS 0x00000000DFFF0200 000040 [ 0.000000] FACS DUMP [ 0.000000] 0x0000: 46 41 43 53 40 00 00 00 00 00 00 00 00 00 00 00 [ 0.000000] 0x0010: 00 00 00 00 00 00 00 00 00 41 41 41 41 41 41 41 [ 0.000000] 0x0020: 01 00 00 00 00 00 00 00 00 41 00 00 00 00 00 00 [ 0.000000] 0x0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
[ 0.000000] ACPI: APIC 0x00000000DFFF0240 00006C (v02 VBOX VBOXAPIC 00000001 ASL 00000061) [ 0.000000] APIC DUMP [ 0.000000] 0x0000: 41 50 49 43 6C 00 00 00 02 21 56 42 4F 58 20 20 [ 0.000000] 0x0010: 56 42 4F 58 41 50 49 43 01 00 00 00 41 53 4C 20 [ 0.000000] 0x0020: 61 00 00 00 00 00 E0 FE 01 00 00 00 02 0A 00 00 [ 0.000000] 0x0030: 02 00 00 00 00 00 02 0A 00 09 09 00 00 00 0D 00 [ 0.000000] 0x0040: 00 08 00 00 01 00 41 41 41 41 41 41 41 41 41 00 [ 0.000000] 0x0050: 00 08 02 02 01 00 00 00 00 08 03 03 01 00 00 00 [ 0.000000] 0x0060: 01 0C 04 00 00 00 C0 FE 00 00 00 00
If you need additional data, please let me know.
Thank you.
Best regards.
Quoted 108 lines
Because of the ACPI interpreter error, ACPI function were terminated, so there is no directory "
/proc/acpi".
And when I typed the acpidump command, errors were shown.The error are as follows.
root@debian:/proc# acpidump -c on Cannot open directory - /sys/firmware/acpi/tables Could not get ACPI tables, AE_NOT_FOUNDroot@debian:/proc# acpidump -c off Cannot open directory - /sys/firmware/acpi/tables Could not get ACPI tables, AE_NOT_FOUNDCould you tell me another way to get information for you? Thank you.
Best regards.
Quoted 89 lines
Quoted 69 lines
Quoted 6 lines
When early abort is occurred due to invalid ACPI information, Linux kernel terminates ACPI by calling
acpi_terminate()function.
The function callsacpi_ns_terminate()function to delete namespace data and ACPI operand cache (acpi_gbl_module_code_list).Quoted 6 lines
But the deletion code in
acpi_ns_terminate()function is wrapped inACPI_EXEC_APPdefinition, therefore the code is only executed when the definition exists.
If the define doesn't exist, ACPI operand cache (acpi_gbl_module_code_list) is leaked, and stack dump is shown in kernel log.
acpi_ns_terminate()actually shouldn't be invoked by Linux. It's not fully functioning in Linux kernel environment.Quoted 7 lines
This causes a security threat because the old kernel (<= 4.9) shows memory locations of kernel functions in stack dump, therefore kernel ASLR can be neutralized.
To fix ACPI operand leak for enhancing security, I made a patch which removes the
ACPI_EXEC_APPdefine inacpi_ns_terminate()function for executing the deletion code unconditionally.However
acpi_gbl_module_code_listdeletion shouldn't be dependent onACPI_EXEC_APP. So your change is acceptable.Quoted 42 lines
I hope that this patch improves the security of Linux kernel.
Thank you.
Signed-off-by Seunghun Han <[email protected]>---
Changes since v1: move position of variables to remove compile warning.
drivers/acpi/acpica/nsutils.c| 23 +++++++++--------------1 file changed, 9 insertions(+), 14 deletions(-)drivers/acpi/acpica/nsutils.c +5
-13@@ -594,25 +594,20 @@ struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle)void acpi_ns_terminate (void ) {acpi_status status; +union acpi_operand_object *prev; +union acpi_operand_object *next;ACPI_FUNCTION_TRACE (ns_terminate); -#ifdef ACPI_EXEC_APP - { -union acpi_operand_object *prev; -union acpi_operand_object *next; +/* Delete any module-level code blocks */ -/* Delete any module-level code blocks */ - - next = acpi_gbl_module_code_list; -while (next) { - prev = next; - next = next->method.mutex; - prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ -acpi_ut_remove_reference (prev); - } + next = acpi_gbl_module_code_list; +while (next) {Quoted 14 lines
drivers/acpi/acpica/nsutils.c struct acpi_namespace_node *acpi_ns_validate_handle(acpi_handle handle) · line 615
Quoted 6 lines
drivers/acpi/acpica/nsutils.c +4
-1+ prev = next; + next = next->method.mutex; + prev->method.mutex =NULL ;/* Clear the Mutex (cheated) field */ +acpi_ut_remove_reference (prev); } -#endif Thus this looks OK to me.
Quoted 5 lines
drivers/acpi/acpica/nsutils.c +0
-1/* * Free the entire namespace -- all nodes and all objects -- 2.1.4
I still would prefer it to go in via the upstream.
Thanks,
Rafael
Quoted 56 lines · Seunghun Han
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 50 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
Rafael
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 63 lines · Seunghun Han
Quoted 56 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 50 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
Quoted 7 lines
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
Rafael
As you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Thank you.
Best regards.
Quoted 76 lines · Seunghun Han
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 63 lines · Seunghun Han
Quoted 56 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 50 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
Quoted 7 lines
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
Rafael
Quoted 6 lines
As you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Thanks,
Rafael
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 80 lines · Seunghun Han
Quoted 79 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 63 lines · Seunghun Han
Quoted 56 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 50 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
Quoted 7 lines
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
Quoted 9 lines
Quoted 8 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Quoted 8 lines
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Thanks,
Rafael
Yes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
Thank you.
Best regards.
Quoted 92 lines · Seunghun Han
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 80 lines · Seunghun Han
Quoted 79 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 63 lines · Seunghun Han
Quoted 56 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 50 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
Quoted 7 lines
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 8 lines
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
If the system basically doesn't work, that information isn't particularly useful.
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Quoted 7 lines
Quoted 3 lines
Thanks,
RafaelYes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
A virtual box or a guest can run without ACPI tables. A bare metal system where ACPI tables are necessary will be more-or-less unusable if the kernel cannot use them (it won't be able to detect interrupt controllers and the PCI host bridge just for starters).
Running a guest with totally broken ACPI tables requires root privileges on the host. Running a bare metal system with totally broken ACPI tables (which seems to be your basic concern) may be a good research project, but nobody will do that in practice. And everybody who tries that will notice what's going on.
Yes, you found a bug, but I still am not convinced about how this is security-related.
Thanks,
Rafael
Hi, Rafael.
I agree with you and I added my opinion below.
2017-02-25 1:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 130 lines · Seunghun Han
Quoted 92 lines
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 80 lines · Seunghun Han
Quoted 79 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 63 lines · Seunghun Han
Quoted 56 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 50 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
Quoted 7 lines
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 8 lines
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
If the system basically doesn't work, that information isn't particularly useful.
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Quoted 7 lines
Quoted 3 lines
Thanks,
RafaelYes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
A virtual box or a guest can run without ACPI tables. A bare metal system where ACPI tables are necessary will be more-or-less unusable if the kernel cannot use them (it won't be able to detect interrupt controllers and the PCI host bridge just for starters).
Quoted 6 lines
Running a guest with totally broken ACPI tables requires root privileges on the host. Running a bare metal system with totally broken ACPI tables (which seems to be your basic concern) may be a good research project, but nobody will do that in practice. And everybody who tries that will notice what's going on.
Yes, you found a bug, but I still am not convinced about how this is security-related.
I totally agree with you that this case is not in practice now.
I just started researching on ACPI, and I don't have enough ideas to occur a security problem using a bug. I just think that it has a little possibility which is security-related.
Thank you so much for your guides.
It helps me a lot to change my research direction.
So, could my patch be merged in next kernel (4.11 rc-1)? or do I need to do something for it?
Please let me know.
Best regards.
Quoted 4 lines
Thanks,
Rafael
Rafael J. Wysocki
maintainerQuoted 147 lines · Seunghun Han
Hi, Rafael.
I agree with you and I added my opinion below.
2017-02-25 1:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 130 lines · Seunghun Han
Quoted 92 lines
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 80 lines · Seunghun Han
Quoted 79 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 63 lines · Seunghun Han
Quoted 56 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 50 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 45 lines · Lv
Quoted 44 lines
Hi,
Quoted 41 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Seunghun Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device) [ 0.175504] ACPI: Added _OSI(Processor Device) [ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.177032] ACPI: Added _OSI(Processor Aggregator Device) [ 0.178284] ACPI: SCI (IRQ16705) allocation failed [ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System Control Interrupt handler(20160930/evevent-131)
Quoted 20 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter [ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281) [ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects [ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2 [ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 0.188000] Call Trace: [ 0.188000] ? dump_stack+0x5c/0x7d [ 0.188000] ? kmem_cache_destroy+0x224/0x230 [ 0.188000] ? acpi_sleep_proc_init+0x22/0x22 [ 0.188000] ? acpi_os_delete_cache+0xa/0xd [ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b [ 0.188000] ? acpi_terminate+0x5/0xf [ 0.188000] ? acpi_init+0x288/0x32e [ 0.188000] ? __class_create+0x4c/0x80 [ 0.188000] ? video_setup+0x7a/0x7a [ 0.188000] ? do_one_initcall+0x4e/0x1b0 [ 0.188000] ? kernel_init_freeable+0x194/0x21a [ 0.188000] ? rest_init+0x80/0x80 [ 0.188000] ? kernel_init+0xa/0x100 [ 0.188000] ? ret_from_fork+0x25/0x30Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and "acpidump -c off" output?I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
Quoted 7 lines
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 8 lines
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
If the system basically doesn't work, that information isn't particularly useful.
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Quoted 7 lines
Quoted 3 lines
Thanks,
RafaelYes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
A virtual box or a guest can run without ACPI tables. A bare metal system where ACPI tables are necessary will be more-or-less unusable if the kernel cannot use them (it won't be able to detect interrupt controllers and the PCI host bridge just for starters).
Quoted 6 lines
Running a guest with totally broken ACPI tables requires root privileges on the host. Running a bare metal system with totally broken ACPI tables (which seems to be your basic concern) may be a good research project, but nobody will do that in practice. And everybody who tries that will notice what's going on.
Yes, you found a bug, but I still am not convinced about how this is security-related.
I totally agree with you that this case is not in practice now.
I just started researching on ACPI, and I don't have enough ideas to occur a security problem using a bug. I just think that it has a little possibility which is security-related.
Quoted 6 lines
Thank you so much for your guides.
It helps me a lot to change my research direction.So, could my patch be merged in next kernel (4.11 rc-1)? or do I need to do something for it?
Please let me know.
Generally, ACPICA patches (and this is one of them) have to go in via the upstream ACPICA project maintained by Bob Moore and Lv. Please see MAINTAINERS for pointers to the mailing list etc.
Lv, can you please advise on the next steps?
Thanks,
Rafael
Hi, Rafael
Quoted 163 lines
From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Rafael J. Wysocki
Subject: Re: [PATCH v2] acpi: acpica: fix acpi operand cache leakQuoted 33 lines · Seunghun Han
Hi, Rafael.
I agree with you and I added my opinion below.
2017-02-25 1:50 GMT+09:00 Rafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 28 lines · Seunghun Han
Quoted 27 lines
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 22 lines · Seunghun Han
Quoted 21 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 16 lines · Seunghun Han
Quoted 15 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <kkamagui(a)gmail.com>:
Quoted 9 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 4 lines · Lv
Quoted 3 lines
Hi,
Quoted 1 line
From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On
Behalf Of Seunghun
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of South Korea.
I have been doing a research on ACPI and making a handcrafted ACPI table for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot process, and Linux kernel goes well without critical problems. But I found some ACPI operand cache leaks in ACPI early abort cases.Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Boot log of ACPI operand cache leak is as follows:
Quoted 6 lines
[ 0.174332] ACPI: Added _OSI(Module Device)
[ 0.175504] ACPI: Added _OSI(Processor Device)
[ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions)
[ 0.177032] ACPI: Added _OSI(Processor Aggregator Device)
[ 0.178284] ACPI: SCI (IRQ16705) allocation failed
[ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System ControlInterrupt handler
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
(20160930/evevent-131)
Quoted 5 lines
[ 0.180008] ACPI: Unable to start the ACPI Interpreter
[ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281)
[ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects
[ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2
[ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox12/01/2006
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
Quoted 15 lines
[ 0.188000] Call Trace:
[ 0.188000] ? dump_stack+0x5c/0x7d
[ 0.188000] ? kmem_cache_destroy+0x224/0x230
[ 0.188000] ? acpi_sleep_proc_init+0x22/0x22
[ 0.188000] ? acpi_os_delete_cache+0xa/0xd
[ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b
[ 0.188000] ? acpi_terminate+0x5/0xf
[ 0.188000] ? acpi_init+0x288/0x32e
[ 0.188000] ? __class_create+0x4c/0x80
[ 0.188000] ? video_setup+0x7a/0x7a
[ 0.188000] ? do_one_initcall+0x4e/0x1b0
[ 0.188000] ? kernel_init_freeable+0x194/0x21a
[ 0.188000] ? rest_init+0x80/0x80
[ 0.188000] ? kernel_init+0xa/0x100
[ 0.188000] ? ret_from_fork+0x25/0x30Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror. So could you send us the handcrafted ACPI table or both the "acpidump -c on" and"acpidump -c off" output?
Quoted 71 lines
Quoted 59 lines
Quoted 22 lines
Quoted 15 lines
Quoted 15 lines
Quoted 11 lines
Quoted 3 lines
I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 8 lines
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
If the system basically doesn't work, that information isn't particularly useful.
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Quoted 7 lines
Quoted 3 lines
Thanks,
RafaelYes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
A virtual box or a guest can run without ACPI tables. A bare metal system where ACPI tables are necessary will be more-or-less unusable if the kernel cannot use them (it won't be able to detect interrupt controllers and the PCI host bridge just for starters).
Quoted 6 lines
Running a guest with totally broken ACPI tables requires root privileges on the host. Running a bare metal system with totally broken ACPI tables (which seems to be your basic concern) may be a good research project, but nobody will do that in practice. And everybody who tries that will notice what's going on.
Yes, you found a bug, but I still am not convinced about how this is security-related.
I totally agree with you that this case is not in practice now.
I just started researching on ACPI, and I don't have enough ideas to occur a security problem using a bug. I just think that it has a little possibility which is security-related.Quoted 6 lines
Thank you so much for your guides.
It helps me a lot to change my research direction.So, could my patch be merged in next kernel (4.11 rc-1)? or do I need to do something for it?
Please let me know.
Quoted 5 lines
Generally, ACPICA patches (and this is one of them) have to go in via the upstream ACPICA project maintained by Bob Moore and Lv. Please see
MAINTAINERSfor pointers to the mailing list etc.Lv, can you please advise on the next steps?
I already gave my advices.
The fix was OK to me and I back ported it to ACPICA:
https://github.com/acpica/acpica/pull/206
However it fixes a code path that in theory shouldn't be invoked in Linux kernel. But anyway it was merged and you will see it in the next ACPICA release.
I asked Han for the handcrafted ACPI table.
And obtained that:
ACPI: FACP 0x00000000DFFF00F0 0000F4 (v04 VBOX VBOXFACP 00000001 ASL 00000061) 0x0000: 46 41 43 50 F4 00 00 00 04 60 56 42 4F 58 20 200x0010: 56 42 4F 58 46 41 43 50 01 00 00 00 41 53 4C 200x0020: 61 00 00 00 00 02 FF DF 80 04 FF DF 41 41 41 410x0030: 2E 44 00 00 A1 A0 00 00 00 40 00 00 00 00 00 000x0040: 04 40 00 00 00 00 00 00 00 00 00 00 08 40 00 000x0050: 20 40 00 00 00 00 00 00 04 02 00 04 02 00 00 000x0060: 65 00 E9 03 00 00 00 00 00 00 00 00 00 03 00 000x0070: 41 05 00 00 01 08 00 01 50 40 00 00 00 00 00 000x0080: 10 00 00 00 00 02 FF DF 00 00 00 00 80 04 FF DF0x0090: 00 00 00 00 01 20 00 02 00 40 00 00 00 00 00 000x00A0: 00 00 00 00 00 00 00 00 00 00 00 00 01 10 00 020x00B0: 04 40 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00C0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00D0: 01 20 00 03 08 40 00 00 00 00 00 00 01 10 00 010x00E0: 20 40 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00F0: 00 00 00 00
ACPI: FACS 0x00000000DFFF0200 0000400x0000: 46 41 43 53 40 00 00 00 00 00 00 00 00 00 00 00 0x0010: 00 00 00 00 00 00 00 00 00 41 41 41 41 41 41 41 0x0020: 01 00 00 00 00 00 00 00 00 41 00 00 00 00 00 00 0x0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ACPI: APIC 0x00000000DFFF0240 00006C (v02 VBOX VBOXAPIC 00000001 ASL 00000061) 0x0000: 41 50 49 43 6C 00 00 00 02 21 56 42 4F 58 20 200x0010: 56 42 4F 58 41 50 49 43 01 00 00 00 41 53 4C 200x0020: 61 00 00 00 00 00 E0 FE 01 00 00 00 02 0A 00 000x0030: 02 00 00 00 00 00 02 0A 00 09 09 00 00 00 0D 000x0040: 00 08 00 00 01 00 41 41 41 41 41 41 41 41 41 000x0050: 00 08 02 02 01 00 00 00 00 08 03 03 01 00 00 000x0060: 01 0C 04 00 00 00 C0 FE 00 00 00 00
Where there is still no AML tables and the failure in the patch description seems to be related to the AML tables. So I'm still not aware of what the "handcrafted tables" meant to us and what the problem was.
Thanks and best regards
Lv
Quoted 7 lines
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 169 lines · Lv
Hi, Rafael
Quoted 167 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Rafael J. Wysocki
Subject: Re: [PATCH v2] acpi: acpica: fix acpi operand cache leakQuoted 33 lines · Seunghun Han
Hi, Rafael.
I agree with you and I added my opinion below.
2017-02-25 1:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 28 lines · Seunghun Han
Quoted 27 lines
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 22 lines · Seunghun Han
Quoted 21 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 16 lines · Seunghun Han
Quoted 15 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 9 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 4 lines · Lv
Quoted 3 lines
Hi,
Quoted 1 line
From: [email protected] [mailto:[email protected]] On
Behalf Of Seunghun
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of
South Korea.I have been doing a research on ACPI and making a handcrafted ACPI table
for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot
process, and Linux kernel goes well without critical problems.
But I found some ACPI operand cache leaks in ACPI early abort cases.Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Boot log of ACPI operand cache leak is as follows:
[ 0.174332] ACPI: Added _OSI(Module Device)
[ 0.175504] ACPI: Added _OSI(Processor Device)
[ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions)
[ 0.177032] ACPI: Added _OSI(Processor Aggregator Device)
[ 0.178284] ACPI: SCI (IRQ16705) allocation failed
[ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System ControlInterrupt handler
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
(20160930/evevent-131)
[ 0.180008] ACPI: Unable to start the ACPI Interpreter
[ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281)
[ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects
[ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2
[ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox12/01/2006
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
[ 0.188000] Call Trace:
[ 0.188000] ? dump_stack+0x5c/0x7d
[ 0.188000] ? kmem_cache_destroy+0x224/0x230
[ 0.188000] ? acpi_sleep_proc_init+0x22/0x22
[ 0.188000] ? acpi_os_delete_cache+0xa/0xd
[ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b
[ 0.188000] ? acpi_terminate+0x5/0xf
[ 0.188000] ? acpi_init+0x288/0x32e
[ 0.188000] ? __class_create+0x4c/0x80
[ 0.188000] ? video_setup+0x7a/0x7a
[ 0.188000] ? do_one_initcall+0x4e/0x1b0
[ 0.188000] ? kernel_init_freeable+0x194/0x21a
[ 0.188000] ? rest_init+0x80/0x80
[ 0.188000] ? kernel_init+0xa/0x100
[ 0.188000] ? ret_from_fork+0x25/0x30Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror. So could you send us the handcrafted ACPI table or both the "acpidump -c on" and"acpidump -c off" output?
Quoted 71 lines
Quoted 59 lines
Quoted 22 lines
Quoted 15 lines
Quoted 15 lines
Quoted 11 lines
Quoted 3 lines
I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 8 lines
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
If the system basically doesn't work, that information isn't particularly useful.
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Quoted 7 lines
Quoted 3 lines
Thanks,
RafaelYes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
A virtual box or a guest can run without ACPI tables. A bare metal system where ACPI tables are necessary will be more-or-less unusable if the kernel cannot use them (it won't be able to detect interrupt controllers and the PCI host bridge just for starters).
Quoted 6 lines
Running a guest with totally broken ACPI tables requires root privileges on the host. Running a bare metal system with totally broken ACPI tables (which seems to be your basic concern) may be a good research project, but nobody will do that in practice. And everybody who tries that will notice what's going on.
Yes, you found a bug, but I still am not convinced about how this is security-related.
I totally agree with you that this case is not in practice now.
I just started researching on ACPI, and I don't have enough ideas to occur a security problem using a bug. I just think that it has a little possibility which is security-related.Quoted 6 lines
Thank you so much for your guides.
It helps me a lot to change my research direction.So, could my patch be merged in next kernel (4.11 rc-1)? or do I need to do something for it?
Please let me know.Generally, ACPICA patches (and this is one of them) have to go in via the upstream ACPICA project maintained by Bob Moore and Lv. Please see
MAINTAINERSfor pointers to the mailing list etc.
Quoted 7 lines
Quoted 1 line
Lv, can you please advise on the next steps?
I already gave my advices.
The fix was OK to me and I back ported it to ACPICA:
https://github.com/acpica/acpica/pull/206
However it fixes a code path that in theory shouldn't be invoked in Linux kernel. But anyway it was merged and you will see it in the next ACPICA release.
Thank you!
Best,
Rafael
Hello, Lv and Rafael.
I checked that my patch was merged to ACPICA project. Thank you for your notice.
I added an analysis report which has the root cause of this problem below.
2017-02-27 11:45 GMT+09:00 Zheng, Lv <[email protected]>:
Quoted 212 lines
Hi, Rafael
Quoted 163 lines
From: [email protected] [mailto:[email protected]] On Behalf Of Rafael J. Wysocki
Subject: Re: [PATCH v2] acpi: acpica: fix acpi operand cache leakQuoted 33 lines · Seunghun Han
Hi, Rafael.
I agree with you and I added my opinion below.
2017-02-25 1:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 28 lines · Seunghun Han
Quoted 27 lines
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 22 lines · Seunghun Han
Quoted 21 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <[email protected]>:
Quoted 16 lines · Seunghun Han
Quoted 15 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <[email protected]>:
Quoted 9 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <[email protected]>:
Quoted 4 lines · Lv
Quoted 3 lines
Hi,
Quoted 1 line
From: [email protected] [mailto:[email protected]] On
Behalf Of Seunghun
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of
South Korea.I have been doing a research on ACPI and making a handcrafted ACPI table
for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot
process, and Linux kernel goes well without critical problems.
But I found some ACPI operand cache leaks in ACPI early abort cases.Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Boot log of ACPI operand cache leak is as follows:
[ 0.174332] ACPI: Added _OSI(Module Device)
[ 0.175504] ACPI: Added _OSI(Processor Device)
[ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions)
[ 0.177032] ACPI: Added _OSI(Processor Aggregator Device)
[ 0.178284] ACPI: SCI (IRQ16705) allocation failed
[ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System ControlInterrupt handler
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
(20160930/evevent-131)
[ 0.180008] ACPI: Unable to start the ACPI Interpreter
[ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281)
[ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects
[ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2
[ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox12/01/2006
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
[ 0.188000] Call Trace:
[ 0.188000] ? dump_stack+0x5c/0x7d
[ 0.188000] ? kmem_cache_destroy+0x224/0x230
[ 0.188000] ? acpi_sleep_proc_init+0x22/0x22
[ 0.188000] ? acpi_os_delete_cache+0xa/0xd
[ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b
[ 0.188000] ? acpi_terminate+0x5/0xf
[ 0.188000] ? acpi_init+0x288/0x32e
[ 0.188000] ? __class_create+0x4c/0x80
[ 0.188000] ? video_setup+0x7a/0x7a
[ 0.188000] ? do_one_initcall+0x4e/0x1b0
[ 0.188000] ? kernel_init_freeable+0x194/0x21a
[ 0.188000] ? rest_init+0x80/0x80
[ 0.188000] ? kernel_init+0xa/0x100
[ 0.188000] ? ret_from_fork+0x25/0x30Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering
AE_NOT_ACQUIREDerror. So could you send us the handcrafted ACPI table or both the "acpidump -c on" and"acpidump -c off" output?
Quoted 71 lines
Quoted 59 lines
Quoted 22 lines
Quoted 15 lines
Quoted 15 lines
Quoted 11 lines
Quoted 3 lines
I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 8 lines
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
If the system basically doesn't work, that information isn't particularly useful.
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Quoted 7 lines
Quoted 3 lines
Thanks,
RafaelYes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
A virtual box or a guest can run without ACPI tables. A bare metal system where ACPI tables are necessary will be more-or-less unusable if the kernel cannot use them (it won't be able to detect interrupt controllers and the PCI host bridge just for starters).
Quoted 6 lines
Running a guest with totally broken ACPI tables requires root privileges on the host. Running a bare metal system with totally broken ACPI tables (which seems to be your basic concern) may be a good research project, but nobody will do that in practice. And everybody who tries that will notice what's going on.
Yes, you found a bug, but I still am not convinced about how this is security-related.
I totally agree with you that this case is not in practice now.
I just started researching on ACPI, and I don't have enough ideas to occur a security problem using a bug. I just think that it has a little possibility which is security-related.Quoted 6 lines
Thank you so much for your guides.
It helps me a lot to change my research direction.So, could my patch be merged in next kernel (4.11 rc-1)? or do I need to do something for it?
Please let me know.Quoted 5 lines
Generally, ACPICA patches (and this is one of them) have to go in via the upstream ACPICA project maintained by Bob Moore and Lv. Please see
MAINTAINERSfor pointers to the mailing list etc.Lv, can you please advise on the next steps?
I already gave my advices.
The fix was OK to me and I back ported it to ACPICA:
https://github.com/acpica/acpica/pull/206
However it fixes a code path that in theory shouldn't be invoked in Linux kernel. But anyway it was merged and you will see it in the next ACPICA release.I asked Han for the handcrafted ACPI table.
And obtained that:
ACPI: FACP0x00000000DFFF00F00000F4 (v04 VBOX VBOXFACP 00000001 ASL 00000061)0x0000: 46 41 43 50 F4 00 00 00 04 60 56 42 4F 58 20 200x0010: 56 42 4F 58 46 41 43 50 01 00 00 00 41 53 4C 200x0020: 61 00 00 00 00 02 FF DF 80 04 FF DF 41 41 41 410x0030: 2E 44 00 00 A1 A0 00 00 00 40 00 00 00 00 00 000x0040: 04 40 00 00 00 00 00 00 00 00 00 00 08 40 00 000x0050: 20 40 00 00 00 00 00 00 04 02 00 04 02 00 00 000x0060: 65 00 E9 03 00 00 00 00 00 00 00 00 00 03 00 000x0070: 41 05 00 00 01 08 00 01 50 40 00 00 00 00 00 000x0080: 10 00 00 00 00 02 FF DF 00 00 00 00 80 04 FF DF0x0090: 00 00 00 00 01 20 00 02 00 40 00 00 00 00 00 000x00A0: 00 00 00 00 00 00 00 00 00 00 00 00 01 10 00 020x00B0: 04 40 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00C0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00D0: 01 20 00 03 08 40 00 00 00 00 00 00 01 10 00 010x00E0: 20 40 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00F0: 00 00 00 00ACPI: FACS
0x00000000DFFF02000000400x0000: 46 41 43 53 40 00 00 00 00 00 00 00 00 00 00 000x0010: 00 00 00 00 00 00 00 00 00 41 41 41 41 41 41 410x0020: 01 00 00 00 00 00 00 00 00 41 00 00 00 00 00 000x0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00ACPI: APIC
0x00000000DFFF024000006C (v02 VBOX VBOXAPIC 00000001 ASL 00000061)0x0000: 41 50 49 43 6C 00 00 00 02 21 56 42 4F 58 20 200x0010: 56 42 4F 58 41 50 49 43 01 00 00 00 41 53 4C 200x0020: 61 00 00 00 00 00 E0 FE 01 00 00 00 02 0A 00 000x0030: 02 00 00 00 00 00 02 0A 00 09 09 00 00 00 0D 000x0040: 00 08 00 00 01 00 41 41 41 41 41 41 41 41 41 000x0050: 00 08 02 02 01 00 00 00 00 08 03 03 01 00 00 000x0060: 01 0C 04 00 00 00 C0 FE 00 00 00 00
Quoted 2 lines
Where there is still no AML tables and the failure in the patch description seems to be related to the AML tables. So I'm still not aware of what the "handcrafted tables" meant to us and what the problem was.
Actually, I did not change DSDT and SSDT. I changed only FACP, FACS and APIC for my handcrafted ACPI table.
I have analyzed the root cause of the problem, and I have found that my handcrafted ACPI table has too big SCI IRQ (like 16705).
So, acpi_os_install_interrupt_handler() which is called by acpi_enable_subsystem()
was failed and returned AE_NOT_ACQUIRED (0x14) with "ACPI: SCI (IRQ16705) allocation failed" log.
Because of error code, acpi_bus_init(), the caller of acpi_enable_subsystem(), showed "Unable to start the ACPI Interpreter" and called acpi_terminate() for exception handling. After calling acpi_terminate(), as you know, cache leak occurred.
This means that error of acpi_load_tables(), acpi_initialize_objects(), acpi_bus_init_irq() and acpi_install_notify_handler() which are called by acpi_bus_init() can cause cache leak.
If you want to see this error handling sequence, I suggest you that you change the code of acpi_os_install_interrupt_handler() to return AE_NOT_ACQUIRED immediately. Then, you can see the error handling sequence without my handcrafted
ACPI table.
I you want additional information about this, please let me know.
Best regards.
Quoted 11 lines
Thanks and best regards
LvQuoted 7 lines
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
Quoted 231 lines
From: Seunghun Han [mailto:kkamagui(a)gmail.com]
Subject: Re: [PATCH v2] acpi: acpica: fix acpi operand cache leakHello, Lv and Rafael.
I checked that my patch was merged to ACPICA project. Thank you for your notice.
I added an analysis report which has the root cause of this problem below.
2017-02-27 11:45 GMT+09:00 Zheng, Lv <lv.zheng(a)intel.com>:
Quoted 3 lines
Hi, Rafael
Quoted 1 line
From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of
Rafael J.
Quoted 209 lines
Quoted 162 lines
Wysocki
Subject: Re: [PATCH v2] acpi: acpica: fix acpi operand cache leakQuoted 33 lines · Seunghun Han
Hi, Rafael.
I agree with you and I added my opinion below.
2017-02-25 1:50 GMT+09:00 Rafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 28 lines · Seunghun Han
Quoted 27 lines
Hi, Rafeal.
I added my opinion below.
2017-02-24 21:13 GMT+09:00 Rafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 22 lines · Seunghun Han
Quoted 21 lines
Hi, Rafael.
I added my opinion below.
2017-02-24 20:50 GMT+09:00 Rafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 16 lines · Seunghun Han
Quoted 15 lines
Hi, Lv Zheng.
I added my handcrafted ACPI table under your request, because "acpidump -c on" and "acpidump -c off" doesn't work.
2017-02-21 19:36 GMT+09:00 Seunghun Han <kkamagui(a)gmail.com>:
Quoted 9 lines
Hello,
I attached the test results below,
2017-02-21 9:53 GMT+09:00 Rowafael J. Wysocki <rjw(a)rjwysocki.net>:
Quoted 4 lines · Lv
Quoted 3 lines
Hi,
From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On
Behalf Of Seunghun
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Han
Subject: [PATCH v2] acpi: acpica: fix acpi operand cache leakI'm Seunghun Han, and I work for National Security Research Institute of
South Korea.I have been doing a research on ACPI and making a handcrafted ACPI table
for my research.
Errors of handcrafted ACPI tables are handled well in Linux kernel while boot
process, and Linux kernel goes well without critical problems.
But I found some ACPI operand cache leaks in ACPI early abort cases.Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Boot log of ACPI operand cache leak is as follows:
[ 0.174332] ACPI: Added _OSI(Module Device)
[ 0.175504] ACPI: Added _OSI(Processor Device)
[ 0.176010] ACPI: Added _OSI(3.0 _SCP Extensions)
[ 0.177032] ACPI: Added _OSI(Processor Aggregator Device)
[ 0.178284] ACPI: SCI (IRQ16705) allocation failed
[ 0.179352] ACPI Exception: AE_NOT_ACQUIRED, Unable to install System ControlInterrupt handler
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
(20160930/evevent-131)
[ 0.180008] ACPI: Unable to start the ACPI Interpreter
[ 0.181125] ACPI Error: Could not remove SCI handler (20160930/evmisc-281)
[ 0.184068] kmem_cache_destroy Acpi-Operand: Slab cache still has objects
[ 0.185358] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc3 #2
[ 0.186820] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox12/01/2006
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
[ 0.188000] Call Trace:
[ 0.188000] ? dump_stack+0x5c/0x7d
[ 0.188000] ? kmem_cache_destroy+0x224/0x230
[ 0.188000] ? acpi_sleep_proc_init+0x22/0x22
[ 0.188000] ? acpi_os_delete_cache+0xa/0xd
[ 0.188000] ? acpi_ut_delete_caches+0x3f/0x7b
[ 0.188000] ? acpi_terminate+0x5/0xf
[ 0.188000] ? acpi_init+0x288/0x32e
[ 0.188000] ? __class_create+0x4c/0x80
[ 0.188000] ? video_setup+0x7a/0x7a
[ 0.188000] ? do_one_initcall+0x4e/0x1b0
[ 0.188000] ? kernel_init_freeable+0x194/0x21a
[ 0.188000] ? rest_init+0x80/0x80
[ 0.188000] ? kernel_init+0xa/0x100
[ 0.188000] ? ret_from_fork+0x25/0x30Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
I'm more interested in the way of triggering AE_NOT_ACQUIRED error.
So could you send us the handcrafted ACPI table or both the "acpidump -c on" and"acpidump -c off" output?
Quoted 71 lines
Quoted 59 lines
Quoted 22 lines
Quoted 15 lines
Quoted 15 lines
Quoted 11 lines
Quoted 3 lines
I modified FACP, FACS, APIC table in VirtualBox for Linux. Here are raw dumps of table.
So, excuse me, but what's the security issue here?
You hacked your ACPI tables into pieces which requires root privileges anyway.
Thanks,
RafaelAs you mentioned earlier, I hacked my ACPI table for research, so it seems that it is not a security issue.
Quoted 6 lines
Quoted 3 lines
But, if new mainboard are released and they have a vendor-specific ACPI table which has invalid data, the old version of kernel (<=4.9) will possibly expose kernel address and KASLR will be neutralized unintentionally.
But that would mean a basically non-functional system, so I'm not sure how anyone can actually take advantage of the "KASLR neutralization".
Quoted 8 lines
I think an attacker can take advantage of the "KASLR neutralization". As you know, KASLR is good technology to protect kernel from kernel exploits.
If the kernel has vulnerabilities, the attacker can make exploit using them. But, the exploit usually needs gadgets (small code), therefore the attacker should know where the gadgets are in kernel. If the KASLR is working in kernel, the attacker should find the actual kernel address, and he can get kernel address information from kernel warning.
If the system basically doesn't work, that information isn't particularly useful.
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines
I know the vendors collaborate with Linux kernel developers, but the problem can still occur.
Hardware vendors release so many kinds of mainboard in a year, and the major Linux distros (Ubuntu, Fedora, etc.) will have 4.8 kernel for a long time.
For this reason, I think this issue has a security aspect.
Well, not quite IMO.
If the system needs ACPI tables and the kernel cannot use them, it just won't work no matter what.
Quoted 7 lines
Quoted 3 lines
Thanks,
RafaelYes, you are right. But, Linux kernel has well-defined exception handlers, so some systems may work fine like my test machine. Moreover the users may not recognize what the problem is, and I think that they will use the system in insecure status for a long time.
A virtual box or a guest can run without ACPI tables. A bare metal system where ACPI tables are necessary will be more-or-less unusable if the kernel cannot use them (it won't be able to detect interrupt controllers and the PCI host bridge just for starters).
Quoted 6 lines
Running a guest with totally broken ACPI tables requires root privileges on the host. Running a bare metal system with totally broken ACPI tables (which seems to be your basic concern) may be a good research project, but nobody will do that in practice. And everybody who tries that will notice what's going on.
Yes, you found a bug, but I still am not convinced about how this is security-related.
I totally agree with you that this case is not in practice now.
I just started researching on ACPI, and I don't have enough ideas to occur a security problem using a bug. I just think that it has a little possibility which is security-related.Quoted 6 lines
Thank you so much for your guides.
It helps me a lot to change my research direction.So, could my patch be merged in next kernel (4.11 rc-1)? or do I need to do something for it?
Please let me know.Quoted 5 lines
Generally, ACPICA patches (and this is one of them) have to go in via the upstream ACPICA project maintained by Bob Moore and Lv. Please see
MAINTAINERSfor pointers to the mailing list etc.Lv, can you please advise on the next steps?
I already gave my advices.
The fix was OK to me and I back ported it to ACPICA:
https://github.com/acpica/acpica/pull/206
However it fixes a code path that in theory shouldn't be invoked in Linux kernel. But anyway it was merged and you will see it in the next ACPICA release.I asked Han for the handcrafted ACPI table.
And obtained that:
ACPI: FACP0x00000000DFFF00F00000F4 (v04 VBOX VBOXFACP 00000001 ASL 00000061)0x0000: 46 41 43 50 F4 00 00 00 04 60 56 42 4F 58 20 200x0010: 56 42 4F 58 46 41 43 50 01 00 00 00 41 53 4C 200x0020: 61 00 00 00 00 02 FF DF 80 04 FF DF 41 41 41 410x0030: 2E 44 00 00 A1 A0 00 00 00 40 00 00 00 00 00 000x0040: 04 40 00 00 00 00 00 00 00 00 00 00 08 40 00 000x0050: 20 40 00 00 00 00 00 00 04 02 00 04 02 00 00 000x0060: 65 00 E9 03 00 00 00 00 00 00 00 00 00 03 00 000x0070: 41 05 00 00 01 08 00 01 50 40 00 00 00 00 00 000x0080: 10 00 00 00 00 02 FF DF 00 00 00 00 80 04 FF DF0x0090: 00 00 00 00 01 20 00 02 00 40 00 00 00 00 00 000x00A0: 00 00 00 00 00 00 00 00 00 00 00 00 01 10 00 020x00B0: 04 40 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00C0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00D0: 01 20 00 03 08 40 00 00 00 00 00 00 01 10 00 010x00E0: 20 40 00 00 00 00 00 00 00 00 00 00 00 00 00 000x00F0: 00 00 00 00ACPI: FACS
0x00000000DFFF02000000400x0000: 46 41 43 53 40 00 00 00 00 00 00 00 00 00 00 000x0010: 00 00 00 00 00 00 00 00 00 41 41 41 41 41 41 410x0020: 01 00 00 00 00 00 00 00 00 41 00 00 00 00 00 000x0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00ACPI: APIC
0x00000000DFFF024000006C (v02 VBOX VBOXAPIC 00000001 ASL 00000061)0x0000: 41 50 49 43 6C 00 00 00 02 21 56 42 4F 58 20 200x0010: 56 42 4F 58 41 50 49 43 01 00 00 00 41 53 4C 200x0020: 61 00 00 00 00 00 E0 FE 01 00 00 00 02 0A 00 000x0030: 02 00 00 00 00 00 02 0A 00 09 09 00 00 00 0D 000x0040: 00 08 00 00 01 00 41 41 41 41 41 41 41 41 41 000x0050: 00 08 02 02 01 00 00 00 00 08 03 03 01 00 00 000x0060: 01 0C 04 00 00 00 C0 FE 00 00 00 00Quoted 1 line
Where there is still no AML tables and the failure in the patch description seems to be related to
the AML tables.
Quoted 1 line
So I'm still not aware of what the "handcrafted tables" meant to us and what the problem was.
Actually, I did not change DSDT and SSDT. I changed only FACP, FACS and APIC for my handcrafted ACPI table.
Quoted 6 lines
I have analyzed the root cause of the problem, and I have found that my handcrafted ACPI table has too big SCI IRQ (like 16705).
So,acpi_os_install_interrupt_handler()which is called byacpi_enable_subsystem()
was failed and returnedAE_NOT_ACQUIRED(0x14) with "ACPI: SCI (IRQ16705) allocation failed" log.
Thanks for the explanation.
There doesn't seem to be any required additional fix for such a wrong sci irq #. Which can release me from the triggered error now. :)
Quoted 9 lines
Because of error code,
acpi_bus_init(), the caller ofacpi_enable_subsystem(), showed "Unable to start the ACPI Interpreter" and calledacpi_terminate()for exception handling. After callingacpi_terminate(), as you know, cache leak occurred.
This means that error ofacpi_load_tables(),acpi_initialize_objects(),acpi_bus_init_irq()andacpi_install_notify_handler()which are called byacpi_bus_init()can cause cache leak.
Quoted 5 lines
If you want to see this error handling sequence, I suggest you that you change the code of
acpi_os_install_interrupt_handler()to returnAE_NOT_ACQUIREDimmediately. Then, you can see the error handling sequence without my handcrafted
ACPI table.
You can always harden the code with acceptable improvements. Feel free to continue your contribution.
Quoted 2 lines
I you want additional information about this, please let me know.
Sure.
Thanks
Lv
Quoted 14 lines
Best regards.
Quoted 11 lines
Thanks and best regards
LvQuoted 7 lines
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html