Skip to contentSkip to conversation

DTS: Linksys Board: Add default trigger for sata led

PATCH In review Ansuel Smith 3 participants 3 messages Feb 17, 2017 – Feb 19, 2017 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DTS: Linksys Board: Add default trigger for sata led

In others board we have the sata led set to funcion with the sata led trigger by default. This patch makes the same for these board that have sata led but disabled by not associating it to any trigger

---
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 1 +
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts   | 1 +
 3 files changed, 3 insertions(+)
arch/arm/boot/dts/armada-385-linksys-caiman.dts +1 -0
index f3cee91..a1b6e68 100644
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "caiman:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
arch/arm/boot/dts/armada-385-linksys-cobra.dts +1 -0
index 1110718..a1a75af 100644
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "cobra:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
arch/arm/boot/dts/armada-xp-linksys-mamba.dts +1 -0
index 83ac884..dcd73ab 100644
@@ -156,6 +156,7 @@
 					esata at 4 {
 						label = "mamba:white:esata";
 						reg = <0x4>;
+						linux,default-trigger = "disk-activity";
 					};
 
 					usb2 at 5 {
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hi Ansuel,

Quoted 2 lines · Ansuel Smith

In others board we have the sata led set to funcion with the sata led trigger by default. This patch makes the same for these board that have sata led but disabled by not associating it to any trigger

Please line wrap the commit message. Other than that,

Quoted 2 lines

thx,

Jason.

Quoted 45 lines
---
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 1 +
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts   | 1 +
 3 files changed, 3 insertions(+)
arch/arm/boot/dts/armada-385-linksys-caiman.dts +1 -0
index f3cee91..a1b6e68 100644
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "caiman:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
arch/arm/boot/dts/armada-385-linksys-cobra.dts +1 -0
index 1110718..a1a75af 100644
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "cobra:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
arch/arm/boot/dts/armada-xp-linksys-mamba.dts +1 -0
index 83ac884..dcd73ab 100644
@@ -156,6 +156,7 @@
 					esata at 4 {
 						label = "mamba:white:esata";
 						reg = <0x4>;
+						linux,default-trigger = "disk-activity";
 					};
 
 					usb2 at 5 {
Signature · 1 line
1.9.1
#2 lore raw

Hi,

Am 18.02.2017 um 15:12 schrieb Jason Cooper:

Quoted 5 lines · Ansuel Smith
Quoted 2 lines

In others board we have the sata led set to funcion with the sata led trigger by default. This patch makes the same for these board that have sata led but disabled by not associating it to any trigger

Please line wrap the commit message.

The subject could also use some love, like mentioning "ARM:" and "armada" and dropping "Board". Compare git log --oneline.

Regards,
Andreas

Quoted 16 lines

Other than that,

Quoted 2 lines

thx,

Jason.

Quoted 5 lines
---
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 1 +
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts   | 1 +
 3 files changed, 3 insertions(+)
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)